Compare commits

...

2541 Commits

Author SHA1 Message Date
Clément Fournier
2c4958e462 Fix toc links
(cherry picked from commit 40f0c4d59b)
2018-06-30 10:24:27 +02:00
Andreas Dangel
211002bb34 [maven-release-plugin] prepare release pmd_releases/6.5.0 2018-06-26 09:07:11 +02:00
Andreas Dangel
8f26c54eb8 Prepare pmd release 6.5.0 2018-06-26 09:01:36 +02:00
Juan Martín Sotuyo Dodero
74cf7dc77b Merge branch 'pr-1201' 2018-06-25 17:22:14 -03:00
Andreas Dangel
6167d26fa9 Make jaxen dependency optional. It is shaded into pmd-core. 2018-06-25 21:54:53 +02:00
Andreas Dangel
f38a4f95c6 [java] MissingOverrideRule exception when analyzing PMD under Java 9
Fixes #1074

Jaxen is now shaded into pmd-core, without org.w3c.dom.**
2018-06-25 21:54:53 +02:00
Clément Fournier
21a5e47322 Merge branch 'pr-1206' 2018-06-25 09:14:17 +02:00
Clément Fournier
8188732ad5 Update release notes, refs #1206 2018-06-25 09:14:06 +02:00
Travis CI (pmd-bot)
9f0da5c4e9 Update documentation 2018-06-25 04:10:01 +00:00
Juan Martín Sotuyo Dodero
1d4039b8b5 Merge branch 'pr-1203' 2018-06-25 00:55:58 -03:00
Juan Martín Sotuyo Dodero
ac0779cb2b Update changelog, refs #1203 2018-06-25 00:55:24 -03:00
Juan Martín Sotuyo Dodero
dd249e1c36 Merge branch 'pr-1192' 2018-06-24 19:28:03 -03:00
Juan Martín Sotuyo Dodero
2d6a599bb1 Merge branch 'pr-1198' 2018-06-24 19:09:30 -03:00
Karl-Philipp Richter
28505a8624 Recommend StringBuilder next to StringBuffer
StringBuilder is a faster non-synchronized alternative to StringBuffer
which should be used where synchronization is not needed. Since "use
StringBuilder or StringBuffer" would immediately lead to the question
which one to use the hints "non-synchronized" and "synchronized" are
added.
2018-06-24 23:03:42 +02:00
Andreas Dangel
9e17867610 Use pmd-build-tools 1.2 2018-06-24 21:12:05 +02:00
Clément Fournier
e113ed4994 Prop up Ncss report levels, allow greater configurability 2018-06-24 19:07:46 +02:00
Clément Fournier
9706cd0f23 Filter out Less files from resource copying 2018-06-24 18:39:08 +02:00
Andreas Dangel
913fe67db1 Corrections for PR review 2018-06-24 10:15:43 +02:00
Travis CI (pmd-bot)
85a2917e71 Update documentation 2018-06-24 04:49:37 +00:00
Juan Martín Sotuyo Dodero
e3b195e753 Merge branch 'pr-836' 2018-06-24 01:39:42 -03:00
Juan Martín Sotuyo Dodero
7cb203b645 Update changelog, refs #836 2018-06-24 01:39:20 -03:00
Juan Martín Sotuyo Dodero
770657dbea New rules un 6.5.0 2018-06-24 01:39:06 -03:00
Juan Martín Sotuyo Dodero
8ee39deace Upgrade to 6.0.0 categories 2018-06-23 22:33:32 -03:00
Juan Martín Sotuyo Dodero
d1b9d05a24 Merge branch 'master' into pr-836 2018-06-23 21:20:07 -03:00
Juan Martín Sotuyo Dodero
b1655f8ebc Single declaration 2018-06-23 21:16:44 -03:00
Juan Martín Sotuyo Dodero
6f2b200bef Revert "merge"
This reverts commit fe5f0daef9.
2018-06-23 21:13:26 -03:00
Juan Martín Sotuyo Dodero
f39865e014 Revert "Merge remote-tracking branch 'Up2Go/master'"
This reverts commit 96fd8fbca6, reversing
changes made to 4e0dd619b6.
2018-06-23 21:07:24 -03:00
Juan Martín Sotuyo Dodero
ad26f8a0ef Merge branch 'pr-1195' 2018-06-23 19:03:35 -03:00
Juan Martín Sotuyo Dodero
9a33025d85 Merge branch 'pr-1197' 2018-06-23 18:11:27 -03:00
Andreas Dangel
10ecef850b Upgrade various maven plugins 2018-06-23 12:48:49 +02:00
Andreas Dangel
fcfee1969e Fix javadoc warnings 2018-06-23 12:30:08 +02:00
Andreas Dangel
b2d98f0a84 Upgrade maven to 3.5.4 2018-06-23 11:10:13 +02:00
Andreas Dangel
70a03a6a68 [java] UnnecessaryFullyQualifiedName: check for package name java.lang 2018-06-23 10:19:38 +02:00
Andreas Dangel
c119d88aba Update release notes, refs #1174 2018-06-22 22:39:11 +02:00
Andreas Dangel
b82e56158a [java] FormalComment - remove unnecessary check for comment prefix 2018-06-22 22:37:27 +02:00
Andreas Dangel
7221903f73 [java] Deprecated CommentUtil, move parts to AST Comment, fix FormalComment 2018-06-22 22:23:49 +02:00
Andreas Dangel
908d65f8c9 [java] CommentUtil: simplify trim method 2018-06-22 21:18:40 +02:00
Andreas Dangel
6a476698ad [java] CommentUtil: Use a single regex for filtering comment lines 2018-06-22 21:03:59 +02:00
Andreas Dangel
f271c736c0 Fix checkstyle 2018-06-22 20:32:22 +02:00
Andreas Dangel
4e4c9a194d [java] UnnecessaryFullyQualifiedName: consider valid java.lang. FQCN usages 2018-06-22 20:00:11 +02:00
Andreas Dangel
b5cb2bbb85 [java] Add Unit test for CommentUtil
Fixes #1174
2018-06-21 21:36:56 +02:00
Andreas Dangel
66882dca8d [java] UnnecessaryFullyQualifiedName doesn't detect java.lang FQ names as violations
Fixes #1186
2018-06-21 17:35:26 +02:00
Andreas Dangel
a89d5413ab [ci] [docs] Improved detection for changes in documentation
Now only updating docs on sourceforge, if there are changes
2018-06-20 20:57:27 +02:00
Andreas Dangel
d3482ecd58 [ci] [docs] Improved detection for changes in documentation 2018-06-20 20:08:30 +02:00
Clément Fournier
b76c00e493 Fix highlighting algo misplacing some style classes 2018-06-19 11:42:07 +02:00
Andreas Dangel
8f49328bfa [ci] [doc] Skip updating gh-pages, if only feed.xml changed 2018-06-19 09:04:08 +02:00
Andreas Dangel
fb6b4aa883 Use DesignerStarter for Windows, too 2018-06-18 20:40:25 +02:00
Andreas Dangel
fd3f58ba59 Simplified check if javafx is available before starting the designer 2018-06-18 20:38:56 +02:00
Clément Fournier
ee971c2747 Revert disabling css logging
Doesn't compile on Java 9. We may be able to use reflection to bypass this,
but I leave it for future work
2018-06-17 15:12:42 +02:00
Clément Fournier
f34cd37f73 Merge branch 'master' into designer-node-highlighting 2018-06-17 14:25:46 +02:00
Clément Fournier
e1066fe5ae Reorder designer menus 2018-06-17 14:25:35 +02:00
Clément Fournier
76ecd31999 Unclutter designer console output
We turn off the css logger, and allow RichTextFX to access internal javafx API to avoid
the illegal access warning.
2018-06-17 14:15:05 +02:00
Andreas Dangel
d1c82a1c0b Update release notes, refs #1193 2018-06-17 10:15:11 +02:00
Juan Martín Sotuyo Dodero
b9bb042565 [doc] Fix Incremental Analysis page title 2018-06-16 22:49:43 -03:00
Clément Fournier
cd5a039e3c Fix ExecutorService not shutdown 2018-06-17 02:10:33 +02:00
Andreas Dangel
0ed13477ad [ci] [doc] call git config for the freshly cloned repo 2018-06-16 22:47:20 +02:00
Andreas Dangel
eb67eec4ad Update generated documentation 2018-06-16 22:35:52 +02:00
Clément Fournier
4054125252 Checkstyle 2018-06-16 22:29:08 +02:00
Andreas Dangel
6ed35c477b Merge branch 'pr-1162' 2018-06-16 22:25:32 +02:00
Clément Fournier
cfe8790368 Merge branch 'master' into designer-node-highlighting 2018-06-16 22:25:31 +02:00
Andreas Dangel
1c523c08b2 Merge branch 'pr-1138' 2018-06-16 22:24:55 +02:00
Andreas Dangel
04fd520139 Update release notes, refs #1138, fixes #1119 2018-06-16 22:23:42 +02:00
Clément Fournier
f8061db6ab PMD:check fix 2018-06-16 22:12:10 +02:00
Travis CI (pmd-bot)
ae225e4c34 Update documentation 2018-06-16 18:07:52 +00:00
Clément Fournier
ba4c71dd08 Touchup 2018-06-16 20:02:51 +02:00
Andreas Dangel
9bf3472159 Merge branch 'pr-1184' 2018-06-16 19:51:58 +02:00
Andreas Dangel
b95efe2e1c Use String.format 2018-06-16 19:51:49 +02:00
Andreas Dangel
79efd28e2f Add missing escapes in release notes 2018-06-16 19:38:50 +02:00
Andreas Dangel
6afc424961 Merge branch 'pr-1155' 2018-06-16 19:38:32 +02:00
Andreas Dangel
c20ed11512 Update release notes, refs #1155, fixes #667 2018-06-16 19:37:52 +02:00
Andreas Dangel
2d880807b6 Merge branch 'pr-1121' 2018-06-16 19:27:46 +02:00
Andreas Dangel
53ed213bdc dogfood: Only fail rules with priority 1 or 2 2018-06-16 17:50:19 +02:00
Andreas Dangel
5a7bbe19a2 dogfood: fix missing override
Note: the rule is disabled for pmd-xml, refs #1074
2018-06-16 17:48:36 +02:00
Andreas Dangel
2c987a2688 Upgrade m-pmd-p to 3.10.0 2018-06-16 15:12:14 +02:00
Clément Fournier
9708bf1e74 Remove StyleContext, split CustomCodeArea in two 2018-06-16 00:15:38 +02:00
Clément Fournier
45321f6328 Remove ability to disable XPath result highlighting 2018-06-16 00:15:38 +02:00
Clément Fournier
bb237b94e4 Split secondary layer into error + name occurence 2018-06-16 00:15:38 +02:00
Clément Fournier
f07c4f708c Factorise syntax highlighting stylesheet with Less 2018-06-16 00:15:38 +02:00
Clément Fournier
f668262f39 Style updates are not queued anymore
This caused unexpected behaviour for dubious performance improvements
2018-06-16 00:15:38 +02:00
Clément Fournier
abe79b2af4 Cache StyleCollection#toSpans
Cache hit rate is great when you're inspecting the AST or XPath results without changing the text
2018-06-16 00:15:38 +02:00
Clément Fournier
9d41d552c0 Prevent XPath from reeavaluating when the code is unparsable
It previously was reevaluated on an out-of-date compilation
unit. It makes no sense to keep an out-of-date root node in
the AstManager so we now use Optional to indicate there is
no compilation unit.
2018-06-16 00:15:38 +02:00
Clément Fournier
ff34b7d1c7 Fix recentFiles always reverted 2018-06-16 00:15:38 +02:00
Clément Fournier
99ded1c500 Use icon pack for xpath toolbar 2018-06-16 00:15:38 +02:00
Clément Fournier
7deed84084 Documentation 2018-06-16 00:15:38 +02:00
Clément Fournier
0726616bc4 Fix highlighting twitching on rapid updates 2018-06-16 00:15:38 +02:00
Clément Fournier
e58bfe2cba Cleanup 2018-06-16 00:15:38 +02:00
Clément Fournier
3d35bc3127 Add syntax highlighting to the XPath result listview 2018-06-16 00:15:38 +02:00
Clément Fournier
1e3f0ce85e Simplify the codeArea's interface 2018-06-16 00:15:38 +02:00
Clément Fournier
16ee4ce5fc Highlight focus node lines 2018-06-16 00:15:38 +02:00
Clément Fournier
eea4403121 Better scroll to node on the editor
We scroll so that the node is made entirely visible
2018-06-16 00:15:38 +02:00
Clément Fournier
732cedcfb5 Fix bug with single node in span 2018-06-16 00:15:38 +02:00
Clément Fournier
5934f1be38 Highlight selected linenumber in the gutter 2018-06-16 00:15:38 +02:00
Clément Fournier
865412171f Use Less mixin to generate xpath style classes 2018-06-16 00:15:38 +02:00
Clément Fournier
6e406b89b7 Improve XPath violation display 2018-06-16 00:15:38 +02:00
Clément Fournier
c5063cdd70 Use LESS to factorise stylesheets 2018-06-16 00:15:38 +02:00
Clément Fournier
4231d1aaf9 Add inline highlighting back 2018-06-16 00:15:38 +02:00
Clément Fournier
f9a791a10c Fix some bugs, cleanup 2018-06-16 00:15:38 +02:00
Clément Fournier
a78b01aaa6 Subtract previous syntax layer instead of recomputing everything 2018-06-16 00:15:38 +02:00
Clément Fournier
87c2c89da2 StyleCollection depth layering, use better algorithm 2018-06-16 00:15:38 +02:00
Clément Fournier
1fa46a5620 Treat syntax highlight specially, introduce NodeStyleSpan 2018-06-16 00:15:38 +02:00
Clément Fournier
3e4cf99e33 Cleanup 2018-06-16 00:15:38 +02:00
Clément Fournier
3aedc65444 Queue styling updates 2018-06-16 00:15:38 +02:00
Clément Fournier
5fc7a997da Fix highlighting wiped off by new changes 2018-06-16 00:15:38 +02:00
Clément Fournier
b45789100a Fix bug 2018-06-16 00:15:38 +02:00
Clément Fournier
76445b13bb Highlighting XPath results doesn't autoscroll anymore
Styling improvements. The previous paradigm for highlighting nodes
was to change the fill and make it bold, I'm now more inclined to
change the background/box or just use bold weight for the focus
node.

With syntax highlighting, it's more readable
2018-06-16 00:15:38 +02:00
Clément Fournier
a59c82e72a Allow to toggle the result highlighting on/off 2018-06-16 00:15:38 +02:00
Clément Fournier
9ff78a63d2 Outline XPath results with borders on the editor 2018-06-16 00:15:38 +02:00
Clément Fournier
0fd7f282f5 Highlight error nodes from the event log panel 2018-06-16 00:15:38 +02:00
Andreas Dangel
5241ebf3cd Merge branch 'pr-1154' 2018-06-13 20:09:39 +02:00
Andreas Dangel
715cb8c4f7 Update release notes, refs #1154 2018-06-13 20:08:54 +02:00
Andreas Dangel
88ac2f5227 Use ASTAnyTypeDeclaration.getTypeKind() 2018-06-13 20:08:03 +02:00
Clément Fournier
3c668afb33 Fix homepage internal links 2018-06-12 14:57:19 +02:00
Juan Martín Sotuyo Dodero
58a59222b0 Merge branch 'fp-unnecessary-modifier-enum' 2018-06-12 00:52:07 -03:00
Juan Martín Sotuyo Dodero
eeca5bbf3a Update changelog, refs #1153 2018-06-12 00:51:25 -03:00
Clément Fournier
71ddcea0e7 Typo!! 2018-06-12 01:38:36 +02:00
Clément Fournier
22023ccfb5 Fix possible NPE 2018-06-12 00:27:30 +02:00
Clément Fournier
3a7e6815bf Update warning link 2018-06-12 00:24:36 +02:00
Clément Fournier
c0077a2eed Create new incremental analysis page, make linking to CLI options possible 2018-06-12 00:22:38 +02:00
Clément Fournier
5cf60df09e Typo 2018-06-11 20:29:23 +02:00
Clément Fournier
77bd3e9510 Improvements for PR #1153 2018-06-11 20:28:00 +02:00
Clément Fournier
72cbfe630f Improve UnnecessaryModifier messages 2018-06-11 19:31:20 +02:00
Juan Martín Sotuyo Dodero
b7b31d16f6 Merge branch 'pr-1179' 2018-06-10 02:26:56 -03:00
Clément Fournier
178d42cc24 Checkstyle 2018-06-10 04:24:48 +02:00
Clément Fournier
577ad0faaa Forgot something 2018-06-10 04:14:55 +02:00
Clément Fournier
4aaab66c50 Merge branch 'master' into split-variableNamingConventions 2018-06-10 04:09:55 +02:00
Clément Fournier
f0e0b3caa2 Moar reverting 2018-06-10 04:07:37 +02:00
Clément Fournier
b08da58069 Rule messages can no longer be declared in Java
This caused problems with the RuleSetWriter. Schade.
2018-06-10 04:05:21 +02:00
Clément Fournier
82b4189bc5 Fix javadoc warning 2018-06-10 03:58:32 +02:00
Clément Fournier
735b8dfe37 Use better name 2018-06-10 03:41:22 +02:00
Clément Fournier
b4c492d94f More doc 2018-06-10 03:35:52 +02:00
Clément Fournier
5cf7891d71 Add getXPathAttributes() to Node interface
Deprecate AttributeNode
2018-06-10 03:26:28 +02:00
Clément Fournier
bf466b8b84 Document Attribute 2018-06-10 03:09:20 +02:00
Clément Fournier
9aacc4d206 Rearrange code 2018-06-10 03:03:57 +02:00
Clément Fournier
3a8febb200 Document AttributeAxisIterator 2018-06-10 03:00:45 +02:00
Juan Martín Sotuyo Dodero
ab9aac28a2 Merge branch 'pr-1180' 2018-06-09 21:37:25 -03:00
Clément Fournier
c3aa662b77 Add unit test 2018-06-10 02:23:30 +02:00
Clément Fournier
57d999c617 Use EventSource in the EventLogger 2018-06-10 02:17:25 +02:00
Juan Martín Sotuyo Dodero
b9cb627483 Update changelog, refs #1173 2018-06-09 20:14:52 -03:00
Juan Martín Sotuyo Dodero
5219172267 [core] Fix broken concatenation on CPD GUI
- Fixes #1173
2018-06-09 20:14:02 -03:00
Juan Martín Sotuyo Dodero
914293daad Restrict upper bound of generic 2018-06-09 20:08:22 -03:00
Juan Martín Sotuyo Dodero
226d4c7c07 Merge branch 'pr-1163' 2018-06-09 20:06:55 -03:00
Juan Martín Sotuyo Dodero
f0071f64fa Merge branch 'pr-1169' 2018-06-09 19:51:16 -03:00
Juan Martín Sotuyo Dodero
c93b6c6812 Update changelog, refs #1169 2018-06-09 19:49:21 -03:00
Travis CI (pmd-bot)
5ffe69ee49 Update documentation 2018-06-09 21:49:08 +00:00
Juan Martín Sotuyo Dodero
3ca449426e Merge branch 'pr-1172' 2018-06-09 18:39:01 -03:00
Juan Martín Sotuyo Dodero
2ed1549eff Update changelog, refs #1172 2018-06-09 18:38:49 -03:00
Juan Martín Sotuyo Dodero
26a5dd625e Merge branch 'pr-1183' 2018-06-09 18:07:23 -03:00
Juan Martín Sotuyo Dodero
eaf474209b Update changelog, refs #1183 2018-06-09 18:07:10 -03:00
jakehemmerle
c6989507cd fixed typos 2018-06-09 11:52:59 -04:00
Clément Fournier
4754bddafe Update release notes, refs #1159 2018-06-09 01:52:45 +02:00
Clément Fournier
2eebe2b07e Merge branch 'pr-1159' 2018-06-09 01:50:24 +02:00
Clément Fournier
1d4eb00ba3 Improve styling 2018-06-09 01:49:00 +02:00
Clément Fournier
cb86f2a4b0 Take the chance to display attributes correctly in the designer 2018-06-08 21:47:33 +02:00
Clément Fournier
226de4875d Fix XML node length with autoclosing element 2018-06-08 21:40:53 +02:00
Clément Fournier
18df5835ff Fix Saxon not reading Xml attributes 2018-06-08 20:36:08 +02:00
Clément Fournier
e533c54ffb Fix visitors not started 2018-06-08 19:43:23 +02:00
akshatbahety
2f730806fb Merge branch 'master' of https://github.com/pmd/pmd 2018-06-08 19:05:41 +05:30
akshatbahety
8380d3d5a9 Minor updates 2018-06-08 15:07:54 +05:30
akshatbahety
6fe9459d1c Minor updates 2018-06-08 14:30:19 +05:30
akshatbahety
84f9c9db32 Minor updates 2018-06-07 17:58:57 +05:30
akshatbahety
7fd3ba4679 Updates 2018-06-07 17:03:19 +05:30
Akshat Bahety
1de2313472 Typo 2018-06-07 16:54:29 +05:30
Akshat Bahety
6d2bbb0ede Classloader is completed. 2018-06-07 16:25:41 +05:30
Akshat Bahety
c61fb73d7b Classloader is completed. 2018-06-07 16:24:31 +05:30
Akshat Bahety
5ae8e72930 Data flow is working properly thanks to @oowekyala for helping me out.
UI is upgraded to make sure buttons are active only when needed (will make a small addition to moveitem up and moveitem down button as discussed)
About the ClassLoader I am a bit confused about how to use `ClasspathClassLoader` I think will be able to merge it today before evening IST.
2018-06-07 04:24:19 +05:30
Andreas Dangel
92e74bb228 Use snapshot build of pmd-build-tools 2018-06-05 22:36:07 +02:00
Akshat Bahety
30f63266fe added the Cancel button
the list needs to be updated in the popup to make the data flow as required
working on validation and left out a couple of changes due to some reasons
2018-06-05 21:56:57 +05:30
Clément Fournier
7eaffe1088 Checkstyle 2018-06-05 05:27:40 +02:00
Clément Fournier
6ae7df6e95 Check if enum switch is exhaustive 2018-06-05 03:01:01 +02:00
Clément Fournier
fafd851e20 WIP, whitelists all enums 2018-06-05 00:48:28 +02:00
Clément Fournier
cc5a99b232 Last touch 2018-06-04 23:45:06 +02:00
Clément Fournier
45ea598337 Fix highlighter 2018-06-04 23:09:37 +02:00
Clément Fournier
4e29b793d2 Fix ConcurrentModificationException on designer
It was triggered when restoring multiple properties,
since the items where added to a collection that was
being iterated.

Also fix a small bug when creating a property named
TODO -> the next property was allowed to be called
TODO if the name wasn't changed, since the name field
wasn't changed, so didn't trigger reevaluation of the
validators.
2018-06-04 00:47:45 +02:00
Akshat Bahety
9b341a62b6 UI Updates. 2018-06-02 19:14:07 +05:30
Matthew Duggan
a7cec0d48d Update stylesheets with a default namespace (Fixes #1168) 2018-06-02 14:00:17 +09:00
Travis CI (pmd-bot)
eaa907cd36 Update documentation 2018-06-01 17:42:29 +00:00
Juan Martín Sotuyo Dodero
f00bfc6370 Merge branch 'pr-1165' 2018-06-01 14:30:41 -03:00
Akshat Bahety
7e1d36ba06 List can be reordered , I'll update the UI by day's end.
I need to still test the classPathLoader @jsotuyod some guidance needed here.
2018-06-01 17:36:44 +05:30
Akshat Bahety
705e007bd7 List can be reordered , I'll update the UI by day's end.
I need to still test the classPathLoader @jsotuyod some guidance needed here.
2018-06-01 17:35:40 +05:30
Andreas Dangel
9bb638fef2 Reformatting 2018-06-01 09:38:15 +02:00
Andreas Dangel
439624319a [ecmascript] InnaccurateNumericLiteral false positive with hex literals
Fixes #861
2018-06-01 09:38:08 +02:00
Clément Fournier
da90b25859 Fix tests 2018-05-31 17:59:12 +00:00
Clément Fournier
f65e67e3bd Add space 2018-05-31 17:52:31 +00:00
Andreas Dangel
f74b7194a4 Fix site.url 2018-05-31 13:11:45 +02:00
Andreas Dangel
9df2aed725 Add logging 2018-05-31 13:06:39 +02:00
Andreas Dangel
0263f658c6 Merge branch 'master' into improve-doc-site-navigation 2018-05-31 13:04:53 +02:00
Andreas Dangel
39ca8e2e51 Make the commit quiet 2018-05-31 13:03:20 +02:00
Andreas Dangel
eed145b53a Updated gems 2018-05-31 12:57:05 +02:00
Andreas Dangel
362b1798cf Revert Gemfile - using group ":jekyll_plugins" disables local plugins 2018-05-31 12:56:51 +02:00
Andreas Dangel
cce2ede528 Push the generated site to gh-pages branch 2018-05-31 12:41:00 +02:00
Andreas Dangel
b2a7448974 Update release notes, refs #869 2018-05-31 11:08:42 +02:00
Andreas Dangel
7b54c5a6c9 [java] GuardLogStatement false positive with something.error on return
Fixes #869
2018-05-31 11:07:10 +02:00
Andreas Dangel
d86891da85 [java] GuardLogStatement false positive with Math.log
Fixes #869
2018-05-31 10:29:07 +02:00
Clément Fournier
f8ee148f68 Add XPath syntax highlighter to Rouge
This is only used when building the site, like the Liquid extensions
2018-05-31 10:20:00 +02:00
Akshat Bahety
8b553ff53d UI Upgrades (understood that we need the components to be scalable will push that in next commit , and rename the fx:id too ) , dropped the list. 2018-05-31 12:05:36 +05:30
Clément Fournier
63e22779bc Enforce fx:id naming convention
Refs pmd/build-tools#7
2018-05-31 07:41:38 +02:00
Juan Martín Sotuyo Dodero
48861e1da2 Merge branch 'pr-1161' 2018-05-30 20:52:17 -03:00
Juan Martín Sotuyo Dodero
6035620bdb Update changelog, refs #1161 2018-05-30 20:51:08 -03:00
Akshat Bahety
8d24a06385 Updated the UI (still some work left) , Working on the fileNames in the list view , about the UI I think this shouldn't be scalable as the components would be just too much out of place , and about showOpenMultipleDialog there need to be a cast in place which throws an exception so I have kept the showOpenDialog till now. Will be working on classPathGenerator tomorrow. 2018-05-31 02:42:56 +05:30
Clément Fournier
e4b9befd44 Fix issue 1158 2018-05-30 22:41:06 +02:00
Andreas Dangel
677cf9a298 Change starter script to support early access java builds 2018-05-30 22:09:01 +02:00
Clément Fournier
9a935d8ae3 Merge branch 'pr-1156' 2018-05-30 21:50:16 +02:00
Akshat Bahety
eefecf692a Merge branch 'master' of https://github.com/akshatbahety/pmd 2018-05-30 22:39:36 +05:30
Akshat Bahety
b16b8f9ccb Merge remote-tracking branch 'upstream/master' 2018-05-30 22:30:50 +05:30
Clément Fournier
95ac9691d3 Fix NPE, controller not found 2018-05-30 18:29:48 +02:00
Clément Fournier
ab536988d8 Fix starter script
It didn't consume correctly trailing info (eg date on java 10).
This is a horribly mistake and makes the script fail on a JRE 10.
We could consider updating the binary distribution for 6.4.0...
@jsotuyod @adangel
2018-05-30 17:58:46 +02:00
Travis CI (pmd-bot)
753a8d236d Update documentation 2018-05-30 14:54:04 +00:00
Juan Martín Sotuyo Dodero
0c52c6520e Merge branch 'pr-1157' 2018-05-30 11:40:37 -03:00
Akshat Bahety
61a5d1494b auxClassPath UI 2018-05-30 15:21:37 +05:30
Andreas Dangel
81c5051832 Fixes #715: [xml] ProjectVersionAsDependencyVersion false positive 2018-05-30 09:23:00 +02:00
Andreas Dangel
fddd0d84af Merge branch 'pr-1152' 2018-05-30 09:01:11 +02:00
Andreas Dangel
eced574622 Minor tweaks for release script: RELEASE_RULESET var and more header lines for release_notes_old.md 2018-05-30 09:01:00 +02:00
Juan Martín Sotuyo Dodero
26b942d529 [ci] Use latest pmd on self 2018-05-30 01:21:21 -03:00
Juan Martín Sotuyo Dodero
148c3651fc [java] AtLeastOneConstructor supports Lombok
- Lombok annotations that create a constructor whitelist the class
 - Take the chance to cover a bunch of other FNs
 - Improve documentation on the rule
 - Some other minor improvements
 - Fixes #667
2018-05-30 01:20:13 -03:00
Juan Martín Sotuyo Dodero
78c437bf93 Checkstyle fixes 2018-05-30 00:02:57 -03:00
Juan Martín Sotuyo Dodero
286ee2906b [java] Fix FP with CommentDefaultAccessModifierRule
- Enum constructors should not be reported, even if nested
 - Nested annotation members should not be reported
2018-05-29 23:40:47 -03:00
Juan Martín Sotuyo Dodero
094430679c [java] Fix FN in UnnecessaryModifierRule
- Enum constructors are inherently private, no need to add that
modifier
2018-05-29 23:06:31 -03:00
Juan Martín Sotuyo Dodero
e3065c388e Automatically update release_notes_old.md 2018-05-29 17:42:27 -03:00
Juan Martín Sotuyo Dodero
d333cc87be Make sure to include the release ruleset if necessary 2018-05-29 17:11:40 -03:00
Juan Martín Sotuyo Dodero
59d7834df1 Fix release ruleset name 2018-05-29 16:55:12 -03:00
Juan Martín Sotuyo Dodero
191b887ff1 Run in batch mode 2018-05-29 16:43:58 -03:00
Juan Martín Sotuyo Dodero
32c34d43cb Automatically reset the release notes 2018-05-29 16:08:48 -03:00
Juan Martín Sotuyo Dodero
9e86b00968 Clean backup poms after release 2018-05-29 15:56:45 -03:00
Juan Martín Sotuyo Dodero
3edb87360a Add new ruleset for 6.4.0 new rules 2018-05-29 15:32:30 -03:00
Juan Martín Sotuyo Dodero
31667cdb89 Fix reference to sitemap_generator.sh 2018-05-29 14:56:54 -03:00
Juan Martín Sotuyo Dodero
7aea5b126f Prepare next development version 2018-05-29 14:05:00 -03:00
Juan Martín Sotuyo Dodero
a788d4b586 [maven-release-plugin] prepare for next development iteration 2018-05-29 13:58:54 -03:00
Juan Martín Sotuyo Dodero
e9d78ede3c [maven-release-plugin] prepare release pmd_releases/6.4.0 2018-05-29 13:58:44 -03:00
Juan Martín Sotuyo Dodero
7a1207323d Prepare pmd release 6.4.0 2018-05-29 13:47:13 -03:00
Juan Martín Sotuyo Dodero
50aa05ffa3 Add missing deprecations to changelog 2018-05-29 13:28:08 -03:00
Juan Martín Sotuyo Dodero
805aa8a9dc Merge branch 'pr-1073' 2018-05-29 13:21:56 -03:00
Juan Martín Sotuyo Dodero
45a390aafb Update changelog 2018-05-29 13:21:34 -03:00
Juan Martín Sotuyo Dodero
5359f4d89d Minor review improvements 2018-05-29 13:19:58 -03:00
Andreas Dangel
1b190be3b1 Replace nbsp (U+00A0) with normal space (U+0020)
Avoiding bash error:
run.sh: line 82: $'[\302\240pmd': command not found
2018-05-28 21:54:32 +02:00
Andreas Dangel
3c6a292407 Merge branch 'master' into java10-basic-support 2018-05-28 21:28:12 +02:00
Andreas Dangel
a46288547d Rework "var" support for java10 using void production for LocalVariableType 2018-05-28 21:18:59 +02:00
Andreas Dangel
0b0479d7c0 Prevent using "var" as type name, annotation name or enum with Java 10 2018-05-28 20:07:10 +02:00
Andreas Dangel
4b096b4f96 Don't return "var" as typeImage for inferred variable types 2018-05-28 19:38:16 +02:00
Juan Martín Sotuyo Dodero
47286ac8c5 Merge pull request #1135 from adangel/ci-scripts
Update to ci scripts
2018-05-27 17:53:18 -03:00
Clément Fournier
9391483180 Merge branch 'master' into improve-doc-site-navigation 2018-05-27 20:12:25 +02:00
Clément Fournier
c0a0f577bb Fix titlemaker bug 2018-05-27 20:10:15 +02:00
Clément Fournier
3465b1a77c Add description to index page 2018-05-27 20:08:43 +02:00
Clément Fournier
a6062bd5a4 Merge branch 'pr-1148' 2018-05-27 18:05:28 +02:00
Clément Fournier
e6b141c30d Update release notes, refs #1148 2018-05-27 18:04:23 +02:00
Clément Fournier
3aa703e7d0 Improve doc 2018-05-27 17:58:04 +02:00
Travis CI (pmd-bot)
6b23baf659 Update documentation 2018-05-27 08:49:06 +00:00
Andreas Dangel
879727b653 Merge branch 'pr-1149' 2018-05-27 10:27:55 +02:00
Andreas Dangel
540c1e22a4 Update release notes, refs #1149 2018-05-27 10:27:42 +02:00
Juan Martín Sotuyo Dodero
456bd44c62 [java] Fix doc for CommentDefaultAccessModifierRule
- We now create docs from the properties registered on the class, so
the default was undocumented. Therefore, I moved the default from XML to
code
 - I take the chance to convert the property to a RegexProperty as it's
most apropriate
 - I take the chance to allow `/* package */` as valid too by default
2018-05-27 04:21:31 -03:00
Andreas Dangel
932517bb79 Merge branch 'pr-1133', fixes #1131 2018-05-27 08:59:33 +02:00
Juan Martín Sotuyo Dodero
bc7c31fc96 Update changelog 2018-05-26 20:16:40 -03:00
Juan Martín Sotuyo Dodero
989126ba9b Use ClassUtils to load classes 2018-05-26 20:12:09 -03:00
Juan Martín Sotuyo Dodero
15c2eb928b Merge pull request #1117 from oowekyala/issue1108-refactor-premature-declaration
[java] Refactor PrematureDeclaration
2018-05-26 19:23:45 -03:00
Juan Martín Sotuyo Dodero
2eb0f39546 Improve release notes 2018-05-26 18:57:57 -03:00
Juan Martín Sotuyo Dodero
61677e6ee9 Update changelog, refs #1131 2018-05-26 18:06:57 -03:00
Juan Martín Sotuyo Dodero
6fa5a45e62 Improvements for consistency 2018-05-26 18:05:37 -03:00
Juan Martín Sotuyo Dodero
dd6ef52289 Remove usage of deprecated methods 2018-05-26 18:00:48 -03:00
Juan Martín Sotuyo Dodero
7ce534134f Update changelog 2018-05-26 17:43:26 -03:00
Andreas Dangel
ba55164b2f Merge branch 'pr-1141' 2018-05-26 22:37:04 +02:00
Juan Martín Sotuyo Dodero
0e7d210bed Update docs 2018-05-26 17:30:18 -03:00
Clément Fournier
929c2dfba2 Corrections for PR #1141 2018-05-26 21:54:39 +02:00
Clément Fournier
e13c9f3fff Fix designer bug with language selection
The autorefresh didn't take into account the case where the language or XPath version
changes, making the choiceboxes useless
2018-05-26 21:41:16 +02:00
Andreas Dangel
ff0a26633c There doesn't seem to be an "eval" available with that version 2018-05-26 21:32:27 +02:00
Andreas Dangel
175b4285d3 [doc] Update gems 2018-05-26 21:31:19 +02:00
Clément Fournier
8080afe101 Update release notes, refs #1137 2018-05-26 21:18:05 +02:00
Clément Fournier
db50f9fb60 Merge branch 'pr-1137' 2018-05-26 21:15:00 +02:00
Clément Fournier
14e575de33 Cleanups
Formatting, a bit of doc, add padding around labels in UI
2018-05-26 21:14:30 +02:00
Juan Martín Sotuyo Dodero
0e44b279f7 Fix AvoidThrowingRawExceptionTypes 2018-05-26 14:48:26 -03:00
Akshat Bahety
b63321ab9c Updates 2018-05-26 22:58:55 +05:30
Andreas Dangel
6a4306aee5 Merge branch 'pr-1147' 2018-05-26 19:23:46 +02:00
Andreas Dangel
8963b084a7 Update release notes, fixes #1145, refs #1147 2018-05-26 19:23:11 +02:00
Andreas Dangel
89a3b6b991 Move comment about why PMDParameter.RulePriorityValidator needs to be public static 2018-05-26 19:22:20 +02:00
Akshat Bahety
46951e362a Updates 2018-05-26 19:14:23 +05:30
Juan Martín Sotuyo Dodero
7572a49d35 [java] Deprecate the old typeof function
- Have new functions typeIs() and typeIsExactly() with simpler syntaxes
 - Nag about the deprecated usage of the old method
 - Replace all internal usages with the new one
 - Have the functions use the TypeHelper to avoid multiple separate
implementations of the same behavior
 - Tidy up a little the TypeHelper
2018-05-26 06:01:56 -03:00
Clément Fournier
3c3883ef8b Fix designer XPath panel popup showing up on double click
It was very easy to trigger accidentally and was annoying
2018-05-26 08:36:21 +02:00
Akshat Bahety
1efe2ad87d Code Format 2018-05-26 10:17:47 +05:30
Akshat Bahety
830809e91b Auto XPath Expression Update 2018-05-26 09:52:12 +05:30
Clément Fournier
401ef67fe1 Prettify Suppressing warnings 2018-05-25 20:47:59 +02:00
Clément Fournier
68c2228248 Prettify CPD page, add sample CPD usage to quickstart page 2018-05-25 20:39:14 +02:00
Akshat Bahety
f07f0b8fff Merge branch 'master' of https://github.com/pmd/pmd 2018-05-25 22:51:06 +05:30
Clément Fournier
c6367a84d8 Fix JCommander help for -min option 2018-05-25 18:35:20 +02:00
Clément Fournier
dcd05a7e5b Fix bug with XPath exceptions in the designer
They would be logged to stderr and not forwarded to the event log
2018-05-25 04:12:05 +02:00
Clément Fournier
c145ff5d3f render_markdown filter 2018-05-25 03:16:01 +02:00
Clément Fournier
de080f02e4 Improve CLI reference 2018-05-25 03:02:37 +02:00
Akshat Bahety
6f2cbfc613 Removed RefreshAST from Designer 2018-05-25 00:43:31 +05:30
Andreas Dangel
19d65171bd Rename colors.sh -> logger.sh 2018-05-24 19:20:12 +02:00
Andreas Dangel
281f151197 Use log_info, log_error, log_success functions instead of the colors 2018-05-24 19:18:57 +02:00
Juan Martín Sotuyo Dodero
ec015d5604 Merge pull request #1144 from oowekyala/update-issue-template
[core] Update issue template
2018-05-24 13:22:19 -03:00
Clément Fournier
eb21f3189d Small improvements 2018-05-24 17:58:54 +02:00
Clément Fournier
a66064446a Update issue template 2018-05-24 17:24:52 +02:00
Clément Fournier
ae8a26c22d Change index title 2018-05-24 17:23:44 +02:00
Travis CI (pmd-bot)
fcd38e3932 Update documentation 2018-05-24 14:37:58 +00:00
Juan Martín Sotuyo Dodero
56e4605eae Merge branch 'pr-1134' 2018-05-24 11:24:59 -03:00
Juan Martín Sotuyo Dodero
c42b39315f Update changelog, refs #1134 2018-05-24 11:24:38 -03:00
Andreas Dangel
206b389974 Update release notes for 6.4.0 - This is a minor release. 2018-05-24 08:30:07 +02:00
Clément Fournier
cf0eb9a9bd Checkstyle 2018-05-24 03:58:29 +02:00
Clément Fournier
f26e982b7f Update release notes, refs #1141 2018-05-24 01:37:21 +02:00
Clément Fournier
463c1c03cd Fix #1114 - Star import overwritten by explicit import is not correctly handled 2018-05-24 01:33:01 +02:00
Clément Fournier
fbd58c14d5 Make tests more readable 2018-05-24 01:25:34 +02:00
Clément Fournier
f463038327 Cleanup UnnecessaryFQN 2018-05-24 01:25:31 +02:00
Clément Fournier
3e159310d2 Document ASTImportDeclaration 2018-05-24 01:10:20 +02:00
Akshat Bahety
beabf09339 Checkstyle Updates 2018-05-24 02:20:46 +05:30
Akshat Bahety
b4b22e96b8 Checkstyle Updates 2018-05-24 01:03:44 +05:30
Clément Fournier
c80cfd6113 Corrections for PR #1134 2018-05-23 21:25:22 +02:00
Travis CI (pmd-bot)
ebf00fc7cf Update documentation 2018-05-23 18:40:20 +00:00
Andreas Dangel
3a65e5059c Merge branch 'pr-1140' 2018-05-23 20:22:23 +02:00
Andreas Dangel
f300d4713b Update release notes, fixes #720, refs #1140 2018-05-23 20:22:14 +02:00
Clément Fournier
0fa74aacfb Improve test readability 2018-05-23 19:41:04 +02:00
Clément Fournier
9cc8068881 Whitelist lambda parameters 2018-05-23 19:38:06 +02:00
Clément Fournier
5ecf60b73c Refactor ShortVariable
No change in functionality, but less wasted tests
2018-05-23 19:32:22 +02:00
Clément Fournier
89bc6c94c8 Whitelist main classes with private static fields 2018-05-23 17:13:44 +02:00
Clément Fournier
8e1ff80573 Allow Helper as a suffix 2018-05-23 17:06:58 +02:00
Clément Fournier
5ea314bc74 Update pmd-doc tests 2018-05-23 16:31:29 +02:00
Clément Fournier
c75a209d31 Fix some display issues with Bootstrap grid, rewrite index summary
Update 404.md
2018-05-23 16:10:16 +02:00
Clément Fournier
5da6525276 Corrections for PR 2018-05-23 04:03:31 +02:00
Clément Fournier
cbfd39b7ca Revert to simple shuffle layout 2018-05-23 02:44:30 +02:00
Clément Fournier
56bcc6f700 Add knowledge base style filter buttons 2018-05-23 02:42:01 +02:00
Akshat Bahety
7d5b44cd8a Merge Conflicts 2018-05-23 02:18:04 +05:30
Akshat Bahety
c272f5251d Removes the need to use RefreshAST every time 2018-05-23 02:03:40 +05:30
Andreas Dangel
fef93eec64 [ci] Add webhooks build notification for gitter 2018-05-22 20:40:37 +02:00
Andreas Dangel
8d21a855e5 Update default snapshot documentation url, use github 2018-05-22 20:31:45 +02:00
Andreas Dangel
ac9f0ac1d4 [ci] Add colors, don't fail the build/release if upload to sourceforge fails 2018-05-22 20:29:32 +02:00
Andreas Dangel
958c509209 [ci] Upload the generated documentation to pmd.sourceforge.net as well 2018-05-22 20:29:32 +02:00
Clément Fournier
392998e4a3 Cleanup 2018-05-22 17:09:26 +02:00
Clément Fournier
f5a0750557 Ignore main method when detecting utility classes 2018-05-22 16:17:10 +02:00
Clément Fournier
1140c1ec56 Allow Utils as suffix 2018-05-22 16:06:19 +02:00
Clément Fournier
fe8752bf67 update tests 2018-05-22 15:49:43 +02:00
Clément Fournier
ce0f151c66 Update codestyle.xml 2018-05-22 15:46:32 +02:00
Clément Fournier
56339f6793 Update rule desc 2018-05-22 15:45:34 +02:00
Clément Fournier
9e7aceed56 Allow numbers in utility class names by default
Refs #1065
2018-05-22 15:41:26 +02:00
Travis CI (pmd-bot)
72f5539a8b Update documentation 2018-05-22 04:58:32 +00:00
Juan Martín Sotuyo Dodero
d846fc5b51 Merge branch 'pr-1129' 2018-05-22 01:48:35 -03:00
Juan Martín Sotuyo Dodero
f06603fc67 Update changelog, refs #1129 2018-05-22 01:48:20 -03:00
Juan Martín Sotuyo Dodero
c3dcb70e9c Further improvements 2018-05-22 01:45:13 -03:00
Karl-Philipp Richter
16ad6904bd Adjust InefficientEmptyStringCheck documentation
InefficientEmptyStringCheckRule.java and the corresponding section
both contain information which the other doesn't. The class Javadoc and
the description section in performance.xml has thus been adjusted.
2018-05-22 06:40:25 +02:00
Juan Martín Sotuyo Dodero
aa2f8b70f1 [java] improve how we deal with broken classes 2018-05-22 01:34:37 -03:00
Juan Martín Sotuyo Dodero
c417d68191 Merge branch 'pr-1126' 2018-05-21 17:00:10 -03:00
Juan Martín Sotuyo Dodero
9ebf624ccb Update changelog, refs #1126 2018-05-21 16:59:22 -03:00
Clément Fournier
5485d08630 Order shuffle panels w.r.t the sidebar ordering 2018-05-21 16:49:12 +02:00
Andreas Dangel
6392642692 Fix release notes, take 2 2018-05-21 15:08:44 +02:00
Andreas Dangel
c85365798b Fix release notes 2018-05-21 15:07:08 +02:00
Andreas Dangel
b808da70a0 Update documentation 2018-05-21 15:03:29 +02:00
Andreas Dangel
4138cdc018 Merge branch 'pr-966' 2018-05-21 14:57:34 +02:00
Andreas Dangel
43f9237e63 Update release notes, fixes #955, refs #966 2018-05-21 14:55:16 +02:00
Andreas Dangel
af7a8b3eb6 Merge branch 'pr-1123' 2018-05-21 13:45:20 +02:00
Travis CI (pmd-bot)
edbc1f479a Update documentation 2018-05-21 11:36:09 +00:00
Andreas Dangel
c95428d27a Merge branch 'pr-1046' 2018-05-21 13:12:24 +02:00
Andreas Dangel
430238113c Update release notes, refs #1046 2018-05-21 12:59:38 +02:00
Andreas Dangel
b3460f6951 whitespaces, javadoc 2018-05-21 12:53:51 +02:00
Andreas Dangel
f14fbd02b5 Rework InsecureCryptoIvRule to use RuleChain on AllocationExpression
No need for Util. Use Symbol Table instead.
2018-05-21 12:46:29 +02:00
Andreas Dangel
e9f6668c9b Rework HardCodedCryptoKeyRule to use RuleChain on AllocationExpression and symbol table 2018-05-21 12:40:34 +02:00
Andreas Dangel
af250c3503 whitespaces 2018-05-21 11:56:23 +02:00
Clément Fournier
dacb0c2e61 Add some more panels to the shuffle page 2018-05-21 11:54:10 +02:00
Clément Fournier
918a812d92 Add logic to exclude some pages based on some tags 2018-05-21 11:54:10 +02:00
Clément Fournier
bb51792ba7 Add shuffle animations to landing page 2018-05-21 11:54:10 +02:00
Clément Fournier
36d07a5060 Update tags all over 2018-05-21 11:54:10 +02:00
Clément Fournier
c3a74507c6 Brush up Suppressing warnings 2018-05-21 11:54:10 +02:00
Clément Fournier
04b0859fb2 Merge Understanding rulesets into Making rulesets 2018-05-21 11:54:10 +02:00
Clément Fournier
891df94c49 Fix header level 2018-05-21 11:54:10 +02:00
Clément Fournier
29e4ce1314 You should transform "using rule properties" to a whole "configuring rules" page 2018-05-21 11:54:10 +02:00
Clément Fournier
8f43350b64 Rewrite understanding_rulesets.md, needs merging with making_rulesets.md 2018-05-21 11:54:10 +02:00
Clément Fournier
457ba978b5 Update tags, make CLI reference page 2018-05-21 11:54:10 +02:00
oowekyala
34ddf6a2ef Added installation page as quickstart 2018-05-21 11:54:10 +02:00
Clément Fournier
1993fce431 Create parameterised include for shuffle panel
Also added some liquid extensions
2018-05-21 11:54:10 +02:00
Clément Fournier
9924bd8bfe Landing page is WIP, add some tags to languages 2018-05-21 11:54:10 +02:00
Andreas Dangel
ac7b94aaa2 The rule is new with 6.4.0. Sort alphabetically 2018-05-21 11:52:11 +02:00
Andreas Dangel
4d31d1fb04 whitespaces 2018-05-21 11:51:24 +02:00
Andreas Dangel
1ee12a4792 Merge branch 'pr-1080'
Fixes #1018
2018-05-21 11:39:21 +02:00
Andreas Dangel
ae3900451e [ui] add "var" as keyword for syntax highlighter 2018-05-21 11:26:26 +02:00
Andreas Dangel
a305f78e26 [java] Reuse isTypeInferred of ASTTYpe for variables 2018-05-21 11:17:25 +02:00
Andreas Dangel
8f4b2647c4 Merge branch 'master' into java10-basic-support 2018-05-21 10:07:05 +02:00
Karl-Philipp Richter
1f18181ef5 Improve implementation hint in InefficientEmptyStringCheck
The alternative implementation mentions iterating over the string and
checking for whitespace which is pretty clear, however, showing the
implementation doesn't hurt, nor does the hint for Apache
commons-lang's StringUtils.isBlank which does exactly that.

The if statement in the demonstration of inefficient code can lead to
confusion because users _might_ think that the check is only
inefficient inside an if statement although it's clear from the
description that it's not.
2018-05-21 06:15:17 +02:00
Juan Martín Sotuyo Dodero
625431f8b1 Remove unnecessary log 2018-05-20 20:33:26 -03:00
Travis CI (pmd-bot)
1d3906356d Update documentation 2018-05-20 06:10:48 +00:00
Juan Martín Sotuyo Dodero
75ea178df4 Merge branch 'pr-1053' 2018-05-20 02:55:25 -03:00
Juan Martín Sotuyo Dodero
998dd2d3ee Merge branch 'pr-1111' 2018-05-20 02:48:22 -03:00
Juan Martín Sotuyo Dodero
a4e4acb4d9 Simplify code 2018-05-20 02:43:18 -03:00
Juan Martín Sotuyo Dodero
3bbebdcabd Fix checkstyle 2018-05-20 02:32:10 -03:00
Juan Martín Sotuyo Dodero
7a23ca638a Avoid NPE
- Fix a bunch of errors in message building along the way
2018-05-20 02:25:58 -03:00
Clément Fournier
a4ea6f8fb5 Multiple improvements and bug corrections in VariableDeclaratorId 2018-05-20 01:09:24 +02:00
Clément Fournier
07b8c4f9b2 Merge branch 'pr-1068' 2018-05-20 01:09:10 +02:00
Clément Fournier
a0ed10c0e7 Update release notes, refs #1075 2018-05-19 23:53:54 +02:00
Clément Fournier
bb1dd661db Merge branch 'pr-1075' 2018-05-19 23:43:44 +02:00
Juan Martín Sotuyo Dodero
4e7c778d3a Merge branch 'pr-1122' 2018-05-19 13:42:59 -03:00
Andreas Dangel
25f51db8d7 [java] Parser Error / Nullpointer when analyzing local generic class 2018-05-19 14:33:30 +02:00
Andreas Dangel
bdb48a963f whitespace 2018-05-19 14:09:32 +02:00
Andreas Dangel
f5f07220ad [java] Fix NPE in InsecureCryptoIvRule 2018-05-19 14:06:02 +02:00
Andreas Dangel
1211e88363 [java] Fix null pointer with local vars in type resolution 2018-05-19 13:25:08 +02:00
Andreas Dangel
17fc7fae5a [java] Fix NPE with ForLoopCanBeForeachRule when using this 2018-05-19 12:02:11 +02:00
Andreas Dangel
0b90fd0154 [java] Fix processing error with Cast + MethodReference
Occurred in https://github.com/spring-projects/spring-framework/blob/master/spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultListableBeanFactory.java#L746
2018-05-19 10:29:20 +02:00
Clément Fournier
059b0f15c0 Abstract functionality of naming conventions rules 2018-05-19 00:19:14 +02:00
Juan Martín Sotuyo Dodero
38f758cf26 Merge branch 'pr-1118' 2018-05-18 19:09:04 -03:00
Clément Fournier
4f6150548e Fix bug with getImage overriding 2018-05-18 21:42:18 +02:00
Andreas Dangel
f80dc37e6c Merge branch 'pr-1116' 2018-05-18 21:10:43 +02:00
Andreas Dangel
8747d3e395 Merge branch 'pr-1113' 2018-05-18 21:08:24 +02:00
Clément Fournier
fb4bf5f4c7 Fix a couple of typos & checkstyle warnings 2018-05-18 21:08:03 +02:00
Clément Fournier
c10d920248 Fix implementation of isFindBoundary, add some doc 2018-05-18 21:00:35 +02:00
Clément Fournier
d1ce28d0c9 Fix wrong implementation of hasImageEqualTo 2018-05-18 20:54:43 +02:00
Clément Fournier
bf10765b0b Update release notes, refs #1116 2018-05-18 18:52:01 +02:00
Clément Fournier
8f9a8d9cb4 Remove invalid doc for multifile analysis 2018-05-18 18:50:10 +02:00
Clément Fournier
9eefc901e4 Fix link to CONTRIBUTING.md
Closes #1112
2018-05-18 14:36:52 +02:00
Clément Fournier
8c34397397 Use "latest" in sitemap instead of the other 2018-05-18 02:19:20 +02:00
Clément Fournier
cc9bd77560 Use standard output instead of hardcoding output file 2018-05-18 02:10:41 +02:00
Clément Fournier
3687f9308e Plug into release.sh 2018-05-18 01:51:05 +02:00
Clément Fournier
b22467e32a Add index pages 2018-05-18 01:32:42 +02:00
Clément Fournier
1272f597e6 Simplify, "latest" dir is ignored 2018-05-18 01:18:09 +02:00
Clément Fournier
f7f11990ad First version, with two loops 2018-05-18 01:16:02 +02:00
Clément Fournier
3062397c95 Add test case for premature decl inside lambda 2018-05-17 23:34:14 +02:00
Clément Fournier
3a572e4a0f Add todo for faster impl of hasDescendantOfAnyType 2018-05-17 23:26:30 +02:00
Clément Fournier
69c8af287a Fix a random false negative 2018-05-17 23:21:00 +02:00
Clément Fournier
7fb2641153 Simplify rule 2018-05-17 23:20:58 +02:00
Clément Fournier
eb4610c0fc Add regression test case, refs #1108 2018-05-17 23:08:25 +02:00
Andreas Dangel
787d62420c Fix unit test, handle Pattern special 2018-05-17 21:00:05 +02:00
Andreas Dangel
61ce9ca3b3 Update changelog, refs #1111 2018-05-17 20:36:09 +02:00
Andreas Dangel
69fc648edd [java] JUnit4TestShouldUseTestAnnotation
*   use xpath 2.0
*   add new regex parameter
*   use typeof
2018-05-17 20:35:58 +02:00
Andreas Dangel
dcf73bf91a [java] False Alarm of JUnit4TestShouldUseTestAnnotation on Predicates
Fixes #572
2018-05-17 16:32:47 +02:00
Travis CI (pmd-bot)
699a8fe099 Update documentation 2018-05-17 12:00:39 +00:00
Clément Fournier
cb6b8277e4 Merge branch 'pr-1101' 2018-05-17 13:48:49 +02:00
Clément Fournier
b93320f723 Update release notes, refs #1101
Closes #1021
2018-05-17 13:47:24 +02:00
Akshat Bahety
6d1d5e5963 Code Style Changes 2018-05-17 12:44:33 +05:30
Andreas Dangel
fa24fa04af Merge branch 'pr-1106' 2018-05-16 19:43:27 +02:00
Andreas Dangel
0544441caa Update release notes, refs #1106, fixes #1100 2018-05-16 19:42:19 +02:00
Andreas Dangel
7b51dd1570 Extend unit tests, refs #1100 2018-05-16 19:41:58 +02:00
Akshat Bahety
dd3f20956f Changes 2018-05-16 23:04:42 +05:30
Travis CI (pmd-bot)
5dfdb5870e Update documentation 2018-05-16 17:24:19 +00:00
Andreas Dangel
fe44f9267e Fix unit test, refs #1105 2018-05-16 19:05:45 +02:00
Juan Martín Sotuyo Dodero
6d7926ca39 Merge branch 'pr-1105' 2018-05-16 12:10:32 -03:00
Robert Sösemann
9a2ac14b05 [vf] URLENCODE is ignored as valid escape method #1100 2018-05-16 15:46:40 +02:00
Clément Fournier
ead33c45bc Update release notes, refs #1105 2018-05-16 14:26:25 +02:00
Clément Fournier
47ffacdf59 Add header before XPath expression in docs 2018-05-16 14:20:25 +02:00
Juan Martín Sotuyo Dodero
d2dcbd4f1c Merge branch 'master' into issue-1051 2018-05-15 10:25:50 -03:00
Akshat Bahety
efc4644b93 Checkstyle Update 2018-05-15 17:57:18 +05:30
Travis CI (pmd-bot)
03aa8d3629 Update documentation 2018-05-15 07:34:43 +00:00
Andreas Dangel
03354aa92a Merge branch 'pr-1097' 2018-05-15 09:17:30 +02:00
Andreas Dangel
9edcbc5d42 Update release notes, refs #1097 2018-05-15 09:16:47 +02:00
Andreas Dangel
393cac8930 [java] Use typeResolution for AvoidThrowingRawExceptionTypes 2018-05-15 09:16:04 +02:00
Andreas Dangel
a5207b017c Merge branch 'pr-1098' 2018-05-15 09:09:51 +02:00
Andreas Dangel
8d6e357383 Update release notes, refs #1098 2018-05-15 09:08:58 +02:00
Andreas Dangel
bc31d9ac63 [java] Simplify ByteInstantiation and ShortInstantiation, too
refs #1098
2018-05-15 09:07:52 +02:00
Andreas Dangel
89a1ad99ba Merge branch 'pr-1099' 2018-05-15 08:53:43 +02:00
Akshat Bahety
80d87aab0f Fixes #1021
adding the error file for typeres
2018-05-14 20:03:35 +05:30
Akshat Bahety
8fb843626c Merge branch 'master' of https://github.com/pmd/pmd 2018-05-14 19:52:28 +05:30
Akshat Bahety
958fd34c0f Fixes #1021 2018-05-14 19:45:41 +05:30
Juan Martín Sotuyo Dodero
676e76dbc1 Update changelog, refs #1099 2018-05-12 02:10:07 -03:00
Juan Martín Sotuyo Dodero
13f0c8000a [java] Don't report UseUtilityClass when extending
- Since the parent class is not a utility, we are neither (the parent
class may have non-static methods and fields).
 - Since this is more general than the original check for exception
types, we remove that
 - Fixes #824
 - Take the chance to have the rule use the rulechain
2018-05-12 02:06:42 -03:00
Juan Martín Sotuyo Dodero
9b3fcc2608 [java] Simplify LongInstantiation and IntegerInstantiation
- Narrow down both rule's search space (therefore making better usage
of the rulechain and reducing number of checks performed)
 - Use type resolution to simplify the rules and avoid FPs when
declaring classes with the same names
2018-05-12 01:37:59 -03:00
Juan Martín Sotuyo Dodero
a378299978 Use type resolution for AvoidThrowingRawExceptionTypes
- Fixes the false negatives
 - Is actually 100X faster as we avoid all those `//ImportDeclaration`
2018-05-12 01:06:38 -03:00
Juan Martín Sotuyo Dodero
43839bd772 Failing test case for AvoidThrowingRawExceptionTypes 2018-05-12 01:03:33 -03:00
Andreas Dangel
70cbfd028e Merge remote-tracking branch 'origin/master' into java10-basic-support 2018-05-11 16:21:08 +02:00
Andreas Dangel
c7ee1e02e4 Update release notes, fixes #743 2018-05-11 16:17:06 +02:00
Andreas Dangel
93347719b3 [java] Rename ASTType.isVarType to ASTType.isTypeInferred 2018-05-11 16:17:00 +02:00
Andreas Dangel
b0266e3e77 [java] Populate types for VariableDeclarator and VariableDeclaratorId
when using local-var type inference
2018-05-11 16:16:52 +02:00
Andreas Dangel
a1b2d59fc2 [java] infer type for method arguments, too 2018-05-11 16:16:38 +02:00
Andreas Dangel
fd3c425d0a [java] Resolve var type in enhanced for loop 2018-05-11 14:36:16 +02:00
Andreas Dangel
e2815a62d7 [java] var type in for loops and try-with-resources
Note: for loop enhanced doesn't support the type resolution yet
2018-05-11 09:43:05 +02:00
Juan Martín Sotuyo Dodero
1e73b8c0c5 Further cleanups 2018-05-11 01:14:26 -03:00
Juan Martín Sotuyo Dodero
d4c016d19d Update changelog, refs #1080 2018-05-10 20:56:24 -03:00
Juan Martín Sotuyo Dodero
85d3089413 Fix copy paste 2018-05-10 20:53:22 -03:00
Juan Martín Sotuyo Dodero
cf914f424d [core] Hack to get Ant's log level
- Very ugly, uses reflection and is limited to the few
implementatations that come with Ant itself or and testutils
 - Intended as a starting point for fixing #1018
2018-05-10 20:53:22 -03:00
Juan Martín Sotuyo Dodero
254c08ea75 Rework into an autoclosable
- Allow callers to simply use a try-with-resources around the measured
code
2018-05-10 20:23:52 -03:00
Juan Martín Sotuyo Dodero
c51fac8dad Better handle mono-thread case 2018-05-09 19:29:54 -03:00
Juan Martín Sotuyo Dodero
0e1b565d03 Minor cleanups 2018-05-09 19:18:43 -03:00
Juan Martín Sotuyo Dodero
21ee3f76ed Merge branch 'pr-1085' 2018-05-09 19:14:06 -03:00
Juan Martín Sotuyo Dodero
1fc1797281 Update changelog, refs #1085 2018-05-09 19:13:49 -03:00
Clément Fournier
329e092e00 Make ClassNamingConventions' utility class definition more precise
Classes which have a superclass or implement an interface are not flagged
as utility classes anymore.
2018-05-08 19:41:17 +02:00
Andreas Dangel
ad4166e300 Merge branch 'pr-1083' 2018-05-08 09:17:40 +02:00
Andreas Dangel
5b0ea25f04 Update release notes, fixes #1077, refs #1083 2018-05-08 09:17:23 +02:00
Clément Fournier
a8bd283545 Fix lambda qname infix in enum constants 2018-05-08 01:31:08 +02:00
Andreas Dangel
f0b847a7ad [java] Determine type for Local Variable using the initializer's expression 2018-05-07 19:47:25 +02:00
Juan Martín Sotuyo Dodero
bcb3f65edb Avoid NPE 2018-05-07 02:43:34 -03:00
Juan Martín Sotuyo Dodero
fb55ca703e Also keep lambdas in a single scope 2018-05-06 20:42:51 -03:00
Juan Martín Sotuyo Dodero
c8b34b0dec Simplify test 2018-05-06 20:42:51 -03:00
Juan Martín Sotuyo Dodero
980c72a10a Simplify constructor scopes 2018-05-06 20:42:51 -03:00
Juan Martín Sotuyo Dodero
eec6ad88c8 Update changelog, refs #1068 2018-05-06 20:42:51 -03:00
Juan Martín Sotuyo Dodero
5de405d23f [java] Fix scoping inconsistencies
- Reduce LocalScope creations. Method parameters and method locals have
the same visibility / reachability, so they should be in the same scope.
 - Fix the grammar `assert` lookahead. There is no need to use `(`
 - Fix illegal test code (shadowing of parameters is illegal)
 - Update Scope tests to deal with changes
 - Fixes #1051
2018-05-06 20:42:33 -03:00
Juan Martín Sotuyo Dodero
2f4d852017 Use the right import 2018-05-03 21:45:52 -03:00
Juan Martín Sotuyo Dodero
0bb75c2ce0 Changes requested by reviewer 2018-05-03 21:41:05 -03:00
Clément Fournier
dd2dcf6357 Merge branch 'pr-1071' 2018-05-03 23:43:59 +02:00
Juan Martín Sotuyo Dodero
8af01d6565 [core] Rework benchmarking code
The old implementation had many limitations:
 - Relayed ALL measuring logic to the client
 - Used `synchronized` methods
 - Was unable to measure nested operations without mixing values
 - Mixed wall-clock and CPU time, which caused trouble when running
multithreaded analysis (negative values for non-meassured time)
 - A separate `main` existed which was undocumented and unsupported.

So I reworked it and added some goodies along the way:
 - When not running in benchmark mode, all operations are NOOPs
 - Nested operations are the default. Total and self time are
differentiated. This allows and encourages to better track overhead (ie:
time spent in a loop over another timed operation)
 - We can meassure call count along with custom counters, which add
meaning to metrics
 - Wall clock time for total execution is separated from all other CPU
times
 - All meassurements are done by the `TimeTracker` itself
 - No `synchronized` use, all structs are thread-safe and lock as little
and sporadically as possible
 - Categories can be split up by labels
 - The tracker is generic, has little knowledge of what is being
tracked. Same applies to report rendering. This is extremely flexible to
add more and custom tracks in the future
2018-05-02 12:31:53 -03:00
Juan Martín Sotuyo Dodero
863083d1a8 Merge branch 'pr-1072' 2018-05-01 14:55:40 -03:00
Clément Fournier
08a37c75cb Avoid some unnecessary computations
They're possibly expensive, eg tree traversal
2018-05-01 18:16:08 +02:00
Andreas Dangel
d3d2fc2b9a [java] Fix rule error due to new AST structure 2018-05-01 17:14:06 +02:00
Andreas Dangel
4af3a52356 [java] Fix unit test - default language is now java10 2018-05-01 17:14:06 +02:00
Andreas Dangel
18dfba939c [java] First step for java10 local variable type inference 2018-05-01 17:14:06 +02:00
Andreas Dangel
8201ec984a [java] Use multiple threads for PMDCoverageTest 2018-05-01 16:48:29 +02:00
Andreas Dangel
60ac38cd71 [java] Update PMDCoverageTest to verify stderr now 2018-05-01 16:48:29 +02:00
Andreas Dangel
d85db07196 [core] Report exceptions thrown during rule execution 2018-05-01 16:48:24 +02:00
Juan Martín Sotuyo Dodero
0d56d76226 Update changelog, refs #1071 2018-04-30 19:04:43 -03:00
Juan Martín Sotuyo Dodero
7a5ff4fcfc [java] Fix false-positives on PrematureDeclaration
- The code failed to detect closures once we enforced find boundaries,
so we now explicitely ask to cross them
2018-04-30 19:02:53 -03:00
Juan Martín Sotuyo Dodero
5ce1bc331f Merge branch 'pr-1069' 2018-04-30 15:53:59 -03:00
Juan Martín Sotuyo Dodero
046d219fb1 Update changelog, refs #1069 2018-04-30 15:53:09 -03:00
Travis CI (pmd-bot)
618de0bb33 Update documentation 2018-04-30 18:09:23 +00:00
Juan Martín Sotuyo Dodero
69ab78accc Merge branch 'pr-1070' 2018-04-30 14:58:16 -03:00
Clément Fournier
7810c893a3 Checkstyle 2018-04-30 18:34:59 +02:00
Clément Fournier
30774b9ccc Update release notes, refs #1070
Closes #1065
2018-04-30 18:28:56 +02:00
Clément Fournier
f8e7b778db Allow numbers in class names 2018-04-30 18:26:05 +02:00
Clément Fournier
d34fd86735 Fix static and private method overriding 2018-04-30 17:58:22 +02:00
Clément Fournier
2abd5c5a59 Fix protected Object members in interface should not be overridden 2018-04-30 17:35:06 +02:00
Andreas Dangel
c6716388b9 Prepare next development version 2018-04-29 09:57:56 +02:00
Andreas Dangel
85874e7e9c [maven-release-plugin] prepare for next development iteration 2018-04-29 09:54:45 +02:00
Andreas Dangel
10c66fbf38 [maven-release-plugin] prepare release pmd_releases/6.3.0 2018-04-29 09:54:36 +02:00
Andreas Dangel
1c93a66747 Prepare pmd release 6.3.0 2018-04-29 09:48:03 +02:00
Andreas Dangel
f0b3ca893e Fix unit test 2018-04-28 20:58:21 +02:00
Andreas Dangel
7d46c453c2 Merge branch 'pr-945' 2018-04-28 20:53:46 +02:00
Travis CI (pmd-bot)
109de192ed Update documentation 2018-04-28 18:35:14 +00:00
Andreas Dangel
098ad9d8a1 Merge branch 'pr-1059' 2018-04-28 20:14:32 +02:00
Andreas Dangel
1051d8b822 Merge branch 'pr-1060' 2018-04-28 20:13:31 +02:00
Andreas Dangel
f11c15cbab Merge branch 'pr-1040' 2018-04-28 20:09:51 +02:00
Juan Martín Sotuyo Dodero
9f20fe164c Merge branch 'pr-1058' 2018-04-28 12:40:16 -03:00
Juan Martín Sotuyo Dodero
d77d389107 Merge branch 'pr-1062' 2018-04-28 12:36:39 -03:00
Juan Martín Sotuyo Dodero
0cd74d9c29 Update changelog, refs #1062 2018-04-28 12:36:23 -03:00
Austin Shalit
13ecaf970f Update ASM to version 6.1.1
This should bring ASM to a version that supports Java 10.
2018-04-28 11:12:53 -04:00
Andreas Dangel
9ca83da878 [doc] Surround the delimiter with spaces, so that the browser can
wrap the default value of multi properties nicely.
2018-04-28 12:05:47 +02:00
Clément Fournier
fd40bef3c2 Dummy commit, to rerun the build 2018-04-28 00:15:06 +02:00
Clément Fournier
cb53810e68 Refactor test, no more XPath 2018-04-28 00:04:45 +02:00
Clément Fournier
ae7536c623 Fix simple comments 2018-04-27 23:50:30 +02:00
Clément Fournier
43d8dc4742 Fix confusing lack of markup 2018-04-27 23:20:25 +02:00
Clément Fournier
f7cf9c16a4 Update release notes, refs #1060
Closes #1004
2018-04-27 23:02:57 +02:00
Clément Fournier
fd6b9098e8 Add checkSingleIfStmt property to ControlStatementBraces
Setting this property to false whitelists if statements without braces,
provided they do not appear in an if statement chain.

The property checkIfElseStmt overrides the new property. Unsetting the
former causes the latter to be noop.
2018-04-27 22:55:50 +02:00
Andreas Dangel
95f4ac62e8 [java] Property ignoredAnnotations does not work for SingularField and ImmutableField
Fixes #1056
2018-04-27 22:26:45 +02:00
Andreas Dangel
529d2da054 [doc] Document the delimiter for multi valued properties 2018-04-27 21:56:45 +02:00
Andreas Dangel
970fdffbb9 [doc] Fix multi value property documentation for rules
Fixes #1057
2018-04-27 21:45:40 +02:00
Clément Fournier
751ee8e167 Merge branch 'master' into improve-method-naming-conventions-rule 2018-04-27 00:07:52 +02:00
Clément Fournier
7d7c2dc94a Add known issue disclaimer 2018-04-26 15:02:55 +02:00
Clément Fournier
7a4a5496aa Support java10 correctly 2018-04-26 14:45:42 +02:00
Clément Fournier
6e1c2482f8 Support windows 2018-04-26 14:42:19 +02:00
Clément Fournier
dcf1a94cf8 Fix bug with empty scopes appearing with no parents
Not sure hiding empty scopes adds much, but it certainly does mess with the
current algorithm
2018-04-26 14:42:19 +02:00
Clément Fournier
930bdd235c Checkstyle + pmd 2018-04-26 14:42:19 +02:00
Clément Fournier
8c2cc4f792 Fix clicking on already selected tree item
The editor now scrolls back to the clicked node
2018-04-26 14:42:19 +02:00
Clément Fournier
5e819c5826 Make the ast treeview autoscroll when selecting a node that's not
visible
2018-04-26 14:42:12 +02:00
Juan Martín Sotuyo Dodero
9ee838758c Merge branch 'pr-778' 2018-04-25 01:43:07 -03:00
Juan Martín Sotuyo Dodero
b8e90e44d6 Update changelog, refs #778 2018-04-25 01:39:39 -03:00
Juan Martín Sotuyo Dodero
4c3f6e5c6b Merge branch 'pr-1033' 2018-04-25 00:35:26 -03:00
Juan Martín Sotuyo Dodero
fd48b98aa2 Merge branch 'pr-1048' 2018-04-25 00:20:49 -03:00
Juan Martín Sotuyo Dodero
fabc52946f Update changelog, refs #1048 2018-04-25 00:20:06 -03:00
Andreas Dangel
00bcecd603 Merge branch 'pr-1031' 2018-04-24 22:24:05 +02:00
Andreas Dangel
6cb0b47ef5 [apex] Add test case, refs #776
Note: only solution right now is supressing the rule for the string.
2018-04-24 22:22:48 +02:00
gibarsin
0942ae36f8 Make MultiThreadProcessor more space efficient 2018-04-24 15:51:10 -03:00
Andreas Dangel
6ccbd11f9d [doc] Update sample configuration of CyclomaticComplexity rule 2018-04-24 15:08:33 +02:00
Sergey Gorbaty
98fe1d3757 Final util 2018-04-23 14:25:08 -07:00
Sergey Gorbaty
ac8135c6a5 Style fix 2018-04-23 14:23:25 -07:00
Sergey Gorbaty
fcac918bd5 merging upstream 2018-04-23 14:03:58 -07:00
Sergey Gorbaty
2378444862 comments 2018-04-23 14:01:28 -07:00
Andreas Dangel
c7e493f283 [java] Enable security ruleset for all-java.xml 2018-04-23 21:21:22 +02:00
Travis CI (pmd-bot)
260f1da440 Update documentation 2018-04-23 19:20:29 +00:00
Andreas Dangel
ba6f3fb5cb Merge branch 'pr-1042' 2018-04-23 21:02:48 +02:00
Andreas Dangel
1f662e81f7 Update release notes, refs #1042 - new rule 2018-04-23 21:01:11 +02:00
Andreas Dangel
092ec8264a Merge branch 'pr-1045', fixes #1036 2018-04-23 20:29:40 +02:00
Andreas Dangel
391193c044 PMD dogfooding - avoid unnecessary local before return 2018-04-23 20:29:13 +02:00
Andreas Dangel
fd71799c83 Don't consider null literal inside lambda 2018-04-23 19:32:13 +02:00
Andreas Dangel
bc9b18cc69 [java] NullAssignment false positive
Fixes #629
2018-04-23 19:32:13 +02:00
Andreas Dangel
bf8855c1e5 Merge branch 'pr-1039' 2018-04-23 18:59:05 +02:00
Andreas Dangel
43e9a7c31b Update release notes, fixes #695 2018-04-23 18:57:46 +02:00
Clément Fournier
71ebcca079 Fix typos in release notes 2018-04-23 14:28:13 +02:00
Juan Martín Sotuyo Dodero
f855b572cc Update userdocs 2018-04-23 03:09:20 -03:00
Juan Martín Sotuyo Dodero
0243c08f84 Merge branch 'pr-1044' 2018-04-23 02:16:18 -03:00
Juan Martín Sotuyo Dodero
dac6d8c1a5 Update changelog, refs #1044 2018-04-23 02:15:45 -03:00
Akshat Bahety
b095e05bae Merge pull request #1 from akshatbahety/patch-2
Singleton Test Case
2018-04-23 10:32:32 +05:30
Akshat Bahety
92ecdde2f4 Singleton Test Case
Added a test case to check the singleton rule for nested classes
2018-04-23 10:29:43 +05:30
Akshat Bahety
c137ebaa60 CheckStyle Updated 2018-04-23 10:04:32 +05:30
Akshat Bahety
bee7adb33a Removed Debugging parts
Updated the file, removed the unnecessary debugging statements
2018-04-23 09:48:34 +05:30
Juan Martín Sotuyo Dodero
59bfc7ab52 Update changelog, refs #1045 2018-04-23 01:05:34 -03:00
Juan Martín Sotuyo Dodero
a91bc4bfb6 [core] Log only once all messages
- CLI runs log only to stderr, never to stdout
 - Both Ant and CLI runs log only once, the root logger never gets a
hold of the logs, completely isolating PMD
2018-04-23 01:02:35 -03:00
Akshat Bahety
1a51582963 Solution for issue #816
Fixed the issue with traversing the tree and checking out if the getInstance method is used twice under the same class.
2018-04-23 02:08:16 +05:30
Juan Martín Sotuyo Dodero
ce264cf0e4 Fix typos 2018-04-22 16:00:28 -03:00
Clément Fournier
855d528563 Merge branch 'pr-1041' 2018-04-22 18:05:39 +02:00
Clément Fournier
933235b140 Update release notes, refs #1041
Closes #1020
2018-04-22 18:05:30 +02:00
Juan Martín Sotuyo Dodero
6c19d9bed6 Update changelog, refs #1039 2018-04-22 02:48:35 -03:00
Juan Martín Sotuyo Dodero
fc2e0a625f [python] Support comment based CPD suppressions 2018-04-21 20:33:30 -03:00
Sergey Gorbaty
6f881116ed Removing comment 2018-04-19 14:15:49 -07:00
Sergey Gorbaty
ec86fd2584 HardCoded keys used as secrets 2018-04-19 14:13:15 -07:00
Sergey Gorbaty
d7ac0b8186 Using narrower scoped AST node + scope for global declarations 2018-04-18 15:20:26 -07:00
Sergey Gorbaty
f9ebe4c119 Version change and use of shorthands 2018-04-18 10:25:12 -07:00
Andreas Dangel
3d9c63a271 Update jacoco plugin for java10 compatibility 2018-04-18 10:28:56 +02:00
Andreas Dangel
22a50a14cf [ci] switch to Oracle jdk10 to support javafx 2018-04-18 10:05:53 +02:00
Andreas Dangel
6c6f644675 [ci] Switch to OpenJDK 10
See https://sormuras.github.io/blog/2018-03-20-jdk-matrix.html
2018-04-18 09:48:46 +02:00
Andreas Dangel
73a18d5fbd Update surefire plugin to support building with java10 2018-04-18 09:26:26 +02:00
Sergey Gorbaty
d3afc40c67 Remove unused code 2018-04-17 17:00:02 -07:00
Sergey Gorbaty
86e95d876c Refactoring 2018-04-17 16:47:13 -07:00
Sergey Gorbaty
9d360ced03 all zeros 2018-04-17 15:37:00 -07:00
Sergey Gorbaty
04bf04af10 Simple example 2018-04-17 15:36:33 -07:00
Sergey Gorbaty
475744b515 Code example 2018-04-17 15:32:33 -07:00
Sergey Gorbaty
1f7fc0ac8b Indentation and license 2018-04-17 15:27:58 -07:00
Sergey Gorbaty
a3f30476ce Hard-coded IV used in crypto operations 2018-04-17 15:02:05 -07:00
Andreas Bergander
7c7a66d750 Make BasicProjectMemoizer thread safe. Fixes issue #1020. 2018-04-17 17:51:32 +02:00
Clément Fournier
3716329a3a Update rule desc and changelog 2018-04-16 16:00:17 +02:00
Clément Fournier
34cc9ed8fe Add tests 2018-04-16 16:00:17 +02:00
Clément Fournier
47923d6eb4 Add regex properties to MethodNamingConventions
Brush up some AST classes
2018-04-16 16:00:12 +02:00
Juan Martín Sotuyo Dodero
539773eb5b Fix PMD dogfooding 2018-04-15 15:37:40 -03:00
Juan Martín Sotuyo Dodero
b965090cc7 [plsql] Support comment-based CPD suppressions 2018-04-15 14:21:42 -03:00
Juan Martín Sotuyo Dodero
29aed16cb9 PMD dogfooding 2018-04-15 12:53:06 -03:00
Juan Martín Sotuyo Dodero
dd1a2910c1 Fixing broken build 2018-04-15 12:46:08 -03:00
Juan Martín Sotuyo Dodero
94f00f4baf [obj-c] Add support for CPD comment-based suppressions 2018-04-15 03:07:48 -03:00
Juan Martín Sotuyo Dodero
cf9b768b90 [matlab] Support comment based CPD suppressions 2018-04-15 02:58:04 -03:00
Juan Martín Sotuyo Dodero
78f7343713 [javascript] Support comment based CPD suppressions 2018-04-15 02:21:28 -03:00
Juan Martín Sotuyo Dodero
94103cb0c2 Merge branch 'pr-1030' 2018-04-15 02:09:35 -03:00
Juan Martín Sotuyo Dodero
04c6451e29 Update PR template
- Use maven wrapper
 - Request to pass PMD dogfood rules
2018-04-15 02:08:21 -03:00
Juan Martín Sotuyo Dodero
052c46f5b6 Merge branch 'pr-1006' 2018-04-15 02:06:41 -03:00
Juan Martín Sotuyo Dodero
9d4354333d Use atomic operations on concurrentmap
- Take the chance to actually use the lazy loading
2018-04-15 02:05:45 -03:00
Juan Martín Sotuyo Dodero
e838179bb2 Fix PMD dogfooding 2018-04-15 01:44:02 -03:00
Juan Martín Sotuyo Dodero
47e345945e [cpp] Allow CPD suppressions with comments 2018-04-14 22:33:37 -03:00
Clément Fournier
83ce600782 Use JunitLoggingRule to intercept log 2018-04-14 04:00:38 +02:00
Clément Fournier
5a65701d0c Add hamcrest matchers to pom for pmd-core 2018-04-14 03:51:35 +02:00
Clément Fournier
0138b1a69b Use ConcurrentMap instead of Set 2018-04-14 03:34:36 +02:00
Andreas Dangel
28714a156b [java] enable type resolution for AvoidUsingShortType
refs #586
2018-04-13 11:12:51 +02:00
Juan Martín Sotuyo Dodero
d6bea21ed6 [core] Refactor CPD token filtering
- Define a generic `TokenFilter` interface in pmd-core
 - Provide a base, extension-friendly `JavaCCTokenFilter` to process and
filter JavaCC token streams, honoring `CPD-OFF` and `CPD-ON` comments
 - Refactor the `JavaTokenizer` to use `JavaCCTokenFilter` by extending
it and adding custom Java-specific token filters
2018-04-11 01:49:40 -03:00
Travis CI (pmd-bot)
379eaed2c8 Update documentation 2018-04-10 15:50:58 +00:00
Juan Martín Sotuyo Dodero
95b20073ae Merge branch 'pr-1032' 2018-04-10 12:34:49 -03:00
Andreas Dangel
5fa3167868 Corrections from PR #1032 2018-04-10 17:29:23 +02:00
Andreas Dangel
b720210723 [java] AvoidUsingShortType erroneously triggered on overrides of 3rd party methods
Fixes #586
2018-04-10 16:29:04 +02:00
Juan Martín Sotuyo Dodero
ffd88ef11e Update changelog, refs #776 2018-04-10 01:31:51 -03:00
Juan Martín Sotuyo Dodero
c77b0b44f3 [apex] Stricter hardcoded ID detection
- IDs are only 15, or 18 digits long
 - 18 digits long IDs are actually 15 digit IDs + checksum, which is now
validated
 - Resolves #776
2018-04-10 01:28:29 -03:00
Andreas Dangel
9d40872259 Avoid potential NPE 2018-04-09 20:29:49 +02:00
Andreas Dangel
bd7489c773 [doc] fix link understanding_rulesets -> making_rulesets 2018-04-09 19:40:27 +02:00
Andreas Dangel
f1923bd4b2 Merge branch 'pr-1026' 2018-04-09 19:30:22 +02:00
Andreas Dangel
228e0be0cd Update release notes, refs #1030 2018-04-09 17:30:40 +02:00
Andreas Dangel
ee5a7eefa3 [java] Refactor how the classloader is passed along, avoiding static 2018-04-09 17:07:07 +02:00
Travis CI (pmd-bot)
e315b3b409 Update documentation 2018-04-09 13:53:11 +00:00
Juan Martín Sotuyo Dodero
b30a31397c Fix checkstyle 2018-04-09 10:43:36 -03:00
Juan Martín Sotuyo Dodero
1126a9334b Merge branch 'pr-1029' 2018-04-09 10:40:02 -03:00
Juan Martín Sotuyo Dodero
e86a635e46 Merge branch 'pr-1028' 2018-04-09 10:35:57 -03:00
Andreas Dangel
82cbd52240 [java] Fix wrong classloader for JavaQualifiedName 2018-04-09 15:34:25 +02:00
Andreas Dangel
354108dc40 [java] False positive for useless parenthesis
Fixes #1023
2018-04-09 12:28:13 +02:00
Andreas Dangel
3275c70b43 Remove old, left-over ruleset documentation 2018-04-09 11:40:20 +02:00
Andreas Dangel
955ab11922 [doc] Use the rule names for the search index, include language
This provides better user experience for the search box on the
documentation page. The search results show now the rule name,
the language and the ruleset name.
2018-04-09 11:36:25 +02:00
Travis CI (pmd-bot)
427a6e041e Update documentation 2018-04-09 06:36:13 +00:00
Juan Martín Sotuyo Dodero
2f5501cc06 Escape pipes in rule default values
- This was breaking the tables for rules such as Java's
`EmptyCatchBlock`
2018-04-09 03:22:27 -03:00
Juan Martín Sotuyo Dodero
e2c1be9b25 Update changelog, refs #894 & #899 2018-04-09 02:23:07 -03:00
Juan Martín Sotuyo Dodero
50158421c1 [java] Prevent NPEs during JavaTypeDefinitionSimple.toString
- Resolves #894
 - Resolves #899
2018-04-09 02:20:25 -03:00
Travis CI (pmd-bot)
d300dc460f Update documentation 2018-04-08 07:44:16 +00:00
Andreas Dangel
bfae79011d Fix checkstyle 2018-04-08 09:33:12 +02:00
Juan Martín Sotuyo Dodero
a24e52b658 Merge branch 'pr-1024' 2018-04-07 21:30:25 -03:00
Juan Martín Sotuyo Dodero
0d8b41de08 Update changelog, refs #1024 2018-04-07 21:29:52 -03:00
Juan Martín Sotuyo Dodero
f8e64abb6e Simplify regexp 2018-04-07 21:23:12 -03:00
Juan Martín Sotuyo Dodero
8a9a47bcad Merge branch 'pr-1007' 2018-04-07 21:09:35 -03:00
Juan Martín Sotuyo Dodero
ae48542132 Revert check on initializers 2018-04-07 21:06:02 -03:00
Juan Martín Sotuyo Dodero
de68b4902f Fix doc formatting 2018-04-07 19:47:18 -03:00
Clément Fournier
8ae3916505 Merge branch 'master' into update-classnamingconventions 2018-04-07 17:42:19 +02:00
Clément Fournier
a3c93766df Move toCamelCase to StringUtil 2018-04-07 17:38:59 +02:00
Clément Fournier
4496aa7d6a Add getKind to AnyTypeBodyDeclaration 2018-04-07 17:24:24 +02:00
Utku Cuhadaroglu
56bf57ec2e Try to fix problem about enum whitlist 2018-04-07 18:09:45 +03:00
Andreas Dangel
4e331aca23 Add MicroDoc to credits page 2018-04-06 14:52:22 +02:00
Andreas Dangel
99a73ca59b Merge branch 'pr-1012'
Closes #1009
2018-04-06 10:01:52 +02:00
Andreas Dangel
344c67150f Update release notes, refs #1009, refs #1012 2018-04-06 09:50:02 +02:00
Utku Cuhadaroglu
e869ea43da fixed test typo 2018-04-05 18:22:22 +03:00
Utku Cuhadaroglu
ace459c670 Accept Enums as a Declaration 2018-04-05 18:18:22 +03:00
Utku Cuhadaroglu
99d38c2a52 Merge pull request #1 from pmd/master
Updated to Original
2018-04-05 18:02:43 +03:00
BBG
c94890b353 fixed comments 2018-04-05 18:41:20 +08:00
Travis CI (pmd-bot)
798c027d8d Update documentation 2018-04-04 15:02:55 +00:00
Andreas Dangel
fff1a5eeee Merge branch 'pr-1010' 2018-04-04 16:44:53 +02:00
Andreas Dangel
9ed902f3df Update release notes
refs #1003, refs #1010
2018-04-04 16:43:27 +02:00
Andreas Dangel
daa117b31d Merge branch 'pr-1013' 2018-04-04 15:43:33 +02:00
Juan Martín Sotuyo Dodero
a74553603d Merge branch 'issue-719' 2018-04-03 21:33:05 -03:00
Juan Martín Sotuyo Dodero
c9621b8880 More explicit implementation 2018-04-03 21:29:47 -03:00
Andreas Dangel
324e3f1208 Merge branch 'pr-1016' 2018-04-03 22:00:53 +02:00
kenji21
19f5110dc1 Update Swift.g4 for swift 4.1 2018-04-03 10:22:42 +02:00
kenji21
ea07ab1359 Merge remote-tracking branch 'upstream/master' 2018-04-03 08:49:12 +02:00
Juan Martín Sotuyo Dodero
eea475cd65 Update changelog, refs #719 2018-04-03 03:44:44 -03:00
Juan Martín Sotuyo Dodero
cb5c100465 [java] Ignore receiver parameters when matching signatures
- Allow sto match all method calls, meaning UnusedPrivateMethod will
not longer produce false positives
 - Resolves #719
2018-04-03 03:42:43 -03:00
Juan Martín Sotuyo Dodero
2052087676 [java] Allow UnusedFormalParameter to ignore receiver params
- Part of #719
2018-04-03 03:42:09 -03:00
Juan Martín Sotuyo Dodero
dbaf2475cf Update changelog, refs #988 2018-04-03 02:38:40 -03:00
Juan Martín Sotuyo Dodero
8c6688b854 [core] Ignore missing files form auxclasspath
- Resolves #988
2018-04-03 02:33:44 -03:00
BBG
27d2d88158 fixed comments 2018-04-02 10:36:35 +08:00
BBG
c0846c26a7 merge master 2018-04-01 19:46:45 +08:00
BBG
ca1aff2e8e fixed pmd violation 2018-04-01 19:16:28 +08:00
BBG
eb09126fb0 detects unnecessary constructor in enum 2018-04-01 19:16:28 +08:00
BBG
a8b3cebb96 Issue #1003: rewriting UneccessaryConstructorRule into java rule 2018-04-01 19:16:28 +08:00
Clément Fournier
3ca6e40197 Merge branch 'master' into update-classnamingconventions 2018-03-29 18:48:31 +02:00
Clément Fournier
a24d2cdb22 Add Generate XPath from stack trace in context menu
The dialog parses a stack trace into an XPath query.
2018-03-29 16:47:30 +02:00
BBG
c1306659fb Issue #1009: fixed FP of JUnitAssertionsShouldIncludeMessage with assertEquals in Junit5 2018-03-29 17:11:00 +08:00
Juan Martín Sotuyo Dodero
109c68be4d Merge branch 'pr-1011' 2018-03-29 02:12:22 -03:00
Juan Martín Sotuyo Dodero
5bc18b8298 Fix checkstyle warnings 2018-03-29 02:12:02 -03:00
Juan Martín Sotuyo Dodero
8aba5be2a1 Merge branch 'tree-transversal-boundaries' 2018-03-29 01:57:01 -03:00
Juan Martín Sotuyo Dodero
1e3b1bf0b5 Merge branch 'master' into tree-transversal-boundaries 2018-03-29 01:54:56 -03:00
Andreas Dangel
5156b1e856 Merge branch 'pr-1002'
Closes #994
2018-03-28 09:17:57 +02:00
Andreas Dangel
42bec12c58 Update changelog, refs #994 refs #1002 2018-03-28 09:15:46 +02:00
Clément Fournier
a3e687d7ee Update release notes, refs #1008 2018-03-28 00:57:37 +02:00
Clément Fournier
0545eadaad Merge branch 'pr-1008'
[core] DOC: fix closing tag for <pmdVersion>
2018-03-28 00:54:15 +02:00
stonio
8be7db8d3b Fix closing tag for pmdVersion 2018-03-27 17:40:45 +02:00
Clément Fournier
66983f0882 Use the rulechain 2018-03-27 15:32:25 +02:00
Clément Fournier
82799bdfe2 Fix property names and utility class detection 2018-03-27 15:05:06 +02:00
Clément Fournier
600ff54187 Update rule documentation and changelog 2018-03-27 14:10:40 +02:00
Clément Fournier
c7f5de7aa1 Make ClassNamingConventions configurable 2018-03-27 13:41:22 +02:00
Clément Fournier
958a26db38 CStyle 2018-03-26 20:53:29 +02:00
Clément Fournier
74bb7598c3 Ensure java rules don't use deprecated attributes
This could be extended to other languages once we
tackle #360
2018-03-26 20:36:40 +02:00
Clément Fournier
7754224f9d Fix deprecated XPath attribute not found
Deprecated attributes are not eliminated from the attribute iterator
anymore, which made deprecating attributes API breaking.

Instead, deprecated attribute usage are now detected and logged as
warnings
2018-03-26 20:29:14 +02:00
Clément Fournier
4253e8717e Improvements to designer syntax highlighting 2018-03-26 18:23:48 +02:00
Ishan Srivastava
e9e0ac97c6 [doc] Delete duplicate page contributing
as it is less maintained than contributing.md

Closes https://github.com/pmd/pmd/issues/994
2018-03-26 15:13:08 +05:30
Andreas Dangel
8625d769f1 Prepare next development version 2018-03-26 09:26:47 +02:00
Andreas Dangel
f3ab54d6da [maven-release-plugin] prepare for next development iteration 2018-03-26 09:23:23 +02:00
Andreas Dangel
59b360a60a [maven-release-plugin] prepare release pmd_releases/6.2.0 2018-03-26 09:23:14 +02:00
Andreas Dangel
a9dfd6e218 Prepare pmd release 6.2.0 2018-03-26 09:17:36 +02:00
Andreas Dangel
3bcecddbb0 Merge branch 'pr-986' 2018-03-26 09:03:24 +02:00
Juan Martín Sotuyo Dodero
7ef2168eae Merge branch 'pr-958' 2018-03-25 23:39:14 -03:00
Juan Martín Sotuyo Dodero
a895d9d3d9 Update changelog, refs #958 2018-03-25 23:37:37 -03:00
BBG
ab660eda54 Issue #955: resolve conflics 2018-03-26 10:35:59 +08:00
BBG
bd33ea2cc6 Issue #955: add subtree comparison function 2018-03-26 10:11:09 +08:00
Clément Fournier
d5f206dc0b Issue #955: add new rule to detect identical catch statement
It flags identical catch statements, based on token equality between the two blocks
Identical catch blocks.
2018-03-26 10:11:09 +08:00
Clément Fournier
cf9db2fed3 Ignore UselessOverridingMethod 2018-03-25 17:03:16 +02:00
BBG
9d9fa22c31 Issue #956: fixed comments 2018-03-25 14:06:43 +08:00
Clément Fournier
6751608b49 Merge branch 'master' into fix-ast-reference-type 2018-03-24 23:59:28 +01:00
Clément Fournier
ea700d84ec Fix designer 2018-03-24 23:48:46 +01:00
Clément Fournier
c589b026ff Make type of formal parameter consistent with variable declarator id 2018-03-24 23:45:09 +01:00
Clément Fournier
d6213b79b1 Merge branch 'master' into fix-ast-reference-type 2018-03-24 22:54:37 +01:00
Travis CI (pmd-bot)
3f1c441a5c Update documentation 2018-03-24 21:31:12 +00:00
Clément Fournier
dbcaf663f4 Fix CompareObjectsWithEquals 2018-03-24 22:17:59 +01:00
Andreas Dangel
14d474f333 Merge branch 'pr-991'
Closes #974
2018-03-24 22:13:37 +01:00
Andreas Dangel
8dfef6c165 Update changelog, refs #974 2018-03-24 22:13:27 +01:00
Clément Fournier
ee85254bd0 Merge branch 'master' 2018-03-24 19:05:13 +01:00
Clément Fournier
a193af1d4a Use auxclasspath ClassLoader to resolve type qualified names 2018-03-24 19:03:29 +01:00
BBG
f0ed81751a Issue #956: add AbstractJavaAnnotatableNode class 2018-03-24 18:39:22 +08:00
BBG
f86ca456a0 Issue #956: fixed comments 2018-03-24 18:39:22 +08:00
BBG
7616f8b7a8 Issue #956: Refactor ignoredAnnotationsDescripror in AbstractIgnoredAnnotRule class 2018-03-24 18:39:22 +08:00
BBG
e654c265a9 Issue #956: fixed comment 2018-03-24 18:39:21 +08:00
BBG
6888806e12 Fixed issue956 2018-03-24 18:39:21 +08:00
Juan Martín Sotuyo Dodero
cec32a8508 Merge branch 'pr-996' 2018-03-23 11:23:31 -03:00
Clément Fournier
d22c99b280 Rename VarDeclID method to isTypeInferred 2018-03-23 13:27:55 +01:00
Clément Fournier
f72463ebde Remove unnecessary comment 2018-03-23 13:18:52 +01:00
Andreas Dangel
579914fb7e Delete old dogfood rulesets 2018-03-23 10:33:41 +01:00
Andreas Dangel
f9ef2c8c4b Remove maven profile jdk8-modules and enable all modules by default
We are now enforcing java9 for building, so these modules are anyway
enabled always
2018-03-23 10:23:56 +01:00
Andreas Dangel
f335e83043 Cleanup pom.xml files 2018-03-23 10:21:16 +01:00
Andreas Dangel
6cd084b7ce Use release build-tools 1.1.0: uses latest dogfood ruleset
Closes #361
2018-03-23 10:12:38 +01:00
Juan Martín Sotuyo Dodero
c71db57733 Merge branch 'master' into tree-transversal-boundaries 2018-03-23 01:19:46 -03:00
Juan Martín Sotuyo Dodero
257d11e4f1 Add unit test for boundary checking 2018-03-23 01:18:53 -03:00
Juan Martín Sotuyo Dodero
809310cbd2 Improve javadocs 2018-03-23 01:17:05 -03:00
Juan Martín Sotuyo Dodero
a1ea36adc0 Simplify calls where possible 2018-03-23 00:52:54 -03:00
Juan Martín Sotuyo Dodero
f00a085087 Merge branch 'pr-987' 2018-03-22 11:51:14 -03:00
Clément Fournier
5ebde0a0e9 Update changelog, refs #993
Closes #992
2018-03-22 15:05:20 +01:00
Clément Fournier
d4c5bd011c Merge branch 'pr-993' 2018-03-22 15:03:40 +01:00
Clément Fournier
89db6fe71d Structure improvement 2018-03-22 15:02:53 +01:00
Clément Fournier
d699c277ea Update release notes, refs #989
Closes #978
2018-03-22 14:41:13 +01:00
Clément Fournier
b969974653 Merge branch 'pr-989' 2018-03-22 14:40:40 +01:00
Clément Fournier
dba594353f Fix link and grammar 2018-03-22 14:35:44 +01:00
Andreas Dangel
f2c8b5e2e8 Make the project be importable by IntelliJ IDEA
See https://youtrack.jetbrains.com/issue/IDEA-188690
2018-03-21 21:54:31 +01:00
Bolarinwa Saheed
08f1fea25b Update writing_documentation.md to fix Issue #992 2018-03-21 19:22:15 +01:00
Travis CI (pmd-bot)
d865fb4627 Update documentation 2018-03-21 16:11:04 +00:00
Clément Fournier
e6e07d22b4 Merge branch 'pr-990' 2018-03-21 16:59:48 +01:00
Clément Fournier
da8969ecb7 Update release notes, refs #990
Closes #832
2018-03-21 16:55:58 +01:00
Clément Fournier
6c9c229516 Remove one example
That example would have been flagged by the rule
2018-03-21 16:52:13 +01:00
Bolarinwa Saheed
3e24180da1 Moved all the description inside a single CDATA tag 2018-03-21 14:17:27 +01:00
Travis CI (pmd-bot)
482cb01d7c Update documentation 2018-03-20 22:56:50 +00:00
Clément Fournier
b52bd878f6 Update the description of MissingOverride 2018-03-20 23:43:15 +01:00
Bolarinwa Saheed
8f54d451d9 Extended the documentation with some markdown inline 2018-03-20 21:58:38 +01:00
Bolarinwa Saheed
87aafcc8ef Added link to Writing Documentation (Dev Docs) 2018-03-20 20:25:43 +01:00
Bolarinwa Saheed
e04f7c2d4f Update design.xml - AvoidThrowingNullPointerException to close Issue #832 2018-03-20 19:54:19 +01:00
Bolarinwa Saheed
d3aa3df15e Revert "Doc on AvoidThrowingNullPointerException updated to close Issue #832"
This reverts commit e27dad1862.
2018-03-20 17:58:17 +01:00
Clément Fournier
603a306370 Deprecate former rules, update changelog 2018-03-20 17:47:09 +01:00
Clément Fournier
67acede81f Report multiple blocks under case label 2018-03-20 17:47:09 +01:00
Clément Fournier
b4b52e037b Revert "Refine case statement treatment"
This reverts commit 580560c28c56cb57ca5350f9035856b1362400ec.
2018-03-20 17:47:09 +01:00
Clément Fournier
1ae8b1c8e6 Refine case statement treatment
Every dangling unbraced statement will be flagged individually
This complexifies the expression, and still ignores some cases, eg:
  case 3:
    {
      x++;
    }
    {
      y++;
      break;
    }

in which the label should be flagged anyway
2018-03-20 17:47:09 +01:00
Clément Fournier
2711d88e3c Add support for case stmts
A case label is flagged if one of its subordinate
    statements is not braced. The message could be more
    explicit, eg, if we flagged the unbraced statement
    instead of the label in case part of the label's
    statements are braced
2018-03-20 17:46:54 +01:00
Clément Fournier
ac3e59a4b7 Add new rule ControlStatementBraces 2018-03-20 17:45:44 +01:00
Bolarinwa Saheed
e27dad1862 Doc on AvoidThrowingNullPointerException updated to close Issue #832 2018-03-20 15:45:39 +01:00
Bolarinwa Saheed
55c34feb97 Update Contibute.md to close Issue #978 2018-03-20 14:09:17 +01:00
Clément Fournier
045308948a Fix pmd-java8 tests 2018-03-20 14:07:33 +01:00
Clément Fournier
73f6b2f6cf Fix compilation + checkstyle + pmd 2018-03-20 13:46:45 +01:00
Juan Martín Sotuyo Dodero
b3a9b9017a Revamp changelog 2018-03-19 17:17:52 -03:00
Clément Fournier
9ff4636194 Add getPrintableName to MethodLikeKind 2018-03-19 15:41:56 +01:00
Clément Fournier
0ebd2ba35c Hide ImmutableList, exposing List instead 2018-03-19 15:23:44 +01:00
Clément Fournier
0f61f2576d Move qname classes into another package 2018-03-19 14:25:00 +01:00
Clément Fournier
26e97032ef Minor changes 2018-03-19 14:25:00 +01:00
Clément Fournier
4154a5931e Add qname resolution step to the designer 2018-03-19 14:25:00 +01:00
Clément Fournier
ccc1443373 Use JavaQualifiedName to resolve anonymous classes types in ClassTypeResolver
Success! We still need to figure out a straightforward bridge between JavaTypeDefinition and qualified names
2018-03-19 14:25:00 +01:00
Clément Fournier
eb8908796c Allow TypeQualifiedNames to resolve their own type lazily
This could allow us to share the JavaQualifiedName implementations
with type resolution
2018-03-19 14:25:00 +01:00
Clément Fournier
1f1637bafd Split JavaQualifiedName into type and operation specific subclasses 2018-03-19 14:24:56 +01:00
Clément Fournier
3c8fcfa6c2 Cleanup QualifiedNameFactory 2018-03-19 14:05:51 +01:00
Clément Fournier
0bba8a2249 Resolve all MethodLike qnames 2018-03-19 14:05:51 +01:00
Clément Fournier
134d529442 Consider anonymous classes
* ASTAllocationExpression and ASTEnumConstant implement JavaQualifiableNode
* It's not satisfying yet, too much code duplication. They should  be
considered by the metrics framework. A good solution would be to add a
new node (see #905)
2018-03-19 14:05:51 +01:00
Clément Fournier
06e38128c4 Wire the visitor into SourceCodeProcessor
We need a way to configure which visitors are run on nodes
obtained from ParserTstUtil
2018-03-19 14:05:51 +01:00
Clément Fournier
ba3611f241 Add visitor to populate qualified names
* Currently populates ASTAnyTypeDeclarations with their qname
* Package tails are shared
2018-03-19 14:05:51 +01:00
Juan Martín Sotuyo Dodero
46ab578f28 Simplify rules when possible 2018-03-19 01:48:46 -03:00
Juan Martín Sotuyo Dodero
36ac7ddd4c Merge branch 'pr-975' 2018-03-19 01:39:06 -03:00
Juan Martín Sotuyo Dodero
4254fb3f15 Merge branch 'pr-895' 2018-03-19 01:33:07 -03:00
Juan Martín Sotuyo Dodero
1301a3821b Update changelog, refs #895 2018-03-19 01:32:52 -03:00
Travis CI (pmd-bot)
5d2ed89dc1 Update documentation 2018-03-18 15:43:17 +00:00
Juan Martín Sotuyo Dodero
acd365ad98 Add new rule to release ruleset 2018-03-18 12:32:04 -03:00
Juan Martín Sotuyo Dodero
2a6a3c5832 Merge branch 'pr-984' 2018-03-18 12:28:38 -03:00
Juan Martín Sotuyo Dodero
0f63ac9131 Update changelog, refs #984 2018-03-18 12:28:19 -03:00
Kirk Clemens
1bd44a3b52 issue983 Update rule to use rule chain pattern 2018-03-17 22:55:04 -05:00
Kirk Clemens
844ab0e6d4 issue983 Add a new test case for an annotation with a single non value element 2018-03-17 19:38:40 -05:00
Kirk Clemens
313da24a71 issue983 Remove pom changes checked in by mistake 2018-03-17 19:37:07 -05:00
Kirk Clemens
28f292f736 issue983 Add new UnnecessaryAnnotationValueElement rule 2018-03-17 19:33:49 -05:00
Clément Fournier
c967e63e6a Merge branch 'master', fix merge conflicts 2018-03-13 16:15:44 +01:00
Clément Fournier
58f76f054e Use javadoc @deprecated for ASTConstructorDeclaration.getParameters 2018-03-13 16:13:39 +01:00
Clément Fournier
92da9faee4 Fix pmd warnings 2018-03-13 00:33:37 +01:00
Juan Martín Sotuyo Dodero
0eef25e57b Checkstyle fixes 2018-03-12 16:53:38 -03:00
Andreas Dangel
b6c84e2ba3 [java] Remove new method getFormalParameters to preserve API compatibility
Refs #912
Refs #881
2018-03-12 20:38:38 +01:00
Juan Martín Sotuyo Dodero
783b449d60 Fix bad merge 2018-03-12 01:41:09 -03:00
Juan Martín Sotuyo Dodero
240d26ef69 Remove unused imports 2018-03-12 01:20:00 -03:00
Juan Martín Sotuyo Dodero
8b3fd24c5a Simplify test 2018-03-12 01:20:00 -03:00
Juan Martín Sotuyo Dodero
8deaf20f4d findDescendantsOfType defaults to not crossing boundaries
- A few places actually need to do so, and some other were simply wrong
 - We can now cross the boundary if searching dowm from it
 - Anonymous inner classes are still somewhat inconsistent
2018-03-12 01:20:00 -03:00
Juan Martín Sotuyo Dodero
cdc50f7667 Remove no longer needed parent check
- Also break once we have a result
2018-03-12 01:17:19 -03:00
Juan Martín Sotuyo Dodero
180cfc1dcc Update changelog, refs #370 & #904 2018-03-12 01:17:19 -03:00
Juan Martín Sotuyo Dodero
19c3487f9e Add test case for #370
- Fixes #370
2018-03-12 01:13:29 -03:00
Juan Martín Sotuyo Dodero
ba54b1c91a Fix failing tests 2018-03-12 01:13:29 -03:00
Juan Martín Sotuyo Dodero
f725f1ebfa [java] Honor find boundaries
- This fixes #904
 - `hasDescendantOfType`, `getFirstDescendantOfType` and
`findDescendantsOfType` are now consistent
2018-03-12 01:13:29 -03:00
Clément Fournier
9eb79af16b Update docs 2018-03-12 01:01:58 +01:00
Clément Fournier
e643da230d Merge branch 'master' 2018-03-12 00:36:56 +01:00
Travis CI (pmd-bot)
f25e35f42d Update documentation 2018-03-11 09:50:28 +00:00
Andreas Dangel
d27273581f Fix PMD / Checkstyle issues 2018-03-11 10:32:37 +01:00
Andreas Dangel
f4441ce938 Merge branch 'pr-912' 2018-03-11 10:15:28 +01:00
Andreas Dangel
96446f384b Update release notes, new rule MissingOverride, refs #912 2018-03-11 10:07:51 +01:00
Andreas Dangel
4514e6fb19 Update versions for new classes 2018-03-11 10:07:11 +01:00
Juan Martín Sotuyo Dodero
451815bf0a Merge branch 'pr-954' 2018-03-11 02:23:26 -03:00
Juan Martín Sotuyo Dodero
1577931fe3 Update changelog 2018-03-11 02:21:59 -03:00
Juan Martín Sotuyo Dodero
5ead2eda16 Use TemporaryFolder instead 2018-03-11 02:16:01 -03:00
Juan Martín Sotuyo Dodero
53e11481dc Merge branch 'pr-952' 2018-03-11 01:41:22 -03:00
Juan Martín Sotuyo Dodero
75b74afe8d Update changelog, refs #952 2018-03-11 01:40:28 -03:00
Juan Martín Sotuyo Dodero
136d147210 Use positive checks 2018-03-11 01:38:29 -03:00
Juan Martín Sotuyo Dodero
309a2a4924 Merge branch 'pr-951' 2018-03-11 01:28:54 -03:00
Juan Martín Sotuyo Dodero
8f5b2a04b8 Update changelog, refs #951 2018-03-11 01:26:19 -03:00
Clément Fournier
6943803ccb Merge branch 'pr-908' 2018-03-11 01:59:55 +01:00
Juan Martín Sotuyo Dodero
df2677457c Use relative links in docs 2018-03-10 18:23:19 -03:00
Juan Martín Sotuyo Dodero
161d7be37e Update broken links in doc 2018-03-10 17:30:19 -03:00
Juan Martín Sotuyo Dodero
05ab784d0b Merge branch 'pr-969' 2018-03-10 17:16:51 -03:00
Juan Martín Sotuyo Dodero
20cddf5079 Update changelog, refs #969 2018-03-10 17:16:12 -03:00
Juan Martín Sotuyo Dodero
185fd15953 Refactor lombok check into separate method 2018-03-10 17:13:25 -03:00
Andreas Dangel
d6ccc58f20 Corrections from PR review (#908), make the metrics visitors extendable again 2018-03-10 20:52:11 +01:00
Juan Martín Sotuyo Dodero
5ba5082ae2 Merge branch 'pr-965' 2018-03-10 16:49:13 -03:00
Juan Martín Sotuyo Dodero
7a0a31b149 Update changelog, refs #963 2018-03-10 16:47:56 -03:00
Clément Fournier
9766e632a9 Remove breaking API changes of JavaQualifiedName
Checked with japicmp
2018-03-10 19:20:02 +01:00
Clément Fournier
2fd5d7c41b Remove breaking binary changes with metrics framework
Spotted using japicmp
2018-03-10 18:49:48 +01:00
Clément Fournier
110c8db6e0 Update release notes, refs #970 2018-03-10 17:13:35 +01:00
Clément Fournier
c88641fa5c Merge branch 'pr-970' 2018-03-10 17:11:27 +01:00
epidemia
87f2403ec3 Remove unused import 2018-03-10 16:43:59 +03:00
epidemia
6e2b75e245 Fixed inefficient use of keySet iterator instead of entrySet iterator for pdm-java 2018-03-10 16:35:43 +03:00
epidemia
219b80a13b Fixed inefficient use of keySet iterator instead of entrySet iterator for pdm-java 2018-03-10 16:03:19 +03:00
Clément Fournier
e592d4baf2 Update release notes, refs #967 2018-03-10 13:50:51 +01:00
Clément Fournier
75ecf7b66f Merge branch 'pr-967' 2018-03-10 13:47:43 +01:00
Clément Fournier
4053e548bf Fix link 2018-03-10 13:47:31 +01:00
Andreas Dangel
8bd1e3b486 Fix PMD dogfood: UncommentedEmptyMethodBody, SimplifyBooleanReturns,
UnnecessaryLocalBeforeReturn, OptimizableToArrayCall,
ClassWithOnlyPrivateConstructorsShouldBeFinal,
UseLocaleWithCaseConversions, NonStaticInitializer, UseCollectionIsEmpty
2018-03-10 12:04:50 +01:00
Kirk Clemens
d0ba8998e7 Minor code cleanup 2018-03-09 23:22:49 -06:00
Kirk Clemens
d94ff95db8 Fix checkstyle issues 2018-03-09 23:02:29 -06:00
Kirk Clemens
9938a4491c Issue 968 Add logic to handle lombok private constructors with utility classes 2018-03-09 22:53:14 -06:00
epidemia
4c76a7f695 Issue 959: fixed broken link to XPath Rule Tutorial 2018-03-09 18:55:52 +03:00
Andreas Dangel
5b93b14373 Fix PMD dogfood: AssignmentInOperand, LooseCoupling 2018-03-09 16:28:14 +01:00
Stephen
264403b354 Make Varargs trigger ArrayIsStoredDirectly
fixes #963
2018-03-09 07:05:13 -08:00
Andreas Dangel
c85abd258a Fix PMD dogfood: AvoidPrefixingMethodParameters, UnnecessaryConstructor,
AvoidUsingShortType
2018-03-09 16:04:15 +01:00
Andreas Dangel
9fb3206d9e PMD dogfood: Upgrade PMD to 6.1.0 2018-03-09 13:00:52 +01:00
Andreas Dangel
cf88117820 Fix PMD dogfood: UnusedFormalParameter, UselessParentheses and UselessOverridingMethod 2018-03-09 12:52:20 +01:00
Andreas Dangel
b8a34eda97 TypeHelper: Remove misleading warning of incomplete auxclasspath
*   Failing to resolve a class in that situation might happen, since
    we use it to probe types
*   Simplify AbstractJUnitRule
2018-03-09 11:22:15 +01:00
Andreas Dangel
f452adbf6a Fix PMD dogfood: SimplifiedTernary 2018-03-09 10:26:23 +01:00
Andreas Dangel
5972c32ecf Fix checkstyle 2018-03-09 10:01:00 +01:00
Andreas Dangel
fb4d564e8b Fix PMD dogfood: AvoidBranchingStatementAsLastInLoop 2018-03-09 09:58:04 +01:00
Andreas Dangel
f3a358c419 Fix PMD dogfood: EmptyCatchBlock 2018-03-09 09:58:04 +01:00
Andreas Dangel
7aaa9966c2 Fix PMD dogfood: AvoidCatchingThrowable
Refs #361
2018-03-09 09:57:15 +01:00
Andreas Dangel
4ace14899c Fix PMD dogfood: UnusedPrivateField
Refs #361
2018-03-09 09:57:15 +01:00
Andreas Dangel
e9abdf7a92 Update pmd configuration to use dogfood and fail build on violations
Refs #361
2018-03-09 09:53:15 +01:00
Clément Fournier
ca4500b40b Delete multi property, add tests 2018-03-06 23:42:41 +01:00
Clément Fournier
9fcf146241 Add RegexMultiProperty 2018-03-06 23:41:32 +01:00
Clément Fournier
d489698157 Add RegexProperty 2018-03-06 23:40:56 +01:00
Clément Fournier
f60a64adb8 checkstyle 2018-03-05 22:25:26 +01:00
Clément Fournier
3d5a0aa4c6 Cleanup 2018-03-05 22:14:57 +01:00
Clément Fournier
f8864e9060 Make real Ant test cases 2018-03-05 21:58:05 +01:00
Clément Fournier
f74a6b3887 Update release notes 2018-03-05 20:56:48 +01:00
Clément Fournier
5d590a259e Add basic Ant test cases, correct behaviour 2018-03-05 20:52:39 +01:00
Clément Fournier
07a9859ce3 Update Ant task and user docs 2018-03-05 17:15:08 +01:00
Clément Fournier
ff1c90d753 Some corrections for PR #954 2018-03-05 16:47:34 +01:00
Clément Fournier
0967d50275 Merge branch 'pr-950' 2018-03-05 14:42:21 +01:00
Clément Fournier
e2c6f1e467 Add '-no-cache' CLI switch, to disable incremental analysis
- The switch discards the argument provided to '-cache' if any
- Using the switch disables the suggestion to use incremental analysis
- Rule tests use that option to avoid the warning, which clutters build logs
- Refs #946
2018-03-05 13:47:48 +01:00
BBG
4e2aee3da3 Issue #839: SignatureDeclareThrowsException's IgnoreJUnitCompletely property not honored for constructors 2018-03-04 22:03:58 +08:00
BBG
92031b1792 Add ignoredAnnotations ptoperty to unusedPrivateMethod rule 2018-03-04 21:32:19 +08:00
Juan Martín Sotuyo Dodero
30afff46c6 [java] Avoid a NPE in Type Resolution
- If a class extends a class that references / extends a missing class,
it's possible for the `NoClassDefFoundError` to only rise once we call
`isAnonymousClass()` on the `Class`.
 - For consistency with missing classes, we set the type to null.
 - Logging such missing classes is still pending #194
2018-03-04 03:46:05 -03:00
Travis CI (pmd-bot)
dc4f6b180b Update documentation 2018-03-04 00:22:50 +00:00
Clément Fournier
e43e7316a7 Merge branch pr-943 2018-03-04 01:06:45 +01:00
Clément Fournier
534d0b62f2 Update release notes, refs #943
Closes #907
2018-03-04 00:57:13 +01:00
Clément Fournier
c96358506b Minor cleanups 2018-03-04 00:52:00 +01:00
Clément Fournier
ba8aeaf648 Use abstract class + interface for AnyTypeDeclaration hierarchy
Remove one breaking API change
2018-03-04 00:37:04 +01:00
Clément Fournier
c9cfb1f29f Rename MethodLike to MethodLikeNode 2018-03-04 00:37:01 +01:00
Clément Fournier
0ef1955080 Use abstract class + interface for MethodLike hierarchy
Removes a breaking API change
2018-03-04 00:36:21 +01:00
Juan Martín Sotuyo Dodero
fdd399393d Update changelog, refs #941 2018-03-03 17:08:07 -03:00
Juan Martín Sotuyo Dodero
0e4a793dd3 Merge branch 'pr-941' 2018-03-03 17:06:56 -03:00
Juan Martín Sotuyo Dodero
a802fafb29 Merge branch 'pr-948' 2018-03-03 16:02:45 -03:00
Juan Martín Sotuyo Dodero
1415d283bc Merge branch 'pr-947' 2018-03-03 16:01:53 -03:00
BBG
8b279fac25 fixes #907 2018-03-03 22:01:21 +08:00
Andreas Dangel
65a5d3f835 [java] Migrate internal rulesets used in unit tests
Avoiding deprecation warnings
References #946
2018-03-03 11:53:22 +01:00
Andreas Dangel
5a5977b1ea Update release notes, fixes #928 2018-03-02 20:34:34 +01:00
Andreas Dangel
d6508c1b28 Fix checkstyle 2018-03-02 20:26:36 +01:00
Andreas Dangel
c94b3790bf Upgrade checkstyle, use pmd-build-tools 1.1.0-SNAPSHOT 2018-03-02 20:24:48 +01:00
Clément Fournier
57e050f8c5 Fix typo 2018-03-02 18:34:46 +01:00
Clément Fournier
09f5384040 Fix NPE caused by unresolved bound in intersection type 2018-03-02 14:10:46 +01:00
Clément Fournier
59901a4687 Fix type resolution of multiple declaration when array dimensions differ 2018-03-02 00:51:52 +01:00
Clément Fournier
d12268bb53 Fix ReferenceType array type resolution for primitive type
ReferenceType previously rolled up the type of its child
without checking for array dimensions.

Add method to JavaTypeDefinition to dimension array type
2018-03-02 00:51:52 +01:00
Clément Fournier
0e61cba1ac Add test case, doesn't pass right now but it's the end goal 2018-03-02 00:51:39 +01:00
Clément Fournier
5daa72adc9 Cleanup ClassTypeResolverTest 2018-03-01 22:43:49 +01:00
reudismam
e1b954289a Use char notation to represent a character to improve performance. 2018-02-26 19:40:40 -03:00
Juan Martín Sotuyo Dodero
c8cd8e1fa8 Changelog update, Add more details about changes in Rhino 2018-02-25 19:29:23 -03:00
Juan Martín Sotuyo Dodero
502e96e3a3 Merge branch 'pr-930' 2018-02-25 19:27:02 -03:00
Juan Martín Sotuyo Dodero
5bf8945f99 Merge branch 'pr-937' 2018-02-25 19:24:52 -03:00
Andreas Dangel
8947876dab Update release script to follow documented release procedure 2018-02-25 12:05:56 +01:00
Andreas Dangel
67a9f84a9c Fix release script 2018-02-25 10:04:45 +01:00
Andreas Dangel
b71857e02b Prepare next development version 2018-02-25 10:00:22 +01:00
Andreas Dangel
098b0dcac0 [maven-release-plugin] prepare for next development iteration 2018-02-25 09:53:26 +01:00
Andreas Dangel
101b71a13e [maven-release-plugin] prepare release pmd_releases/6.1.0 2018-02-25 09:53:19 +01:00
Andreas Dangel
17e991b662 Prepare pmd release 6.1.0 2018-02-25 09:45:42 +01:00
Andreas Dangel
84e388cdf2 Merge branch 'pr-801' 2018-02-24 22:42:20 +01:00
Andreas Dangel
6b4962e479 Update release notes, refs #801 2018-02-24 22:41:36 +01:00
Andreas Dangel
039e4157e8 Merge branch 'pr-931' 2018-02-24 21:40:02 +01:00
Andreas Dangel
3c280b8ef2 Use Files.move instead of File.renameTo
This prevents problems when building PMD under Windows
2018-02-24 20:40:38 +01:00
Andreas Dangel
8f6f8e9842 Corrections for PR #931 2018-02-22 08:54:29 +01:00
Andreas Dangel
cc08bd47cf [java] UnusedImports false positive for static import
Fixes #925
2018-02-21 20:43:14 +01:00
Andreas Dangel
d619fd360d [ecmascript] Update rhino to 1.7.7.2
Refs #699
2018-02-21 19:56:20 +01:00
Travis CI (pmd-bot)
bff93c53fb Update documentation 2018-02-20 17:01:00 +00:00
Juan Martín Sotuyo Dodero
97d8893b43 Merge branch 'pr-927' 2018-02-20 13:47:14 -03:00
Juan Martín Sotuyo Dodero
906c162d04 Update changelog, refs #927 2018-02-20 13:46:43 -03:00
Andreas Dangel
09f871d92e Merge branch 'pr-918', fixes #909 2018-02-20 08:36:59 +01:00
Andreas Dangel
25421ba340 Update release notes, refs #918, refs #909 2018-02-20 08:35:49 +01:00
wata727
8127b3c8e3 Fix example of AbstractClassWithoutAnyMethod 2018-02-20 14:45:22 +09:00
Travis CI (pmd-bot)
23b25056f0 Update documentation 2018-02-20 04:51:36 +00:00
Juan Martín Sotuyo Dodero
e6bf9f031f Merge branch 'pr-926' 2018-02-20 01:40:06 -03:00
Juan Martín Sotuyo Dodero
90095480b0 Merge branch 'pr-924' 2018-02-20 01:37:10 -03:00
Clément Fournier
a6d3c2baa1 Miscellaneous cleanups 2018-02-20 01:24:23 +01:00
Clément Fournier
1c991dd79e Fix property test random crash 2018-02-20 01:24:02 +01:00
Clément Fournier
3257aeae4f Corrections for PR #912 2018-02-20 00:34:15 +01:00
Akshat Bahety
e2f37d4d97 Indentation
changed to 8 spaces for qa plugin.
2018-02-20 04:20:55 +05:30
Andreas Dangel
acf6a31bed [java] ConsecutiveLiteralAppends with types other than string
*   Updated documentation to include also non-string literals
*   Added additional test cases
*   Fixes #541
2018-02-19 20:03:31 +01:00
Juan Martín Sotuyo Dodero
b6a8402dc7 Merge branch 'pr-923' 2018-02-18 20:22:21 -03:00
Andreas Dangel
73de6eb1f0 [ci] Use Java9 for building PMD
Fixes #854
2018-02-18 21:49:25 +01:00
Juan Martín Sotuyo Dodero
1c9a4fd31c Merge branch 'pr-922' 2018-02-18 17:36:57 -03:00
Andreas Dangel
394948624f Update release notes, fixes #853 2018-02-18 20:37:59 +01:00
Andreas Dangel
18c79a34f4 Fix deprecations 2018-02-18 20:25:42 +01:00
Andreas Dangel
2087dd9472 Fix integration test - scala is now active always 2018-02-18 20:24:04 +01:00
Andreas Dangel
9392239c45 scala update, part 2
* Update to new scala API
* remove comments support which was not used anyway
* Use scala-maven-plugin to generate javadoc
2018-02-18 20:23:32 +01:00
Andreas Dangel
74ae8d0d6e Remove profile jdk9-disabled - scala is now active always 2018-02-18 19:07:37 +01:00
Andreas Dangel
fc21190bb7 scala update, part 1 2018-02-18 18:52:07 +01:00
Andreas Dangel
9c007afb57 Fixes #795
Merge branch 'pr-919'
2018-02-18 18:40:33 +01:00
Andreas Dangel
9fbaa835ab Fix typo, add removal version for deprecated interfaces/classes 2018-02-18 18:40:25 +01:00
Andreas Dangel
7997e16f1b Merge branch 'pr-920' 2018-02-18 18:35:22 +01:00
Andreas Dangel
aac36cb11e Update release notes, refs #920 2018-02-18 18:35:12 +01:00
Juan Martín Sotuyo Dodero
32af9cabf2 [java] Update valid identifiers
- Newer Java versions have allowed for a lot more tokens in identifiers
2018-02-18 04:44:27 -03:00
Juan Martín Sotuyo Dodero
21d02f90af Remove unused import 2018-02-18 04:37:44 -03:00
Juan Martín Sotuyo Dodero
6d1a8888a9 Update changelog, refs #795 2018-02-17 21:45:15 -03:00
Juan Martín Sotuyo Dodero
1c68248eee Update tests 2018-02-17 21:39:59 -03:00
Juan Martín Sotuyo Dodero
46aa1e2f2a Remove usages of deprecated classes 2018-02-17 21:39:10 -03:00
Juan Martín Sotuyo Dodero
08560add78 Deprecate FileReporter 2018-02-17 21:38:39 -03:00
Juan Martín Sotuyo Dodero
33626e7a2d Implement new renderer for CPD
- Write directly to writers, don't handle strings
2018-02-17 21:37:51 -03:00
Juan Martín Sotuyo Dodero
78890afe13 Merge branch 'pr-884' 2018-02-17 17:32:52 -03:00
Juan Martín Sotuyo Dodero
cdb28f72ff Update changelog 2018-02-17 17:32:09 -03:00
Juan Martín Sotuyo Dodero
0253a0c615 Merge branch 'pr-916' 2018-02-17 17:25:54 -03:00
Travis CI (pmd-bot)
94bb23d22c Update documentation 2018-02-17 17:30:18 +00:00
Juan Martín Sotuyo Dodero
123f2139b9 Merge branch 'pr-914' 2018-02-17 14:17:04 -03:00
Juan Martín Sotuyo Dodero
1992a0d33b Update changelog, refs #914 2018-02-17 14:16:47 -03:00
Juan Martín Sotuyo Dodero
f4c7cc70bc Merge branch 'pr-901' 2018-02-17 14:13:55 -03:00
Juan Martín Sotuyo Dodero
99d853c39d Update changelog, refs #901 2018-02-17 14:13:32 -03:00
Juan Martín Sotuyo Dodero
f62fe38d97 Minor cleanups 2018-02-17 14:12:23 -03:00
Akshat Bahety
d2fb476eae Docs Updated qa-Eclipse
Added a qa-Eclipse plugin to the table.
2018-02-17 12:28:11 +05:30
Clément Fournier
22596e5176 Add ghost production for TypeAnnotation to cleanup the grammar
Type annotations can be nearly everywhere since Java 8, which makes the grammar
really hard to read when the check for correct jdk version is repeated all over
the place.
2018-02-16 23:53:37 +01:00
Clément Fournier
c401e2cbc6 Move boilerplate to an abstract class 2018-02-16 15:31:52 +01:00
Clément Fournier
d25fbcf8c0 Remove unnecessary javadoc 2018-02-16 00:25:06 +01:00
Clément Fournier
f2ba4e442c Update FormalParameter type resolution for varargs 2018-02-15 23:58:20 +01:00
Clément Fournier
4e3f1395e4 Consider return type covariance 2018-02-15 11:58:02 +01:00
Clément Fournier
6440d043c8 Cleanup, ensure no false positive 2018-02-15 02:33:33 +01:00
Clément Fournier
ab634bf720 Consider Object methods inherited into interfaces 2018-02-15 01:15:33 +01:00
Akshat Bahety
997a1f61fa Documentation Updated
As written in issue #891 apex uses Single Quotes ' ' instead of Double " "
Updated the document to represent the same to the user.
2018-02-15 05:32:47 +05:30
Clément Fournier
8884599f8d Consider varargs parameters 2018-02-15 00:12:21 +01:00
Clément Fournier
64a7e3780e Use bridge method as cue to which method is overridden
This adds support for methods inherited from a supertype with type parameters.
Overloads of the inherited (bridged) methods defined in the subclass
with the same number of parameters still go undetected.

RuleViolationComparator contains a good example of this: the two compare
methods compile to three methods: compare(RV,RV), compare(String,String)
and a bridge method compare(Object,Object). But short of doing more
complicated analysis on the type parameters (or reading the bytecode),
there is no way to determine whether the bridge delegates to the
compare(String,String) or compare(RV,RV), so we can't know which is
overridden.

Another corner case is the following:
public <V> void setProperty(MultiValuePropertyDescriptor<V> propertyDescriptor, V... values)

in AbstractDelegateRule, inherited from Rule. I don't know yet why it's
not detected.
2018-02-14 19:40:29 +01:00
Clément Fournier
f330007278 Change algorithm to explore hierarchy only once, avoid exploring same classes twice 2018-02-14 17:32:19 +01:00
Clément Fournier
f1d0d74087 Checkstyle 2018-02-14 01:22:22 +01:00
Clément Fournier
4bb707a3bd Test case for generic method 2018-02-14 00:42:07 +01:00
Clément Fournier
5ddb5a2a29 Make ASTFormalParameter a typenode
It feels right
2018-02-14 00:25:00 +01:00
Clément Fournier
9b93311c53 Cleanup ASTAnnotation
It's now a typenode
2018-02-14 00:14:20 +01:00
Clément Fournier
7db3f4a006 Add MissingOverrideRule and some tests
Doesn't support method overriden from generic supertype.
Known limitations that are supposed to be fixed shortly
are #910 and anonymous enum constants (the fix for that
is somewhere in my branches, after #895)
2018-02-13 23:29:37 +01:00
Clément Fournier
8cb7573379 Fix problem with outer enum and annotation types 2018-02-13 12:30:38 +01:00
Clément Fournier
733c871b96 Fix nested anonymous class bug with type resolution 2018-02-13 02:46:55 +01:00
Juan Martín Sotuyo Dodero
cd9f4f2248 Merge branch 'pr-892' 2018-02-08 23:06:02 -03:00
Clément Fournier
1d9a2f194d Fix merge fail + checkstyle 2018-02-08 18:55:00 +01:00
Clément Fournier
40a5e3c569 Merge branch 'master' into improve-javaqualifiedname 2018-02-08 17:03:15 +01:00
Clément Fournier
a039788dfb Fix the bugfix
Qualified names now use structural comparison to determine equality. Using toString
hid away some bugs. We still use toString to shortcut the comparison,
since it's cached.
2018-02-08 16:59:07 +01:00
Clément Fournier
3ede676e0a Fix two bugs with qname regex parsing 2018-02-08 16:24:46 +01:00
Clément Fournier
8d520b6d8d Update JavaParserVisitorReducedAdapter to consider MethodLike 2018-02-07 23:14:28 +01:00
Juan Martín Sotuyo Dodero
2909eb02b7 Merge branch 'pr-903' 2018-02-07 12:59:26 -03:00
Juan Martín Sotuyo Dodero
ef85cf4c8f Update changelog, refs #903 2018-02-07 12:59:08 -03:00
Clément Fournier
c245ef1ea9 Format test cases 2018-02-07 14:18:33 +01:00
Clément Fournier
45cb5f3252 Minor style corrections 2018-02-07 14:12:01 +01:00
Clément Fournier
bb2e35b815 Fix ImmutableField false positive when lambda is in constructor
Fixes #855
2018-02-07 14:05:47 +01:00
Clément Fournier
240ccfb32f Improve a confusing code construct 2018-02-06 18:30:09 +01:00
Juan Martín Sotuyo Dodero
90527c646e Update changelog, refs #900 2018-02-05 02:30:22 -03:00
Clément Fournier
3d8d9ff013 Corrections for PR comments #901 2018-02-04 20:47:20 +01:00
Clément Fournier
5a3e1941d0 Use multi valued property as a PoC 2018-02-03 14:31:31 +01:00
Clément Fournier
5e8e125afa Replace synthetic proxy with static proxy for Xml nodes
Fixes #739
2018-02-03 14:24:24 +01:00
Juan Martín Sotuyo Dodero
117f4cf87a Merge branch 'pr-900' 2018-02-02 13:48:54 -03:00
reudismam
7e380e5d98 Use isEmpty method. 2018-02-02 12:28:25 -03:00
Andreas Dangel
7938dcd8c4 [ci] Add pmd-commits@lists.sourceforge.net for build notifications 2018-02-01 19:25:46 +01:00
Clément Fournier
b30d64dd4f Make cyclo count lambdas separately 2018-02-01 00:28:32 +01:00
Clément Fournier
7e2930be3f Adapt the metrics framework to consider MethodLike 2018-02-01 00:28:32 +01:00
Clément Fournier
ba10a60a7c Add JavaQualifiedName support for lambdas.
Add MethodLike superclass to ASTMethodDecl, ASTConstructorDecl, ASTLambdaExpr
2018-02-01 00:28:27 +01:00
Clément Fournier
1f6fc296c5 Split JavaQualifiedName into static factory + class 2018-01-31 22:44:59 +01:00
Clément Fournier
72a901089f Optimise format regex
Use possessive quantifiers to make it fail faster
2018-01-31 22:44:59 +01:00
Clément Fournier
332dadce2d Cleanup JavaQualifiedName to make it really immutable
Use an immutable list to avoid array copies everywhere
2018-01-31 22:44:59 +01:00
Clément Fournier
5fcfb0af8f Formatting and code rearrangement 2018-01-31 22:44:59 +01:00
Clément Fournier
ece8c7e84c Add qualified name support for anonymous classes
* Simplify the API of JavaQualifiedName
* The name of an anonymous class is for now
  only available via JavaQualifiedName factories,
  not from the nodes
2018-01-31 22:44:59 +01:00
Clément Fournier
a3c0f7d3ab Documentation 2018-01-31 22:44:59 +01:00
Clément Fournier
f7636f27f3 Make JavaQualifiedName represent packages like in the JLS
The unnamed package is not represented as a lone full stop anymore.

Rename QualifiedNameTest into JavaQualifiedNameTest
2018-01-31 22:44:59 +01:00
Clément Fournier
55d3bbe881 Refactor ASTAnyTypeDeclaration into an abstract class.
Remove getQualifiedName's copypasta.
2018-01-31 22:44:59 +01:00
Clément Fournier
6ab52371cc Fix NPE in ForLoopCanBeForeach 2018-01-30 16:29:00 +01:00
Clément Fournier
47cfc3909c Merge branch 'master' into issue-784 2018-01-30 16:09:44 +01:00
Andreas Dangel
79882b1eb0 [ci] Fix coveralls integration: run a install first 2018-01-30 09:53:59 +01:00
Andreas Dangel
5c8016e58e Merge branch 'pr-889' 2018-01-30 09:43:29 +01:00
Andreas Dangel
257402cf95 Merge branch 'pr-890' 2018-01-30 09:34:06 +01:00
Juan Martín Sotuyo Dodero
f86a06be4a Fix checkstyle 2018-01-29 23:26:42 -03:00
Juan Martín Sotuyo Dodero
c2e11ddff2 [ci] Upgrade m-pmd-p
- Reenable pmd dogfoding
 - Upgrade to use PMD 6.0.1 on self
2018-01-29 23:19:43 -03:00
Juan Martín Sotuyo Dodero
75b60b8a88 Update changelog, refs #888 2018-01-29 14:12:54 -03:00
Juan Martín Sotuyo Dodero
f9df6ed01e [java] Fix grammar for <> in Java 1.8
- Fixes #888
 - Allow the contents of an anonymous class to use diamong notation, but
the anonymous class itself can't use it
2018-01-29 14:10:40 -03:00
Juan Martín Sotuyo Dodero
53fa98a672 Merge branch 'pr-886' 2018-01-27 20:03:43 -03:00
Juan Martín Sotuyo Dodero
4c079ff9c5 Update changelog, refs #886 2018-01-27 20:03:26 -03:00
Matias Comercio
bdf988030c Add missing unit test 2018-01-26 19:02:18 -03:00
Matias Comercio
d8d271c2f1 Fix issue-885
False positive on Java rule: CompareObjectsWithEqualsRule

Enum class exlicit usage was not being considered an Enum type in the rule
2018-01-26 18:18:10 -03:00
Andreas Dangel
22a42ecd6f Merge branch 'pr-878' 2018-01-26 10:13:42 +01:00
Andreas Dangel
9062b4f09e [java] CommentRequiredRule: Add unit test
Add a unit test to verify the dysfunctionalReason is detected
correctly.

Refs #877
2018-01-26 09:58:50 +01:00
Juan Martín Sotuyo Dodero
b439bb823f Merge branch 'pr-875' 2018-01-25 21:25:18 -03:00
Juan Martín Sotuyo Dodero
0360e0838e Update changelog, refs #875 2018-01-25 21:24:15 -03:00
Juan Martín Sotuyo Dodero
41de94776e Properly handle shortnames with comma-separated args
- Also added unit tests to make sure the behavior is as expected
2018-01-25 21:20:13 -03:00
Clément Fournier
91790c387d Merge branch 'pr-870' 2018-01-26 00:22:34 +01:00
Clément Fournier
21650ba85a Move util.documents into n.s.pmd.documents
Fix commit 40ad978 compilation errors
2018-01-26 00:20:38 +01:00
Juan Martín Sotuyo Dodero
c34519431c Merge branch 'pr-828' 2018-01-25 19:55:33 -03:00
Juan Martín Sotuyo Dodero
476d9a6d4d Update changelog, refs #828 2018-01-25 19:54:16 -03:00
Juan Martín Sotuyo Dodero
6a801ee26c Move document classes out of the util package 2018-01-25 19:53:58 -03:00
Juan Martín Sotuyo Dodero
a33958bc63 Merge branch 'pr-882' 2018-01-25 19:49:32 -03:00
Juan Martín Sotuyo Dodero
f816bb65ba Merge branch 'pr-883' 2018-01-25 19:43:58 -03:00
Clément Fournier
35157be961 Update release notes, refs #784 2018-01-25 23:22:41 +01:00
Clément Fournier
69937a40e5 Fix ForLoopCanBeForeach flagging loops with two iterators
Resolves #784
2018-01-25 23:16:46 +01:00
Clément Fournier
34c29e93fb Update release notes, refs #825 2018-01-25 22:59:24 +01:00
Clément Fournier
6fb01ca19d ExcessiveClassLength considers annotation and enum types 2018-01-25 22:57:28 +01:00
Clément Fournier
3f38835d78 ExcessiveMethodLength considers constructors 2018-01-25 22:52:44 +01:00
Clément Fournier
b7950cca1b Merge branch 'pr-868' 2018-01-25 18:46:03 +01:00
Clément Fournier
95eede5493 Update release notes, refs #868 2018-01-25 18:41:27 +01:00
Juan Martín Sotuyo Dodero
49a7c7d75b update broken url 2018-01-25 12:10:27 -03:00
Clément Fournier
0578b36145 Cleanup AbstractNode 2018-01-25 14:15:57 +01:00
Juan Martín Sotuyo Dodero
ae0ef47e1d Merge branch 'pr-879' 2018-01-25 10:09:45 -03:00
gonzalo
c25089ef9a PR Improvements - 3 2018-01-25 09:46:38 -03:00
Clément Fournier
b1c5e3dfc0 Revert making AbstractVFNode and AbstractJspNode abstract
Revert me for 7.0.0

see #881, #879
2018-01-25 12:14:22 +01:00
gonzalo
80aba0c858 PR Improvements - 2 2018-01-24 23:35:22 -03:00
Clément Fournier
0316462916 Checkstyle 2018-01-25 03:13:22 +01:00
Clément Fournier
1bdca98f03 Flag deprecated impl to find it quickly 2018-01-25 03:10:04 +01:00
Clément Fournier
27ccd140ef Cleanup 2018-01-25 03:06:54 +01:00
Clément Fournier
6a3b332aee Abstract toString into AbstractNode, deprecate the implementation
Log that the default implementation will be removed
2018-01-25 03:02:44 +01:00
gonzalo
3d818b0963 PR Improvements - 1 2018-01-24 20:09:13 -03:00
Clément Fournier
cd105125d8 Update release notes, refs #879 2018-01-24 19:36:17 +01:00
Clément Fournier
3c0bb45a60 Add getXPathNodeName to the Node interface
A default implementation is available in AbstractNode
to preserve compatibility with the previous way, which
used Object.toString.

Fixes #569
2018-01-24 19:22:36 +01:00
Juan Martín Sotuyo Dodero
ccb8bae42d Update changelog, refs #877 2018-01-24 01:46:10 -03:00
Juan Martín Sotuyo Dodero
7ec99ba218 [java] Fix misconfiguration detection
- Resolves #877
2018-01-24 01:45:02 -03:00
Robert Sösemann
c90061d067 Merge pull request #1 from pmd/master
Update my fork
2018-01-23 23:37:44 +01:00
Clément Fournier
0fb9c4678c Update release notes, refs #845 2018-01-23 21:17:31 +01:00
Clément Fournier
80bd38485a Merge branch 'pr-845'
Refs #543
2018-01-23 21:09:08 +01:00
Alberto Fernandez
9936b1f833 removed unnecesary counter 2018-01-23 17:56:10 +01:00
John Zhang
aeb554ee62 Issue 872 fix
This commit attempts a fix to issue 872.
The inputFileName ('master' file) parameter may be null,
in which case the function returns just the file name if short name is required.
2018-01-23 11:46:02 +11:00
Travis CI (pmd-bot)
8aeddd09a4 Update documentation 2018-01-21 20:01:11 +00:00
Juan Martín Sotuyo Dodero
02e84360aa [doc] Update sidebar generation 2018-01-21 16:50:02 -03:00
Juan Martín Sotuyo Dodero
10d8b194bb Revert "Update documentation"
This reverts commit 3548fd14c0.
2018-01-21 16:24:40 -03:00
Juan Martín Sotuyo Dodero
c436e9bd94 Fix checkstyle errors 2018-01-21 16:16:06 -03:00
Juan Martín Sotuyo Dodero
26288b0022 [core] Remove usages of deprecated PMD.VERSION
- Take the chance to add some helpers to PMDVersion that seem needed
 - Have CodeClimate renderer point to pmd.github.io rather than SF
2018-01-21 16:02:48 -03:00
Travis CI (pmd-bot)
3548fd14c0 Update documentation 2018-01-21 18:12:05 +00:00
Juan Martín Sotuyo Dodero
142fb16358 Merge branch 'pr-860' 2018-01-21 14:59:31 -03:00
Juan Martín Sotuyo Dodero
33edaeb46b Update changelog, refs #803 2018-01-21 14:52:55 -03:00
Juan Martín Sotuyo Dodero
527bfce72f Merge branch 'pr-803' 2018-01-21 14:52:00 -03:00
Juan Martín Sotuyo Dodero
77f3637f53 Remove quotes 2018-01-21 14:51:43 -03:00
Juan Martín Sotuyo Dodero
1065006b8a Upodate changelog, refs #790 2018-01-21 14:47:45 -03:00
Juan Martín Sotuyo Dodero
e1e8ad5984 Merge branch 'pr-790' 2018-01-21 14:47:11 -03:00
Juan Martín Sotuyo Dodero
17c925b9db Update changelog, refs #830 2018-01-21 14:45:06 -03:00
Juan Martín Sotuyo Dodero
3de3335714 Merge branch 'pr-830' 2018-01-21 14:42:09 -03:00
Juan Martín Sotuyo Dodero
69fc4ffc2d Update changelog, refs #791 2018-01-21 14:39:57 -03:00
Juan Martín Sotuyo Dodero
e6be5b3e44 Merge branch 'pr-818' 2018-01-21 14:39:07 -03:00
Andreas Dangel
5bcc09ccc4 Release script: add step to update docs/_config.yml 2018-01-21 16:51:52 +01:00
Andreas Dangel
182dadaa4b Prepare next development version 2018-01-21 16:45:02 +01:00
Andreas Dangel
8fbb156fd9 [maven-release-plugin] prepare for next development iteration 2018-01-21 16:42:50 +01:00
Andreas Dangel
0e460317e4 [maven-release-plugin] prepare release pmd_releases/6.0.1 2018-01-21 16:42:42 +01:00
Andreas Dangel
585b2c4642 Prepare pmd release 6.0.1 2018-01-21 16:30:51 +01:00
Andreas Dangel
34b9d23887 Update/fix release script
*   fix syntax error
*   allow to override the next version
2018-01-21 16:22:59 +01:00
Travis CI (pmd-bot)
81c5b27df0 Update documentation 2018-01-21 15:02:06 +00:00
Andreas Dangel
b3f4520ed1 Merge branch 'pr-867' 2018-01-21 15:42:40 +01:00
Andreas Dangel
02989303a6 [java] Avoid double rule de-referincing in controversial and migrating_* 2018-01-21 15:42:28 +01:00
Andreas Dangel
594f7e3254 Merge branch 'pr-865' 2018-01-21 15:30:48 +01:00
Andreas Dangel
f7ecfaa01b Update release notes, refs #865 2018-01-21 15:30:41 +01:00
gonzalo
9d7d89b669 Add XPath flow documentation && Made small refactor 2018-01-21 11:09:50 -03:00
Juan Martín Sotuyo Dodero
15db5ad0b4 [java] typeresolution points directly to categories
- Fixes #866
2018-01-21 06:21:55 -03:00
Juan Martín Sotuyo Dodero
abc73bfc7b [core] Log all rules' movements to categories
- All rules will log where they where moved to, even if the ruleset is
referenced as a whole
 - All deprecation warnings now let's users know on which version
support will be removed.
2018-01-21 05:43:49 -03:00
Andreas Dangel
c6bc5ff306 Merge branch 'pr-857'
Closes #827
2018-01-20 17:57:38 +01:00
Clément Fournier
f8ca4a75d3 Extract Pattern constant from parse method 2018-01-20 01:53:23 +01:00
Andreas Dangel
3472bf1764 [doc] Fix wrong bootclasspath to be able to use java8 api 2018-01-18 16:33:33 +01:00
Andreas Dangel
7faba76809 Update release notes, fixes #848 2018-01-17 20:57:28 +01:00
Andreas Dangel
411be4ac00 [doc] Further changes for windows compatibility 2018-01-17 20:51:56 +01:00
Andreas Dangel
090975a972 [doc] Fix file handle leak in SidebarGenerator 2018-01-17 20:19:33 +01:00
Andreas Dangel
1ef5367498 [doc] Fix build/unit tests under windows
* expect line names with windows path normalized to unix paths
* normalize line endings
* File.separator might be a backslash and needs to be escaped in regex
2018-01-17 19:41:45 +01:00
Alberto Fernandez
2c2c2f4dd9 Checkstyle fixes 2018-01-17 16:06:54 +01:00
Alberto Fernandez
883bed3cf8 Better detection of corner cases
the firts changes checks for a exact level to search AdditiveExpression.

So code like
throw new Exception("something bad:" + (e)); gets undetected.

This change search if part of a AdditiveExpression to the base node.
2018-01-17 15:25:38 +01:00
Clément Fournier
6e461f09d7 Update release notes, refs #827 2018-01-17 00:15:35 +01:00
Clément Fournier
65949bcf6e Merge branch 'master' of github.com:pmd/pmd into issue-827 2018-01-17 00:15:13 +01:00
Clément Fournier
2ca4b347c3 Make TCC consider local classes.
If a local class is declared inside a method of the outer class,
then attribute accesses made by the local class count as if they
are made by the enclosing method.
2018-01-16 23:42:29 +01:00
Clément Fournier
8cfc073b8c Add local class support to JavaQualifiedName 2018-01-16 20:35:15 +01:00
Clément Fournier
27b4abe221 Add isLocal() to ASTClassOrInterfaceDeclaration 2018-01-16 18:18:23 +01:00
Juan Martín Sotuyo Dodero
c843a6f534 Make test cases more direct
- No personal interpretation, but let Java process the values
2018-01-16 01:14:42 -03:00
Andreas Dangel
96cc4f01f3 Merge branch 'pr-849'
Closes #841
2018-01-15 20:45:34 +01:00
Andreas Dangel
23a673114c Merge branch 'pr-835' 2018-01-15 20:42:48 +01:00
Juan Martín Sotuyo Dodero
fe53f8bb91 Update changelog, refs #841 2018-01-14 16:17:11 -03:00
Juan Martín Sotuyo Dodero
391c1e8842 Unify literal parsing logic 2018-01-14 16:15:22 -03:00
Juan Martín Sotuyo Dodero
ab96e34099 [java] Resolve NumberFormatException
- InsufficientStringBufferDeclaration now supports all numbr formats
(even octal and binary)
 - We move the logic of understanding the literal value to the literal
node. Looking for other places where this logic is being replicated is
pending
2018-01-14 16:14:38 -03:00
Juan Martín Sotuyo Dodero
a5b546d044 Java 7 compatible implementation 2018-01-13 21:01:37 -03:00
Juan Martín Sotuyo Dodero
79a43fac0f Update changelog, refs #831 2018-01-13 20:44:29 -03:00
Juan Martín Sotuyo Dodero
303f05d8d3 [java] Resolve StackOverflow in JavaTypeDefinitionSimple.toString()
- Resolves #831
2018-01-13 20:43:01 -03:00
Juan Martín Sotuyo Dodero
0c9f27bbbe Inline gitter badge 2018-01-13 20:42:22 -03:00
Juan Martín Sotuyo Dodero
b0775343ca Merge pull request #840 from gitter-badger/gitter-badge
Add a Gitter chat badge to README.md
2018-01-13 20:41:48 -03:00
Juan Martín Sotuyo Dodero
554abc4ac9 Merge branch 'pr-846' 2018-01-13 20:40:46 -03:00
Andreas Dangel
ff9a951c9e Determine java7 home with jdk_switcher 2018-01-13 11:23:26 +01:00
Andreas Dangel
4f62e84392 Use openjdk7
See https://raw.githubusercontent.com/michaelklishin/jdk_switcher/1e091549285fb0f2591cef679b4135cfbfcc0b4c/jdk_switcher.sh for the paths
See travis-ci/travis-ci#7964
2018-01-13 11:13:59 +01:00
Andreas Dangel
12409be1ef Update release notes, refs #842 2018-01-12 23:37:14 +01:00
Andreas Dangel
4ba1cbcb46 Use bootclasspath when building for java7
Note: this is only works correctly, if the property java7.home is set
Fixes #842
2018-01-12 23:36:18 +01:00
Alberto Fernandez
a4d5ff683d Fix checkstyle 2018-01-12 23:31:58 +01:00
Alberto Fernandez
4f67d99c9f Fix false negative PreserveStackTrace on string concatenation
PMD should fire PreserveStackTrace in the following code

public void foo(String a) throws Exception {
    try {
        int i = Integer.parseInt(a);
    } catch(Exception e){
        throw new Exception("something bad:" + e);
        // Stack trace is lost, but no violation was reported!
    }
}

Closes pmd/pmd#543
2018-01-12 23:09:17 +01:00
Anand
3f71e7392e Remove dependency from pmd test 2018-01-11 15:22:59 -08:00
Anand
7a403acaa7 Add rule preventing the use of non existent annotations in apex 2018-01-11 15:22:49 -08:00
Andreas Dangel
9bc7074fb9 Merge branch 'pr-821' 2018-01-11 17:30:40 +01:00
Andreas Dangel
b6fc30964e Add unit test, refs #817 2018-01-11 17:29:34 +01:00
Andreas Dangel
17ea5a89a0 Merge branch 'pr-820' 2018-01-11 17:16:04 +01:00
The Gitter Badger
e6df2c4436 Add Gitter badge 2018-01-11 07:48:19 +00:00
Anand
96fd8fbca6 Merge remote-tracking branch 'Up2Go/master'
# Conflicts:
#	pmd-apex/src/main/resources/rulesets/apex/ruleset.xml
2018-01-09 17:33:32 -08:00
gonzalo
40ad978d8f Receive Charset of Document in the constructor 2018-01-08 08:56:40 -03:00
gonzalo
de09472421 Change filePath type from String to Path 2018-01-08 02:34:30 -03:00
gonzalo
000d72d3be Change name in document operations comparator inner method && Change visibility of getter in DocumentFile 2018-01-08 02:29:44 -03:00
gonzalo
bb8b2cdd4e [WIP] Working fix for <Line, Offset> mapping to support any type of line separators in the same source file && other minor fixes 2018-01-08 01:55:52 -03:00
Clément Fournier
4b43bbcb19 Merge branch 'pr-822' 2018-01-08 00:33:17 +01:00
Juan Martín Sotuyo Dodero
dd0c94a082 Merge branch 'pr-826' 2018-01-07 18:17:31 -03:00
Juan Martín Sotuyo Dodero
4ce6a019e1 Add test scenario 2018-01-07 17:33:33 -03:00
Tobias Weimer
fd51f6254a Update performance.xml
Added missing CDATA
2018-01-07 19:19:17 +01:00
Tobias Weimer
af4c5b2a87 Update performance.xml
Added note about Arrays.asList()
2018-01-05 15:47:16 +01:00
Tobias Weimer
142e533833 Update performance.xml
new Boolean(), new Byte() and new Short() are deoprecated in JDK 9 too.
2018-01-05 15:29:59 +01:00
gonzalo
40bb0a0fe6 Remove Java 8 and 9 language usages 2018-01-03 23:37:58 -03:00
gonzalo
f09a9b62bd Remove source/target configuration for maven-compiler-plugin added by IDEA 2018-01-03 12:03:13 -03:00
gonzalo
8f6484cadc Add operations to manipulate a document 2018-01-03 11:30:07 -03:00
Andreas Dangel
baee671c4a Update release notes, refs #782 2018-01-01 16:33:35 +01:00
Clément Fournier
17dee8d1aa Merge branch 'pr-823' 2017-12-31 18:54:14 +01:00
Juan Martín Sotuyo Dodero
72b22cfa5f Update changelog, refs #812 2017-12-31 01:38:26 -03:00
Juan Martín Sotuyo Dodero
2059eac54b [java] Fix concurrency issue on metrics' framework
- Resolves #812
2017-12-31 01:36:56 -03:00
Juan Martín Sotuyo Dodero
99f8a72f27 Update changelog, refs #800 2017-12-31 01:23:13 -03:00
Juan Martín Sotuyo Dodero
c64f6af157 [java] Avoid NPE in ForLoopCanBeForeachRule
- Take the chance to make this rule use the rulechain
 - This partially fixes #800, but the FN is still unhandled
2017-12-31 01:20:04 -03:00
Juan Martín Sotuyo Dodero
c10a8c6844 Update changelog, refs #817 2017-12-31 01:03:13 -03:00
Juan Martín Sotuyo Dodero
83496c0e59 [java] Fix NPE on UnnecessaryModifierRule
- Fixes #817
2017-12-31 01:01:30 -03:00
Juan Martín Sotuyo Dodero
ec7f64fe55 Update changelog, refs #814 2017-12-31 00:49:59 -03:00
Juan Martín Sotuyo Dodero
729d77614f Handle more kinds of errors
- Handle equally incomplete classpath, having a classpath which
   requires a different JRE version than the one used to run PMD and
   others.
 - Fixes #814
2017-12-31 00:48:23 -03:00
Clément Fournier
ea63134e6b Reorganise sidebar and files 2017-12-31 00:36:18 +01:00
Andreas Dangel
f4577f9e14 [core] Only issue a deprecation warning, if the referenced ruleset is not empty
and all rules have been deprecated.
Fixes #782
2017-12-28 17:17:11 +01:00
Juan Martín Sotuyo Dodero
cd58d15bc2 Merge branch 'pr-806' 2017-12-24 13:35:45 -03:00
Andreas Dangel
4700692e29 [java] Rewrite GuardLogStatementRule without XPath
- uses now a Java only implementions
- Fixes #783
2017-12-24 11:51:29 +01:00
Andreas Dangel
0ce2939c6b Change version to 6.0.1-SNAPSHOT 2017-12-23 09:54:03 +01:00
Andreas Dangel
0c46f3b6dc Merge branch 'pr-804' 2017-12-23 09:41:58 +01:00
Juan Martín Sotuyo Dodero
3d75a7fdfd Update changelog, refs #794 2017-12-23 02:03:41 -03:00
Juan Martín Sotuyo Dodero
f1b4674505 Update docs
- Be more clear as to how to enable incremental analysis
 - Fix broken links
2017-12-23 02:02:09 -03:00
Juan Martín Sotuyo Dodero
d5a7edf7ff Log links to the proper PMD version 2017-12-23 02:01:43 -03:00
Juan Martín Sotuyo Dodero
19cda30527 Merge branch 'pr-798' 2017-12-23 00:57:09 -03:00
Andreas Dangel
109f458dbf Fixes #793 [java] Parser error with private method in nested classes in interfaces
*   Remember old state to allow nesting
*   Fix ASTMethodDeclaration.isInterfaceMember
*   Extended tests
2017-12-22 12:03:20 +01:00
Tobias Weimer
99ea002a95 Update similarprojects.md
Added SpotBugs
2017-12-21 20:58:13 +01:00
Clément Fournier
bc95ca803c Beanify controllers, new settings persistence logic
Add property edition to the XPath panel
2017-12-21 17:08:11 +01:00
Juan Martín Sotuyo Dodero
b25e68d907 Merge branch 'pr-799' 2017-12-21 00:35:48 -03:00
Juan Martín Sotuyo Dodero
3f478bc6f3 Update changelog, refs #799 2017-12-21 00:35:05 -03:00
Travis CI (pmd-bot)
ca41530cf3 Update documentation 2017-12-21 02:41:34 +00:00
Juan Martín Sotuyo Dodero
a42203edc4 Merge branch 'pr-786' 2017-12-20 23:32:30 -03:00
Juan Martín Sotuyo Dodero
0d33ba12b2 Update changelog, refs #786 2017-12-20 23:31:54 -03:00
Juan Martín Sotuyo Dodero
481dcc85b3 Merge branch 'pr-789' 2017-12-20 23:27:56 -03:00
Juan Martín Sotuyo Dodero
9788b8a998 Merge branch 'pr-796' 2017-12-20 23:25:04 -03:00
Juan Martín Sotuyo Dodero
91bce046f5 Update change log, refs #796 2017-12-20 23:24:37 -03:00
Robert Sösemann
9304c70084 Fixes #788 [apex] Method chaining breaks ApexCRUDViolation 2017-12-20 23:25:40 +01:00
Andreas Dangel
64b862eef9 Fixes #793 [java] Parser error with private method in nested classes in interfaces 2017-12-20 22:42:34 +01:00
Andreas Dangel
ef41c71870 github - Update issue template 2017-12-20 20:39:41 +01:00
Robert Sösemann
f267a8f7c7 Fixed https://github.com/pmd/pmd/issues/792 2017-12-20 15:58:12 +01:00
Tobias Weimer
766565a0bf Update performance.xml
new Integer() and new Long() is deoprecated in JDK 9.
2017-12-19 20:55:48 +01:00
Tobias Weimer
fbd9306889 Update performance.xml
Reference to Arrays.copyOf
2017-12-19 20:52:23 +01:00
Tobias Weimer
75fe76cbf5 Update errorprone.xml
Note that Oracle has declared Object.finalize() as deprecated since JDK 9.
2017-12-19 20:48:45 +01:00
Clément Fournier
904924a0c5 Update framework impl page 2017-12-19 12:25:29 +01:00
Clément Fournier
4f7786abc9 Update metrics tuto page 2017-12-19 00:40:00 +01:00
Clément Fournier
c5ddb2fa3c Remove code ref 2017-12-18 12:50:45 +01:00
Clément Fournier
42deb3791c Fix #785: NPE with metrics on empty declarations 2017-12-17 12:59:49 +01:00
Andreas Dangel
b3161639f8 [doc] Update Ruby/Jekyll/Gems 2017-12-15 18:26:26 +01:00
Andreas Dangel
1e25611991 [doc] next version 2017-12-15 16:50:58 +01:00
Andreas Dangel
342b5c3c1d [ci] fix uploading doc to pmd.github.io during release 2017-12-15 16:46:34 +01:00
Andreas Dangel
05d29f4c9b [doc] fix documentation of rule pom/ProjectVersionAsDependencyVersion 2017-12-15 16:46:34 +01:00
Andreas Dangel
cb954e93e5 Prepare next development version 2017-12-15 16:45:46 +01:00
Travis CI (pmd-bot)
cdc33280d6 Update documentation 2017-12-15 15:21:42 +00:00
Andreas Dangel
a975048655 [maven-release-plugin] prepare for next development iteration 2017-12-15 16:01:22 +01:00
Andreas Dangel
9b6fe90225 [maven-release-plugin] prepare release pmd_releases/6.0.0 2017-12-15 16:01:14 +01:00
Andreas Dangel
63742b98e9 Avoid pmdVersion property which conflicts with releasing
See https://issues.apache.org/jira/browse/MRELEASE-932
2017-12-15 15:50:56 +01:00
Andreas Dangel
e88db416b2 [doc] Update release docu 2017-12-15 15:39:59 +01:00
Andreas Dangel
bab09de827 Prepare pmd release 6.0.0 2017-12-15 15:39:39 +01:00
Travis CI (pmd-bot)
bc66441da6 Update documentation 2017-12-15 11:12:04 +00:00
Andreas Dangel
ca07aa2964 [doc] Update release notes, docs 2017-12-15 12:02:24 +01:00
Andreas Dangel
5eb3ecd5ad [core] Make sure, a language with empty version selects the default version 2017-12-15 12:02:04 +01:00
Andreas Dangel
d6a9be55a8 Unify rule category names 2017-12-15 11:22:33 +01:00
Andreas Dangel
998cad8595 [java] fix PMDCoverageTest ruleset 2017-12-15 11:13:35 +01:00
Andreas Dangel
bd77ba6a0f [ci] Go back to java8 in order to include scala in the release 2017-12-15 11:05:36 +01:00
Andreas Dangel
a61b2e16c1 [scala] Properly activate/decativate scala depending on java version 2017-12-15 10:58:09 +01:00
Andreas Dangel
02fadc1689 [core] Fix classloader closed issue when executing Ant task
Note: the problem (ClassNotFoundExceptions) only shows up with java8
- with java9 the classloader seems to be still usable, even after
we closed it...
2017-12-15 10:32:06 +01:00
Andreas Dangel
99d1e96b1b [doc] Update doc regarding properties
refs #504, refs #762
2017-12-11 19:50:33 +01:00
Andreas Dangel
7e5c272f17 release notes: add missing toc entry 2017-12-09 10:44:39 +01:00
Travis CI (pmd-bot)
5ae9607cfc Update documentation 2017-12-09 09:42:47 +00:00
Andreas Dangel
c8645440f2 Update release notes with new rules 2017-12-09 10:24:30 +01:00
Andreas Dangel
1bdb412c09 Merge branch 'pr-764' 2017-12-09 10:12:12 +01:00
Andreas Dangel
060848a455 Update release notes, refs #764
closes #762
closes #763
2017-12-09 10:11:10 +01:00
Andreas Dangel
2f4e1ba20d Update release notes, closes #766 2017-12-09 09:44:29 +01:00
kenji21
56cead8423 Add Associated Type Constraints & Class and Protocol Existential example
Update token count to match these additions already managed by the
grammar
2017-12-08 06:13:11 +01:00
kenji21
b10e21df7f Add more swift4 syntax and update grammar for multiline 2017-12-08 06:06:19 +01:00
kenji21
315bb87c7f Update Swift.g4 grammar to have swift4 keypath support 2017-12-08 06:06:19 +01:00
Juan Martín Sotuyo Dodero
83c15e2e45 Merge branch 'pr-774' 2017-12-08 00:59:32 -03:00
Juan Martín Sotuyo Dodero
9c832e3ac5 Update changelog, refs #774 2017-12-08 00:59:03 -03:00
Juan Martín Sotuyo Dodero
0f9e521ea7 Update docs 2017-12-08 00:54:48 -03:00
Juan Martín Sotuyo Dodero
3817dc2782 Improve docs 2017-12-08 00:42:56 -03:00
Juan Martín Sotuyo Dodero
53a9449141 Use autogenerated versions of docs 2017-12-08 00:39:29 -03:00
Travis CI (pmd-bot)
5a228d2b6f Update documentation 2017-12-08 01:56:40 +00:00
Juan Martín Sotuyo Dodero
b32644c744 Merge branch 'pr-775' 2017-12-07 22:48:36 -03:00
Juan Martín Sotuyo Dodero
dc75904de6 Make sure we only recomend this to "modern" JVMs 2017-12-07 22:48:08 -03:00
Juan Martín Sotuyo Dodero
8accdf01a4 Merge branch 'pr-733' 2017-12-07 22:41:15 -03:00
Andreas Dangel
a86aea2379 [apex] Create separate module "pmd-apex-jorje" which provides the apex jorje parser 2017-12-06 20:14:03 +01:00
Andreas Dangel
6a5e49efee [apex] Attach apex jorje jar using classifier "apex-jorje" 2017-12-05 22:34:43 +01:00
Andreas Dangel
38bc6bf1fa [apex] Fix suppress warnings support 2017-12-04 21:44:57 +01:00
Andreas Dangel
892a673c9f [apex] Remove empty catches, fix old reflections calls in Helper 2017-12-04 21:44:57 +01:00
Andreas Dangel
dbcd36cd7a [apex] Fix ApexCRUDViolation rule
- reflection not necessary anymore
- constructor is now not anymore returned
as <init> but as the actual name
2017-12-04 21:44:57 +01:00
Andreas Dangel
7f8c8a0854 [apex] Fix line/column numbering 2017-12-04 21:44:57 +01:00
Andreas Dangel
29c7061bde [apex] Adjust to new apex jorje 2017-12-04 21:44:52 +01:00
Andreas Dangel
6caad3485c [apex] Add script to create minimized apex jorje jar, add jar as dependency 2017-12-04 21:14:27 +01:00
Andreas Dangel
7fa49aacc6 [apex] Declare transitive dependencies 2017-12-04 21:13:54 +01:00
Travis CI (pmd-bot)
e8023e8913 Update documentation 2017-12-04 04:41:05 +00:00
Juan Martín Sotuyo Dodero
2ff93cc82e Merge branch 'pr-772' 2017-12-04 01:33:05 -03:00
Travis CI (pmd-bot)
8405ce3d65 Update documentation 2017-12-03 18:48:50 +00:00
Andreas Dangel
b3a7271b98 Merge branch 'pr-771' 2017-12-03 19:32:19 +01:00
Andreas Dangel
83b2e91f3d Update release notes, closes #768 2017-12-03 19:22:11 +01:00
Andreas Dangel
07cb937d6e [java] Update OptimizableToArrayCall rule for current JVMs
See https://sourceforge.net/p/pmd/bugs/1454/
and https://shipilev.net/blog/2016/arrays-wisdom-ancients/
2017-12-01 11:41:23 +01:00
Chas Honton
ac36d678bb Updates per suggestions; merge four rules into one 2017-11-30 21:53:48 -08:00
Chas Honton
51241368b3 Avoid using FileInput/Output - see JDK-8080225 2017-11-30 20:10:04 -08:00
Andreas Dangel
e84800b34c Update ruleset factory compatibility 2017-11-30 22:54:07 +01:00
Andreas Dangel
0f96c82695 Update release notes, closes #457 2017-11-30 22:49:34 +01:00
Andreas Dangel
5e3b4504d8 [java] Remove old rules GuardDebugLogging and GuardLogStatementJavaUtil 2017-11-30 22:48:01 +01:00
Andreas Dangel
1447ac8a4a [java] Merge GuardDebugLogging and GuardLogStatementJavaUtil into
the rule GuardLogStatement
2017-11-30 22:38:14 +01:00
Clément Fournier
2c94dd993d Corrections for PR #771 2017-11-30 19:31:11 +01:00
Clément Fournier
41a6b78231 Revert back to __ from :: for Apex namespaces 2017-11-30 18:38:11 +01:00
Clément Fournier
41a3202a18 Fix Apex metrics framework failing on triggers, refs #768 2017-11-30 15:22:26 +01:00
Clément Fournier
36ba0e9581 Add a handle on the value parser of the property 2017-11-30 11:34:44 +01:00
Clément Fournier
53f6c39f65 Make the constants available from the string type id 2017-11-29 00:18:40 +01:00
Clément Fournier
b81158ecf0 Convert PropertyDescriptorUtil to an enum and enrich its interface
refs #763
2017-11-28 19:44:24 +01:00
Clément Fournier
539d541ffd Hide factories of MethodProperty, MethodMultiProperty, FileProperty from XPath rules
refs #762
2017-11-28 19:02:29 +01:00
Clément Fournier
abdb96238d Improve builders interface 2017-11-28 18:49:23 +01:00
Travis CI (pmd-bot)
345cc50f78 Update documentation 2017-11-27 20:11:47 +00:00
Andreas Dangel
ae6894c73f Merge branch 'pr-761' 2017-11-27 20:57:45 +01:00
Andreas Dangel
a0de21003a Update release notes, refs #760 2017-11-27 20:57:23 +01:00
Andreas Dangel
be29ba44e2 Merge branch 'pr-758' 2017-11-27 20:55:42 +01:00
Andreas Dangel
cbeaea0e73 Update release notes, refs #758 2017-11-27 20:54:37 +01:00
Andreas Dangel
7976170300 [doc] Update working with properties
Refs #736
2017-11-27 20:48:38 +01:00
Andreas Dangel
8eb5170b31 Merge branch 'pr-736' 2017-11-27 20:47:27 +01:00
Andreas Dangel
acef94f28a Update release notes, refs #736 2017-11-27 20:46:44 +01:00
Juan Martín Sotuyo Dodero
309b964441 [apex] Avoid FPs on non-existing else block
- IfElseStatement always has 2 BlockStatements, for the if and the
   else, even if not present on the code. When that happens, the phantom
   block is given the same location the parent has.
 - Fixes #760
2017-11-27 10:43:23 -03:00
Clément Fournier
4724ed4636 Expose the full mappings in property descriptor util 2017-11-25 16:15:42 +01:00
Juan Martín Sotuyo Dodero
decf2ae7d0 Merge branch 'pr-756' 2017-11-25 00:26:02 -03:00
Travis CI (pmd-bot)
fe6592882c Update documentation 2017-11-25 02:43:53 +00:00
Juan Martín Sotuyo Dodero
e3a6ee76d4 Merge branch 'pr-753' 2017-11-24 23:35:47 -03:00
Andreas Dangel
456432ad6f Resolve deprecated usages 2017-11-24 20:48:02 +01:00
Andreas Dangel
08b018274c [core] Fix rule loading - only override the flags, if they are true
Avoid disabling type resolution
2017-11-24 20:45:13 +01:00
Andreas Dangel
b879e76d8b Update release notes 2017-11-24 20:21:12 +01:00
Andreas Dangel
fa1e16fcf8 [java] Remove FUTURE comment from AccessNode 2017-11-24 20:15:58 +01:00
Andreas Dangel
4214a75fc4 [core] Add bean-like getter/setter for Rule 2017-11-24 20:13:20 +01:00
Andreas Dangel
2a1b7addb4 Revert "[core] add temporary support for maven debug output"
This reverts commit 61376f8112.

With https://issues.apache.org/jira/browse/MPMD-246 this is not needed
anymore.
2017-11-24 18:11:12 +01:00
Andreas Dangel
71ee2b6d9e Merge branch 'pr-749' 2017-11-24 14:36:55 +01:00
Andreas Dangel
62eb616ea6 Update release notes, refs #749 2017-11-24 14:36:06 +01:00
Andreas Dangel
114afdaa0e [doc] Fix type names of property value types 2017-11-24 14:35:00 +01:00
Andreas Dangel
c49ae6b769 Merge branch 'pr-742' 2017-11-24 11:51:18 +01:00
Andreas Dangel
6c14880afa Merge branch 'pr-741' 2017-11-24 11:45:10 +01:00
Andreas Dangel
4ad209c81f Update release notes, refs #732 2017-11-24 11:44:59 +01:00
Andreas Dangel
3bad361e2f [java] Change MoreThanOneLoggerRule to avoid classloader issues
refs #732
2017-11-24 11:43:23 +01:00
Andreas Dangel
2d0f6ffc89 [doc] Fix automated links generation
Resolves #751
2017-11-24 09:51:08 +01:00
Andreas Dangel
3132080b83 [doc] Fix how moved and deprecated rules are linked
Text should be the old name, the link should point to the new name/rule
2017-11-24 09:28:05 +01:00
Travis CI (pmd-bot)
70fc3d75bb Update documentation 2017-11-23 20:47:04 +00:00
Andreas Dangel
8b77f6769e Merge branch 'pr-748' 2017-11-23 21:27:41 +01:00
Andreas Dangel
31725ae241 Merge branch 'pr-747' 2017-11-23 21:25:36 +01:00
Travis CI (pmd-bot)
9bfde52869 Update documentation 2017-11-23 19:39:06 +00:00
Andreas Dangel
6136de2d28 Fix Metrics ruleset name 2017-11-23 20:30:32 +01:00
Andreas Dangel
f436e8b38f [ci] fix sonar.host.url - it's now https://sonarcloud.io 2017-11-23 20:23:31 +01:00
Andreas Dangel
72b5bda178 Deprecate the old bgastviewer implementation 2017-11-23 20:20:38 +01:00
Juan Martín Sotuyo Dodero
a95b2a6d85 Deprecate the old designer's classes 2017-11-23 00:39:43 -03:00
Juan Martín Sotuyo Dodero
cbef7a5602 Merge branch 'pr-731' 2017-11-22 18:03:49 -03:00
Andreas Dangel
204e64ea62 Merge branch 'pr-711' 2017-11-22 21:51:31 +01:00
Andreas Dangel
7d7189f749 Update release notes, refs #711 2017-11-22 21:43:57 +01:00
Andreas Dangel
c17322a9e6 Add new designer to start scripts 2017-11-22 21:37:38 +01:00
Andreas Dangel
47a29fdb17 Add break and adjust logging 2017-11-22 21:31:13 +01:00
Andreas Dangel
16c3c161bc Merge remote-tracking branch 'origin/master' into api-ruleset-compatibility 2017-11-22 21:29:28 +01:00
Clément Fournier
9c0b865477 Add disclaimer and xpath example 2017-11-21 22:38:28 +01:00
Clément Fournier
6fa288497a Remove the remains of the old article.
That part was about developing a UI for an IDE plugin. The info was heavily outdated, and the up to date info can be found in the javadoc of the PropertyDescriptor interface.
2017-11-21 22:38:28 +01:00
Clément Fournier
c43717f66d Fix some inconsistencies 2017-11-21 22:38:27 +01:00
Clément Fournier
09d9cdd3a5 Update title, link and sidebar 2017-11-21 22:38:27 +01:00
Clément Fournier
02f0ab05a8 Remove outdated info 2017-11-21 22:38:27 +01:00
Clément Fournier
2101233235 Complete XPath properties doc 2017-11-21 22:38:13 +01:00
Juan Martin Sotuyo Dodero
b4e0cd3649 [java] EmptyCatchBlock ignore expected by default
- We chnge the default to ignore exceptions named `ignore` or
   `expected`, users can still override this behaviour.
2017-11-21 18:30:50 -03:00
Juan Martin Sotuyo Dodero
4e29faa3eb [java] Merge EmptyStaticInitializer into EmptyInitializer 2017-11-21 17:51:59 -03:00
Juan Martin Sotuyo Dodero
802e7a7df0 Fix checkstyle 2017-11-21 17:51:34 -03:00
Clément Fournier
b654b1b839 Complete properties doc for java rules 2017-11-21 21:21:46 +01:00
Juan Martín Sotuyo Dodero
4cae41deb9 Merge branch 'master' into api-ruleset-compatibility 2017-11-21 14:54:41 -03:00
Juan Martín Sotuyo Dodero
a9ce410845 Merge branch 'master' into api-ruleset-compatibility 2017-11-21 14:53:42 -03:00
Juan Martin Sotuyo Dodero
e79cc20da4 Merge branch 'pr-723' 2017-11-21 14:50:42 -03:00
Juan Martin Sotuyo Dodero
23035524b9 Update changelog, refs #723 2017-11-21 14:50:00 -03:00
Juan Martin Sotuyo Dodero
4f5b18dfba Simplifications 2017-11-21 14:48:06 -03:00
Juan Martin Sotuyo Dodero
62397892ae Merge branch 'pr-746' 2017-11-21 13:49:16 -03:00
Juan Martin Sotuyo Dodero
42676fee09 Update changelog, refs #746 2017-11-21 13:49:02 -03:00
Clément Fournier
77048f16ea Fix another few things 2017-11-21 17:33:29 +01:00
Clément Fournier
60abf4994f Fix typo in incremental analysis log message 2017-11-21 17:14:21 +01:00
Juan Martin Sotuyo Dodero
1ad3c7e194 Merge branch 'pr-744' 2017-11-21 12:50:04 -03:00
Juan Martin Sotuyo Dodero
0bdf831845 Update changelog, refs #744 2017-11-21 12:49:49 -03:00
Juan Martin Sotuyo Dodero
b5fc443ae3 Further improve the CPD supported language list 2017-11-21 12:48:43 -03:00
Travis CI (pmd-bot)
41b6644c1f Update documentation 2017-11-21 15:43:00 +00:00
Juan Martin Sotuyo Dodero
8edd3ed091 Merge branch 'pr-733' 2017-11-21 12:34:06 -03:00
Michał Kuliński
452a77abfd Added Apex to supported languages 2017-11-21 16:32:58 +01:00
Juan Martin Sotuyo Dodero
324e0216df Update changelog, refs #733 2017-11-21 12:29:41 -03:00
Clément Fournier
5a978cb7b0 Make CommentRequirement private 2017-11-21 11:45:09 +01:00
Clément Fournier
632ed17464 Corrections for PR #723 2017-11-21 11:28:25 +01:00
Juan Martin Sotuyo Dodero
6028e77e62 [core] Improve classloaders
- Avoid a race condition that could produce multiple threads loading
   the same class at the same time.
 - Fixed a broken check on PMDASMClassLoader that would always return
   false.
2017-11-21 00:16:20 -03:00
Juan Martin Sotuyo Dodero
3ca4b71f72 [java] Don't expect to load classes from execution classpath
- We can't assume the classes needed for analysis will be available
in the execution classpath, we need to make sure to load them from the
same classloader / auxclaspath used during analysis.
 - Resolves #732
2017-11-21 00:12:52 -03:00
Travis CI (pmd-bot)
0ff05ed740 Update documentation 2017-11-20 20:38:24 +00:00
Juan Martin Sotuyo Dodero
d8fdbde68d Merge branch 'pr-727' 2017-11-20 17:29:41 -03:00
Juan Martin Sotuyo Dodero
a2985b89ab Update changelog, refs #727 2017-11-20 16:57:51 -03:00
Juan Martin Sotuyo Dodero
3ffeeca518 Only allow null default values 2017-11-20 16:56:10 -03:00
Juan Martin Sotuyo Dodero
73df7d048a Merge branch 'pr-729' 2017-11-20 16:37:12 -03:00
Juan Martin Sotuyo Dodero
301f8db6f5 Merge branch 'pr-738' 2017-11-20 15:49:16 -03:00
Clément Fournier
7fa795ba89 Revert "Fix xml/InvalidDependencyTypes property", which triggers #739
This reverts commit 9e6be2d8a2.
2017-11-19 18:17:37 +01:00
Clément Fournier
d4b39729f1 Make attributes support full value range 2017-11-19 16:19:18 +01:00
Travis CI (pmd-bot)
45c74ba6f6 Update documentation 2017-11-19 13:06:13 +00:00
Andreas Dangel
c4b8c72cf6 Merge remote-tracking branch 'origin/master' 2017-11-19 13:53:21 +01:00
Andreas Dangel
98ac510443 Merge branch 'pr-734' 2017-11-19 13:47:02 +01:00
Andreas Dangel
35bed4e2d0 Update release notes, refs #734 2017-11-19 13:44:54 +01:00
Andreas Dangel
fd0cdb9514 Mark property "reportLevel" of CyclomaticComplexityRule as deprecated 2017-11-19 13:39:21 +01:00
Clément Fournier
9e6be2d8a2 Fix xml/InvalidDependencyTypes property 2017-11-19 13:30:20 +01:00
Travis CI (pmd-bot)
ab80d18ff6 Update documentation 2017-11-19 09:54:59 +00:00
Andreas Dangel
7a29a71c0d Merge branch 'pr-737' 2017-11-19 10:38:55 +01:00
Andreas Dangel
05836de7a8 Update release notes, refs #737 2017-11-19 10:38:16 +01:00
Andreas Dangel
d2d79bcfca Update release notes, mention the new rule categories 2017-11-19 10:31:10 +01:00
Andreas Dangel
9b8571e688 [doc] Mention rule categories 2017-11-19 10:30:38 +01:00
Andreas Dangel
ca3960a106 [doc] Remove reference to gettingstarted ruleset 2017-11-19 09:46:49 +01:00
Clément Fournier
3055d25aac Fix doc 2017-11-18 15:34:42 +01:00
Clément Fournier
79dd6c525f Fix npath documentation bad rendering 2017-11-18 15:31:58 +01:00
Clément Fournier
3f91560c11 Remove directories from recent files 2017-11-18 14:47:51 +01:00
Clément Fournier
38034fe517 Make export wizard work! 2017-11-17 22:06:45 +01:00
Clément Fournier
456ae3db98 Put list cell factories into fxml 2017-11-17 21:58:50 +01:00
Clément Fournier
2dce5e1ea5 Improve scope hierarchy node display 2017-11-17 21:13:19 +01:00
Clément Fournier
f9c00d8408 Cleanup pom 2017-11-17 20:33:16 +01:00
Clément Fournier
652b80004d Make Saxon support multival properties as XPath sequences 2017-11-17 18:41:07 +01:00
Clément Fournier
09da4255df Change List<> syntax to List[] for xpath prop descriptors 2017-11-17 14:09:34 +01:00
Andreas Dangel
42da2b89f2 [doc] Use category instead of rulesets 2017-11-13 21:29:24 +01:00
Clément Fournier
7cab3cbc73 Move CyclomaticComplexity from metrics to design w/ deprecated property 2017-11-12 13:33:05 +01:00
Juan Martín Sotuyo Dodero
227a0046c5 Merge branch 'pr-726' 2017-11-11 19:14:02 -03:00
Juan Martín Sotuyo Dodero
64627765e3 Update changelog, refs #726 2017-11-11 19:13:16 -03:00
Clément Fournier
2eee7a1276 Decouple enum constants from their labels 2017-11-11 22:40:02 +01:00
Clément Fournier
a9843c6a44 Add accessor comment requirement property 2017-11-11 22:17:11 +01:00
Clément Fournier
3e1a787f26 Fix override property 2017-11-11 22:17:11 +01:00
Clément Fournier
57deb9d78d Pretty print the messages 2017-11-11 22:17:11 +01:00
Clément Fournier
e316fcc64f Remove some garbage 2017-11-11 22:17:00 +01:00
Clément Fournier
2efb52be14 Add ignore override property 2017-11-11 20:59:27 +01:00
Andreas Dangel
ea38e30204 Update release notes, refs #394 2017-11-11 14:31:27 +01:00
Andreas Dangel
58b996a634 [core] Add all rules of a ruleset, if the ruleset itself is deprecated
that is: The ruleset only contains deprecated rules.
2017-11-11 14:06:50 +01:00
Clément Fournier
bf3ce9d37a Allow null value for numeric properties 2017-11-11 12:20:43 +01:00
Clément Fournier
b9a605c86a Shorten test case 2017-11-11 12:07:51 +01:00
Andreas Dangel
0e389af616 [core] Add old RuleSetFactory constructor back for API backwards compatibility 2017-11-11 12:07:13 +01:00
Andreas Dangel
ba3e2bc788 [core] RuleSetFactory: Filter by minimumPriority at the end
-   Resolves #394
2017-11-11 12:03:45 +01:00
Clément Fournier
64d07ccf5a Add annotations to apex syntax highlighter 2017-11-10 20:34:08 +01:00
Andreas Dangel
6b5e8ce344 [doc] List the rules of the additional rulesets 2017-11-10 20:18:23 +01:00
Clément Fournier
2979d82755 Allow tokens to receive several css classes 2017-11-10 18:57:59 +01:00
Andreas Dangel
490fe312f2 [doc] Move the additional rulesets to the bottom 2017-11-10 17:59:04 +01:00
Andreas Dangel
26ba531c85 [doc] Add sidebar entries for rule categories 2017-11-10 17:49:16 +01:00
Andreas Dangel
9a9fb0b12f [doc] Scan for additional rulesets and list them per language 2017-11-10 14:23:22 +01:00
Andreas Dangel
06a1244e15 [doc] Add unit test for all rulesets and fix existing rulesets 2017-11-10 14:03:05 +01:00
Andreas Dangel
1c9c750a0a [doc] Strip leading whitespace indentation from rule description 2017-11-10 11:44:35 +01:00
Andreas Dangel
490bf99a01 [doc] Mark deprecated properties 2017-11-10 10:35:55 +01:00
Travis CI (pmd-bot)
c647f73811 Update documentation 2017-11-09 21:19:35 +00:00
Andreas Dangel
fe086dd1ee Merge remote-tracking branch 'pmd-sf/master' 2017-11-09 22:07:30 +01:00
Andreas Dangel
3b624bf687 Merge branch 'pr-722' 2017-11-09 22:04:46 +01:00
Andreas Dangel
24d79fe5b9 Merge branch 'pr-722' 2017-11-09 21:57:28 +01:00
Andreas Dangel
80638f663d Update release notes, refs #722 2017-11-09 21:57:21 +01:00
Clément Fournier
c1ccc26de8 Fix #725: numeric property descriptors now check their default value 2017-11-09 21:25:41 +01:00
Clément Fournier
947d4ab1a8 Fix issue #721 2017-11-09 20:54:03 +01:00
Clément Fournier
31696c7397 Deprecate compat property for 7.0.0 2017-11-09 20:28:09 +01:00
Clément Fournier
695defcc61 Add old property back and log warning + correct the property range 2017-11-09 15:02:59 +01:00
Travis CI (pmd-bot)
b159143a06 Update documentation 2017-11-08 20:08:46 +00:00
Andreas Dangel
d0f0c467a0 Merge branch 'pr-717' 2017-11-08 20:54:12 +01:00
Clément Fournier
33b22cb7de Remove ruledef dir 2017-11-08 19:08:45 +01:00
Clément Fournier
d3f72c27bd Adapt to changes on master 2017-11-08 19:08:01 +01:00
Clément Fournier
3dfdef1467 Correct override behaviour 2017-11-08 18:57:10 +01:00
Clément Fournier
b7caf2ff76 Remove rule factory singleton 2017-11-08 18:57:10 +01:00
Clément Fournier
f98ac47045 Inline ruleset schema constants 2017-11-08 18:57:10 +01:00
Clément Fournier
b5761ec2a1 Fix documentation 2017-11-08 18:57:10 +01:00
Clément Fournier
e3bc90c1eb Use enum constants to identify nodes 2017-11-08 18:57:10 +01:00
Clément Fournier
86b0bb4cd7 Rule references use rule factory. Properties declared in a rule ref throw an exception while parsing 2017-11-08 18:57:10 +01:00
Clément Fournier
845e7ca7a8 Plug into RuleSetFactory 2017-11-08 18:56:09 +01:00
Clément Fournier
d933deed6b Fix merge conflicts 2017-11-08 18:52:53 +01:00
Clément Fournier
8a048fd18d Rule factory and builder 2017-11-08 18:52:53 +01:00
Clément Fournier
f8bea7f580 Move NPathComplexity from metrics to design 2017-11-08 14:11:36 +01:00
Clément Fournier
1337533920 Use enum for css class names in highlighters 2017-11-08 13:10:54 +01:00
Clément Fournier
e336a4f711 Use ${project.version} in the pom.xml 2017-11-08 12:49:26 +01:00
Juan Martín Sotuyo Dodero
aa3068fedd Merge branch 'pr-716' 2017-11-07 23:11:22 -03:00
Juan Martín Sotuyo Dodero
2c0957a07b Add back the removed UnnecessaryFinalModifier rule 2017-11-07 20:39:30 -03:00
Andreas Dangel
6bba28acbe Add categories.properties files 2017-11-07 22:23:17 +01:00
Clément Fournier
56c8662d2c Merge branch 'master' into fx-designer 2017-11-07 19:34:41 +01:00
Clément Fournier
7d85448659 Merge branch 'master' into fx-designer 2017-11-07 19:34:02 +01:00
Clément Fournier
539269b3d7 Correct syntax highlighters 2017-11-07 19:31:28 +01:00
Juan Martín Sotuyo Dodero
7bbf6d1a56 Update changelog, refs #717 2017-11-07 00:34:15 -03:00
Juan Martín Sotuyo Dodero
f9f96b84fe [java] merge UnnecessaryFinalModifier into UnnecessaryModifier
- I take the chance to also flag final resources in try-with-resources
 - This resolves #411
 - This resolves #676
 - The rule is now using the rulechain
2017-11-07 00:34:00 -03:00
Juan Martín Sotuyo Dodero
b1665cf6c1 Merge branch 'pr-708' 2017-11-06 18:54:59 -03:00
Andreas Dangel
243044b056 [doc] Update doc for xml/pom rules 2017-11-06 21:26:23 +01:00
Andreas Dangel
d07dcb085a [xml] Move pom/ProjectVersionAsDependencyVersion to errorprone 2017-11-06 21:22:45 +01:00
Juan Martín Sotuyo Dodero
25da0c86f2 Merge branch 'pr-697' 2017-11-06 13:41:27 -03:00
Clément Fournier
82b76de771 More 2017-11-06 13:58:14 +01:00
Clément Fournier
fc683fbe12 Small improvements, PR #711 2017-11-06 13:57:12 +01:00
Clément Fournier
29f373dd78 Fix a few things, PR #711 2017-11-06 00:38:33 +01:00
Clément Fournier
9f10c9ca5c Fix core and pom bug 2017-11-05 23:14:31 +01:00
Clément Fournier
b5a9857fbf Remove unnecessary icons 2017-11-05 17:13:31 +01:00
Clément Fournier
eef30d2761 Add verbose mode 2017-11-05 16:52:39 +01:00
Juan Martín Sotuyo Dodero
9e1342f30a Merge branch 'pr-696' 2017-11-04 19:48:28 -03:00
Juan Martín Sotuyo Dodero
9e894fdce9 Update changelog, refs #696 2017-11-04 19:47:58 -03:00
Juan Martín Sotuyo Dodero
8d381daeb3 Merge branch 'pr-669' 2017-11-04 19:40:14 -03:00
Juan Martín Sotuyo Dodero
3b28625b8a Update changelog, refs #669 2017-11-04 19:39:31 -03:00
Juan Martín Sotuyo Dodero
5d6a03612e Rename builder method 2017-11-04 19:19:39 -03:00
Travis CI (pmd-bot)
c011398c93 Update documentation 2017-11-04 21:26:32 +00:00
Juan Martín Sotuyo Dodero
e7e5e13a7d Merge branch 'pr-703' 2017-11-04 18:18:13 -03:00
Andreas Dangel
e064efbad3 [apex] Move AvoidHardCodingId Rule to errorprone 2017-11-04 20:16:04 +01:00
Travis CI (pmd-bot)
dd2b06f748 Update documentation 2017-11-04 19:12:47 +00:00
Andreas Dangel
d0b3845ba0 Consider renamed rule MisleadingVariableName in RuleSetFactoryCompatibility 2017-11-04 19:57:31 +01:00
Andreas Dangel
e1a588f499 Merge branch 'master' into ruleset-categories 2017-11-04 19:53:21 +01:00
Andreas Dangel
04c8d0a6c9 Merge branch 'pr-687' 2017-11-04 19:40:56 +01:00
Andreas Dangel
961cf8d49a Merge branch 'pr-686' 2017-11-04 19:32:36 +01:00
Juan Martín Sotuyo Dodero
0c0486d40c Update maven wrapper to 3.5.2 2017-11-04 02:27:42 -03:00
Travis CI (pmd-bot)
1678017fe0 Update documentation 2017-11-03 21:24:16 +00:00
Juan Martín Sotuyo Dodero
9e024e06c0 Merge branch 'pr-706' 2017-11-03 18:16:28 -03:00
Juan Martín Sotuyo Dodero
6b618f6ce2 Merge branch 'pr-705' 2017-11-03 17:58:19 -03:00
Juan Martín Sotuyo Dodero
4f53c3efb8 Merge branch 'pr-707' 2017-11-03 17:53:25 -03:00
Juan Martín Sotuyo Dodero
e4440982cc Merge branch 'pr-704' 2017-11-03 17:51:34 -03:00
Travis CI (pmd-bot)
51c7024a77 Update documentation 2017-11-03 20:43:10 +00:00
Juan Martín Sotuyo Dodero
e74237c74b Merge branch 'pr-700' 2017-11-03 17:26:34 -03:00
Andreas Dangel
17f2e793d7 Fix TODO - false positive of UselessParenthesis (refs #709) 2017-11-03 20:09:16 +01:00
Andreas Dangel
e0f92716d9 [xml] Reorganize rules into categories 2017-11-03 17:36:25 +01:00
Andreas Dangel
5b0472950c [vm] Reorganize rules into categories 2017-11-03 17:08:34 +01:00
Andreas Dangel
cae170f4e2 [visualforce] Reorganize rules into categories 2017-11-03 16:37:34 +01:00
Andreas Dangel
9f70e9d2c8 [doc] Update generated plsql ruleset files 2017-11-03 16:30:15 +01:00
Andreas Dangel
5459636fbe [plsql] Move rules and tests to new packages 2017-11-03 16:24:51 +01:00
Andreas Dangel
d05ca8ade4 [plsql] Reorganize rules into categories 2017-11-03 16:17:14 +01:00
Andreas Dangel
ac49d6fb6f [doc] Update generated jsp ruleset files 2017-11-03 15:37:24 +01:00
Andreas Dangel
15526591d4 [jsp] Move rules and tests to new packages 2017-11-03 15:31:00 +01:00
Andreas Dangel
f05c865a24 [jsp] Reorganize rules into categories 2017-11-03 15:20:42 +01:00
Andreas Dangel
981887869d [doc] Update generated apex ruleset files 2017-11-03 14:45:56 +01:00
Andreas Dangel
7e3b3fbff5 [apex] Update code climate ruleset 2017-11-03 14:45:27 +01:00
Andreas Dangel
8c53cb8879 [apex] Move rules and tests to new packages 2017-11-03 14:25:26 +01:00
Andreas Dangel
e9425e34d8 [apex] Reorganize rules into categories 2017-11-03 14:05:40 +01:00
Andreas Dangel
f00224cd90 [javascript] Update rule category descriptions 2017-11-03 12:27:00 +01:00
Andreas Dangel
5359b71569 [doc] Update generated ruleset documentation 2017-11-03 12:24:38 +01:00
Andreas Dangel
aacae9e47d [java] Update category descriptions 2017-11-03 12:18:22 +01:00
Andreas Dangel
19c48cbcee [doc] Fix unit test 2017-11-03 12:13:45 +01:00
Andreas Dangel
20863e1853 Fix checkstyle 2017-11-03 12:08:00 +01:00
Andreas Dangel
c9952e613c [core] fix references to new rules for v6.0.0 2017-11-03 12:04:45 +01:00
Andreas Dangel
77959e9937 [java] Fix unit tests 2017-11-03 12:04:26 +01:00
Andreas Dangel
238494b092 [java] Moving rules into correct packages according to the new category - Part 3 2017-11-03 11:54:34 +01:00
Andreas Dangel
696c1cb651 [java] Moving rules into correct packages according to the new category - Part 2 2017-11-02 20:36:28 +01:00
Andreas Dangel
b3e485d325 [java] Moving rules into correct packages according to the new category - Part 1 2017-11-01 20:17:11 +01:00
Andreas Dangel
c29f2a44e6 Revert "Temporarily disable the unit tests until the rules are moved into the"
This reverts commit ded09b6498.
2017-11-01 18:54:10 +01:00
Clément Fournier
ac2ff0f6af Merge branch 'master' into properties-builder 2017-11-01 18:47:29 +01:00
Andreas Dangel
69be69c35c [javascript] Add category descriptions 2017-11-01 18:44:34 +01:00
Andreas Dangel
fb79716cfa [javascript] Move rule AvoidTrailingComma to errorprone 2017-11-01 18:43:35 +01:00
Clément Fournier
fc0cb45f49 Merge branch 'master' into properties-builder 2017-11-01 18:21:54 +01:00
Clément Fournier
6b50104cb5 Corrections for PR #669 2017-11-01 18:17:57 +01:00
Clément Fournier
8915e17f20 Fix focus problems 2017-11-01 15:47:46 +01:00
Clément Fournier
63a35c2967 Merge branch 'master' of https://github.com/pmd/pmd into fx-designer 2017-11-01 15:29:32 +01:00
Clément Fournier
c58921303d Support Java 9 and 8 2017-11-01 15:29:11 +01:00
Clément Fournier
1295f29ac9 Export to rule wizard 2017-10-31 19:01:51 +01:00
Andreas Dangel
593226ce2a [doc] Update generated ecmascript ruleset files 2017-10-31 15:58:35 +01:00
Andreas Dangel
a4248afbbc [javascript] Move rules and tests to new packages 2017-10-31 15:48:05 +01:00
Andreas Dangel
b2f8cc094c [javascript] Reorganize rules into categories 2017-10-31 15:32:50 +01:00
Andreas Dangel
1d07ad353e [doc] Update generated ruleset documentation 2017-10-31 12:17:55 +01:00
Andreas Dangel
57c1021c3c [java] Move rules between categories, fix typo for AvoidAccessibilityAlteration 2017-10-31 11:58:22 +01:00
Juan Martín Sotuyo Dodero
c466179c2a Handle SecurityErrors on bad auxclasspath entries 2017-10-31 01:53:03 -03:00
Andreas Dangel
cee3d6ad2d Fix invalid language version 2017-10-30 22:00:52 +01:00
Andreas Dangel
cc5ff0a018 [doc] Adjust rule doc generator to use "category" 2017-10-30 21:19:49 +01:00
Andreas Dangel
68a56ee0d8 [java] Move category rulesets into own category directory
restore previous design rulesest
2017-10-30 21:19:36 +01:00
Andreas Dangel
bf6eacf96b [java] Fix wrong externalInfoUrls, add missing minimumLanguageVersion 2017-10-30 21:19:04 +01:00
Juan Martín Sotuyo Dodero
64628370c8 Merge branch 'pr-679' 2017-10-30 16:56:17 -03:00
Juan Martín Sotuyo Dodero
eb526f55ac Update changelog, refs #679 2017-10-30 16:55:40 -03:00
Juan Martín Sotuyo Dodero
91d40710dc Temporarily disable PMD checks on Travis 2017-10-30 16:54:38 -03:00
Matias Comercio
9348c54afb Fix PR - 1
- Remove unnecessary asserts for checking setup
- Improve `for` loop performance in AbstractNode.removeChildAtIndex method
- Remove unnecessary detachment of the node being removed children
2017-10-30 15:39:16 -03:00
Juan Martín Sotuyo Dodero
67f0fbbbfe Add missing @Overrides 2017-10-30 00:26:42 -03:00
Andreas Dangel
0a38e06442 [doc] add generated ruleset documentation 2017-10-29 21:32:45 +01:00
Andreas Dangel
6a6ef9e18e [doc] fix doc generator tests which depended on a ruleset from java 2017-10-29 21:28:40 +01:00
Andreas Dangel
ded09b6498 Temporarily disable the unit tests until the rules are moved into the
correct packages
2017-10-29 21:12:39 +01:00
Andreas Dangel
42973c4291 [java] Reorganize rulesets into new categories
Best Practices, Code Style, Design, Documentation, Error Prone,
Multithreading, Performance, Security
2017-10-29 21:11:59 +01:00
Matias Comercio
2466ba7163 Add remove & removeChildAtIndex to Node interface
- Implement these methods at AbstractNode.
- Add AbstractNodeTest class with test cases for the implemented methods.
  - Add JUnitParams dependency: https://github.com/Pragmatists/JUnitParams
  - Implement these test cases using JUnitParams features
2017-10-29 13:18:06 -03:00
Matias Comercio
8e120da008 Fix missing validation on cast for AbstractJavaRule 2017-10-28 19:47:32 -03:00
Juan Martín Sotuyo Dodero
368ca2b3d6 Merge branch 'pr-694' 2017-10-28 18:14:38 -03:00
Juan Martín Sotuyo Dodero
6072b50f11 Update changelog, refs #694 2017-10-28 18:14:16 -03:00
Matias Comercio
d21be5ddc1 Add minor fixes to root pom 2017-10-28 17:44:18 -03:00
Andreas Dangel
989dd133fd Merge branch 'pr-692' 2017-10-28 20:18:56 +02:00
Andreas Dangel
2dec92c9d5 Merge branch 'pr-691' 2017-10-28 20:04:10 +02:00
Andreas Dangel
0cff7b841a [java] Mark ASTArrayDimsAndInits and ASTVariableDeclaratorId as Dimensionable 2017-10-28 20:01:07 +02:00
Andreas Dangel
6b1b135104 Merge branch 'pr-690' 2017-10-28 19:55:59 +02:00
Andreas Dangel
ca9b42b7e5 Merge branch 'pr-689' 2017-10-28 19:48:39 +02:00
gonzalo
91b8a22b42 Update GenericToken specialToken method to obtain only comment tokens 2017-10-28 14:42:44 -03:00
gonzalo
e8fdbdbca4 Update GenericToken interface to expose directly region methods 2017-10-28 14:42:44 -03:00
gonzalo
0e011767ce Change ant tasks over (VM) Token class 2017-10-28 14:42:44 -03:00
gonzalo
c606d409f4 Change ant tasks over (Python) Token class 2017-10-28 14:42:44 -03:00
gonzalo
1c0d762a37 Change ant tasks over (PL/SQL) Token class 2017-10-28 14:42:44 -03:00
gonzalo
da902d658f Change ant tasks over (Objective-C) Token class 2017-10-28 14:42:44 -03:00
gonzalo
026576e266 Change ant tasks over (Matlab) Token class 2017-10-28 14:42:44 -03:00
gonzalo
f29e3f0408 Change ant tasks over (CPP) Token class 2017-10-28 14:42:44 -03:00
gonzalo
647a17f060 Change ant tasks over (Ecmascript5) Token class 2017-10-28 14:42:44 -03:00
gonzalo
26461e59c1 Simplify method name in GenericToken && improve ant task replacetoken 2017-10-28 14:42:44 -03:00
gonzalo
95835b8134 Update getter in GenericToken 2017-10-28 14:42:44 -03:00
gonzalo
00ed0a1eab Add RegionByLineImpl javadoc 2017-10-28 14:42:44 -03:00
gonzalo
00ce16c177 [Not Working] Change ant tasks over (VisualForce) Token class 2017-10-28 14:42:44 -03:00
gonzalo
020abafeab Change ant tasks over (JSP) Token class 2017-10-28 14:42:44 -03:00
gonzalo
490b34fea3 Change ant tasks over (Java) Token class 2017-10-28 14:42:44 -03:00
gonzalo
2d01332635 Convert GenericToken from class to interface && Add RegionByLine 2017-10-28 14:42:44 -03:00
Andreas Dangel
591737b2d9 Merge branch 'pr-688' 2017-10-28 19:41:28 +02:00
Andreas Dangel
c728db039e Merge branch 'pr-683' 2017-10-28 19:31:49 +02:00
Andreas Dangel
6d846af07e Merge branch 'pr-680' 2017-10-28 19:27:39 +02:00
Andreas Dangel
20f16762f2 Update release notes, refs #680 2017-10-28 19:19:27 +02:00
Juan Martín Sotuyo Dodero
d1d9c6f3c6 [java] Fix NPE in type resolution
- The resolution of `GenericArrayType` was broken, so we caused NPEs.
 - Those types are now properly resolved, but the test case is still
incomplete due to missing pieces in type inference
2017-10-27 23:53:17 -03:00
Juan Martín Sotuyo Dodero
71d94b4ccd [java] Avoid runtime errors on incomplete classpath 2017-10-27 02:27:32 -03:00
Juan Martín Sotuyo Dodero
83d513edca Fix specificity test for varargs vs fixed
- We used to fail upon mixing varargs with fixed arity instead of
treating the vararg as a fixed arity as per the spec
2017-10-27 00:57:21 -03:00
Juan Martín Sotuyo Dodero
1d02c24b34 Consider only direct children 2017-10-27 00:08:26 -03:00
Juan Martín Sotuyo Dodero
b3dea3240c Generalize test 2017-10-26 22:38:40 -03:00
Juan Martín Sotuyo Dodero
b76945bbbb Be consistent on naming 2017-10-26 22:33:31 -03:00
Juan Martín Sotuyo Dodero
05927af574 [java] Properly resolve array types
- Honor dimensions of arrays
 - Resolve types for allocations as well as declarations of arrays
2017-10-26 22:31:29 -03:00
Juan Martín Sotuyo Dodero
d8f203a859 Chesktyle 2017-10-26 18:03:54 -03:00
Juan Martín Sotuyo Dodero
8fe2befbbc Add a proper test case 2017-10-26 13:11:39 -03:00
Juan Martín Sotuyo Dodero
ae2898e238 [java] Properly handle 0-arg calls
- We no longer take all methods as applicable for a 0-arg method call
during type resolution.
2017-10-26 12:23:44 -03:00
Juan Martín Sotuyo Dodero
71200e6a67 Default to reduce to false for the time being 2017-10-26 10:06:18 -03:00
Juan Martín Sotuyo Dodero
92cc66a8cd Checkstyle fixes 2017-10-26 01:13:04 -03:00
Juan Martín Sotuyo Dodero
9d59c0317c [java] Fix boxing rules
- Boolean types were not considered since we were using the
subtypability set which deals exclusively with numeric types
 - Fixes #650
2017-10-26 00:54:47 -03:00
Juan Martín Sotuyo Dodero
eb22ab194c Update changelog, refs #603 2017-10-25 18:06:34 -03:00
Juan Martín Sotuyo Dodero
1308b2c7fa [core] Changes to execution classpath invalidate cache
- Resolves #603
2017-10-25 18:03:13 -03:00
Juan Martín Sotuyo Dodero
ebeab0f445 [java] Simplify ForLoopShouldBeWhileLoop
- Remove checks that will always be true (a node can't be a Type and
a Statement and an Expression at the same time)
 - Simplify count(*) > 1 checks (expensive) for an Expression check (the one
node we actually care about)
2017-10-25 12:57:35 -03:00
Juan Martín Sotuyo Dodero
20093c809a Rework ruleset loading
- ResourceLoader is now instantiable, and we can tell which classloader
to use to get resources
 - We will always use the execution classloader, or just add the paths
added by ant, but *never* the auxclasspath
 - The classpath added by Ant won't get into the auxclasspath either
2017-10-24 18:07:09 -03:00
Juan Martín Sotuyo Dodero
042b1bda02 [java] Handle properly reduction incompatibilities
- When a reduce operation return null (it's incompatible), we should
handle it properly instead of producing a NPE.
2017-10-24 00:13:01 -03:00
Juan Martín Sotuyo Dodero
42d965844f Avoid duplicate code 2017-10-23 17:46:21 -03:00
Juan Martín Sotuyo Dodero
96bb1f4bc7 [core] Support parent-last classloading
- We will now always load classes from auxclasspath during
typeresolution, even if we have a class with the same name in PMD's
classpath
 - This prevents conflicts when using different versions of the same
dependencies
2017-10-23 14:23:05 -03:00
Juan Martín Sotuyo Dodero
2d15c6dba6 Merge branch 'pr-661' 2017-10-19 00:42:27 -03:00
Juan Martín Sotuyo Dodero
91bf92fe26 Update changelog, refs #661 2017-10-18 23:59:07 -03:00
Juan Martín Sotuyo Dodero
8ef0d6989c Move AvoidHardcodingIdRule to style ruleset 2017-10-18 23:58:44 -03:00
Juan Martín Sotuyo Dodero
e3f9c728d7 content update 2017-10-18 23:51:01 -03:00
Juan Martín Sotuyo Dodero
b9e76ab28f Merge branch 'pr-675' 2017-10-18 11:45:41 -03:00
Juan Martín Sotuyo Dodero
fded4f140f Update changelog, refs #675 2017-10-18 11:45:26 -03:00
gonzalo
c00400ef77 Fix try with final resource 2017-10-18 08:50:06 -03:00
Travis CI (pmd-bot)
53210842c8 Update documentation 2017-10-17 16:59:20 +00:00
Juan Martín Sotuyo Dodero
fc3da283bd Merge branch 'pr-666' 2017-10-17 13:43:52 -03:00
Juan Martín Sotuyo Dodero
92f1cdd923 Update changelog, refs #666 2017-10-17 13:42:28 -03:00
Juan Martín Sotuyo Dodero
30aa7fca11 Add DoNotExtendJavaLangThrowable to release ruleset 2017-10-17 13:35:45 -03:00
Juan Martín Sotuyo Dodero
2e3e884426 Merge branch 'pr-665' 2017-10-17 13:13:06 -03:00
Juan Martín Sotuyo Dodero
a8823b96cf Merge branch 'pr-670' 2017-10-17 12:54:51 -03:00
Andreas Dangel
2b60ecaead Update release notes, refs #605 2017-10-16 21:26:12 +02:00
Andreas Dangel
ffcf5cb704 [apex] Remove shading for the apex modules - not needed anymore
Fixes #605. The apex modules do not contain any non-apex code anymore
(not an uber-jar anymore).

Explicitely defining asm as runtime dependency.
2017-10-16 21:26:12 +02:00
Andreas Dangel
4eab602fd3 Merge branch 'pr-668' 2017-10-16 21:18:14 +02:00
Andreas Dangel
4f2c7960e6 Update changelog, refs #668 2017-10-16 21:18:06 +02:00
Clément Fournier
d7d502e0c4 Fix maven 2017-10-16 19:53:43 +02:00
Clément Fournier
a986e38b3d Merge branch 'master' of https://github.com/pmd/pmd into fx-designer 2017-10-16 13:54:30 +02:00
Clément Fournier
c50311bd85 Correct formatter 2017-10-16 00:08:56 +02:00
Clément Fournier
a47471f742 Replace IntegerProperty 2017-10-15 22:22:36 +02:00
Clément Fournier
d891fe048a Fix javadoc warnings on pmd-core 2017-10-15 22:07:34 +02:00
Clément Fournier
13f3651048 Cleanup 2017-10-15 21:56:09 +02:00
Clément Fournier
57631bfb30 Few PoCs 2017-10-15 19:59:58 +02:00
Clément Fournier
12855d3cf2 Fix tests 2017-10-15 18:02:24 +02:00
Clément Fournier
6295a96783 Refactored everything 2017-10-15 17:50:02 +02:00
Clément Fournier
2c16faff36 Refactor numeric properties 2017-10-15 16:45:26 +02:00
Clément Fournier
2d449dbef6 Full builder hierarchy 2017-10-15 16:30:14 +02:00
Clément Fournier
610cd21a9c Clarify design 2017-10-15 15:58:23 +02:00
Clément Fournier
2e272c3f7b More mature design w/ small PoC 2017-10-15 14:42:44 +02:00
Clément Fournier
aff5f20112 Draft of builders 2017-10-15 13:08:47 +02:00
Clément Fournier
4f6e55ce26 Mediator pattern 2017-10-14 20:02:00 +02:00
Robert Painsi
82b219428b [java] Add DoNotExtendJavaLangThrowable rule
Copy and pasted code from DoNotExtendJavaLangError rule.

Resolves #367
https://github.com/pmd/pmd/issues/367
2017-10-14 18:19:55 +02:00
Andreas Dangel
77968550ef [java] Fix unit tests 2017-10-13 14:09:47 +02:00
Andreas Dangel
944b2f448b [java] Move rule SignatureDeclareThrowsException from typeresolution to strictexception
Replace existing rule with the typeresolution-based implementation.
2017-10-13 14:04:27 +02:00
Andreas Dangel
8470d32322 [java] Move rule UnusedImports from typeresolution to imports
Replace existing rule with the typeresolution-based implementation.
2017-10-13 12:54:26 +02:00
Andreas Dangel
a89d449169 [java] Move rule CloneMethodMustImplementCloneable from typeresolution to clone
Replace existing rule with the typeresolution-based implementation.
2017-10-13 12:37:04 +02:00
Andreas Dangel
2ef082ae19 [java] Move rule LooseCoupling from typeresolution to coupling
Replace existing rule with the typeresolution-based implementation.
2017-10-13 12:36:36 +02:00
Andreas Dangel
598c7910a3 Merge branch 'pr-664' 2017-10-13 10:51:00 +02:00
Andreas Dangel
d2c52eb37b Merge branch 'pr-662' 2017-10-13 10:48:31 +02:00
Andreas Dangel
e737e38d73 [ci] check for var encrypted_5630fbebf057_iv in setup-secrets
This should now allow forked builds to finally run on travis...
2017-10-13 10:37:16 +02:00
Juan Martín Sotuyo Dodero
6f5f6d3d97 Update changelog, refs #328 2017-10-10 12:10:59 -03:00
Juan Martín Sotuyo Dodero
dbe0168865 [java] Avoid errors upon resolving invalid classes
- Resolves #328
 - Take the chance to simplify some error handling
(`NoClassDefFoundError` extends `LinkageError`)
2017-10-10 12:08:52 -03:00
Juan Martín Sotuyo Dodero
a81d142317 [core] Avoid a phony warning about not using cache
- Avoid creating a NoopAnalysisCache by default to prevent a phony
warning about not using the cache being printed.
 - This way, we only produce a new instance lazily if not configured,
preserving the same behaviour bu without the warning.
2017-10-10 00:46:07 -03:00
Jan Aertgeerts
475405e18f [apex] test issue - count 2017-10-09 23:43:43 +02:00
Jan Aertgeerts
9845f74f68 [apex] rework visit 2017-10-09 23:35:14 +02:00
Jan Aertgeerts
6989b45067 [apex] avoid hardcoding id's 2017-10-09 23:24:47 +02:00
Travis CI (pmd-bot)
da8ac69f4e Update documentation 2017-10-09 19:10:37 +00:00
Juan Martín Sotuyo Dodero
6000bcb2e2 Merge branch 'pr-660' 2017-10-09 15:51:11 -03:00
Juan Martín Sotuyo Dodero
047dfa54f0 Update changelog, refs #660 2017-10-09 15:48:40 -03:00
Juan Martín Sotuyo Dodero
4dcef95e43 Add new apex-performance/AvoidSoslInLoops rule to 600 ruleset 2017-10-09 15:44:20 -03:00
Jan Aertgeerts
96de1715cd [apex] avoid sosl in loops 2017-10-09 16:04:54 +02:00
Travis CI (pmd-bot)
591eedecea Update documentation 2017-10-08 23:28:51 +00:00
Juan Martín Sotuyo Dodero
60c87ff783 Merge branch 'pr-625' 2017-10-08 20:20:10 -03:00
Juan Martín Sotuyo Dodero
34a565ca00 Update changelog, refs #625 2017-10-08 20:00:36 -03:00
Juan Martín Sotuyo Dodero
3c067d8071 Add references to 6.0.0 release ruleset 2017-10-08 19:55:32 -03:00
Travis CI (pmd-bot)
ec63573517 Update documentation 2017-10-08 22:54:47 +00:00
Juan Martín Sotuyo Dodero
33804aa08f Merge branch 'pr-632' 2017-10-08 19:45:38 -03:00
Juan Martín Sotuyo Dodero
f3b3bdb693 Update changelog, refs #632 2017-10-08 19:44:56 -03:00
Juan Martín Sotuyo Dodero
9b28bdbe86 Add AvoidDirectAccessTriggerMap to 6.0.0 release rs 2017-10-08 19:37:16 -03:00
Andreas Dangel
5279901a03 [ci] fix script 2017-10-08 09:54:02 +02:00
Andreas Dangel
f13ba86f9c [ci] consider forked builds as pull requests
forked builds are travis builds on forked repos
2017-10-08 09:43:56 +02:00
Jan Aertgeerts
dedf954cb0 [apex] move to style ruleset and add literal expression in arrayload exception 2017-10-07 23:28:38 +02:00
Andreas Dangel
61376f8112 [core] add temporary support for maven debug output
refs #650
2017-10-07 21:28:56 +02:00
Juan Martín Sotuyo Dodero
005e0d0fdf Merge branch 'pr-653' 2017-10-06 19:09:21 -03:00
Juan Martín Sotuyo Dodero
312d896db8 update changelog, refs #653 2017-10-06 19:08:59 -03:00
Andreas Dangel
1c3049ee6c Fix checkstyle 2017-10-06 21:07:25 +02:00
Andreas Dangel
1af49cdca9 Fix checkstyle 2017-10-06 20:25:01 +02:00
Andreas Dangel
af4ddfbbcf [java] Fix rule StringToString after arrays are arrays 2017-10-06 20:17:09 +02:00
Andreas Dangel
e84866aa8d [java] typeresolution: don't throw if the type variables couldn't be resolved 2017-10-06 20:09:26 +02:00
Andreas Dangel
ece871c2f7 [java] typeresolution: when we couldn't resolve a method in
the first two phases, we assumed, that it would be varargs method.
This is not always the case.
2017-10-06 19:48:55 +02:00
Andreas Dangel
afae1385aa [java] typeresolution: support varags with generics 2017-10-06 18:05:30 +02:00
Andreas Dangel
acc05d4c9c [java] typeresolution: resolve arrays in some cases correctly 2017-10-06 18:05:27 +02:00
Andreas Dangel
04e65cd20c [java] typeresolution: avoid NPE if no type is known for a method argument 2017-10-06 18:05:27 +02:00
Andreas Dangel
231956c47e [java] typeresolution: simple inheritance/override check 2017-10-06 18:05:24 +02:00
Andreas Dangel
c0302cd314 [java] check for parsing/processing errors in unit test 2017-10-05 22:40:37 +02:00
Andreas Dangel
1582e40055 [java] typeresolution - add unit test for abstract return type case 2017-10-05 22:31:55 +02:00
Andreas Dangel
716e21221c [java] typeresolution: add test for generic wildcard method parameters 2017-10-05 22:28:00 +02:00
Juan Martín Sotuyo Dodero
d5a83ae807 Revert "Revert "Merge branch 'pr-287'""
This reverts commit 63ea1906af.
2017-10-05 17:03:57 -03:00
Andreas Dangel
efb78e9f79 [java] TypeResolution - support basic method overriding 2017-10-05 21:39:16 +02:00
Andreas Dangel
2e5dcf9a95 [java] Fix NPE in NcssCount rule
Parent could also be a enum or an annotation and not just a class/interface.
2017-10-05 21:04:25 +02:00
Andreas Dangel
dd596f0aef [java] Typeresolution: Return empty set instead of null for erased cadidate set 2017-10-05 20:56:46 +02:00
Andreas Dangel
b517838fbb [java] Fix ClassTypeResolver when using annotated types 2017-10-04 21:09:49 +02:00
Andreas Dangel
1ecf87c2b5 [java] Fix RedundantFieldInitializerRule not able to parse java7 literals with underscore 2017-10-04 20:54:42 +02:00
Clément Fournier
0cb4d99645 Make it work 2017-10-02 23:05:04 +02:00
Clément Fournier
15b638082b Split fxml and controllers 2017-10-02 02:24:39 +02:00
Clément Fournier
619f19cd83 Extracted XPath and node info 2017-10-01 22:06:19 +02:00
Clément Fournier
e96604dec2 Merge branch 'master' of https://github.com/pmd/pmd into fx-designer 2017-10-01 17:49:28 +02:00
Clément Fournier
9d1c491c8d Use random group names in highlighters 2017-10-01 15:37:26 +02:00
Clément Fournier
b8ac709161 Change syntax highlighting algorithm
Boost in time and space performance
2017-10-01 15:00:34 +02:00
Andreas Dangel
6fc758c21a [ci] enable all java9 modules for sonar and coveralls 2017-10-01 14:08:07 +02:00
Andreas Dangel
e991f2c4f3 [ci] run sonar and coveralls without travis wait 2017-10-01 13:40:49 +02:00
Andreas Dangel
a1a4b0b9eb Defining jacoco version, so that sonar might work again 2017-10-01 13:18:35 +02:00
Juan Martín Sotuyo Dodero
d192c5668b Merge branch 'pr-646' 2017-09-30 19:16:57 -03:00
Juan Martín Sotuyo Dodero
e055416aaa Merge branch 'pr-645' 2017-09-30 18:54:03 -03:00
Juan Martín Sotuyo Dodero
f7c0437470 Merge branch 'pr-644' 2017-09-30 18:40:48 -03:00
Juan Martín Sotuyo Dodero
077792cf26 Update changelog, refs #644 2017-09-30 18:40:00 -03:00
Juan Martín Sotuyo Dodero
5d51df880a Add JUnit test to validate output 2017-09-30 18:37:04 -03:00
Juan Martín Sotuyo Dodero
8086746d96 Merge branch 'pr-606' 2017-09-30 17:38:55 -03:00
Clément Fournier
c0c5e73a0b Improve syntax highlighting performance 2017-09-30 17:37:50 +02:00
Clément Fournier
ab8feda251 Styling 2017-09-30 15:24:31 +02:00
Andreas Dangel
24097aa3fa Fix whitespace 2017-09-30 11:32:01 +02:00
Andreas Dangel
d7c1dac59a Merge branch 'pr-619' 2017-09-30 11:31:27 +02:00
Andreas Dangel
54b68c9238 Update changelog, refs #618 2017-09-30 11:30:39 +02:00
Andreas Dangel
72db0dfc07 Merge branch 'pr-616' 2017-09-30 10:39:04 +02:00
Andreas Dangel
15a1097aa2 Update release notes, mention PMD.setupReport is gone. 2017-09-30 10:38:20 +02:00
Andreas Dangel
ef42ac0d88 Update release notes, refs #604 2017-09-29 19:52:16 +02:00
Andreas Dangel
e60d1c2a24 Merge branch 'pr-615' 2017-09-29 19:42:11 +02:00
Andreas Dangel
66b67a8a95 Merge branch 'pr-614' 2017-09-29 14:16:29 +02:00
Andreas Dangel
f59ec03db1 Merge branch 'pr-612' 2017-09-29 11:42:08 +02:00
Andreas Dangel
883465772c [doc] Updated getting help 2017-09-29 11:38:11 +02:00
Andreas Dangel
3f2610ea21 Merge branch 'pr-602' 2017-09-29 11:21:26 +02:00
Andreas Dangel
eb6624deb6 Update doc about "How PMD Works" 2017-09-29 11:20:42 +02:00
Andreas Dangel
f7d67df442 Remove ruleset schema 3.0.0 2017-09-29 11:20:37 +02:00
Andreas Dangel
b42ba5ea45 Update release notes, refs #602 2017-09-29 10:41:09 +02:00
Clément Fournier
e21cf002f6 Documentation 2017-09-28 21:21:01 +02:00
Clément Fournier
1de1633587 Improve syntax highlighting internals 2017-09-28 21:20:41 +02:00
Clément Fournier
3f503e9f7d Draft of exception logging 2017-09-28 00:25:56 +02:00
Andreas Dangel
712a29d3ea Update release notes, mentioning java9 is the new default 2017-09-27 21:26:21 +02:00
Andreas Dangel
5bfff7615f Add missing entity resolver in unit test 2017-09-27 21:20:45 +02:00
Andreas Dangel
8113696941 Update ASM library to support java9 2017-09-27 21:11:37 +02:00
Clément Fournier
9e906da5db Fix xml syntax highlighter overflow 2017-09-27 12:44:24 +02:00
Clément Fournier
f0f289df0c Major UI redesign, looking good 2017-09-27 01:35:59 +02:00
Clément Fournier
4173e7c495 Fix synchronization problem 2017-09-25 23:09:46 +02:00
Clément Fournier
cd16b18ed6 Revamp syntax highlighting + support XML 2017-09-25 22:41:13 +02:00
Clément Fournier
0e2803c1f8 Nice tab model 2017-09-25 15:16:02 +02:00
Clément Fournier
8a05e36196 Focus from violation results to ast -> inefficient for large files 2017-09-24 18:25:08 +02:00
Clément Fournier
27addb5014 Made UI for event logging 2017-09-24 17:40:26 +02:00
Clément Fournier
f686c4858c Fix open recent menu 2017-09-24 16:08:59 +02:00
Clément Fournier
0f6ad23a78 Change xpath selection to choicebox 2017-09-24 15:06:49 +02:00
Clément Fournier
7e475632b4 Make css great again 2017-09-24 14:37:39 +02:00
Clément Fournier
49dd443a48 Reorganise style context 2017-09-24 13:39:17 +02:00
Clément Fournier
fa19af9a57 Refactor CSS pt 1 2017-09-24 13:29:43 +02:00
Andreas Dangel
2f67eaf7e6 [ci] Update travis scripts to use java 9 2017-09-24 10:39:54 +02:00
Andreas Dangel
166f958ce2 [doc] Update docs, remove toolchain requirements, require java 9 2017-09-24 10:39:49 +02:00
Andreas Dangel
577ef1ff71 Declaring used dependencies explicitly
as determined by dependency:analyze
2017-09-24 10:39:49 +02:00
Andreas Dangel
a175b90665 Update plugins 2017-09-24 10:39:44 +02:00
Andreas Dangel
b72f1bd18c Adjust javadoc settings: disable doclint, add weird dependency 2017-09-24 10:39:39 +02:00
Clément Fournier
1451ff80a2 Improve Java syntax highlighting 2017-09-24 03:16:44 +02:00
Clément Fournier
f784d85b92 Add XPath syntax highlighter 2017-09-24 02:42:20 +02:00
Clément Fournier
5cb7aa0620 Move language selection into choicebox 2017-09-24 00:52:16 +02:00
Clément Fournier
facc7c141c Simplify syntax highlighting internals 2017-09-23 23:49:56 +02:00
Clément Fournier
b8a99a2174 Add logo proposition 2017-09-23 22:43:39 +02:00
Clément Fournier
1878916abe Apex syntax highlighter 2017-09-23 22:43:07 +02:00
Clément Fournier
a8f8d60870 Add manifest stuff to package jar 2017-09-23 22:40:34 +02:00
Clément Fournier
f5e72214ba Add opt out for syntax highlighting 2017-09-23 20:25:16 +02:00
Andreas Dangel
8bd413591f Add enforcer plugin to make sure, we are using java9 2017-09-23 19:24:37 +02:00
Andreas Dangel
ade0d7d029 Update compiler plugin, use "release" option, adjust java.version properties
No need for the toolchain plugin anymore
2017-09-23 19:24:17 +02:00
Andreas Dangel
8fc518c814 Using java9 as default version 2017-09-23 18:48:37 +02:00
Clément Fournier
d93fa7535e Syntax highlighting for Java 2017-09-23 18:48:02 +02:00
Clément Fournier
a66c5a448f Style layer management 2017-09-23 16:03:34 +02:00
Clément Fournier
ca2e28742d Custom code area control 2017-09-23 02:15:01 +02:00
Andreas Dangel
51181f123f Update release notes, refs #584 2017-09-23 00:31:02 +02:00
Andreas Dangel
6590a358e6 Support concise try-with-resources with java9 2017-09-23 00:15:08 +02:00
Andreas Dangel
280a656f87 Checkstyle 2017-09-22 23:51:56 +02:00
Andreas Dangel
f30eb4b5ff Use semantic lookahead for the module productions
The new keyword are only "restricted keywords" and can still be used
as identifiers.
2017-09-22 23:43:43 +02:00
Andreas Dangel
07eede38db Fix unit test after changing return type to String (for XPath attributes) 2017-09-22 23:39:38 +02:00
Filipe Esperandio
a4c1150891 Fix wrong internal property name 2017-09-22 17:18:48 -03:00
Filipe Esperandio
4d01d2c6d5 Remove import 2017-09-22 17:13:01 -03:00
Filipe Esperandio
c6aaf3fbc4 Prevent internal dev-properties from being displayed on CodeClimate's documentation markdown 2017-09-22 17:10:10 -03:00
Andreas Dangel
1020bf73db Enhance grammar to parse Java 9 module-info.java 2017-09-22 21:35:24 +02:00
Andreas Dangel
cb772167bb Simplify Java Language Module 2017-09-22 15:37:23 +02:00
Andreas Dangel
fa44c405bd Interface methods can be private now 2017-09-22 15:32:24 +02:00
Andreas Dangel
672f9216dd Simplify grammar: TypeArguments is not used here, it's resolved
as a child by ClassOrInterfaceType already
2017-09-22 15:32:24 +02:00
Andreas Dangel
77222904de Check for diamond operator for anonymous classes 2017-09-22 15:32:19 +02:00
Andreas Dangel
722b2b1657 Allow nested private methods 2017-09-22 13:33:08 +02:00
Andreas Dangel
cfa4b5b85c Add Java9 Language Module, Update grammar
* Java8 mode now rejects private methods in interfaces
* Java9 mode now rejects "_" as identifier
2017-09-22 12:19:38 +02:00
Clément Fournier
d12e70aab5 Truly disable multifile 2017-09-22 01:04:48 +02:00
Jan Aertgeerts
2639b4fe66 [apex] Add AvoidDirectAccessTriggerMap rule to the performance set 2017-09-20 12:42:22 +02:00
Jan Aertgeerts
8bc6810196 [apex] add empty statement block rule 2017-09-19 10:21:55 +02:00
Jan Aertgeerts
a890dbf68c [apex] use correct AST 2017-09-18 20:12:57 +02:00
Jan Aertgeerts
5d7237cd2d [apex] style, indent 2017-09-18 00:35:00 +02:00
Jan Aertgeerts
882139e189 [apex] fix tests and add to ruleset for tests 2017-09-17 23:35:42 +02:00
Clément Fournier
60d40aee6b Checkstyle 2017-09-17 23:17:32 +02:00
Clément Fournier
4f25c1feb3 Add test case for operations 2017-09-17 22:54:40 +02:00
Clément Fournier
8af7d28197 Corrections for PR #602 2017-09-17 22:38:54 +02:00
Jan Aertgeerts
62c1a6fc68 [apex] single quote ruining tests xml 2017-09-17 21:50:39 +02:00
Jan Aertgeerts
1ddd5d2ac6 [apex] fix catch xpath and add meaningful names for test cases 2017-09-17 21:37:54 +02:00
Jan Aertgeerts
8a95fcd257 [apex] fix xpath, test recheck 2017-09-17 19:54:01 +02:00
Jan Aertgeerts
bec10ce1d2 [apex] add tests for empty checks 2017-09-17 19:42:24 +02:00
Jan Aertgeerts
00b06ef810 [apex] version since in empty rules, correct xpath expression 2017-09-17 18:46:05 +02:00
Jan Aertgeerts
cacb82ace5 [apex] Add test for empty xpath checks. 2017-09-17 18:45:37 +02:00
Clément Fournier
4545c8bf18 Ignore typeres failures 2017-09-17 16:35:24 +02:00
Jan Aertgeerts
c3da9ec086 empty code ruleset for apex 2017-09-17 16:19:51 +02:00
Clément Fournier
48b89ac8d2 Remember recent files 2017-09-17 15:18:29 +02:00
Clément Fournier
6e645502ec Fix divider positions on maximize 2017-09-17 14:03:39 +02:00
Clément Fournier
62a1fbd189 Save full screen setting 2017-09-17 02:28:48 +02:00
Clément Fournier
88f4e2722e Scope hierarchy 2017-09-16 20:26:58 +02:00
Clément Fournier
fee9c5cdef Add license and load source from file 2017-09-16 18:24:21 +02:00
Travis CI (pmd-bot)
df87db8d7a Update documentation 2017-09-16 14:34:19 +00:00
Andreas Dangel
9e55969eb1 Merge branch 'pr-601' 2017-09-16 16:18:17 +02:00
Andreas Dangel
16eb55d0c8 Merge branch 'pr-596' 2017-09-16 16:09:45 +02:00
Andreas Dangel
4272674488 Merge branch 'pr-593' 2017-09-15 11:07:56 +02:00
Andreas Dangel
7ec56e37b0 Merge branch 'pr-592' 2017-09-15 10:59:14 +02:00
Juan Martín Sotuyo Dodero
8d808049f3 Merge branch 'pr-620' 2017-09-14 11:49:25 -03:00
Juan Martín Sotuyo Dodero
5bbca3e59d Update changelog, refs #620 2017-09-14 11:49:08 -03:00
Juan Martín Sotuyo Dodero
02fc43737a Remove commented default access modifier 2017-09-14 11:47:52 -03:00
Clément Fournier
51fc08a8f6 Fix compil error 2017-09-14 15:31:31 +02:00
Clément Fournier
0349ad74c1 Forgot stuff in n.s.pmd 2017-09-14 15:28:40 +02:00
Clément Fournier
45cb608c17 Merge branch 'multifile-split' of https://github.com/oowekyala/pmd into multifile-split 2017-09-14 14:37:18 +02:00
Clément Fournier
f02026995d Merge upstream 2017-09-14 14:37:00 +02:00
Clément Fournier
4743b92a09 Merge branch 'master' into multifile-split 2017-09-14 00:30:04 +02:00
Clément Fournier
6a162c238c Moved properties to n.s.pmd.properties 2017-09-14 00:05:55 +02:00
Juan Martín Sotuyo Dodero
14cb503713 [core] Revamp charset / stream management
- File encoding is converted to Charset only once. Errors in it's setup
wil fail the run immeditable instead of producing one error per file.
 - We make sure to close the source stream from the same place we create
it, by using try-with-resources
 - When wrapping the stream to a reader, we use try-with-resources
again, just in case
 - The bechmark code now takes into account charset setup, and more
closely resembles the normal execution path
 - This fixes #618
2017-09-13 18:22:38 -03:00
Juan Martín Sotuyo Dodero
09d49c6e68 Merge branch 'pr-587' 2017-09-12 18:01:10 -03:00
Juan Martín Sotuyo Dodero
8273c9e188 Update changelog, refs #587 2017-09-12 18:00:25 -03:00
Juan Martín Sotuyo Dodero
835792d0fb Merge branch 'pr-607' 2017-09-12 17:50:37 -03:00
Juan Martín Sotuyo Dodero
be27dea8de Checkstyle fixes 2017-09-12 17:23:12 -03:00
Juan Martín Sotuyo Dodero
e734c9cce9 Add failing test scenario for repeated config error 2017-09-12 17:11:38 -03:00
Juan Martín Sotuyo Dodero
62fd6b3be4 [core] dysfunctional rules are removed only once
Under multi-thread runs, each thread parsed it's own copy of the
ruleset, and removed dysfunctional rules. This meant 1 `ConfigError` per
thread was being generated.
  Since #519, we now log `ConfigErrors`, meaning multiple identical
logs in reports and noise for the user.
  Therefore, we change our approach. RuleSets are parsed only once.
Dysfunctional rules are filtered and reported early on, before
dispathing actual file analysis. Each analysis thread can then produce
their own copy of the ruleset by taking advantage of the `deepCopy`
support for rules, ruleset and rulesets introduced in #464.
  The result is not only more concise reports, but the analysis thread
actually perform less work. Rulesets XMLs are parsed exactly once,
instead of 1 + 1 per thread as before, and rule configuration is
validated only once.

  During this process an issue with how property descriptors where
copied has arised and was fixed. A new unit test to validate this
scenario has been introduced.
2017-09-12 17:11:25 -03:00
Andreas Dangel
ee727c4504 Fix remaining tests after merge 2017-09-11 22:08:32 +02:00
Andreas Dangel
54423d05a6 Merge branch 'master' into junit-rule-pmd-test-runner 2017-09-11 22:04:55 +02:00
Andreas Dangel
29523c7ec5 [doc] Fix doc about testing framework 2017-09-11 21:58:00 +02:00
Andreas Dangel
59b12b7bcd Apply schema for apex rules tests 2017-09-11 21:56:06 +02:00
Andreas Dangel
d10d4abe52 Apply schema for xml rules tests 2017-09-11 21:56:06 +02:00
Andreas Dangel
dd0b776d1d Apply schema for velocity rules tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
5266436b69 Apply schema for plsql rules tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
284938b97b Apply schema for visualforce tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
c903294c61 Apply schema for jsp rules tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
555448aba8 Apply schema for javascript rules tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
4f5cae32d9 Apply schema for java rules tests 2017-09-11 21:55:50 +02:00
Andreas Dangel
ef3d3a87c6 Fix schema and exception reporting
* relax order of test-code and code-fragment
* allow sourceType with language version
* define complexTypes
* relax requirements
2017-09-11 21:55:25 +02:00
Andreas Dangel
72b5ca8b4f Fix schema and parser after rename 2017-09-11 21:55:25 +02:00
Andreas Dangel
21388c3638 [doc] Mention schema in documentation 2017-09-11 21:55:25 +02:00
Andreas Dangel
116f218907 Add schema validation to rule tests 2017-09-11 21:55:18 +02:00
Clément Fournier
732af08f16 Corrections for PR #587 2017-09-10 21:30:45 +02:00
Juan Martín Sotuyo Dodero
599f588e16 Typo 2017-09-10 06:09:57 -03:00
Juan Martín Sotuyo Dodero
4ef8495dcb Update changelog, refs #615 2017-09-10 05:51:16 -03:00
Juan Martín Sotuyo Dodero
1f4144e975 Update changelog, refs #614 2017-09-10 05:43:08 -03:00
Juan Martín Sotuyo Dodero
ad1013c2ba Fix typo 2017-09-10 05:36:58 -03:00
Juan Martín Sotuyo Dodero
49d314fc5b [core] Incremental Analysis can detect changes to jars
- We now look inside the jars of the classpath in search for any
changes. If we find any, we invalidate the cache.
 - Resolves #604
2017-09-10 05:35:09 -03:00
Juan Martín Sotuyo Dodero
9418ab1822 [core] Improve incremental analysis logging
- Resolves #608
 - Log succesful cache loading
 - Log hits / misses on debug, reason for miss too
 - Invite users to enable incremental analysis
 - Provide a new section on the web for the feature. May be promoted to
a top level page at some point.
2017-09-09 21:57:28 -03:00
Juan Martín Sotuyo Dodero
116c428708 [core] Restrict root element of ruleset xml
- Unfortunately DTD doesn't allow to do this... we should probably
cease to support DTD altogether...
2017-09-09 19:45:12 -03:00
Juan Martín Sotuyo Dodero
2bb4d3fbfe Restrict root element to pmd 2017-09-09 19:27:23 -03:00
Travis CI (pmd-bot)
6d4e902a2a Update documentation 2017-09-09 22:20:05 +00:00
Juan Martín Sotuyo Dodero
1e67bbc9c1 Merge branch 'pr-568' 2017-09-09 19:11:58 -03:00
Juan Martín Sotuyo Dodero
1600891562 Merge branch 'pr-598' 2017-09-09 18:56:30 -03:00
Juan Martín Sotuyo Dodero
2fdb8de3f2 Update changelog, refs #598 2017-09-09 18:55:29 -03:00
Clément Fournier
e993a7bf21 Test xml keys are unique 2017-09-09 18:00:38 +02:00
Andreas Dangel
4f371618d9 Add initial xml schema for rule tests 2017-09-09 11:11:35 +02:00
Travis CI (pmd-bot)
3d18e8b36f Update documentation 2017-09-09 08:12:38 +00:00
Andreas Dangel
aba96473f3 Merge branch 'pr-566' 2017-09-09 09:58:16 +02:00
Andreas Dangel
388afb9618 Fix typo 2017-09-09 09:58:05 +02:00
Andreas Dangel
a50d5a82cc Add new rule to internal ruleset 600.xml 2017-09-09 09:56:27 +02:00
Andreas Dangel
4672249157 Update release notes, refs #566 2017-09-09 09:54:53 +02:00
Andreas Dangel
41b4eed58f Merge remote-tracking branch 'origin/master' into pr-566 2017-09-09 09:53:17 +02:00
Andreas Dangel
b99d8ec519 [doc] Add the minimal version of "Getting help" 2017-09-08 16:35:56 +02:00
Andreas Dangel
b5eb2ef467 Fix checkstyle 2017-09-08 16:35:48 +02:00
Andreas Dangel
cb9f0d0c69 [doc] Add test framework documentation 2017-09-08 16:35:48 +02:00
Andreas Dangel
9498473c20 PMDTestRunner should not fail, if there are no unit tests 2017-09-08 16:35:48 +02:00
Andreas Dangel
276028d04e Simplify PMDTestRunner 2017-09-08 16:35:48 +02:00
Andreas Dangel
154616e9f5 Create a new JUnit test runner to execute rule tests
This runner now also supports Before, After, and (JUnit) Rules.
2017-09-08 16:35:48 +02:00
Andreas Dangel
d8351ee6d6 Merge branch 'pr-588' 2017-09-08 16:28:13 +02:00
Andreas Dangel
2fe26b7e53 Update release notes, refs #588 2017-09-08 16:27:53 +02:00
Clément Fournier
dfb6bd4d50 Fix unneeded recompilation causing loss of node focus 2017-09-08 00:41:43 +02:00
Clément Fournier
61c98d25cb Display metrics in node info section 2017-09-08 00:18:35 +02:00
Clément Fournier
68cb110491 Preserve old cache file 2017-09-07 23:50:30 +02:00
Clément Fournier
8944071975 Cache compilation unit 2017-09-07 23:50:16 +02:00
Clément Fournier
b7aefda068 Checkstyle 2017-09-07 18:46:00 +02:00
oowekyala
443f73b744 Fix #388 2017-09-07 17:21:11 +02:00
Juan Martín Sotuyo Dodero
194106fb73 Update changelog, refs #601 2017-09-07 12:12:26 -03:00
Clément Fournier
cb76a82e77 Documentation 2017-09-07 17:11:25 +02:00
Juan Martín Sotuyo Dodero
96d2983f4f [core] Fix NPE on cache
- Resolves #600
2017-09-07 12:05:58 -03:00
Clément Fournier
9bf8a50a30 Fix ncss tests 2017-09-07 00:16:36 +02:00
Clément Fournier
4f393648cb Separation in apex module 2017-09-07 00:00:11 +02:00
Clément Fournier
e2d8076f9e Deleted the façade 2017-09-06 23:33:24 +02:00
Clément Fournier
7464705cf7 Merge branch 'master' of https://github.com/pmd/pmd into multifile-split 2017-09-06 23:25:51 +02:00
Clément Fournier
be936fb0cd Save left toolbar divider position 2017-09-06 23:18:54 +02:00
Clément Fournier
1cbc4b06f4 Remove the refresh XPath toggle 2017-09-06 21:17:37 +02:00
Clément Fournier
500fa16abf Improve encapsulation 2017-09-06 21:01:32 +02:00
Clément Fournier
9beee76492 Fix xpath eval 2017-09-06 19:38:58 +02:00
Clément Fournier
8127404f2c Documentation for metric XPath function 2017-09-06 11:24:20 +02:00
Clément Fournier
d1a311fe7b Merge branch 'master' of https://github.com/pmd/pmd into xpath-metrics 2017-09-06 10:55:18 +02:00
Clément Fournier
1e9724a8b8 Small improvements 2017-09-06 00:15:24 +02:00
Clément Fournier
d925c91bb6 Implemented settings save/restore cycle 2017-09-06 00:05:06 +02:00
Clément Fournier
660ce96558 Refactor into MVP 2017-09-06 00:05:06 +02:00
Clément Fournier
681552af86 Language version selection 2017-09-06 00:05:06 +02:00
Clément Fournier
2828f5c9bc UI redesign 2017-09-06 00:04:54 +02:00
Travis CI (pmd-bot)
6d8c41113f Update documentation 2017-09-05 16:54:59 +00:00
Andreas Dangel
fdfd0f79e6 Merge remote-tracking branch 'origin/master' 2017-09-05 18:38:23 +02:00
Travis CI (pmd-bot)
5e5ddc36b6 Update documentation 2017-09-05 16:29:26 +00:00
Andreas Dangel
a887393d29 Merge branch 'pr-591' 2017-09-05 18:28:17 +02:00
Andreas Dangel
fa86d073af Merge branch 'pr-585' 2017-09-05 18:03:47 +02:00
Andreas Dangel
a41df604e5 Update release notes, refs #585 2017-09-05 18:03:15 +02:00
Andreas Dangel
2e9c21f9a6 Merge branch 'master' into docs-updates 2017-09-05 17:46:42 +02:00
Andreas Dangel
57cfbb08cc [doc] fix typos 2017-09-05 17:44:22 +02:00
Andreas Dangel
7120369c12 [doc] document for each rule a sample how to reference it 2017-09-05 17:37:31 +02:00
Andreas Dangel
b37210d8da [doc] Add "Understanding Rulesets" 2017-09-05 17:28:42 +02:00
Andreas Dangel
f4fa09bfdc [doc] XPath rule: Add missing ruleset example 2017-09-05 17:18:38 +02:00
Andreas Dangel
b7f3032070 [doc] Update gems 2017-09-05 17:05:03 +02:00
Juan Martín Sotuyo Dodero
c6acda64f2 Update changelog, refs #565 2017-09-04 11:47:48 -03:00
Juan Martín Sotuyo Dodero
02c016d95f [java] java-basic/DontCallThreadRun false negative
- Use type resolution to determine when we are using a `Thread`
 - Fixes #565
2017-09-04 11:35:36 -03:00
Juan Martín Sotuyo Dodero
402b14f859 Update changelog, refs #593 2017-09-04 02:06:47 -03:00
Juan Martín Sotuyo Dodero
079fc1cc68 [core] Provide and XML Schema for XML reports
- Fixes #538
2017-09-04 02:01:50 -03:00
Juan Martín Sotuyo Dodero
3023a8274d Update changelog, refs #592 2017-09-03 21:23:09 -03:00
Juan Martín Sotuyo Dodero
e295711343 Harden XML parsing
- Fixes #532
2017-09-03 21:12:15 -03:00
Juan Martín Sotuyo Dodero
1ede9323a2 Update changelog, refs #591 2017-09-03 20:15:47 -03:00
Juan Martín Sotuyo Dodero
0b90595de3 Update changelog, refs #533 2017-09-03 20:06:07 -03:00
Juan Martín Sotuyo Dodero
cdc5cde3a0 Merge branch 'pr-533' 2017-09-03 19:56:14 -03:00
Juan Martín Sotuyo Dodero
e18fb2398b Include stacktrace for ProcessingError on reports 2017-09-03 19:55:02 -03:00
Juan Martín Sotuyo Dodero
de506f35ae Improve java-design/MissingStaticMethodInNonInstantiatableClass
- Remove false positives
 - Simplify xpath expression
 - Don't use count for checking for `= 0` or `> 0`
 - Fixes #590
2017-09-03 18:52:19 -03:00
Juan Martín Sotuyo Dodero
69b44c4cb4 Fix compilation warning 2017-09-03 18:47:04 -03:00
Clément Fournier
f8a717b6af Attributes popup, still buggy 2017-09-01 09:16:32 +02:00
Clément Fournier
76ab8d5cf2 XPath version and errors 2017-08-31 21:19:54 +02:00
Clément Fournier
c25b503026 Fix highlighting 2017-08-31 18:44:07 +02:00
Clément Fournier
6ed3bcd463 Highlighting of selected node 2017-08-31 16:46:41 +02:00
Clément Fournier
22ee16b09b Icons 2017-08-31 14:29:43 +02:00
Clément Fournier
097ae9cb1f XPath evaluation, custom CodeArea dependency 2017-08-31 00:21:03 +02:00
Clément Fournier
12bb17bf8f XPath attributes in listview 2017-08-30 23:16:24 +02:00
Clément Fournier
85cb3fc215 Add xpath pane 2017-08-30 21:07:32 +02:00
Clément Fournier
fbccc8a523 TreeCellFactory to format ast tree cells 2017-08-30 20:20:01 +02:00
Clément Fournier
f240760c4a TreeView for the AST working 2017-08-30 15:17:12 +02:00
Clément Fournier
36bc618789 Refresh AST button 2017-08-30 15:15:12 +02:00
Clément Fournier
6c63f39a29 Styling for code area 2017-08-30 15:15:12 +02:00
Clément Fournier
820b561cc4 Rename package 2017-08-30 15:15:12 +02:00
Clément Fournier
808ef0cc89 Added text area handle 2017-08-30 15:15:12 +02:00
Clément Fournier
e7c1a520d6 Moved to pmd-ui 2017-08-30 15:15:12 +02:00
oowekyala
14d0d14a18 Draft w/ mvn system dependency 2017-08-30 15:15:12 +02:00
Clément Fournier
e751992761 XPath function for metrics 2017-08-29 23:04:20 +02:00
Andreas Dangel
d301e99737 Merge branch 'pr-583' 2017-08-29 19:55:11 +02:00
Andreas Dangel
ef90939d8c Update release notes, refs #583 2017-08-29 19:54:34 +02:00
Clément Fournier
5b519459b9 Move static constants of ValueParser to class ValueParsers 2017-08-29 19:53:44 +02:00
Clément Fournier
d3300079b9 Add reference to GodClassRule, complete code sample 2017-08-29 13:27:21 +02:00
Clément Fournier
cc362d764f Moved NcssCountRule to codesize.xml 2017-08-28 22:01:11 +02:00
Juan Martín Sotuyo Dodero
2c5190aa91 Merge branch 'pr-582' 2017-08-28 16:42:11 -03:00
Juan Martín Sotuyo Dodero
ef91d41680 Merge branch 'pr-579' 2017-08-28 16:18:42 -03:00
Juan Martín Sotuyo Dodero
6d30cf7789 Update changelog, refs #579 2017-08-28 16:14:24 -03:00
Andreas Dangel
6fccc0c2eb Merge branch 'pr-518' 2017-08-28 20:31:08 +02:00
Andreas Dangel
cb2e7a3a13 Update release notes, refs #518 2017-08-28 20:30:12 +02:00
Bendegúz Nagy
599f91a796 Java, typeres: rename JavaTypeDefinitionSpecial to JavaTypeDefinitionUpper 2017-08-28 19:27:17 +02:00
Bendegúz Nagy
e1892944ff Java, typeres: make java type definition lower bound into a subclass 2017-08-28 13:59:30 +02:00
Clément Fournier
87e1e1834d Pimp up the docs 2017-08-28 01:07:52 +02:00
Clément Fournier
ac7e1e970f WeakHashMap for project memoizers 2017-08-27 23:42:13 +02:00
Clément Fournier
dcf5403003 Cache signatures in nodes 2017-08-27 23:32:17 +02:00
Clément Fournier
8b0eaa6c3d Remove fluent API for sigmasks 2017-08-27 23:32:17 +02:00
Clément Fournier
584041e1e7 Removed the metrics visitor 2017-08-27 23:32:17 +02:00
Clément Fournier
eed9859053 Hide multifile from rules 2017-08-27 23:32:17 +02:00
oowekyala
76b9b39368 Separated multifile analysis from metrics 2017-08-27 23:32:09 +02:00
Clément Fournier
c1459ab4f9 Added version info to the API 2017-08-26 21:58:52 +02:00
Clément Fournier
99a42461a7 Writing custom metrics 2017-08-26 21:58:46 +02:00
Andreas Dangel
23a936e654 Merge branch 'pr-580' 2017-08-26 11:06:33 +02:00
Andreas Dangel
fcdc2bde4d Update relase notes, refs #580 2017-08-26 11:05:41 +02:00
Andreas Dangel
d31d0dd7cd Merge branch 'pr-578' 2017-08-26 10:57:34 +02:00
Andreas Dangel
f6be3b8620 Update release notes, refs #578 2017-08-26 10:56:20 +02:00
Travis CI (pmd-bot)
0055eb15f3 Update documentation 2017-08-25 18:18:18 +00:00
Juan Martín Sotuyo Dodero
1e4c963003 Merge branch 'pr-581' 2017-08-25 15:01:54 -03:00
Juan Martín Sotuyo Dodero
c7314cc55e Update changelog, refs #581 2017-08-25 15:01:37 -03:00
Andreas Dangel
87d8a2fc45 [core] java9 build updates
* Updates the javadoc maven plugin, so that PMD can be built
  with a java9+mvn3.5.0 environment
* Makes sure, that the java8 modules are also enabled for java9
  and later
2017-08-25 11:47:20 +02:00
Niklas Baudy
f0d5f9392a Address comments. 2017-08-25 08:34:09 +02:00
Clément Fournier
5a2fc3e2c3 Checkstyle 2017-08-25 00:20:45 +02:00
Clément Fournier
f5530660af Corrections for PR #578 2017-08-24 23:57:16 +02:00
Niklas Baudy
cfa99e291e Relax AbstractClassWithoutAnyMethod when class is annotated by @AutoValue. 2017-08-24 23:27:04 +02:00
Andreas Dangel
d3757e7611 Merge branch 'pr-464' 2017-08-24 23:01:21 +02:00
Clément Fournier
9d5b2a5e7c Add AbstractMetric to topple the class hierarchy of metrics 2017-08-24 22:28:43 +02:00
Bendegúz Nagy
186d0edd91 Java, typeres: update generics parsing to produce upper and lower bounds 2017-08-24 22:10:17 +02:00
Andreas Dangel
ef90a6ed4c [doc] Finish pull request documentation
refs #359
2017-08-24 21:35:08 +02:00
Juan Martín Sotuyo Dodero
d544c7f122 Merge branch 'pr-570' 2017-08-24 11:15:57 -03:00
Juan Martín Sotuyo Dodero
7fb8989977 Update changelog, refs #570 2017-08-24 11:15:12 -03:00
Bendegúz Nagy
2126517563 Java, typeres: fix PR comments 2017-08-24 16:06:51 +02:00
Bendegúz Nagy
a61ca6b2b3 Java, typeres: fix PR comments 2017-08-24 12:16:55 +02:00
Clément Fournier
f631abc6d3 Fix tests 2017-08-24 09:53:30 +02:00
Clément Fournier
9f1e520ee9 Data class rule displays metric values 2017-08-24 09:24:07 +02:00
Clément Fournier
925be17be3 Merge upstream 2017-08-24 09:09:21 +02:00
Andreas Dangel
c675004a7d [doc] Fixes from PR #568 2017-08-23 21:08:58 +02:00
Andreas Dangel
1008f7ef70 Merge branch 'pr-573' 2017-08-23 20:40:08 +02:00
Andreas Dangel
0e906f386a Update release notes, refs #573 2017-08-23 20:39:05 +02:00
Juan Martín Sotuyo Dodero
1967b7de8d Add Visualforce to README 2017-08-23 14:55:09 -03:00
Andreas Dangel
b1b2683e92 [core] Use new schema version 3.0.0 2017-08-22 20:59:42 -03:00
Travis CI (pmd-bot)
9a4e1fb577 Update documentation 2017-08-22 21:48:40 +00:00
Juan Martín Sotuyo Dodero
9f64519b0a Merge branch 'pr-576' 2017-08-22 18:30:50 -03:00
Juan Martín Sotuyo Dodero
8abfe5958e Update changelog, refs #576 2017-08-22 18:30:28 -03:00
Marcel Möhring
dbf3adb770 [doc][java] Add hint for Guava users in InefficientEmptyStringCheck
Fixes issue #571.
2017-08-22 22:51:43 +02:00
Clément Fournier
57439e9dc9 Remove findChildNodesWithXPathChecked from Node interface 2017-08-22 22:23:22 +02:00
Clément Fournier
e45061962e Corrections for PR #573 2017-08-22 22:23:11 +02:00
Andreas Dangel
4cf5be95cd [doc] Enhance pull request documentation, use existing page
refs #359
2017-08-22 20:45:47 +02:00
Clément Fournier
d85f4ce341 Documentation 2017-08-22 17:14:29 +02:00
Clément Fournier
5001701989 Use ATFD metric in GodClassRule -> done refactoring 2017-08-22 17:14:27 +02:00
Clément Fournier
2f678791cc ATFD metric 2017-08-22 17:13:54 +02:00
Clément Fournier
d14603078d Use TCC metric in GodClassRule 2017-08-22 17:13:54 +02:00
Clément Fournier
6a6804c7a1 TCC metric 2017-08-22 17:13:53 +02:00
Clément Fournier
a9be7d4f59 Use WMC metric in GodClassRule 2017-08-22 16:20:14 +02:00
Clément Fournier
43bbe83e6b Fix Woc integer division 2017-08-22 16:15:52 +02:00
Bendegúz Nagy
8676d8b544 Java, typeres: model wildcard types 2017-08-22 03:05:43 +02:00
Bendegúz Nagy
86d7d24e9c Java, typeres: model intersection types 2017-08-22 02:58:57 +02:00
Bendegúz Nagy
c17ab78ae1 Java, typeres: model lower bounds 2017-08-22 02:58:57 +02:00
Bendegúz Nagy
ed42fed650 Java, typeres: model upper bounds 2017-08-22 02:58:57 +02:00
Andreas Dangel
7f87882a43 [doc] Add first draft for pull request merge process
refs #359
2017-08-21 22:33:20 +02:00
Andreas Dangel
08dddc2ba7 Merge branch 'pr-567' 2017-08-21 22:23:42 +02:00
Andreas Dangel
2fa98064c7 Update release notes, refs #567 2017-08-21 22:08:29 +02:00
Andreas Dangel
bc2ed8cade Merge branch 'metric-options' of https://github.com/oowekyala/pmd into pr-567 2017-08-21 22:07:13 +02:00
Andreas Dangel
aef1c81da0 Merge branch 'pr-515' 2017-08-20 19:40:11 +02:00
Andreas Dangel
9ed5f651fa Remove unused ProgressMonitor interface 2017-08-20 19:33:24 +02:00
Andreas Dangel
b49eb24579 Merge branch 'issue-463' of https://github.com/Monits/pmd into pr-515 2017-08-20 19:30:15 +02:00
Clément Fournier
8f45685af6 Documented metrics and rule 2017-08-20 18:00:55 +02:00
Clément Fournier
1379142788 Added test case 2017-08-20 17:43:03 +02:00
Clément Fournier
768c8a7227 Started doc 2017-08-20 17:43:03 +02:00
Clément Fournier
6e4a293009 DataClassRule working -> champagne!! 2017-08-20 17:42:54 +02:00
Clément Fournier
55c6c8865d WOC tests 2017-08-20 17:41:35 +02:00
Clément Fournier
60df71fc85 NOAM tests 2017-08-20 17:41:35 +02:00
Clément Fournier
3643883f5f NOPA tests 2017-08-20 17:41:35 +02:00
Clément Fournier
acc06a91e4 Consider double results in metric test rules 2017-08-20 17:41:35 +02:00
Clément Fournier
ea097cc600 WOC metric 2017-08-20 17:41:35 +02:00
Clément Fournier
68490f7320 Added metric keys 2017-08-20 17:41:35 +02:00
Clément Fournier
41f0c14d17 NOPA metric 2017-08-20 17:41:35 +02:00
Clément Fournier
21f268c0fb NOAM metric 2017-08-20 17:41:34 +02:00
Clément Fournier
47aa1435ad Consider ConcurrentModificationException in iterator loop 2017-08-20 14:30:00 +02:00
Clément Fournier
9b05d5264e Corrections for PR #567 2017-08-19 20:23:38 +02:00
Andreas Dangel
9ae5f0d3a9 Merge branch 'pr-553' 2017-08-19 18:42:57 +02:00
Andreas Dangel
785b04944c Fix checkstyle 2017-08-19 18:34:54 +02:00
Andreas Dangel
dc5b814d05 Update release notes, refs #553 2017-08-19 18:32:49 +02:00
Andreas Dangel
b58e23ca71 Merge branch 'parserTst++' of https://github.com/oowekyala/pmd into pr-553 2017-08-19 18:31:31 +02:00
Andreas Dangel
e05940b246 [doc] Complete the maven PMD version upgrade example
To be sure, that it works, all dependencies need to be referenced/overridden.
Refs #402
2017-08-19 10:40:33 +02:00
Andreas Dangel
5957bc3db5 [doc] Restored original author information 2017-08-18 20:37:35 +02:00
Andreas Dangel
f3a3af1333 [doc] Upgrade PMD version at runtime for Maven PMD Plugin
Fixes #402
2017-08-18 19:55:16 +02:00
Andreas Dangel
2c2d62a66a [doc] Restructure Tools + Integrations 2017-08-18 19:42:12 +02:00
Andreas Dangel
f0134cbca7 [doc] Add "Writing Documentation" 2017-08-18 19:06:39 +02:00
Clément Fournier
4096f9f077 Update doc 2017-08-18 17:58:12 +02:00
Clément Fournier
d28620fd45 Removed a few hundred unnecessary lines 2017-08-18 15:22:15 +02:00
Clément Fournier
8b11246bb3 Replaced javadoc for metrics with link to doc site 2017-08-18 14:58:04 +02:00
Clément Fournier
36f3dbaf03 ConsiderAssert option for cyclo 2017-08-18 14:53:46 +02:00
Clément Fournier
66b418de79 Update doc 2017-08-18 14:44:57 +02:00
oowekyala
d33039870b Fixed tests 2017-08-18 14:44:57 +02:00
oowekyala
3a2866b703 Finished the doc 2017-08-18 14:44:57 +02:00
oowekyala
f747129e8c Internal builder for MetricOptions 2017-08-18 14:44:57 +02:00
oowekyala
8bac632333 Documentation 2017-08-18 14:44:57 +02:00
oowekyala
34894bca6f Decorators work 2017-08-18 14:44:57 +02:00
oowekyala
ceba5afece MetricOptions bundle, decorator doesn't work
The decorator needs some work because the decorated visitor takes over control to visit the children
2017-08-18 14:44:57 +02:00
oowekyala
6408b57b8e Varargs options -> bad 2017-08-18 14:44:57 +02:00
Clément Fournier
eb645b379a Fix failed build 2017-08-18 13:56:31 +02:00
Clément Fournier
7194328c4f Completed doc and tests 2017-08-18 12:12:45 +02:00
Andreas Dangel
fd1a3b78fa [doc] Create developer resources 2017-08-18 10:47:11 +02:00
Andreas Dangel
dda923fe1e [doc] Rework introduction page 2017-08-18 10:33:43 +02:00
Andreas Dangel
b3f76562a3 Update email for pmd-bot 2017-08-18 09:45:15 +02:00
oowekyala
1c73437a78 Merge branch 'master' of https://github.com/pmd/pmd into for2foreach 2017-08-17 21:46:26 +02:00
Travis CI (pmd-bot)
0351b88c83 Update documentation 2017-08-17 18:54:02 +00:00
Juan Martín Sotuyo Dodero
24213a80ca Merge branch 'pr-562' 2017-08-17 15:35:18 -03:00
Andreas Dangel
24e9a9f5c5 [doc] Add UnnecessaryParentheses back as deprecated and moved 2017-08-17 20:25:13 +02:00
Andreas Dangel
35e25912ac Merge remote-tracking branch 'origin/master' into docs-update-for-405
# Conflicts:
#	pmd-java/src/main/resources/rulesets/java/controversial.xml
#	pmd-java/src/main/resources/rulesets/java/design.xml
#	pmd-java/src/main/resources/rulesets/java/unnecessary.xml
2017-08-17 20:15:10 +02:00
Andreas Dangel
0cf2bb4845 [doc] Remove internal links from release_notes_old.md...
...since they don't and won't work
...and we have a TOC generated anyways
2017-08-17 20:06:30 +02:00
Juan Martín Sotuyo Dodero
a661b5a2bb Merge branch 'pr-563' 2017-08-17 15:04:36 -03:00
Juan Martín Sotuyo Dodero
0b56cdd416 Update changelog, refs #563 2017-08-17 15:04:16 -03:00
Andreas Dangel
b3f04079d6 [doc] Fixes from PR review 2017-08-17 20:01:50 +02:00
Bendegúz Nagy
80a15c7851 Java, typeres: fix PR comments 2017-08-17 18:11:37 +02:00
Travis CI (pmd-bot)
42c7980932 Update documentation 2017-08-16 18:28:00 +00:00
Juan Martín Sotuyo Dodero
8eb2986192 Merge branch 'pr-556' 2017-08-16 15:18:00 -03:00
Juan Martín Sotuyo Dodero
ddc9fcacbc Update changelog, refs #556 2017-08-16 15:16:44 -03:00
Juan Martín Sotuyo Dodero
93c3393999 Add fully qualified test case 2017-08-16 15:16:35 -03:00
Juan Martín Sotuyo Dodero
9d234d9567 Merge branch 'pr-554' 2017-08-16 14:16:25 -03:00
Juan Martín Sotuyo Dodero
3ba55ff1c0 Update changelog, refs #554 2017-08-16 14:15:46 -03:00
oowekyala
248b9837d6 Corrections for PR #554 2017-08-16 17:26:08 +02:00
oowekyala
2b8ed89edd Merge branch 'master' of https://github.com/pmd/pmd into for2foreach 2017-08-16 15:56:47 +02:00
oowekyala
2d5f1355c2 Deleted controversial/UnnecessaryParentheses 2017-08-16 14:37:46 +02:00
oowekyala
a4dc70610b Enhanced unnecessary/UselessParentheses with tests from controversial/UnnecessaryParentheses 2017-08-16 14:31:52 +02:00
Bendegúz Nagy
bc20be1ed8 Java, typeres: add basic method type inference 2017-08-16 00:02:34 +02:00
Bendegúz Nagy
1426b23ce5 Java, typeres: add support for producing initial method inference constraints 2017-08-16 00:02:34 +02:00
Bendegúz Nagy
90b802526c Java, typeres: add producing initial bounds for method invocation 2017-08-16 00:02:34 +02:00
Andreas Dangel
c48e2dad01 [ci] update email notification 2017-08-15 20:39:34 +02:00
Andreas Dangel
3a8a4ae969 Merge branch 'pr-557' 2017-08-15 20:36:55 +02:00
Andreas Dangel
dc8d3403f7 Update changelog, refs #557 2017-08-15 20:36:33 +02:00
Andreas Dangel
238f5f9eab Merge branch 'npath' of https://github.com/oowekyala/pmd into pr-557 2017-08-15 20:35:30 +02:00
Andreas Dangel
fa6b41215f Merge branch 'pr-555' 2017-08-15 20:31:01 +02:00
Andreas Dangel
16c55fca20 Remove bogus file 2017-08-15 20:26:00 +02:00
Andreas Dangel
28470d47ff Update changelog, refs #555 2017-08-15 20:13:08 +02:00
Andreas Dangel
35fb3c8723 Merge branch 'cyclo' of https://github.com/oowekyala/pmd into pr-555 2017-08-15 20:11:53 +02:00
oowekyala
0df423f1d2 Removed some redundancy in ClassTypeResolver and MetricsVisitorTest 2017-08-15 14:56:07 +02:00
oowekyala
17bb56a179 Made ParserTst a static utility class 2017-08-15 14:40:18 +02:00
Andreas Dangel
c8c4b73c80 [doc] Move the changelog to docs as "pmd_release_notes"
Also update the release scripts
2017-08-15 14:31:03 +02:00
Andreas Dangel
23d947b4bf [doc] Add syntax highlighting for code examples 2017-08-15 14:31:03 +02:00
Andreas Dangel
f918249eda [doc] Fix unit test after ruleset.xml changes 2017-08-15 14:31:03 +02:00
Andreas Dangel
b8cea8b7d4 [xml] Fix unit tests 2017-08-15 14:31:03 +02:00
Andreas Dangel
f29dcd549f Remove remaining references to pmd-build-tools-plugin 2017-08-15 14:31:03 +02:00
Andreas Dangel
819da2c3b4 [doc] [xml] Adjust externalInfoUrl properties to new site - Part 11
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
ceef1819e5 [doc] [vm] Adjust externalInfoUrl properties to new site - Part 10
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
af782c542c [doc] [visualforce] Adjust externalInfoUrl properties to new site - Part 9
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
9eb3aef9d6 [doc] [plsql] Adjust externalInfoUrl properties to new site - Part 8
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
69267eebdd [doc] [jsp] Adjust externalInfoUrl properties to new site - Part 7
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
7efa9021be [doc] [javascript] Adjust externalInfoUrl properties to new site - Part 6
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
cfa4e15d54 [doc] [apex] Adjust externalInfoUrl properties to new site - Part 5
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
1aaf52f0b0 [doc] [java] Adjust externalInfoUrl properties to new site - Part 4
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
9b1b3654b3 [doc] [java] Adjust externalInfoUrl properties to new site - Part 3
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
745acfa350 [doc] [java] Adjust externalInfoUrl properties to new site - Part 2
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
6e02494e5e [doc] [java] Adjust externalInfoUrl properties to new site - Part 1
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
3972be80cc [doc] Render rule names as keywords, so that the rules can be searched 2017-08-15 14:31:03 +02:00
Andreas Dangel
85c41033f5 [doc] Fix relative paths to images 2017-08-15 14:31:03 +02:00
Andreas Dangel
3d9511a0e5 [doc] Remove old maven site 2017-08-15 14:31:03 +02:00
Juan Martín Sotuyo Dodero
f3aa28ca1c Merge branch 'pr-550' 2017-08-15 00:30:17 -03:00
Juan Martín Sotuyo Dodero
98d43ee9dd Update changelog, refs #550 2017-08-15 00:29:39 -03:00
Bendegúz Nagy
288ca5da43 Java, typres: fix PR comments 2017-08-14 22:17:27 +02:00
Andreas Dangel
888dd2305c Merge branch 'pr-545' 2017-08-14 10:21:20 +02:00
Andreas Dangel
40c65acabb Update changelog, refs #545 2017-08-14 10:20:48 +02:00
oowekyala
41123508bc Use typeresolution in UncommentedEmptyConstructorRule 2017-08-13 23:28:39 +02:00
oowekyala
7d126ab206 Fix cyclo doc 2017-08-13 19:23:42 +02:00
oowekyala
b24edf9565 Merge branch 'master' of https://github.com/pmd/pmd into npath 2017-08-13 19:20:48 +02:00
oowekyala
3d08dbb480 Fix #357 2017-08-13 19:18:25 +02:00
oowekyala
abc70c6cf6 Fix test 2017-08-13 18:42:46 +02:00
oowekyala
5bd2fc1382 Merge branch 'master' of https://github.com/pmd/pmd into cyclo 2017-08-13 18:40:46 +02:00
oowekyala
69b32d4c00 Fix #537 2017-08-13 18:36:13 +02:00
oowekyala
5cff0e7a7a Added some utility methods to ParserTst 2017-08-13 17:56:40 +02:00
oowekyala
65fd4ea123 Added examples to metric docs & visitor description 2017-08-13 16:59:22 +02:00
oowekyala
54ec57bb3e Corrections for PR #545 2017-08-13 16:58:59 +02:00
oowekyala
2598c2dcce Merge branch 'master' of https://github.com/pmd/pmd into PR-apex 2017-08-13 16:57:59 +02:00
Travis CI (pmd-bot)
52d78d2fa9 Update documentation 2017-08-13 11:40:50 +00:00
Andreas Dangel
4c255cb1fa [ci] Fix script to actually push the docs 2017-08-13 13:30:49 +02:00
Andreas Dangel
8fa15fa0f0 Merge branch 'pr-548' 2017-08-13 12:44:23 +02:00
Andreas Dangel
908e8edc13 Update docs 2017-08-13 12:37:57 +02:00
Andreas Dangel
c38961720d Update changelog, refs #548 2017-08-13 12:07:15 +02:00
Andreas Dangel
d87ae0e4f7 Merge branch 'docs-metrics' of https://github.com/oowekyala/pmd into pr-548 2017-08-13 12:05:51 +02:00
Juan Martín Sotuyo Dodero
39250fce10 Merge branch 'pr-489' 2017-08-12 20:20:58 -03:00
Juan Martín Sotuyo Dodero
df0eba603d Update changelog, reflect impact of Apex Jorje update 2017-08-12 20:19:24 -03:00
Juan Martín Sotuyo Dodero
8fc1cc526d Merge branch 'pr-552' 2017-08-12 19:27:13 -03:00
Juan Martín Sotuyo Dodero
25f081de24 Merge branch 'pr-526' 2017-08-12 19:23:45 -03:00
Andreas Dangel
332e982508 Merge branch 'pr-539' 2017-08-12 22:07:22 +02:00
Andreas Dangel
86f5fa99c0 Merge branch 'issue-536' of https://github.com/Monits/pmd into pr-539 2017-08-12 22:06:56 +02:00
Andreas Dangel
c8dd41ac32 [ci] Push changes to docs, if there are any
refs #526
2017-08-12 21:55:31 +02:00
Andreas Dangel
58e52a5ce3 Update changelog, refs #489 2017-08-12 19:12:44 +02:00
Andreas Dangel
d070c35112 Merge remote-tracking branch 'origin/master' into apex-update 2017-08-12 19:10:32 +02:00
Andreas Dangel
9a71a6fd75 [apex] Handle blockstatements without curly braces
The new parser seems to always return a BlockStatement, regardless
whether it's a real block or just an expression statement.
2017-08-12 18:48:38 +02:00
Andreas Dangel
174184d9bc [apex] fix syntax errors in unit tests
Note: the test case in VariableNamingConvetion with a
custom annotation type is not relevant
for apex, since there are no custom annotations.
2017-08-12 17:52:33 +02:00
oowekyala
c9d3c8b5ae Moved to migrating ruleset 2017-08-12 17:51:12 +02:00
Andreas Dangel
da4272dc74 [doc] update generated documentation 2017-08-12 12:08:17 +02:00
Andreas Dangel
ca9004b9f7 [doc] add test for simple markdown formatting in rule description 2017-08-12 12:02:03 +02:00
Andreas Dangel
a4416a78e2 [doc] add minimum language version, add property for tests 2017-08-12 11:55:40 +02:00
Andreas Dangel
f1630932f2 [doc] update generated documentation 2017-08-12 11:47:47 +02:00
Andreas Dangel
2bff86d0f7 [doc] Output XPath expression and link to rule class implementation 2017-08-12 11:22:54 +02:00
oowekyala
ff89698cd2 Considers iterators 2017-08-11 23:16:13 +02:00
Andreas Dangel
06e8e32d23 [doc] update generated documentation 2017-08-11 21:52:18 +02:00
Andreas Dangel
9111316c01 [doc] Support renamed/moved rules 2017-08-11 21:37:24 +02:00
oowekyala
d749166191 Prefix increment works 2017-08-11 21:35:06 +02:00
Andreas Dangel
171ebad444 [doc] Add deprecation label for deprecated rules 2017-08-11 20:28:06 +02:00
Andreas Dangel
ba32ed572b [core] Take deprecated flag into account when loading rulesets/rules 2017-08-11 20:17:37 +02:00
oowekyala
1f6ef4a497 Removed false positives with start index != 0 2017-08-11 19:32:14 +02:00
Bendegúz Nagy
f51c75fa73 Java, typeres: basic type variable resolution in place 2017-08-11 18:41:49 +02:00
Bendegúz Nagy
7e49521762 Java, typeres: WIP resolution 2017-08-11 18:19:17 +02:00
Bendegúz Nagy
7a707aa7b6 Java, typeres: add erased candidate set and minimal erased candidate set methods 2017-08-11 18:19:17 +02:00
Bendegúz Nagy
0f657b3a52 Java, typeres: add supertype set and erased supertype set methods to JavaTypeDefinition 2017-08-11 18:19:17 +02:00
Bendegúz Nagy
37139c4038 Java, typeres: implement equals for JavaTypeDefinition 2017-08-11 18:19:17 +02:00
Bendegúz Nagy
c94bb39352 Java, typeres: partial resolution algorithm for type inference 2017-08-11 18:19:17 +02:00
Bendegúz Nagy
b22b4ec588 Java, typeres: compute variable's dependencies in type inference resolution step 2017-08-11 18:19:17 +02:00
oowekyala
b9e71bf4e4 Support for iteration on arrays 2017-08-11 18:16:55 +02:00
oowekyala
038503677b Added more tests 2017-08-11 17:49:00 +02:00
oowekyala
c0f1d36b05 First test passed 2017-08-11 13:02:59 +02:00
Andreas Dangel
2816988454 [doc] update generated documentation
Note: only new lines have been added
2017-08-11 11:41:15 +02:00
Andreas Dangel
d6c23fd17f [doc] Add unit test for rule doc generator
Therefore the file writer has been mocked. The rulesets to be
documented are now given, rather than determined by the generator.
2017-08-11 11:40:38 +02:00
Andreas Dangel
0b9b7e2a5d Fix checkstyle 2017-08-10 19:41:00 +02:00
Andreas Dangel
5113af6568 Fix build 2017-08-10 19:27:33 +02:00
Andreas Dangel
d537b2acbe [doc] move RuleDocGenerator into pmd-doc
It'll be executed during package phase.
2017-08-10 19:18:35 +02:00
Andreas Dangel
8bdb0a5d22 [doc] add pmd-doc submodule 2017-08-10 19:00:10 +02:00
Juan Martín Sotuyo Dodero
69fc7c8451 Merge branch 'pr-549' 2017-08-09 12:24:42 -03:00
Juan Martín Sotuyo Dodero
79ff3a461d Update changelog, refs #549 2017-08-09 12:24:15 -03:00
oowekyala
0958621ca8 Fix #521 2017-08-09 16:51:43 +02:00
oowekyala
319e6977d1 Fix spacing problem in descriptions 2017-08-09 14:59:10 +02:00
oowekyala
4be56ab274 Added code example for npath 2017-08-08 22:09:24 +02:00
oowekyala
1105d62a29 Interface doc 2017-08-08 20:33:47 +02:00
oowekyala
2bd9dc6a70 Finished NPath description 2017-08-08 16:39:12 +02:00
oowekyala
b86f0aec59 Fix npath bugs with ternary 2017-08-08 16:00:30 +02:00
oowekyala
c9783209f4 Changed defaults 2017-08-08 15:54:08 +02:00
oowekyala
a712f5cc5c Refactored Cyclo into op metric
The rule now uses WMC to report classes
2017-08-08 15:51:45 +02:00
oowekyala
6abe95d2be Metrics rule descriptions 2017-08-08 15:43:41 +02:00
oowekyala
193ae355bb Documentation 2017-08-08 00:13:20 +02:00
oowekyala
62d40be59a Merge branch 'master' of https://github.com/pmd/pmd into docs-metrics 2017-08-07 22:23:05 +02:00
oowekyala
51bc82c889 Custom namespace when they're unknown 2017-08-07 19:49:11 +02:00
oowekyala
904b7f84fa Merge branch 'master' of https://github.com/pmd/pmd into metrics-apex 2017-08-07 18:15:32 +02:00
oowekyala
b937d84515 Documentation 2017-08-07 18:01:29 +02:00
oowekyala
02307ca8d5 Code examples for doc + fix Ncss ignoring asserts 2017-08-07 17:47:57 +02:00
Andreas Dangel
585a555ba5 Merge pull request #542 from oowekyala/metrics-abstraction
[java, core] Metrics abstraction
2017-08-07 17:05:05 +02:00
oowekyala
e9f4674f30 Merge branch 'master' of https://github.com/pmd/pmd into docs-metrics 2017-08-07 16:17:34 +02:00
oowekyala
f982acca32 Checkstyle 2017-08-06 23:57:36 +02:00
oowekyala
3b27387c76 Updated changelog 2017-08-06 22:22:17 +02:00
oowekyala
f804e11ec5 Merge branch 'metrics-abstraction' into metrics-apex 2017-08-05 14:44:32 +02:00
oowekyala
6c8c6f917a Made basicProjectMemoizer abstract 2017-08-05 14:44:15 +02:00
oowekyala
510938c013 Merge branch 'metrics-abstraction' into metrics-apex 2017-08-04 22:27:49 +02:00
oowekyala
58c7978913 Checkstyle fix 2017-08-04 22:27:29 +02:00
oowekyala
05b502e247 Fix Apex module 2017-08-04 22:26:58 +02:00
oowekyala
2df4ad9bf4 Merge metrics-abstraction + fix pmd-java 2017-08-04 21:36:50 +02:00
oowekyala
78814b5edb Deleted OperationStats 2017-08-04 21:29:43 +02:00
oowekyala
2771448a37 Restricted qualifiedName interface 2017-08-04 19:44:43 +02:00
oowekyala
152dddf6c5 Separated memoization from signature matching 2017-08-04 19:19:50 +02:00
oowekyala
35e2610473 Merge branch metrics-abstraction 2017-08-03 18:56:00 +02:00
oowekyala
909f989571 Checkstyle fixes 2017-08-03 18:49:04 +02:00
oowekyala
379f1be403 Merge branch metrics-abstraction 2017-08-03 18:46:26 +02:00
oowekyala
6d0ebbf63d Resolve conflicts 2017-08-03 18:42:58 +02:00
oowekyala
aa8c21d6e9 Picked changes to pmd-core and pmd-java from branch metrics-apex 2017-08-03 18:10:24 +02:00
oowekyala
f2e9a9a1ac Merge branch 'master' of https://github.com/pmd/pmd into metrics-apex 2017-08-03 18:00:11 +02:00
Dennis Kieselhorst
1643e10cbd add Throwable to ProcessingError to allow full error reporting 2017-08-03 09:21:01 +02:00
Juan Martín Sotuyo Dodero
0b2389c798 Update changelog, refs #536 2017-08-02 23:58:57 -03:00
Juan Martín Sotuyo Dodero
86501e6bc0 [java] CommentDefaultAccessModifierRule should consider constructors too
- Resolves #536
2017-08-02 23:56:34 -03:00
Juan Martín Sotuyo Dodero
be5ae89bc0 Merge branch 'pr-524' 2017-08-02 16:39:04 -03:00
Juan Martín Sotuyo Dodero
57b556350c Update changelog, refs #524 2017-08-02 16:38:18 -03:00
Bendegúz Nagy
bd503ba139 Java, typeres: fix PR comments 2017-08-02 21:13:28 +02:00
Andreas Dangel
1b71861d9b Merge pull request #519 from Monits/render-config-errors
[core] Render config errors
2017-08-02 16:52:18 +02:00
Andreas Dangel
ed3c8e85c4 Merge pull request #529 from oowekyala/metrics-abstraction
[java] Abstracted the Java metrics framework
2017-08-01 20:06:42 +02:00
oowekyala
661dfdb6c1 Merge branch 'master' of https://github.com/pmd/pmd into metrics-apex 2017-08-01 19:20:33 +02:00
Clément Fournier
acb8e6582c Merge branch 'master' into metrics-abstraction 2017-08-01 19:16:00 +02:00
oowekyala
ba73842aa4 Changelog entry 2017-08-01 19:15:03 +02:00
oowekyala
40af40bcd2 Made signature matching optional + doc 2017-08-01 19:07:44 +02:00
oowekyala
a0c6437c0e Cyclo rule + more stuff 2017-08-01 17:02:51 +02:00
oowekyala
68452939ab More work 2017-08-01 17:01:10 +02:00
oowekyala
e1c985c7d5 Adapted components to AST 2017-08-01 16:56:21 +02:00
oowekyala
e4e3fd33d8 Marker interface for class and interface 2017-08-01 16:55:30 +02:00
Juan Martín Sotuyo Dodero
8d3abb1268 Merge branch 'pr-535' 2017-08-01 11:24:33 -03:00
Juan Martín Sotuyo Dodero
bb75cce2e7 Update changelog, refs #535 2017-08-01 11:24:16 -03:00
Clément Fournier
acd710a8f3 Fix broken Apex visitor adapter 2017-08-01 15:41:56 +02:00
oowekyala
6a0e7c5879 Corrections for PR #529 2017-08-01 11:56:45 +02:00
Andreas Dangel
fece0cc702 [doc] Update generated rule doc 2017-07-31 21:15:00 +02:00
Andreas Dangel
0266912494 [doc] Sort the rules also on the language index page 2017-07-31 21:14:15 +02:00
Andreas Dangel
1d706726af [doc] Update generated rule doc 2017-07-31 21:11:21 +02:00
Andreas Dangel
3e39828dd9 [doc] Fixes for #526 2017-07-31 21:10:55 +02:00
oowekyala
e662aef673 Moved the index into language specific doc 2017-07-30 23:31:39 +02:00
oowekyala
162f4bc3f0 Memoization tests ok 2017-07-30 23:05:43 +02:00
oowekyala
1bee5d7e39 Minimal tests 2017-07-30 18:56:00 +02:00
oowekyala
8f8e129e4f Metric keys 2017-07-30 16:45:12 +02:00
oowekyala
d9273add4f Façade and Computer 2017-07-30 15:25:58 +02:00
oowekyala
e02dfae300 Visitor 2017-07-30 15:14:55 +02:00
oowekyala
e9fab949b7 Operation signatures 2017-07-30 15:02:03 +02:00
oowekyala
7fd85f77a3 Groundwork: qualifiednames 2017-07-30 00:13:56 +02:00
oowekyala
a61fe03e86 Merge branch 'master' of https://github.com/pmd/pmd into metrics-apex 2017-07-30 00:09:08 +02:00
oowekyala
231758fa3a Merge branch 'master' of https://github.com/pmd/pmd into metrics-abstraction 2017-07-30 00:04:21 +02:00
Juan Martín Sotuyo Dodero
fe1d7748ad Merge branch 'pr-528' 2017-07-29 19:02:06 -03:00
oowekyala
d4ede86230 Merge branch master from upstream 2017-07-30 00:01:50 +02:00
Juan Martín Sotuyo Dodero
04f4f86160 Update changelog, refs #528 2017-07-29 19:01:25 -03:00
Juan Martín Sotuyo Dodero
3bcdb7787d Merge branch 'pr-530' 2017-07-29 18:55:16 -03:00
Juan Martín Sotuyo Dodero
9046179cdb Update changelog, refs #530 2017-07-29 18:54:44 -03:00
Juan Martín Sotuyo Dodero
4c96b9bb20 Update changelog, refs #525 2017-07-29 18:51:43 -03:00
oowekyala
3b48ef6407 Fix issue #527 2017-07-29 20:07:19 +02:00
oowekyala
5e035b8e57 Flattened the packages in pmd-core 2017-07-29 16:50:06 +02:00
oowekyala
7fc250ad6d SignatureMatcher interface 2017-07-29 16:26:43 +02:00
oowekyala
56f3b3ea62 Specific interface for the java project mirror 2017-07-29 14:52:09 +02:00
oowekyala
622170991f Abstracted Façade, Memoizer, Computer 2017-07-29 13:53:45 +02:00
Ayoub Kaanich
d33b9d9eae Fix typo 2017-07-29 07:41:47 +01:00
oowekyala
63e51152f5 Abstracted Computer, Memoizer, ProjectMirror 2017-07-28 21:53:38 +02:00
Andreas Dangel
92fc1e4fbe Merge branch 'pr-517' 2017-07-28 14:55:18 +02:00
Andreas Dangel
c1f6ce0f00 Update changelog, refs #517 2017-07-28 14:53:52 +02:00
Andreas Dangel
b94f218155 Merge branch 'docs-metrics' of https://github.com/oowekyala/pmd into pr-517 2017-07-28 14:53:05 +02:00
Andreas Dangel
a2279a735a Merge branch 'pr-523' 2017-07-28 14:52:38 +02:00
Andreas Dangel
a31739c0c2 Update changelog, refs #523 2017-07-28 14:45:38 +02:00
Andreas Dangel
93b7b122f4 Merge branch 'npath' of https://github.com/oowekyala/pmd into pr-523 2017-07-28 14:44:06 +02:00
oowekyala
05f2ffce4c Extracted the facade and stripped responsibilities of packageStats 2017-07-28 13:18:13 +02:00
oowekyala
66df4948a0 More corrections 2017-07-28 13:02:54 +02:00
Andreas Dangel
4c3e65c8f9 Fix checkstyle 2017-07-28 12:23:17 +02:00
Andreas Dangel
4dd218bc25 [doc] Add initially generated rule docs and update sidebar 2017-07-28 12:16:12 +02:00
Andreas Dangel
84313b9ebe [doc] Create a simple rule doc generator 2017-07-28 12:16:12 +02:00
Andreas Dangel
509acb6d8f [doc] Add option to select the active sidebar item
If the page contains the variable "sidebaractiveurl" in the yaml
frontmatter, this is additionally used to select the active item
in the sidebar. Useful, if the page doesn't have its own item,
but wants to activate e.g. the parent page.
2017-07-28 12:16:12 +02:00
Andreas Dangel
236154100f [doc] Add possibility to override editme link location
If the page contains the variable "editmepath" in the yaml frontmatter,
this will be used instead of "page.path" (the actual markdown file).
This is useful, if the page is generated from another source.
2017-07-28 12:16:12 +02:00
Juan Martín Sotuyo Dodero
5360974903 Merge branch 'pr-525' 2017-07-27 21:58:12 -03:00
Juan Martín Sotuyo Dodero
d5d32f996b Make bash scripts executable 2017-07-27 21:43:34 -03:00
Matias Comercio
e5ddad3c3b Remove pushed .gitignored files
These files were already at the repository
but they should have been ignored
2017-07-27 18:31:20 -03:00
oowekyala
7e5374ea8d Corrections for PR #523 2017-07-27 22:46:45 +02:00
Matias Comercio
5880a85bb1 Autofix line ending issues
These files didn't have the expected line ending according to
the .gitattributes rule: `*       text=auto`.

Don't know why this could have happened, but all these files
where created before the mentioned rule
2017-07-27 17:28:29 -03:00
oowekyala
edc8d980bb Signed nodes for field and operation declarations 2017-07-27 18:35:14 +02:00
oowekyala
582eedf4f6 Abstracted qualified names 2017-07-27 18:01:54 +02:00
oowekyala
8c33501ffe OperationStats are accessible from packageStats 2017-07-27 17:34:02 +02:00
oowekyala
796f1a1fc1 Split ClassStats' responsibilities 2017-07-27 17:05:32 +02:00
Bendegúz Nagy
9959338890 Java, typeres: add support for explicit type arguments 2017-07-27 16:50:50 +02:00
Juan Martín Sotuyo Dodero
b899cc1001 Merge branch 'pr-522' 2017-07-27 11:15:38 -03:00
Juan Martín Sotuyo Dodero
739da071f3 Update changelog, refs #522 2017-07-27 11:15:15 -03:00
oowekyala
1ee8cc4e8d Fix bug in key hashcode with null names or metric 2017-07-27 01:18:31 +02:00
oowekyala
bccaabb00d Merge branch 'master' of https://github.com/pmd/pmd into npath 2017-07-27 00:59:19 +02:00
oowekyala
9eedf85395 Finished the tests 2017-07-27 00:47:26 +02:00
oowekyala
d06cb63d38 Tests of the rule 2017-07-26 23:50:08 +02:00
Bendegúz Nagy
704d87b470 Java, typeres: fix PR comments 2017-07-26 23:44:51 +02:00
Andreas Dangel
bad96d16d7 Merge pull request #516 from Monits/issue-468
[java] Fix issue 468
2017-07-26 20:21:43 +02:00
oowekyala
bef9e64021 Reused existing npath implementation 2017-07-26 19:49:41 +02:00
oowekyala
9c3a97f641 First iteration of npath 2017-07-26 17:49:58 +02:00
oowekyala
904c127069 Merge branch 'metrics' into npath 2017-07-26 15:29:10 +02:00
Bendegúz Nagy
87bbe9e5b3 Java, typedef: fix a bug with nested classes if the outter class is generic 2017-07-26 12:44:54 +02:00
oowekyala
97b3a59efb Corrections for PR #517 2017-07-26 01:51:43 +02:00
Andreas Dangel
b4e799aaef Merge branch 'pr-511' 2017-07-25 21:41:22 +02:00
Andreas Dangel
2e01150764 Update changelog, refs #511 2017-07-25 21:41:13 +02:00
Andreas Dangel
2c0f0c2b99 Merge branch 'metrics' of https://github.com/oowekyala/pmd into pr-511 2017-07-25 21:39:49 +02:00
Andreas Dangel
1211a6f93a [ci] use a container-based build environment again
Since we don't use docker anymore, let's try to use a container-based
build environment again
2017-07-25 21:33:48 +02:00
Andreas Dangel
0a4d212438 [ci] fix rsync paths 2017-07-25 21:14:08 +02:00
Andreas Dangel
ff0149fb7f [ci] run jekyll directly without docker 2017-07-25 21:09:23 +02:00
Andreas Dangel
e432a32818 [ci] we seem to have some kind of permission problem 2017-07-25 20:40:58 +02:00
Juan Martín Sotuyo Dodero
aad99cdf49 Update changelog, refs #519 2017-07-25 13:43:57 -03:00
Juan Martín Sotuyo Dodero
6fcfa04a1f Add tests and update old ones 2017-07-25 12:52:59 -03:00
Juan Martín Sotuyo Dodero
86883f26c7 [core] Render config errors
- All renderers preivously including processing errors now also include
configuration errors.
 - I take the chance to fix a couple of issues with `VBHTMLRenderer`,
that was rendering processing errors using `toString()` (which has a
default implementation)
 - Notice that renderers that didn't previously include processing
errors are unmodified
2017-07-25 12:52:49 -03:00
Juan Martín Sotuyo Dodero
87aa70a096 Merge branch 'pr-514' 2017-07-25 11:41:17 -03:00
Juan Martín Sotuyo Dodero
84a542a790 Update changelog, refs #514 2017-07-25 11:40:46 -03:00
oowekyala
82d071a102 Rename metrics.metrics to metrics.impl 2017-07-25 15:41:12 +02:00
oowekyala
194bc6d71a Fix Checkstyle violations 2017-07-25 14:18:26 +02:00
Bendegúz Nagy
67e4daa177 Java, typeres: fix for PR comments 2017-07-25 13:27:46 +02:00
oowekyala
e14e338ef4 Made backwards compatible constructors 2017-07-25 11:35:11 +02:00
oowekyala
edf8ce0732 Factorized enumerated property 2017-07-25 11:27:55 +02:00
oowekyala
01257cb8eb Merge branch 'master' into docs-metrics 2017-07-25 10:11:15 +02:00
oowekyala
33d1327bdb Merge branch 'master' into metrics-followup 2017-07-25 10:10:49 +02:00
oowekyala
dddf78d443 Checkstyle fixes 2017-07-25 10:04:44 +02:00
oowekyala
2fa7cab876 Merge branch 'metrics' into metrics-followup 2017-07-25 09:34:49 +02:00
oowekyala
962b4587b5 Revert renaming classStats, opStats, packStats 2017-07-25 09:34:07 +02:00
Juan Martín Sotuyo Dodero
f5c345bd0a Update changelog, res #468 2017-07-24 17:51:41 -03:00
Juan Martín Sotuyo Dodero
df2765152e [java] Resolve #468
- This is still not perfect. There are plenty of scenarios where this
could fail (ie: multidimensional arrays), but is closer to what we want
without a full rewrite.
 - On the future we need to review this rule once again.
2017-07-24 17:49:25 -03:00
Juan Martín Sotuyo Dodero
9143630351 Merge branch 'pr-508' 2017-07-24 17:28:33 -03:00
Juan Martín Sotuyo Dodero
9bef9eb508 Merge branch 'pr-507' 2017-07-24 17:27:10 -03:00
Juan Martín Sotuyo Dodero
3519d82ddb Fix checkstyle issues 2017-07-24 16:57:30 -03:00
Juan Martín Sotuyo Dodero
7a965ea363 Add exclusion of transitive dependency
- Allow the invalid import from ever happening again
2017-07-24 16:55:58 -03:00
Juan Martín Sotuyo Dodero
583184aae2 Fix bad imports 2017-07-24 16:55:58 -03:00
Juan Martín Sotuyo Dodero
cf7cc735b2 Update changelog 2017-07-24 16:55:58 -03:00
Juan Martín Sotuyo Dodero
1d639b6c96 Remove usages of deprecated methods 2017-07-24 16:55:58 -03:00
Juan Martín Sotuyo Dodero
94ed1e8a86 Remove usages of deprecated methods 2017-07-24 16:11:15 -03:00
Juan Martín Sotuyo Dodero
ffbd8c02ff Deprecate a bunch of useless methods
- Either not used, or we have better implementations available on
Apache commons
2017-07-24 15:50:22 -03:00
Juan Martín Sotuyo Dodero
0ab96a3da6 Remove deprecated APIs 2017-07-24 15:14:46 -03:00
Juan Martín Sotuyo Dodero
6464f89e2b Merge branch 'pr-513' 2017-07-24 14:55:45 -03:00
Juan Martín Sotuyo Dodero
f65fbb6204 Update changelog, refs #513 2017-07-24 14:54:57 -03:00
Bendegúz Nagy
9c8cbecc18 Java, typeres: fix for maximally specific method selection 2017-07-24 19:44:59 +02:00
Juan Martín Sotuyo Dodero
7df4d55273 Merge branch 'pr-512' 2017-07-24 14:41:35 -03:00
Juan Martín Sotuyo Dodero
713628a183 Update changelog, refs #512 2017-07-24 14:40:52 -03:00
Bendegúz Nagy
2146a077eb Java, typeres: add static method resolution 2017-07-24 19:38:08 +02:00
Bendegúz Nagy
4fb214cf64 Java, typeres: add static method access tests 2017-07-24 19:38:08 +02:00
Bendegúz Nagy
6b335b1a25 Java, typeres: split incorporation tests 2017-07-24 19:36:30 +02:00
Juan Martín Sotuyo Dodero
5eb47c4dd2 Make RuleSetReference immutable 2017-07-24 14:13:22 -03:00
Bendegúz Nagy
db6dc4d5bc Java, typeres: add incorporation and tests 2017-07-24 18:31:49 +02:00
Juan Martín Sotuyo Dodero
19da55f1fe [core] Allow deep copying of RuleSets
- Copy constructor for RuleSets
 - Copy constructor for RuleSet
 - Copy method for Rules
 - I'm still sharing a few objects that are not strictly immutables, but
treated as them
2017-07-24 12:47:49 -03:00
Juan Martín Sotuyo Dodero
7918e782f3 Merge branch 'pr-506' 2017-07-24 12:43:00 -03:00
Juan Martín Sotuyo Dodero
d182f5f5f4 Update changelog, refs #506 2017-07-24 12:42:38 -03:00
Bendegúz Nagy
3bec082a40 Merge branch 'master' into reduction 2017-07-24 16:54:22 +02:00
Bendegúz Nagy
b38dc2cd02 Java, typeres: fix for PR 2017-07-24 16:37:32 +02:00
Juan Martín Sotuyo Dodero
7cfc44abf8 Add toString for typeres classes
- This will make debugging and error messages a little more clear
2017-07-24 11:24:51 -03:00
oowekyala
4c0bd26091 Implemented hashCode and equals in metric keys factory methods 2017-07-24 16:13:56 +02:00
oowekyala
ac89e1420c Moved interfaces and renamed package
Prepare abstraction of metrics
2017-07-24 16:03:33 +02:00
Andreas Dangel
5727dabd38 [doc] Add build script for PMD documentation, disable old site build 2017-07-23 11:00:52 +02:00
Andreas Dangel
ab6d88e286 [doc] Fix PMD Version in sidebar 2017-07-22 14:38:37 +02:00
Andreas Dangel
c1fe2dfbd5 [doc] Fix edit me link, remove news link from top, add site.pmd.version var 2017-07-22 14:17:08 +02:00
Andreas Dangel
4370ff663e [doc] Fix links between pages 2017-07-22 12:03:16 +02:00
Andreas Dangel
6e59b0e103 [doc] Add remaining pages (FAQ, Releasing), add images 2017-07-22 11:37:13 +02:00
Andreas Dangel
81077e3ce0 [doc] Rename the files to remove boilerplate filename prefixes
The actual output filename is defined in the frontmatter
variable "permalink". And this is used in the sidebar to link
to this page.
2017-07-22 11:15:40 +02:00
Andreas Dangel
b87d567525 [doc] Add remaining pages from old "usage" section 2017-07-22 11:06:01 +02:00
Andreas Dangel
80d99744ee [doc] Add pages from old "usage" section 2017-07-21 22:47:32 +02:00
Bendegúz Nagy
6fb3b99c2c Java, typeres: add reduce method tests 2017-07-21 21:02:10 +02:00
Juan Martín Sotuyo Dodero
0265a0c9f1 Merge branch 'pr-502' 2017-07-21 12:51:41 -03:00
Juan Martín Sotuyo Dodero
4929be55e1 Update changelog, refs #502 2017-07-21 12:50:52 -03:00
Juan Martín Sotuyo Dodero
98172a26fe Remove useless override 2017-07-21 12:47:53 -03:00
Andreas Dangel
58ea1c7d4f [doc] Add pages from the old "overview" section 2017-07-21 12:15:15 +02:00
Andreas Dangel
6d5f975464 [doc] remove the old release notes, we have them on the main page 2017-07-21 12:14:31 +02:00
Andreas Dangel
a4890ad9cd [doc] add favicon 2017-07-21 11:45:25 +02:00
Andreas Dangel
2af006201f Merge branch 'master' into docs-ghpages 2017-07-21 11:31:33 +02:00
Andreas Dangel
48b7ec1aaf Revert "Change github edit button temporarily to point to adangel/pmd"
This reverts commit 7ee6284ec2.
2017-07-21 11:31:24 +02:00
Andreas Dangel
98bb301998 Merge branch 'pr-505' 2017-07-21 11:19:17 +02:00
Andreas Dangel
a6f8107577 Update changelog, refs #505 2017-07-21 11:18:18 +02:00
Bendegúz Nagy
b86750cc97 Java, typeres: add reduce methods for type inference 2017-07-21 09:51:41 +02:00
Bendegúz Nagy
c2bb8e5f4b Java, typeres: fix double visitation 2017-07-21 00:31:54 +02:00
oowekyala
1ac1fabe38 Corrections for PR #505 2017-07-20 22:41:55 +02:00
oowekyala
85e529eeeb Added WMC description 2017-07-20 19:57:42 +02:00
oowekyala
ad14f69b9b Index of metrics 2017-07-20 19:44:24 +02:00
oowekyala
99b3c5e12f Checkstyle fixes 2017-07-20 12:59:47 +02:00
Clément Fournier
0f313f9044 Merge branch 'master' into metrics 2017-07-20 12:48:54 +02:00
oowekyala
875a79f34f Last corrections 2017-07-20 12:26:10 +02:00
Bendegúz Nagy
60f6935f84 Java, typeres: refactor ClassTypeResolver::visit(ASTName, Object) 2017-07-19 21:25:51 +02:00
Bendegúz Nagy
800cfa6e48 Java, typeres: add static field resolution 2017-07-19 21:22:09 +02:00
Bendegúz Nagy
926fe63a11 Java, typeres: add failing static field access tests 2017-07-19 21:22:09 +02:00
Andreas Dangel
98670a736f [ci] increase timeout for site generation 2017-07-19 20:47:07 +02:00
Andreas Dangel
c808ad1245 Merge branch 'pr-499' 2017-07-19 20:18:20 +02:00
Andreas Dangel
b5316b48c4 Update changelog, refs #499 2017-07-19 20:07:14 +02:00
Andreas Dangel
e4a42cdc9d Merge branch 'memoization-tests' of https://github.com/oowekyala/pmd into pr-499 2017-07-19 20:06:14 +02:00
oowekyala
b41e674cbd Merge branch master from upstream 2017-07-18 00:42:33 +02:00
Andreas Dangel
1e3347d95b Merge branch 'pr-487' 2017-07-17 21:04:33 +02:00
Andreas Dangel
230994848a Update changelog, refs #487 2017-07-17 20:50:50 +02:00
Andreas Dangel
ef246adf2a Merge branch 'fix-extends-object' of https://github.com/Monits/pmd into pr-487 2017-07-17 20:49:37 +02:00
Andreas Dangel
dc90db14ba Merge branch 'pr-479' 2017-07-17 20:43:26 +02:00
Andreas Dangel
d18b4f9948 Update changelog, refs #479 2017-07-17 20:23:07 +02:00
Andreas Dangel
16d1d80062 Merge branch 'typesafe-properties' of https://github.com/oowekyala/pmd into pr-479 2017-07-17 20:18:37 +02:00
oowekyala
026b03dfb2 Some documentation about Wmc and Cyclo 2017-07-17 14:54:16 +02:00
Juan Martín Sotuyo Dodero
b259db6d59 Merge branch 'pr-503' 2017-07-16 17:22:45 -03:00
Andreas Dangel
fba00843bb [apex] Disable logging of jorje apex lexer
Fixes #500
2017-07-16 21:17:05 +02:00
oowekyala
2a53d2e532 Added tests for Cyclo 2017-07-16 16:33:21 +02:00
oowekyala
1c1e97e7e4 Added factory methods for custom metric keys 2017-07-16 14:45:00 +02:00
oowekyala
516f9da10b Generified Metrics and keys 2017-07-16 14:22:11 +02:00
oowekyala
5e887b61d3 Fix bug with empty statements in the body of a class 2017-07-15 18:39:13 +02:00
oowekyala
ca41c67371 Checkstyle fixes 2017-07-15 16:50:46 +02:00
oowekyala
31ed6fd565 Removed overloads of setProperty 2017-07-15 16:41:38 +02:00
oowekyala
35dee58bc8 Fix initialisation bug 2017-07-15 16:36:11 +02:00
oowekyala
e270ff13f6 Merge branch memoization-tests 2017-07-14 16:38:56 +02:00
oowekyala
f44a08d9d5 Fix memo tests 2017-07-14 16:32:02 +02:00
oowekyala
278e857bf6 Reworked factories 2017-07-14 02:15:50 +02:00
oowekyala
879a7d375c Modularized numeric and packaged properties 2017-07-13 21:43:18 +02:00
Juan Martín Sotuyo Dodero
c408dc3ba9 Merge branch 'pr-501' 2017-07-13 15:42:52 -03:00
Juan Martín Sotuyo Dodero
4adfebffdf Update changelog, refs #501 2017-07-13 15:42:30 -03:00
oowekyala
282cf5bd66 Added PackagedPropertyDescriptor interface 2017-07-13 19:03:10 +02:00
oowekyala
8474131f5b Removed wrappers altogether 2017-07-13 16:53:26 +02:00
oowekyala
5e57af605c Removed need for wrappers 2017-07-13 16:46:05 +02:00
oowekyala
e39cbba24a Added overloads of setProperty for multivalued properties 2017-07-13 14:54:05 +02:00
oowekyala
0164edf585 Corrections for #479 2017-07-13 14:17:30 +02:00
Bendegúz Nagy
976240ca48 Java, typeres: add choosing most specific vararg method 2017-07-13 10:54:45 +02:00
Bendegúz Nagy
12a16caf69 Java, typeres: add vararg most specific tests 2017-07-13 10:54:45 +02:00
oowekyala
9075cb005c Fix bug with empty value strings 2017-07-12 20:00:32 +02:00
oowekyala
9a2a91115b Deprecated PropertyDescriptorFactory 2017-07-12 19:04:09 +02:00
oowekyala
648e15122e Revert "Removed PropertyDescriptorFactory"
This reverts commit 72d435f2f6.
2017-07-12 18:39:13 +02:00
oowekyala
772875d13f More tests 2017-07-12 18:38:40 +02:00
oowekyala
72d435f2f6 Removed PropertyDescriptorFactory 2017-07-12 18:07:23 +02:00
oowekyala
1f0908388b Added some tests 2017-07-12 17:40:47 +02:00
oowekyala
7eac745cb5 Fix Ncss tests 2017-07-12 17:03:34 +02:00
oowekyala
fb64e130f8 Memoization tests 2017-07-11 21:02:06 +02:00
Juan Martín Sotuyo Dodero
865f86599f Merge branch 'pr-492' 2017-07-11 15:57:21 -03:00
Juan Martín Sotuyo Dodero
ac50d9a47f Update changelog, refs #492 2017-07-11 15:55:56 -03:00
oowekyala
d92b7e5376 Added a version to Ncss 2017-07-11 17:04:01 +02:00
oowekyala
3061778587 Memoization tests 2017-07-11 17:02:52 +02:00
oowekyala
79fc51220c Merge branch 'typesafe-properties' of https://github.com/oowekyala/pmd into typesafe-properties 2017-07-11 16:06:23 +02:00
Clément Fournier
824f87995d Merge branch 'master' into typesafe-properties 2017-07-11 16:05:17 +02:00
oowekyala
341d66b694 Abstracted Metrics to use MetricKeys 2017-07-11 14:47:45 +02:00
oowekyala
65ef499433 Removed isRequired 2017-07-11 12:09:02 +02:00
oowekyala
707fd9bdd0 Removed choices from EnumeratedPropertyDescriptor 2017-07-11 12:02:20 +02:00
Bendegúz Nagy
4728eff5d6 Java, typeres: move method typeresolution methods into a helper class 2017-07-11 10:35:15 +02:00
oowekyala
1d5ec7f1b6 Cleaned OperationSignature 2017-07-10 21:05:39 +02:00
Andreas Dangel
bea145d106 Changelog - fix typos 2017-07-10 20:57:02 +02:00
Andreas Dangel
301ad55688 Merge branch 'pr-482' 2017-07-10 20:54:46 +02:00
Andreas Dangel
3f24f64da7 Update changelog, refs #482 #495 2017-07-10 20:47:48 +02:00
Andreas Dangel
969c66d363 Merge branch 'metrics' of https://github.com/oowekyala/pmd into pr-482 2017-07-10 20:38:19 +02:00
oowekyala
8136053154 Update getter and setter detection 2017-07-10 19:52:51 +02:00
oowekyala
8b7745cf14 Update tests to reset correctly: depends on #495 2017-07-10 19:18:13 +02:00
oowekyala
ea633ece0a Merge branch 'reinit-tests' into metrics 2017-07-10 18:16:42 +02:00
oowekyala
58401cecc8 Deleted MetricsForceHook 2017-07-10 18:16:28 +02:00
oowekyala
f19428660e Custom rule reinitialization code 2017-07-10 17:18:59 +02:00
Bendegúz Nagy
2a7fbc1d43 Java, typeres: put links to JLS sections for method resolution 2017-07-09 22:48:26 +02:00
Bendegúz Nagy
979ef7c77c Java, typeres: fix checkstyle issues 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
97f7f6a6de Java, typeres: add vararg method resolution 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
176ccb4533 Java, typeres: add vararg tests for method resolution 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
65be8c6afb Java, typeres: add ethod resolution second phase 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
430486a761 Java, typeres: add second phase method resolution tests 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
877f9d1b71 Java, typeres: add most specific method resolution 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
1b52d46c26 Java, typeres: add first phase method overoad resolution 2017-07-08 22:31:19 +02:00
Bendegúz Nagy
5b53b73bb8 Java, typeres: add method first phase tests 2017-07-08 22:31:19 +02:00
Juan Martín Sotuyo Dodero
e56bf2a407 Simplify solution 2017-07-08 17:10:56 -03:00
Juan Martín Sotuyo Dodero
fdd2a6b637 Merge branch 'pr-486' 2017-07-08 16:25:46 -03:00
Juan Martín Sotuyo Dodero
d8da47d9b9 Update changelog, refs #486 2017-07-08 16:23:17 -03:00
Andreas Dangel
6e084e7f27 Merge branch 'coveralls' 2017-07-08 20:46:41 +02:00
Andreas Dangel
e32e6e08d9 Add coveralls badge 2017-07-08 20:42:58 +02:00
Andreas Dangel
ce96da092a [doc] Remove jacoco report and surefire report for site generation 2017-07-08 20:33:02 +02:00
Andreas Dangel
e8dcbda839 [ci] Add coveralls.io
Updated jacoco, add maven profile "coveralls"
2017-07-08 20:30:25 +02:00
Juan Martín Sotuyo Dodero
f8c8c01c86 Avoid ArrayList instantiation 2017-07-08 15:12:35 -03:00
Andreas Dangel
d669395bab [core] Missing screenshot on "How to write a rule" doc
Fixes #480
2017-07-08 20:00:43 +02:00
Andreas Dangel
68046a0064 Merge branch 'issue-412' 2017-07-08 19:43:34 +02:00
Andreas Dangel
c6eeed6d48 Merge branch 'issue-412' of https://github.com/Monits/pmd into issue-412 2017-07-08 19:34:18 +02:00
Juan Martín Sotuyo Dodero
6f37c17565 Merge branch 'pr-490' 2017-07-08 13:59:08 -03:00
Andreas Dangel
8b109f9981 [ci] let's try the quiet option (-q) of maven
travis_wait_truncated doesn't work, since the pipes are buffered...
2017-07-08 13:10:32 +02:00
Andreas Dangel
e9ac18427a [ci] add a truncated travis_wait function
Since travis_wait outputs the "Still running" indication into the
same stream as the command's output, we need to make sure, we
output these indications to avoid a build timeout.
But to workaround the log size limit, we shouldn't output everything.
travis_wait_truncated now outputs the head immediately, while
only outputting the tail of the log after the command is finished.
2017-07-08 12:48:43 +02:00
Andreas Dangel
a3a1f1b30b [ci] add more logging during build-site.sh execution 2017-07-08 12:15:17 +02:00
Andreas Dangel
4efa375a06 Merge branch 'improve-travis' of https://github.com/Monits/pmd into pr-456 2017-07-08 11:49:25 +02:00
Andreas Dangel
ead8d964c5 [cpp] Undo changes to String literals in grammar, it's not needed anymore
Such slightly illegal char escape sequences can still be parsed now.
2017-07-08 11:48:06 +02:00
Andreas Dangel
5bcf30a2a4 [cpp] Add unit test to assert begin/end of Tokens with continuation 2017-07-08 11:32:54 +02:00
Andreas Dangel
ec631f3993 [cpp] Don't skip the continuation character in the grammar anymore
Since we now have a CppCharStream, we can remove the changes
introduced for #431
2017-07-07 23:11:27 +02:00
Andreas Dangel
9618481218 Update changelog, refs #448 2017-07-07 22:46:29 +02:00
Andreas Dangel
dbc2d02895 [cpp] Add custom CppCharStream for line continuation support
Fixes #448
2017-07-07 22:46:21 +02:00
Juan Martín Sotuyo Dodero
37f4be1a35 Merge branch 'pr-488' 2017-07-07 15:04:35 -03:00
Juan Martín Sotuyo Dodero
134de93257 Update changelog, be more explicit on Apex CPD changes 2017-07-07 15:04:15 -03:00
Andreas Dangel
c47866e474 [apex] Add test for Apex Lexer/Parser/Compiler
The compiler seems to have a problem with Soql expressions
See ApexCompilerSoqlTest
2017-07-07 10:54:52 +02:00
Andreas Dangel
2f69324a4a [apex] Upgrade Apex to use new jorje compiler v224
There are some AST changes:
* no DottedExpression anymore
* NewNameValueObjectExpression has been renamed to NewKeyValueObjectExpression
* no TestNode anymore
* new types: CastExpression, ConstructorPreamble, IllegalStoreExpression,
  MethodBlockStatement, Modifier, MultiStatement, NestedExpression,
  NestedSToreExpression, StatementExecuted
2017-07-07 10:54:23 +02:00
Andreas Dangel
02b2e3cf7a Update changelog, refs #488 2017-07-07 10:52:23 +02:00
Andreas Dangel
0f36c9ae2b [apex] CPD: Prepared option to switch on case sensitive check 2017-07-07 10:38:49 +02:00
Andreas Dangel
e669b28341 [apex] Adjust CPD Tests with using ApexLexer
Note: comments are comments now and not compared anymore
2017-07-07 10:38:49 +02:00
Andreas Dangel
c32cf3703a [apex] Use ApexLexer for CPD tokenizer 2017-07-07 10:38:49 +02:00
oowekyala
78edc46e48 Merge branch 'master' of https://github.com/pmd/pmd into metrics 2017-07-06 23:38:08 +02:00
oowekyala
a0ed1aab06 Documentation on AbstractNode 2017-07-06 23:37:08 +02:00
Juan Martín Sotuyo Dodero
50a2e9fdcf Fix typeresolution for anonymous extending object
- This is really an edge case, with little or no real-world scenarios,
just fix it for completeness
2017-07-06 18:00:07 -03:00
oowekyala
ff870e159e Small corrections 2017-07-06 14:48:38 +02:00
Bendegúz Nagy
0c483205da Java, typres: make MethodType immutable, remove getApplicableMethods overload 2017-07-05 21:19:45 +02:00
Bendegúz Nagy
2fd1c89ede Java, typeres: fix checkstyle and mvn tests 2017-07-05 19:49:29 +02:00
Bendegúz Nagy
4a16fbc9eb Java, typres: add more method tests 2017-07-05 18:46:23 +02:00
Bendegúz Nagy
ed9b015c9f Java, typres: fix mvntest 2017-07-05 13:57:50 +02:00
oowekyala
d90e2e75fb Fixed failing tests 2017-07-05 00:15:22 +02:00
Juan Martín Sotuyo Dodero
96003e31db Give more visibility to external contributors
- Acknowledge the amazing people behind each contribution
2017-07-04 12:15:15 -03:00
Juan Martín Sotuyo Dodero
02c3e0a6de Merge branch 'pr-484' 2017-07-04 12:11:49 -03:00
Juan Martín Sotuyo Dodero
087bf40fea Update changelog, refs #484 2017-07-04 12:11:10 -03:00
patriksevallius
111de11893 Changed linux usage to a more unix like path 2017-07-04 09:27:54 +02:00
Bendegúz Nagy
35597c9ef0 Java, typres: Add simple method type resolution 2017-07-04 00:06:32 +02:00
Bendegúz Nagy
0c2099ab98 Java, typeres: add method applicability tests 2017-07-03 19:48:45 +02:00
oowekyala
8fd95190b2 Removed AbstractSimpleJavaMetricsRule 2017-07-03 14:44:46 +02:00
oowekyala
cd2f414ace Merge branch 'master' of https://github.com/pmd/pmd into metrics 2017-07-02 15:58:34 +02:00
Andreas Dangel
6652ec9545 [travis] fix release script for upload site 2017-07-01 20:01:19 +02:00
Andreas Dangel
a271c49152 Merge branch 'pmd/5.8.x' 2017-07-01 19:27:43 +02:00
Andreas Dangel
7c9f438eaf Prepare next development version 2017-07-01 19:13:16 +02:00
Andreas Dangel
3ef33bc37e [maven-release-plugin] prepare for next development iteration 2017-07-01 19:08:17 +02:00
oowekyala
f65207639b Removed a change to CollectionUtil 2017-06-30 18:54:28 +02:00
oowekyala
a30449d475 Enhanced wrappers 2017-06-30 16:25:14 +02:00
oowekyala
2b56f54824 Cleaned up abstract metric 2017-06-30 13:32:38 +02:00
oowekyala
6a3b394aa0 Solve plugin errors 2017-06-28 23:59:22 +02:00
oowekyala
b103d8f011 Specialised BasicPropertyDescriptorFactory 2017-06-28 17:48:11 +02:00
oowekyala
c51cab446a Split interfaces 2017-06-27 15:45:33 +02:00
oowekyala
2fe8ded6bd Made properties final 2017-06-27 14:15:14 +02:00
oowekyala
40282e77ae Added NcssCountRule 2017-06-27 09:33:19 +02:00
oowekyala
bc8637d23e Use ParameterizedMetricKeys again 2017-06-27 08:01:50 +02:00
oowekyala
fbf72de7ca Rearranged code 2017-06-27 07:02:16 +02:00
oowekyala
d5f69e5f81 Simplified getter and setter detection 2017-06-27 07:01:32 +02:00
oowekyala
a4af2220ec Merge branch 'master' of https://github.com/pmd/pmd into metrics 2017-06-27 05:58:14 +02:00
oowekyala
de1298f1fa Corrected multinumeric properties 2017-06-27 05:57:45 +02:00
oowekyala
df59eb8977 Finally the enum transformation is complete 2017-06-27 05:55:17 +02:00
oowekyala
e1b12da174 Some documentation 2017-06-27 05:01:15 +02:00
oowekyala
68f869e81e Turned PropertyDescriptorFields into an enum
Fully commented multi valued properties
2017-06-26 23:51:50 +02:00
oowekyala
54f4a8647c Merge branch 'master' of https://github.com/pmd/pmd into typesafe-properties 2017-06-26 21:09:52 +02:00
oowekyala
1104b6cd49 Debugged tests 2017-06-26 21:08:53 +02:00
Juan Martín Sotuyo Dodero
affd0f7134 Update changelog, refs #469 2017-06-26 15:09:34 -03:00
Juan Martín Sotuyo Dodero
3c6eed61fc [java] Detect more unnecessary finals
- Mark unnecessary finals in anonymous class methods.
 - Mark unnecessary finals in enum instance methods.
 - Fixes #412
2017-06-26 15:03:23 -03:00
Juan Martín Sotuyo Dodero
d93c5ce676 Update changelog 2017-06-26 14:13:35 -03:00
Juan Martín Sotuyo Dodero
80f901187a Merge branch 'pr-379' 2017-06-26 14:11:35 -03:00
Juan Martín Sotuyo Dodero
4da86f2b8e Document API changes 2017-06-26 13:08:14 -03:00
Juan Martín Sotuyo Dodero
df80e52788 Merge branch 'pr-420' 2017-06-26 13:04:53 -03:00
Juan Martín Sotuyo Dodero
cd5ec52250 Update changelog, refs #420 2017-06-26 13:03:28 -03:00
oowekyala
739dccfcca Refactored AbstractPropertyTester and subclasses
Still fails test though
2017-06-26 16:03:35 +02:00
oowekyala
bb8fe903ea Generified PropertyDescriptorFactory 2017-06-26 15:12:14 +02:00
oowekyala
785d663553 Finished refactoring properties 2017-06-26 14:22:10 +02:00
oowekyala
b2673b38b5 POC on boolean and enumerated properties 2017-06-25 21:11:00 +02:00
oowekyala
578bbf8f7b Draft for the new API 2017-06-25 17:40:16 +02:00
Juan Martín Sotuyo Dodero
042672c8f5 Add missing tail 2017-06-24 17:31:58 -03:00
Andreas Dangel
7f1292b212 Update version to 6.0.0-SNAPSHOT 2017-06-24 22:29:36 +02:00
Juan Martín Sotuyo Dodero
c9990a53cb Adopt feedback 2017-06-24 17:28:40 -03:00
oowekyala
2346176fe5 Added tests for LOC 2017-06-24 22:25:30 +02:00
oowekyala
3ecc9be86f Added tests for WMC 2017-06-24 22:09:00 +02:00
oowekyala
ccb375d126 Merge branch 'master' of https://github.com/pmd/pmd into metrics 2017-06-24 22:01:31 +02:00
oowekyala
db2fd2f3a5 Consider annotation types 2017-06-24 18:54:53 +02:00
oowekyala
217b65ba5e Refactored CyclomaticComplexityRule into a MetricsRule 2017-06-24 18:09:32 +02:00
oowekyala
8e005f95a8 Deleted ParameterizedMetricKey 2017-06-24 17:32:51 +02:00
oowekyala
df68816b6d Signatures equals now checks identity 2017-06-24 00:12:43 +02:00
oowekyala
6ab9088759 Tests for NCSS + reduced visitor adapter 2017-06-23 23:55:16 +02:00
oowekyala
4ec86558a7 Added support for enums 2017-06-23 23:28:11 +02:00
oowekyala
b302a9a6ba Added test for standard CYCLO 2017-06-23 18:25:49 +02:00
Juan Martín Sotuyo Dodero
66bed6779c [ci] Improve Travis builds
- use travis_wait for long running tasks with no output
 - enable fast-finish to abort all builds if one fails
2017-06-21 21:25:38 -03:00
oowekyala
371aba37b1 Use EnumSet for NodeType 2017-06-13 15:12:26 +02:00
oowekyala
0568de5daf Use name() in place of description in NodeType 2017-06-01 03:34:19 +02:00
oowekyala
fc1c0e5c4b Checkstyle fix 2017-05-31 23:00:07 +02:00
oowekyala
7af9c2344b Fixed #408 - UR anomaly in assert statements 2017-05-31 22:55:18 +02:00
oowekyala
d27e899933 Made CurrentPath iterable 2017-05-31 22:30:27 +02:00
oowekyala
f82294ca5d Factored logging messages 2017-05-31 22:15:00 +02:00
oowekyala
daa54876ea Checkstyle fixes 2017-05-31 21:49:29 +02:00
oowekyala
3c1162b393 Removed ids 2017-05-31 21:30:08 +02:00
oowekyala
435f6ce16e Changed NodeType to an enum 2017-05-31 21:27:44 +02:00
Andreas Dangel
6a27ac55a7 Rename pages so the "Edit me" link is working 2017-05-25 13:13:25 +02:00
Andreas Dangel
97bfcf49fc Add folder properties, so that "Edit me" link works correctly 2017-05-25 13:04:24 +02:00
Andreas Dangel
4c41e1e8a4 Add "--rm=true" flag for running docker 2017-05-25 12:39:40 +02:00
Andreas Dangel
7ee6284ec2 Change github edit button temporarily to point to adangel/pmd 2017-05-25 12:37:55 +02:00
Andreas Dangel
ae7be0539c Add more release notes 2017-05-25 12:35:02 +02:00
Andreas Dangel
70ab4f2468 Restructure pages: product is now "pmd", sidebar new, pages moved
Removed the samples mydoc, product1, product2
2017-05-25 12:16:23 +02:00
Andreas Dangel
624705bd70 Info about using docker 2017-05-25 11:12:17 +02:00
Andreas Dangel
f0df36517e Update sidebar structure 2017-05-25 11:12:08 +02:00
Andreas Dangel
b14da68b5a Update theme from https://github.com/tomjohnson1492/documentation-theme-jekyll 2017-05-25 10:22:39 +02:00
Andreas Dangel
b193bb28d8 Add 'docs/' from commit '106142b25c9387ffd002437027ced1b04f494205'
git-subtree-dir: docs
git-subtree-mainline: 23545aa7ea
git-subtree-split: 106142b25c
2017-05-25 10:01:42 +02:00
Andreas Dangel
051bee9192 Fixes #1513 [java] Remove deprecated rule UseSingleton 2017-05-05 11:52:12 +02:00
Robert Sösemann
b97462fa24 Make Time to fix property work for XPath rules 2017-04-24 12:22:23 +02:00
Robert Sösemann
b3046de6ee Fix Checkstyle issues 2017-04-24 11:54:10 +02:00
Robert Sösemann
0096700a66 https://github.com/pmd/pmd/pull/329#discussion_r112703324 2017-04-21 17:17:44 +02:00
Robert Sösemann
a575910cdd Made CODACY_TIME_TO_FIX property static final 2017-04-21 11:26:20 +02:00
Robert Sösemann
9d0c4d2c8e Define new Codacy.com specific property for Apex rulesets 2017-04-20 11:46:40 +02:00
Robert Sösemann
cc9edda049 Add custom rule property for Codacy.com plus minor adjustments 2017-04-06 15:27:02 +02:00
Anand
4e0dd619b6 Remove dependency from pmd test 2017-04-03 00:17:48 -07:00
Anand
9aa8bfaa41 Add rule preventing the use of non existent annotations in apex 2017-04-03 00:16:04 -07:00
Anand
fe5f0daef9 merge 2017-04-01 19:48:00 -07:00
Anand
cd10daba18 Merge remote-tracking branch 'Up2Go/master' 2017-04-01 17:38:48 -07:00
JosephAllen
106142b25c Update index.md 2016-09-12 16:46:12 -04:00
JosephAllen
e88c2bde90 Updated Favicon 2016-09-10 18:33:44 -04:00
JosephAllen
b48228044d uploaded favicon.ico 2016-09-10 18:29:55 -04:00
JosephAllen
120eca7224 Removed favicon 2016-09-10 18:26:31 -04:00
JosephAllen
d20d5e3615 Adding Favicon 2016-09-10 18:25:29 -04:00
JosephAllen
ecf75728fa Minor text updates 2016-09-10 17:15:09 -04:00
JosephAllen
423e032a86 Udpated How it works page 2016-09-10 17:13:43 -04:00
JosephAllen
b2a3725a8f Changed Index page label on Sidebar 2016-09-10 17:06:01 -04:00
JosephAllen
1c2727166c Udpated Sidebar 2016-09-10 16:30:29 -04:00
JosephAllen
d3b5c22433 Added How it works to Sidbar 2016-09-10 16:28:00 -04:00
JosephAllen
19b15cb37a Formatting Updates 2016-09-10 00:27:22 -04:00
JosephAllen
0ff3645f71 Major Documentation Updates 2016-09-10 00:07:47 -04:00
JosephAllen
713a9e091e Added Customizing Pages 2016-09-09 20:27:54 -04:00
JosephAllen
a729ab11b5 Updated Relase Notes 2016-09-09 17:11:22 -04:00
JosephAllen
0cfe784b63 Update README.md 2016-09-07 22:26:46 -04:00
JosephAllen
f55a1ddf06 Update for image handling 2016-09-07 22:24:55 -04:00
JosephAllen
e77e8bf65f Many Updates 2016-09-07 22:17:39 -04:00
JosephAllen
d69b9f8ad0 Notes Update 2016-09-07 21:12:28 -04:00
JosephAllen
f06290e348 5.4.0 Release Notes 2016-09-07 21:09:55 -04:00
JosephAllen
52109dda2c New Release Note 2016-09-07 21:06:21 -04:00
JosephAllen
3e47866b9e Deleted Deprecated Pages 2016-09-07 20:56:30 -04:00
JosephAllen
de0e9cce62 Sidebar Update 2016-09-07 20:54:28 -04:00
JosephAllen
33a385ce1e Updated Release Notes 2016-09-07 20:52:34 -04:00
JosephAllen
63b59fbe67 Update README.md 2016-09-07 20:45:41 -04:00
JosephAllen
a8517daf85 Update README.md 2016-09-07 20:45:17 -04:00
JosephAllen
5783e262f8 Release Notes Update 2016-09-07 20:41:14 -04:00
JosephAllen
a007e89659 Release Notes as Blog Posts 2016-09-07 20:29:11 -04:00
JosephAllen
bba201d44e Sidebar Update 2016-09-07 20:24:18 -04:00
JosephAllen
323a3e5943 New Release Notes Path 2016-09-07 20:22:40 -04:00
JosephAllen
5be5088b4e Removed Deprecated Pages 2016-09-07 20:12:09 -04:00
JosephAllen
53730a6713 Sidebar udpate 2016-09-07 20:10:22 -04:00
JosephAllen
08dfa205db Release Notes 2016-09-07 20:09:35 -04:00
JosephAllen
df382d4425 Release Notes 2016-09-07 20:08:44 -04:00
JosephAllen
7aaab9c276 5.4.1 release notes 2016-09-07 20:07:27 -04:00
JosephAllen
cdb0daa2f8 Updates 2016-09-07 20:03:00 -04:00
JosephAllen
8db0d07e54 Release Notes 2016-09-07 20:01:53 -04:00
JosephAllen
f4ed395924 Added 5.4.2 Release notes 2016-09-07 20:00:50 -04:00
JosephAllen
db73069a3b Updates for the release notes path 2016-09-07 19:55:16 -04:00
JosephAllen
b7542f559f Udpates to Support Custom Tags 2016-09-07 19:32:46 -04:00
JosephAllen
9c43cb3d08 Create new Tag page 2016-09-07 19:24:26 -04:00
JosephAllen
c4800b8369 Again 2016-09-07 19:21:40 -04:00
JosephAllen
889978dfed Changelog 2016-09-07 19:18:03 -04:00
JosephAllen
5c084d453a More 2016-09-07 19:15:21 -04:00
JosephAllen
0a010fc548 More 2016-09-07 19:12:54 -04:00
JosephAllen
7f55f4aedc MOre Udpates 2016-09-07 19:11:47 -04:00
JosephAllen
1d41c98808 Updated Release Notes 2016-09-07 19:10:38 -04:00
JosephAllen
0806e645bc Updated Release Notes 2016-09-07 19:07:45 -04:00
JosephAllen
1b08556aec Updated Sidebar 2016-09-07 18:54:46 -04:00
JosephAllen
4e2ca2b898 More condif Updates 2016-09-07 18:52:38 -04:00
JosephAllen
f73ada0698 More Udpates 2016-09-07 18:49:48 -04:00
JosephAllen
a98a96307f Updated Config 2016-09-07 18:48:38 -04:00
JosephAllen
25043414d4 Index Update 2016-09-07 18:33:08 -04:00
JosephAllen
c8d4ee8fae Updating Theme 2016-09-07 18:23:55 -04:00
JosephAllen
af06642705 Updated mydoc_introduction.md 2016-09-07 18:13:46 -04:00
JosephAllen
e947459280 Updated intro 2016-09-07 17:41:23 -04:00
JosephAllen
15eb11732d Updated GemLock 2016-09-07 17:33:21 -04:00
JosephAllen
150e143dd4 Moved Site file back 2016-09-07 17:29:50 -04:00
JosephAllen
327192d2a5 Moved Read.md 2016-09-07 17:21:58 -04:00
JosephAllen
e41a3c0f2c Removed Unneeded file 2016-09-07 17:21:00 -04:00
JosephAllen
4007247f11 Moved to Site folder to Match Current Site 2016-09-07 17:20:24 -04:00
JosephAllen
73e79c67dc Test 2016-09-07 17:19:09 -04:00
JosephAllen
62ede752c5 Setup 2016-09-07 17:18:31 -04:00
JosephAllen
a902912b59 Update mydoc_introduction.md 2016-09-07 16:45:47 -04:00
JosephAllen
6fe7eab7ac Update mydoc_introduction.md 2016-09-07 16:45:19 -04:00
Joseph Allen
24eaf59199 3rd Committ 2016-09-07 16:43:10 -04:00
Joseph Allen
4af5170365 2nd Commit 2016-09-07 16:39:23 -04:00
Joseph Allen
c0fee28409 1st Committ 2016-09-07 16:10:48 -04:00
JosephAllen
91058640f0 Initial commit 2016-09-07 14:32:22 -04:00
2653 changed files with 144922 additions and 54435 deletions

View File

@@ -1,6 +1,9 @@
Please, prefix the report title with the language it applies to within brackets, such as *[java]* or *[apex]*. If not specific to a language, you can use *[core]*
<!-- Please, prefix the report title with the language it applies to within brackets, such as [java] or [apex].
If not specific to a language, you can use [core]. -->
**Rule Set:**
**Affects PMD Version:**
**Rule:**
**Description:**
@@ -12,3 +15,4 @@ Please, prefix the report title with the language it applies to within brackets,
**Running PMD through:** *[CLI | Ant | Maven | Gradle | Designer | Other]*
<!-- If relevant, also include your JDK and OS information, e.g. for ClassNotFoundException, LinkageError, reflection failures, etc. -->

View File

@@ -2,8 +2,9 @@ Please, prefix the PR title with the language it applies to within brackets, suc
Before submitting a PR, please check that:
- [ ] The PR is submitted against `master`. The PMD team will merge back to support branches as needed.
- [ ] `mvn test` passes.
- [ ] `mvn checkstyle:check` passes. [Check this for more info](https://github.com/pmd/pmd/blob/master/CONTRIBUTING.md#code-style)
- [ ] `./mvnw test` passes.
- [ ] `./mvnw pmd:check` passes.
- [ ] `./mvnw checkstyle:check` passes. [Check this for more info](https://github.com/pmd/pmd/blob/master/CONTRIBUTING.md#code-style)
**PR Description:**

1
.gitignore vendored
View File

@@ -10,3 +10,4 @@ bin/
.idea
*.patch
*/src/site/site.xml
pmd-core/dependency-reduced-pom.xml

Binary file not shown.

View File

@@ -1 +1 @@
distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.0/apache-maven-3.5.0-bin.zip
distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.4/apache-maven-3.5.4-bin.zip

View File

@@ -1,16 +1,11 @@
dist: trusty
sudo: false
addons:
apt:
packages:
- oracle-java8-installer
ssh_known_hosts:
- web.sourceforge.net
language: java
jdk: oraclejdk8
env:
global:
- secure: KBEuB6U1p5RQXSYe157AwydFr/zpXQPA0IChVCgZV+X1mMyy9ZtrjH1J1AXuviseDDXDbaT25sRnsvpl82rfRw2xOkMGXHy4N95/ylTSr8DjHxTao71BhXsvFycNobFva5y2EGNWqDvpS8I2oSZo7Qk4la3yep3rcJQvcy6RDbbhpDTbL1QMFyadunIBm0WtqbunrMqtjSqaoPsXz8TiQuxHvX4vEXzVbaxV1QQt79Vi+daa6wAV3mRQAugnx+UffsC8JqMxgm06usWeJgCJzxgm8E7clZCLmf53B2TL8dK6bIYbqyvOY3uFxitsTG0d8Z0GOJwXBgZNgbniTRO8ZJSty5eZP8LBybbjVLSL25DNTWtCjADUL/uySnXIEidlMt2N/3QmH7zrGAfAk/tIwKpdRca2GLLydeXf6PSkiahnPEkIY/QupcsOLELhdifpdOjb8QW1OenA+vUbNM9dccLwKnX6Fj9cu4VQG601AcYDr2eyhq8WYkr3wYdw/6KdUa3hmplowTBs+qguppP+eOSgGuEsy38KLtqnvm6WlHy6tcLmcVYKG3DmR1b7TWXsOXC6/VMH8BHBkvsF1QdRg9+Cgx07vX3Hw7roPiYzmaO9Ajs20ATsUfRskMuWCTeTSK5pN8X27veRCZlhFjeKQMDdmfVwzpAfRgKsl3TEn1I=
@@ -23,15 +18,21 @@ env:
- secure: "JIhuqaI0i+zvuqqXiQBHpuKr7AQ8jfk6Gbr8Qgiq4yJtdEWXZGxnAT9BmlbjkgT7ABXvLgxf2CIdUOMo1yYfBlxQL/y5+e89jaVpYF3tvNAzYQ1e12VzQRsd/jDb7qvm7tw3rDHEn3dSEot7Q6KbPcL6WzWJINVMCCmOgvq9gKHgE6Y5q5EgZ5rxiXyuO27ndzcbxaor4PIaiSzHO9+AJQ7p2zDLP+kG4nKVTBX0l9VoKiYFhIpIhpbigi3jyLDMDRiWpwTWZC6P8/RXfZg/lc5ADOuM2DM8oXPpZuqOa/g31LWQOSCuEnQ1G16vbLgipSPpgAc7jYWD5cywhG9dLkiKaZDh5x0meLM2RoAgz6eAnQfTTqJ68OM9o9yXjubEedsNpNRAr9/DXMd+fbh10W2vbvL5HCNB3lic3anehhR9le7PLuEKxg654wXt3KM2PZGVWbotIyBK0CvGzqGkppvwT23QdDDqSdkWuGQIhGQ0xBOdYkwebycxP5wwPUmObG+mymQ1Be2BXvmghttsiJdKlt4CVSYOJUMus6kU32G95hdTgKblsX4J1Of2i1nYsjyMKh3k945tqXwQrIsxOOQug0oIkz24zlLaOaQcorWtJ6Y1HPaZKpVIFUEF0y8Uq/O4oB2bOYC6WDUQfpj7nRG6xbi+BeBS84m1ttCEk4g="
matrix:
- BUILD=deploy
- BUILD=site
- BUILD=doc
- BUILD=sonar
- BUILD=coveralls
matrix:
fast_finish: true
before_install:
- wget https://github.com/sormuras/bach/raw/master/install-jdk.sh
- bash .travis/setup-secrets.sh
- bash .travis/configure-maven.sh
install: true
# Install OracleJDK 10 - see https://sormuras.github.io/blog/2018-03-20-jdk-matrix.html
install: . ./install-jdk.sh -F 10 -L BCL
before_script: true
script: bash .travis/build-$BUILD.sh
script: source .travis/build-$BUILD.sh
after_success: true
@@ -42,7 +43,7 @@ deploy:
file_glob: true
file:
- pmd-dist/target/pmd-*.zip
- target/pmd-doc-*.zip
- docs/pmd-doc-*.zip
skip_cleanup: true
on:
tags: true
@@ -51,10 +52,17 @@ deploy:
after_deploy: bash .travis/release.sh
notifications:
webhooks:
urls:
- https://webhooks.gitter.im/e/0e6dd310db54b96c2653
- https://webhooks.gitter.im/e/65efc1ea65175ad23ab6
on_success: always # options: [always|never|change] default: always
on_failure: always # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always
email:
recipients:
- adangel@users.sourceforge.net
on_success: always
- andreas.dangel@adangel.org
on_success: change
on_failure: always
cache:
directories:

View File

@@ -1,43 +0,0 @@
#
# Helper functions to run a chatty, long task in the background,
# redirecting the output to file and keep travis happy by regularly
# writing to the log.
#
# This is to workaround the travis log length limit of 4MB
# Solution from http://stackoverflow.com/questions/26082444/how-to-work-around-travis-cis-4mb-output-limit/26082445#26082445
#
# Source this file into the shell script, that needs it.
#
# expected variables
# Name | Example Value
# PING_SLEEP | 30s
# BUILD_OUTPUT | /tmp/build-step-logfile.out
# PING_PID_FILE | /tmp/build-step-ping.pid
touch $BUILD_OUTPUT
dump_output() {
echo Tailing the last 100 lines of output:
tail -100 $BUILD_OUTPUT
}
kill_ping() {
if [ -e $PING_PID_FILE ]; then
PING_LOOP_PID=$(cat $PING_PID_FILE)
kill $PING_LOOP_PID
rm $PING_PID_FILE
fi
}
error_handler() {
kill_ping
echo ERROR: An error was encountered with the build.
dump_output
exit 1
}
# If an error occurs, run our error handler to output a tail of the build
trap 'error_handler' ERR
# Set up a repeating loop to send some output to Travis.
bash -c "while true; do echo \$(date) - building ...; sleep $PING_SLEEP; done" &
PING_LOOP_PID=$!
echo "$PING_LOOP_PID" > $PING_PID_FILE

33
.travis/build-coveralls.sh Executable file
View File

@@ -0,0 +1,33 @@
#!/bin/bash
set -e
source .travis/logger.sh
source .travis/common-functions.sh
VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
log_info "Building PMD Coveralls.io report ${VERSION} on branch ${TRAVIS_BRANCH}"
if ! travis_isPush; then
echo "Not proceeding, since this is not a push!"
exit 0
fi
#
# for java9: enable all modules.
# coveralls plugin seems to need java.xml.bind module
echo "MAVEN_OPTS='-Xms1g -Xmx1g --add-modules java.se.ee'" > ${HOME}/.mavenrc
(
# disable fast fail, exit immediately, in this subshell
set +e
./mvnw clean install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
./mvnw test jacoco:report coveralls:report -Pcoveralls -B -V
if [ $? -ne 0 ]; then
log_error "Error creating coveralls report"
else
log_success "New coveralls result: https://coveralls.io/github/pmd/pmd"
fi
true
)

71
.travis/build-deploy.sh Normal file → Executable file
View File

@@ -1,37 +1,78 @@
#!/bin/bash
set -e
source .travis/logger.sh
source .travis/common-functions.sh
function push_docs() {
if git diff --quiet docs; then
log_info "No changes in docs..."
else
log_info "Found changes in docs..."
if [ "$TRAVIS_BRANCH" == "master" ]; then
git config user.name "Travis CI (pmd-bot)"
git config user.email "andreas.dangel+pmd-bot@adangel.org"
git add -A docs
git commit -m "Update documentation"
git push git@github.com:pmd/pmd.git HEAD:master
log_success "Successfully pushed docs update"
else
log_info "Not on master branch, won't commit+push"
fi
fi
}
VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
echo "Building PMD ${VERSION} on branch ${TRAVIS_BRANCH}"
log_info "Building PMD ${VERSION} on branch ${TRAVIS_BRANCH}"
MVN_BUILD_FLAGS="-B -V"
if travis_isPullRequest; then
echo "This is a pull-request build"
./mvnw verify -B -V
log_info "This is a pull-request build"
./mvnw verify $MVN_BUILD_FLAGS
elif travis_isPush; then
if [[ "$VERSION" != *-SNAPSHOT && "$TRAVIS_TAG" != "" ]]; then
echo "This is a release build for tag $TRAVIS_TAG"
./mvnw deploy -Possrh,pmd-release -B -V
elif [[ "$VERSION" == *-SNAPSHOT ]]; then
echo "This is a snapshot build"
./mvnw deploy -Possrh -B -V
if [[ "${VERSION}" != *-SNAPSHOT && "${TRAVIS_TAG}" != "" ]]; then
echo -e "\n\n"
log_info "This is a release build for tag ${TRAVIS_TAG}"
echo -e "\n\n"
./mvnw deploy -Possrh,pmd-release $MVN_BUILD_FLAGS
elif [[ "${VERSION}" == *-SNAPSHOT ]]; then
log_info "This is a snapshot build"
./mvnw deploy -Possrh $MVN_BUILD_FLAGS
push_docs
else
# other build. Can happen during release: the commit with a non snapshot version is built, but not from the tag.
echo "This is some other build, probably during release: commit with a non-snapshot version on branch master..."
./mvnw verify -Possrh -B -V
log_info "This is some other build, probably during release: commit with a non-snapshot version on branch master..."
./mvnw verify $MVN_BUILD_FLAGS
# we stop here - no need to execute further steps
exit 0
fi
# Uploading pmd distribution to sourceforge
rsync -avh pmd-dist/target/pmd-*-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
rsync -avh src/site/markdown/overview/changelog.md ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/ReadMe.md
(
# disable fast fail, exit immediately, in this subshell
set +e
echo -e "\n\n"
log_info "Uploading pmd distribution to sourceforge..."
rsync -avh pmd-dist/target/pmd-*-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
if [ $? -ne 0 ]; then
log_error "Error while uploading pmd-*-${VERSION}.zip to sourceforge!"
log_error "Please upload manually: https://sourceforge.net/projects/pmd/files/pmd/"
fi
rsync -avh docs/pages/release_notes.md ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/ReadMe.md
if [ $? -ne 0 ]; then
log_error "Error while uploading release_notes.md as ReadMe.md to sourceforge!"
log_error "Please upload manually: https://sourceforge.net/projects/pmd/files/pmd/"
fi
true
)
else
echo "This is neither a pull request nor a push!"
log_info "This is neither a pull request nor a push. Not executing any build."
exit 1
fi

82
.travis/build-doc.sh Executable file
View File

@@ -0,0 +1,82 @@
#!/bin/bash
set -e
source .travis/logger.sh
source .travis/common-functions.sh
VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
log_info "Building PMD Documentation ${VERSION} on branch ${TRAVIS_BRANCH}"
if ! travis_isPush; then
log_info "Not building site, since this is not a push!"
exit 0
fi
pushd docs
# run jekyll
echo -e "\n\n"
log_info "Building documentation using jekyll..."
bundle install
bundle exec jekyll build
# create pmd-doc archive
echo -e "\n\n"
log_info "Creating pmd-doc archive..."
mv _site pmd-doc-${VERSION}
zip -qr pmd-doc-${VERSION}.zip pmd-doc-${VERSION}/
(
# disable fast fail, exit immediately, in this subshell
set +e
if [[ "${TRAVIS_TAG}" != "" || "${VERSION}" == *-SNAPSHOT ]]; then
echo -e "\n\n"
log_info "Uploading pmd doc distribution to sourceforge..."
rsync -avh pmd-doc-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
if [ $? -ne 0 ]; then
log_error "Couldn't upload pmd-doc-${VERSION}.zip!"
log_error "Please upload manually: https://sourceforge.net/projects/pmd/files/pmd/"
fi
fi
# rsync site to pmd.sourceforge.net/snapshot
if [[ "${VERSION}" == *-SNAPSHOT && "${TRAVIS_BRANCH}" == "master" ]] && has_docs_change; then
echo -e "\n\n"
log_info "Uploading snapshot site to pmd.sourceforge.net/snapshot..."
travis_wait rsync -ah --stats --delete pmd-doc-${VERSION}/ ${PMD_SF_USER}@web.sourceforge.net:/home/project-web/pmd/htdocs/snapshot/
if [ $? -ne 0 ]; then
log_error "Couldn't upload the snapshot documentation. It won't be current on http://pmd.sourceforge.net/snapshot/"
else
log_success "Successfully uploaded snapshot documentation: http://pmd.sourceforge.net/snapshot/"
fi
fi
true
)
#
# Push the generated site to gh-pages branch
#
if [[ "${VERSION}" == *-SNAPSHOT && "${TRAVIS_BRANCH}" == "master" ]] && has_docs_change; then
echo -e "\n\n"
log_info "Pushing the new site to github pages..."
git clone --branch gh-pages --depth 1 git@github.com:pmd/pmd.git pmd-gh-pages
# clear the files first
rm -rf pmd-gh-pages/*
# copy the new site
cp -a pmd-doc-${VERSION}/* pmd-gh-pages/
(
cd pmd-gh-pages
git config user.name "Travis CI (pmd-bot)"
git config user.email "andreas.dangel+pmd-bot@adangel.org"
git add -A
git commit -q -m "Update documentation"
git push git@github.com:pmd/pmd.git HEAD:gh-pages
log_success "Successfully pushed site to https://pmd.github.io/pmd/"
)
fi
popd

View File

@@ -1,63 +0,0 @@
#!/bin/bash
set -e
source .travis/common-functions.sh
VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
echo "Building PMD Site ${VERSION} on branch ${TRAVIS_BRANCH}"
if ! travis_isPush; then
echo "Not building site, since this is not a push!"
exit 0
fi
(
export PING_SLEEP=30s
export BUILD_OUTPUT=/tmp/build-site.out
export PING_PID_FILE=/tmp/build-site-ping.pid
source .travis/background-job-funcs.sh
# Run the build, redirect output into the file
./mvnw install -DskipTests=true -B -V >> $BUILD_OUTPUT 2>&1
./mvnw site site:stage -Psite -B -V >> $BUILD_OUTPUT 2>&1
# The build finished without returning an error so dump a tail of the output
dump_output
# nicely terminate the ping output loop
kill_ping
)
# create pmd-doc archive
(
cd target
mv staging pmd-doc-${VERSION}
zip -qr pmd-doc-${VERSION}.zip pmd-doc-${VERSION}/
)
# Uploading pmd doc distribution to sourceforge
if [[ "$TRAVIS_TAG" != "" || "$VERSION" == *-SNAPSHOT ]]; then
rsync -avh target/pmd-doc-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
fi
(
if [[ "$VERSION" == *-SNAPSHOT && "$TRAVIS_BRANCH" == "master" ]]; then
# this can take very long and no output is generated. therefore use the background job again
export PING_SLEEP=30s
export BUILD_OUTPUT=/tmp/build-site-upload.out
export PING_PID_FILE=/tmp/build-site-upload-ping.pid
source .travis/background-job-funcs.sh
# Uploading snapshot site...
rsync -ah --stats --delete target/pmd-doc-${VERSION}/ ${PMD_SF_USER}@web.sourceforge.net:/home/project-web/pmd/htdocs/snapshot/
# The build finished without returning an error so dump a tail of the output
dump_output
# nicely terminate the ping output loop
kill_ping
fi
)

32
.travis/build-sonar.sh Normal file → Executable file
View File

@@ -1,29 +1,33 @@
#!/bin/bash
set -e
source .travis/logger.sh
source .travis/common-functions.sh
VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
echo "Building PMD Sonar ${VERSION} on branch ${TRAVIS_BRANCH}"
log_info "Building PMD Sonar ${VERSION} on branch ${TRAVIS_BRANCH}"
if ! travis_isPush; then
echo "Not updating sonar, since this is not a push!"
exit 0
fi
#
# for java9: enable all modules.
# sonar plugin seems to need java.xml.bind module
echo "MAVEN_OPTS='-Xms1g -Xmx1g --add-modules java.se.ee'" > ${HOME}/.mavenrc
export PING_SLEEP=30s
export BUILD_OUTPUT=/tmp/build-sonar.out
export PING_PID_FILE=/tmp/build-sonar-ping.pid
(
# disable fast fail, exit immediately, in this subshell
set +e
source .travis/background-job-funcs.sh
# Run the build, redirect output into the file
./mvnw clean org.jacoco:jacoco-maven-plugin:prepare-agent package sonar:sonar -Dsonar.host.url=https://sonarqube.com -Dsonar.login=${SONAR_TOKEN} -B -V >> $BUILD_OUTPUT 2>&1
# The build finished without returning an error so dump a tail of the output
dump_output
# nicely terminate the ping output loop
kill_ping
# Run the build
./mvnw clean org.jacoco:jacoco-maven-plugin:prepare-agent package sonar:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=${SONAR_TOKEN} -B -V
if [ $? -ne 0 ]; then
log_error "Error updating sonar..."
else
log_success "New sonar results: https://sonarcloud.io/dashboard?id=net.sourceforge.pmd%3Apmd"
fi
true
)

31
.travis/common-functions.sh Normal file → Executable file
View File

@@ -2,18 +2,17 @@
set -e
echo "TRAVIS_REPO_SLUG: $TRAVIS_REPO_SLUG"
echo "TRAVIS_PULL_REQUEST_SLUG: $TRAVIS_PULL_REQUEST_SLUG"
echo "TRAVIS_PULL_REQUEST_BRANCH: $TRAVIS_PULL_REQUEST_BRANCH"
echo "TRAVIS_PULL_REQUEST: $TRAVIS_PULL_REQUEST"
echo "TRAVIS_SECURE_ENV_VARS: $TRAVIS_SECURE_ENV_VARS"
echo "TRAVIS_BRANCH: $TRAVIS_BRANCH"
echo "TRAVIS_TAG: $TRAVIS_TAG"
echo "TRAVIS_ALLOW_FAILURE: $TRAVIS_ALLOW_FAILURE"
echo "TRAVIS_REPO_SLUG: ${TRAVIS_REPO_SLUG}"
echo "TRAVIS_PULL_REQUEST_SLUG: ${TRAVIS_PULL_REQUEST_SLUG}"
echo "TRAVIS_PULL_REQUEST_BRANCH: ${TRAVIS_PULL_REQUEST_BRANCH}"
echo "TRAVIS_PULL_REQUEST: ${TRAVIS_PULL_REQUEST}"
echo "TRAVIS_SECURE_ENV_VARS: ${TRAVIS_SECURE_ENV_VARS}"
echo "TRAVIS_BRANCH: ${TRAVIS_BRANCH}"
echo "TRAVIS_TAG: ${TRAVIS_TAG}"
echo "TRAVIS_ALLOW_FAILURE: ${TRAVIS_ALLOW_FAILURE}"
function travis_isPullRequest() {
if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then
if [ "${TRAVIS_REPO_SLUG}" != "pmd/pmd" ] || [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
return 0
else
return 1
@@ -21,9 +20,19 @@ function travis_isPullRequest() {
}
function travis_isPush() {
if [ "$TRAVIS_PULL_REQUEST" = "false" ] && [ "${TRAVIS_SECURE_ENV_VARS}" = "true" ]; then
if [ "${TRAVIS_REPO_SLUG}" = "pmd/pmd" ] && [ "${TRAVIS_PULL_REQUEST}" = "false" ] && [ "${TRAVIS_SECURE_ENV_VARS}" = "true" ]; then
return 0
else
return 1
fi
}
function has_docs_change() {
if [[ $(git diff --name-only ${TRAVIS_COMMIT_RANGE}) = *"docs/"* ]]; then
log_info "Checking for changes in docs/ (TRAVIS_COMMIT_RANGE=${TRAVIS_COMMIT_RANGE}): changes found"
return 0
else
log_info "Checking for changes in docs/ (TRAVIS_COMMIT_RANGE=${TRAVIS_COMMIT_RANGE}): no changes"
return 1
fi
}

7
.travis/configure-maven.sh Normal file → Executable file
View File

@@ -1,7 +1,6 @@
#!/bin/bash
set -e
echo "MAVEN_OPTS='-Xms1g -Xmx1g'" > $HOME/.mavenrc
mkdir -p $HOME/.m2
cp .travis/travis-toolchains.xml $HOME/.m2/toolchains.xml
cp .travis/travis-settings.xml $HOME/.m2/settings.xml
echo "MAVEN_OPTS='-Xms1g -Xmx1g'" > ${HOME}/.mavenrc
mkdir -p ${HOME}/.m2
cp .travis/travis-settings.xml ${HOME}/.m2/settings.xml

18
.travis/logger.sh Normal file
View File

@@ -0,0 +1,18 @@
#!/bin/bash
COL_GREEN="\e[32m"
COL_RED="\e[31m"
COL_RESET="\e[0m"
COL_YELLOW="\e[33;1m"
function log_error() {
echo -e "${COL_RED}[ERROR] $*${COL_RESET}"
}
function log_info() {
echo -e "${COL_YELLOW}[INFO] $*${COL_RESET}"
}
function log_success() {
echo -e "${COL_GREEN}[SUCCESS] $*${COL_RESET}"
}

68
.travis/release.sh Normal file → Executable file
View File

@@ -1,24 +1,38 @@
#!/bin/bash
set -e
source .travis/logger.sh
echo "BUILD: $BUILD"
RELEASE_VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
echo "RELEASE_VERSION: $RELEASE_VERSION"
if [ "${BUILD}" = "deploy" ]; then
RELEASE_VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
# Deploy to ossrh has already been done with the usual build. See build-deploy.sh
# The site has been built before, the files have already been uploaded to sourceforge.
# Since this is a release, making the binary the new default file...
curl -H "Accept: application/json" -X PUT -d "default=windows&default=mac&default=linux&default=bsd&default=solaris&default=others" \
-d "api_key=${PMD_SF_APIKEY}" https://sourceforge.net/projects/pmd/files/pmd/${RELEASE_VERSION}/pmd-bin-${RELEASE_VERSION}.zip
(
# disable fast fail, exit immediately, in this subshell
set +e
# The site has been built before, the files have already been uploaded to sourceforge.
# Since this is a release, making the binary the new default file...
log_info "Selecting pmd-bin-${RELEASE_VERSION} as default on sourceforge.net..."
curl -H "Accept: application/json" -X PUT -d "default=windows&default=mac&default=linux&default=bsd&default=solaris&default=others" \
-d "api_key=${PMD_SF_APIKEY}" https://sourceforge.net/projects/pmd/files/pmd/${RELEASE_VERSION}/pmd-bin-${RELEASE_VERSION}.zip
if [ $? -ne 0 ]; then
log_error "Couldn't select latest binary as default on sourceforge.net"
else
log_info "pmd-bin-${RELEASE_VERSION} is now the default download option."
fi
true
)
# Assumes, the release has already been created by travis github releases provider
RELEASE_ID=$(curl -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" https://api.github.com/repos/pmd/pmd/releases/tags/pmd_releases/${RELEASE_VERSION}|jq ".id")
RELEASE_NAME="PMD ${RELEASE_VERSION} ($(date -u +%d-%B-%Y))"
RELEASE_BODY=$(tail -n +3 src/site/markdown/overview/changelog.md) # skips the first 2 lines - the heading 'PMD Release Notes'
RELEASE_BODY=$(tail -n +6 docs/pages/release_notes.md) # skips the first 6 lines - the heading 'PMD Release Notes'
RELEASE_BODY="${RELEASE_BODY//'\'/\\\\}"
RELEASE_BODY="${RELEASE_BODY//$'\r'/}"
RELEASE_BODY="${RELEASE_BODY//$'\n'/\\r\\n}"
@@ -29,7 +43,7 @@ cat > release-edit-request.json <<EOF
"body": "$RELEASE_BODY"
}
EOF
echo "Updating release at https://api.github.com/repos/pmd/pmd/releases/${RELEASE_ID}..."
log_info "Updating release at https://api.github.com/repos/pmd/pmd/releases/${RELEASE_ID}..."
RESPONSE=$(curl -i -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" -H "Content-Type: application/json" --data "@release-edit-request.json" -X PATCH https://api.github.com/repos/pmd/pmd/releases/${RELEASE_ID})
@@ -46,30 +60,58 @@ fi
fi
if [ "${BUILD}" = "site" ]; then
if [ "${BUILD}" = "doc" ]; then
echo "Adding the site to pmd.github.io..."
echo -e "\n\n"
log_info "Adding the new doc to pmd.github.io..."
# clone pmd.github.io. Note: This uses the ssh key setup earlier
# In order to speed things up, we use a sparse checkout - no need to checkout all directories here
mkdir pmd.github.io
(
cd pmd.github.io
git init
git config user.email "adangel+pmd-bot@users.sourceforge.net"
git config user.name "Andreas Dangel (PMD Releases)"
git config user.name "Travis CI (pmd-bot)"
git config user.email "andreas.dangel+pmd-bot@adangel.org"
git config core.sparsecheckout true
git remote add origin git@github.com:pmd/pmd.github.io.git
echo "latest/" > .git/info/sparse-checkout
git pull --depth=1 origin master
rsync -a ../target/pmd-doc-${RELEASE_VERSION}/ pmd-${RELEASE_VERSION}/
rsync -a ../docs/pmd-doc-${RELEASE_VERSION}/ pmd-${RELEASE_VERSION}/
git add pmd-${RELEASE_VERSION}
git commit -q -m "Added pmd-${RELEASE_VERSION}"
git rm -qr latest
cp -a pmd-${RELEASE_VERSION} latest
git add latest
git commit -q -m "Copying pmd-${RELEASE_VERSION} to latest"
../.travis/sitemap_generator.sh > sitemap.xml
git add sitemap.xml
git commit -q -m "Generated sitemap.xml"
git push origin master
)
(
echo -e "\n\n"
# disable fast fail, exit immediately, in this subshell
set +e
log_info "Uploading the new release to pmd.sourceforge.net which serves as an archive..."
travis_wait rsync -ah --stats pmd-doc-${VERSION}/ ${PMD_SF_USER}@web.sourceforge.net:/home/project-web/pmd/htdocs/pmd-${RELEASE_VERSION}/
if [ $? -ne 0 ]; then
log_error "Uploading documentation to pmd.sourceforge.net failed..."
log_error "Please upload manually (PMD Version: ${RELEASE_VERSION})"
else
log_success "The documentation is now available under http://pmd.sourceforge.net/pmd-${RELEASE_VERSION}/"
fi
true
)
fi

11
.travis/setup-secrets.sh Normal file → Executable file
View File

@@ -1,13 +1,18 @@
#!/bin/bash
set -e
if [ "$TRAVIS_PULL_REQUEST" != "false" ] || [ "${TRAVIS_SECURE_ENV_VARS}" != "true" ]; then
echo "Not setting up secrets (TRAVIS_PULL_REQUEST=${TRAVIS_PULL_REQUEST} TRAVIS_SECURE_ENV_VARS=${TRAVIS_SECURE_ENV_VARS})."
if [ "${TRAVIS_REPO_SLUG}" != "pmd/pmd" ] || [ "${TRAVIS_PULL_REQUEST}" != "false" ] || [ "${TRAVIS_SECURE_ENV_VARS}" != "true" ] || [ "${encrypted_5630fbebf057_iv}" = "" ]; then
echo "Not setting up secrets:"
echo " TRAVIS_REPO_SLUG=${TRAVIS_REPO_SLUG}"
echo " TRAVIS_PULL_REQUEST=${TRAVIS_PULL_REQUEST}"
echo " TRAVIS_SECURE_ENV_VARS=${TRAVIS_SECURE_ENV_VARS}"
[ "${encrypted_5630fbebf057_iv}" = "" ] && echo " Variable encrypted_5630fbebf057_iv is not set"
exit 0
fi
echo "Setting up secrets..."
openssl aes-256-cbc -K $encrypted_5630fbebf057_key -iv $encrypted_5630fbebf057_iv -in .travis/secrets.tar.enc -out .travis/secrets.tar -d
openssl aes-256-cbc -K ${encrypted_5630fbebf057_key} -iv ${encrypted_5630fbebf057_iv} -in .travis/secrets.tar.enc -out .travis/secrets.tar -d
pushd .travis && tar xfv secrets.tar && popd
mkdir -p "$HOME/.ssh"
chmod 700 "$HOME/.ssh"

56
.travis/sitemap_generator.sh Executable file
View File

@@ -0,0 +1,56 @@
#!/bin/bash
# Sitemap generator
# Assumes we have the latest version of the site under "latest" and "pmd-${RELEASE_VERSION}"
# https://www.sitemaps.org/protocol.html
WEBSITE_PREFIX="https://pmd.github.io/"
DOC_PREFIX="latest/" # "pmd-${RELEASE_VERSION}/"
DATE=`date +%Y-%m-%d`
# Priority is relative to the website, can be chosen in {0.1, 0.2, ..., 1}
# Default priority is 0.5
LATEST_PRIORITY=0.8
# Writes to standard output
cat << HEADER_END
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>${WEBSITE_PREFIX}index.html</loc>
<priority>1</priority>
<changefreq>monthly</changefreq>
<lastmod>$DATE</lastmod>
</url>
<url>
<loc>${WEBSITE_PREFIX}${DOC_PREFIX}index.html</loc>
<priority>0.9</priority>
<changefreq>monthly</changefreq>
<lastmod>$DATE</lastmod>
</url>
HEADER_END
for page in ${DOC_PREFIX}pmd_*.html
do
cat << ENTRY_END
<url>
<loc>${WEBSITE_PREFIX}$page</loc>
<priority>$LATEST_PRIORITY</priority>
<changefreq>monthly</changefreq>
<lastmod>$DATE</lastmod>
</url>
ENTRY_END
done
echo "</urlset>"

View File

@@ -1,34 +0,0 @@
<?xml version="1.0" encoding="UTF8"?>
<toolchains>
<!-- place this file in ${user.home}/.m2/toolchains.xml -->
<!-- see: https://github.com/travis-ci/travis-cookbooks/blob/master/cookbooks/travis_java/templates/ubuntu/jdk_switcher.sh.erb -->
<toolchain>
<type>jdk</type>
<provides>
<version>1.6</version>
</provides>
<configuration>
<jdkHome>/usr/lib/jvm/java-6-openjdk-amd64</jdkHome>
</configuration>
</toolchain>
<toolchain>
<type>jdk</type>
<provides>
<version>1.7</version>
</provides>
<configuration>
<jdkHome>/usr/lib/jvm/java-7-openjdk-amd64</jdkHome>
</configuration>
</toolchain>
<toolchain>
<type>jdk</type>
<provides>
<version>1.8</version>
</provides>
<configuration>
<jdkHome>/usr/lib/jvm/java-8-oracle</jdkHome>
</configuration>
</toolchain>
</toolchains>

View File

@@ -1,11 +1,7 @@
# How to build PMD
PMD uses [Maven](https://maven.apache.org/).
You'll need to have a `~/.m2/toolchains.xml` file setup
with jdk 1.7 and jdk 1.8 (for some features in pmd).
See [maven toolchains](https://maven.apache.org/guides/mini/guide-using-toolchains.html).
A example file can be found here: [example-toolchains.xml](https://github.com/pmd/pmd/blob/master/example-toolchains.xml).
PMD uses [Maven](https://maven.apache.org/) and requires [Java 9](http://www.oracle.com/technetwork/java/javase/downloads/index.html)
for building.
PMD uses the [maven wrapper](https://github.com/takari/maven-wrapper), so you can simply build PMD as following:
@@ -19,11 +15,14 @@ This will create the zip files in the directory `pmd-dist/target`:
That's all !
## How to build the documentation (maven site)?
**Note:** While Java 9 is required for building, running PMD only requires Java 7 (or Java 8 for Apex).
Building the maven site is done with the following commands:
## How to build the documentation?
./mvnw clean install -DskipTests=true
./mvnw install site site:stage -Psite
cd docs
bundle install # once
bundle exec jekyll build
You'll find the built site in the directory `target/staging/`.
You'll find the built site in the directory `_site/`.
For more info, see [README in docs directory](docs/README.md).

View File

@@ -29,10 +29,11 @@ When filing a bug report, please provide as much information as possible, so tha
## Documentation
There is some documentation available under <https://pmd.github.io>. Feel free to create a bug report if
documentation is missing, incomplete or outdated.
There is some documentation available under <https://pmd.github.io/pmd>. Feel free to create a bug report if
documentation is missing, incomplete or outdated. See [Bug reports](#bug-reports).
The documentation is generated as a maven site, the source is available at: <https://github.com/pmd/pmd/tree/master/src/site>
The documentation is generated as a Jekyll site, the source is available at: <https://github.com/pmd/pmd/tree/master/docs>. You can find build instructions there.
For more on contributing documentation check <https://pmd.github.io/pmd/pmd_devdocs_writing_documentation.html>
## Questions

View File

@@ -1,12 +1,14 @@
# PMD
[![Join the chat at https://gitter.im/pmd/pmd](https://badges.gitter.im/pmd/pmd.svg)](https://gitter.im/pmd/pmd?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Build Status](https://travis-ci.org/pmd/pmd.svg?branch=master)](https://travis-ci.org/pmd/pmd)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/net.sourceforge.pmd/pmd/badge.svg)](https://maven-badges.herokuapp.com/maven-central/net.sourceforge.pmd/pmd)
[![Coverage Status](https://coveralls.io/repos/github/pmd/pmd/badge.svg)](https://coveralls.io/github/pmd/pmd)
## About
**PMD** is a source code analyzer. It finds common programming flaws like unused variables, empty catch blocks,
unnecessary object creation, and so forth. It supports Java, JavaScript, Salesforce.com Apex, PLSQL, Apache Velocity,
unnecessary object creation, and so forth. It supports Java, JavaScript, Salesforce.com Apex and Visualforce, PLSQL, Apache Velocity,
XML, XSL.
Additionally it includes **CPD**, the copy-paste-detector. CPD finds duplicated code in

View File

@@ -24,7 +24,7 @@ echo "Releasing PMD"
echo "-------------------------------------------"
# see also https://gist.github.com/pdunnavant/4743895
CURRENT_VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec|tail -1)
CURRENT_VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
RELEASE_VERSION=${CURRENT_VERSION%-SNAPSHOT}
MAJOR=$(echo $RELEASE_VERSION | cut -d . -f 1)
MINOR=$(echo $RELEASE_VERSION | cut -d . -f 2)
@@ -40,6 +40,12 @@ fi
DEVELOPMENT_VERSION="$MAJOR.$NEXT_MINOR.$NEXT_PATCH"
DEVELOPMENT_VERSION="${DEVELOPMENT_VERSION}-SNAPSHOT"
# allow to override the next version, e.g. via "NEXT_VERSION=7.0.0 ./do-release.sh"
if [ "$NEXT_VERSION" != "" ]; then
DEVELOPMENT_VERSION="${NEXT_VERSION}-SNAPSHOT"
fi
# http://stackoverflow.com/questions/1593051/how-to-programmatically-determine-the-current-checked-out-git-branch
CURRENT_BRANCH=$(git symbolic-ref -q HEAD)
CURRENT_BRANCH=${CURRENT_BRANCH##refs/heads/}
@@ -60,22 +66,35 @@ export RELEASE_VERSION
export DEVELOPMENT_VERSION
export CURRENT_BRANCH
echo "* Update version/release info in **src/site/markdown/overview/changelog.md**."
RELEASE_RULESET="pmd-core/src/main/resources/rulesets/releases/${RELEASE_VERSION//\./}.xml"
echo "* Update version/release info in **docs/pages/release_notes.md**."
echo
echo " ## $(date -u +%d-%B-%Y) - ${RELEASE_VERSION}"
echo
echo "* Ensure all the new rules are listed in a the proper file:"
echo " pmd-core/src/main/resources/rulesets/releases/${RELEASE_VERSION}.xml file."
echo "* Update date info in **docs/_config.yml**."
echo
echo "* Update **../pmd.github.io/index.html** to mention the new release"
echo "* Ensure all the new rules are listed in a the proper file:"
echo " ${RELEASE_RULESET}"
echo
echo "* Update **../pmd.github.io/_config.yml** to mention the new release"
echo
echo "* Add **../pmd.github.io/_posts/$(date -u +%Y-%m-%d)-PMD-${RELEASE_VERSION}.md"
echo
echo "Press enter to continue..."
read
echo "Committing current changes (pmd)"
if [[ -e ${RELEASE_RULESET} ]]
then
git add ${RELEASE_RULESET}
fi
git commit -a -m "Prepare pmd release ${RELEASE_VERSION}"
(
echo "Committing current changes (pmd.github.io)"
cd ../pmd.github.io
git add _posts/$(date -u +%Y-%m-%d)-PMD-${RELEASE_VERSION}.md
git commit -a -m "Prepare pmd release ${RELEASE_VERSION}"
git push
)
@@ -96,41 +115,57 @@ echo
cat <<EOF
PMD ${RELEASE_VERSION} released
* minor version with lots of bug fixes
* Changelog: https://pmd.github.io/pmd-${RELEASE_VERSION}/overview/changelog.html
* Downloads: https://github.com/pmd/pmd/releases/tag/pmd_releases%2F${RELEASE_VERSION}
* Fixed Bugs: https://sourceforge.net/p/pmd/bugs/milestone/PMD-${RELEASE_VERSION}/
* Documentation: https://pmd.github.io/pmd-${RELEASE_VERSION}/
And Copy-Paste the release notes
EOF
echo
echo "Press enter to continue..."
read
echo
echo "Check the milestone on sourceforge:"
echo "<https://sourceforge.net/p/pmd/bugs/milestones>"
echo
echo "Check the milestone on github:"
echo "<https://github.com/pmd/pmd/milestones>"
echo " --> move any open issues to the next milestone, close the current milestone"
echo " --> Maybe there are some milestones on sourceforge, too: <https://sourceforge.net/p/pmd/bugs/milestones>."
echo
echo
echo "Prepare Next development version:"
echo "* Move version/release info from **src/site/markdown/overview/changelog.md** to **src/site/markdown/overview/changelog-old.md**."
echo "* Update version/release info in **src/site/markdown/overview/changelog.md**."
echo "* Update version/date info in **docs/_config.yml**."
echo
cat <<EOF
# PMD Release Notes
echo
echo "Press enter to continue..."
read
# update release_notes_old
OLD_RELEASE_NOTES=$(tail -n +8 docs/pages/release_notes_old.md)
NEW_RELEASE_NOTES=$(tail -n +6 docs/pages/release_notes.md)
echo "$(head -n 7 docs/pages/release_notes_old.md)" > docs/pages/release_notes_old.md
echo "$NEW_RELEASE_NOTES" >> docs/pages/release_notes_old.md
echo >> docs/pages/release_notes_old.md
echo "$OLD_RELEASE_NOTES" >> docs/pages/release_notes_old.md
# reset release notes template
cat > docs/pages/release_notes.md <<EOF
---
title: PMD Release Notes
permalink: pmd_release_notes.html
keywords: changelog, release notes
---
## ????? - ${DEVELOPMENT_VERSION}
The PMD team is pleased to announce PMD ${DEVELOPMENT_VERSION%-SNAPSHOT}.
This is a bug fixing release.
This is a minor release.
### Table Of Contents
* [New and noteworthy](#New_and_noteworthy)
* [Fixed Issues](#Fixed_Issues)
* [API Changes](#API_Changes)
* [External Contributions](#External_Contributions)
* [New and noteworthy](#new-and-noteworthy)
* [Fixed Issues](#fixed-issues)
* [API Changes](#api-changes)
* [External Contributions](#external-contributions)
### New and noteworthy
@@ -141,11 +176,10 @@ This is a bug fixing release.
### External Contributions
EOF
echo
echo "Press enter to continue..."
read
git commit -a -m "Prepare next development version"
git push origin ${CURRENT_BRANCH}
./mvwn -B release:clean
echo
echo
echo
@@ -155,7 +189,12 @@ echo
echo "Send out an announcement mail to the mailing list:"
echo "To: PMD Developers List <pmd-devel@lists.sourceforge.net>"
echo "Subject: [ANNOUNCE] PMD ${RELEASE_VERSION} Released"
echo "Body: !!Copy Changelog!!"
echo
echo " * Downloads: https://github.com/pmd/pmd/releases/tag/pmd_releases%2F${RELEASE_VERSION}"
echo " * Documentation: https://pmd.github.io/pmd-${RELEASE_VERSION}/"
echo
echo " And Copy-Paste the release notes"
echo
echo
echo
echo "------------------------------------------"

5
docs/.gitignore vendored Normal file
View File

@@ -0,0 +1,5 @@
_site/
.sass-cache/
.jekyll-metadata
_pdf
.idea/

8
docs/404.md Normal file
View File

@@ -0,0 +1,8 @@
---
title: "Page Not Found"
search: exclude
---
Sorry, but the page you were trying to view does not exist. Check the URL for correctness, or try using keyword search using our search bar.
[Back to the index](index.html)

26
docs/Dockerfile Normal file
View File

@@ -0,0 +1,26 @@
FROM ruby:2.4.2
MAINTAINER mrafayaleem@gmail.com
RUN apt-get clean \
&& mv /var/lib/apt/lists /var/lib/apt/lists.broke \
&& mkdir -p /var/lib/apt/lists/partial
RUN apt-get update
RUN apt-get install -y \
node \
python-pygments \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/
WORKDIR /tmp
ADD Gemfile /tmp/
ADD Gemfile.lock /tmp/
RUN bundle install
VOLUME /src
EXPOSE 4000
WORKDIR /src
ENTRYPOINT ["jekyll"]

4
docs/Gemfile Normal file
View File

@@ -0,0 +1,4 @@
source 'https://rubygems.org'
gem 'jekyll'
gem 'github-pages'

250
docs/Gemfile.lock Normal file
View File

@@ -0,0 +1,250 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (4.2.10)
i18n (~> 0.7)
minitest (~> 5.1)
thread_safe (~> 0.3, >= 0.3.4)
tzinfo (~> 1.1)
addressable (2.5.2)
public_suffix (>= 2.0.2, < 4.0)
coffee-script (2.4.1)
coffee-script-source
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
commonmarker (0.17.9)
ruby-enum (~> 0.5)
concurrent-ruby (1.0.5)
dnsruby (1.60.2)
em-websocket (0.5.1)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0.6.0)
ethon (0.11.0)
ffi (>= 1.3.0)
eventmachine (1.2.7)
execjs (2.7.0)
faraday (0.15.2)
multipart-post (>= 1.2, < 3)
ffi (1.9.23)
forwardable-extended (2.6.0)
gemoji (3.0.0)
github-pages (186)
activesupport (= 4.2.10)
github-pages-health-check (= 1.8.1)
jekyll (= 3.7.3)
jekyll-avatar (= 0.5.0)
jekyll-coffeescript (= 1.1.1)
jekyll-commonmark-ghpages (= 0.1.5)
jekyll-default-layout (= 0.1.4)
jekyll-feed (= 0.9.3)
jekyll-gist (= 1.5.0)
jekyll-github-metadata (= 2.9.4)
jekyll-mentions (= 1.3.0)
jekyll-optional-front-matter (= 0.3.0)
jekyll-paginate (= 1.1.0)
jekyll-readme-index (= 0.2.0)
jekyll-redirect-from (= 0.13.0)
jekyll-relative-links (= 0.5.3)
jekyll-remote-theme (= 0.3.1)
jekyll-sass-converter (= 1.5.2)
jekyll-seo-tag (= 2.4.0)
jekyll-sitemap (= 1.2.0)
jekyll-swiss (= 0.4.0)
jekyll-theme-architect (= 0.1.1)
jekyll-theme-cayman (= 0.1.1)
jekyll-theme-dinky (= 0.1.1)
jekyll-theme-hacker (= 0.1.1)
jekyll-theme-leap-day (= 0.1.1)
jekyll-theme-merlot (= 0.1.1)
jekyll-theme-midnight (= 0.1.1)
jekyll-theme-minimal (= 0.1.1)
jekyll-theme-modernist (= 0.1.1)
jekyll-theme-primer (= 0.5.3)
jekyll-theme-slate (= 0.1.1)
jekyll-theme-tactile (= 0.1.1)
jekyll-theme-time-machine (= 0.1.1)
jekyll-titles-from-headings (= 0.5.1)
jemoji (= 0.9.0)
kramdown (= 1.16.2)
liquid (= 4.0.0)
listen (= 3.1.5)
mercenary (~> 0.3)
minima (= 2.4.1)
nokogiri (>= 1.8.2, < 2.0)
rouge (= 2.2.1)
terminal-table (~> 1.4)
github-pages-health-check (1.8.1)
addressable (~> 2.3)
dnsruby (~> 1.60)
octokit (~> 4.0)
public_suffix (~> 2.0)
typhoeus (~> 1.3)
html-pipeline (2.8.0)
activesupport (>= 2)
nokogiri (>= 1.4)
http_parser.rb (0.6.0)
i18n (0.9.5)
concurrent-ruby (~> 1.0)
jekyll (3.7.3)
addressable (~> 2.4)
colorator (~> 1.0)
em-websocket (~> 0.5)
i18n (~> 0.7)
jekyll-sass-converter (~> 1.0)
jekyll-watch (~> 2.0)
kramdown (~> 1.14)
liquid (~> 4.0)
mercenary (~> 0.3.3)
pathutil (~> 0.9)
rouge (>= 1.7, < 4)
safe_yaml (~> 1.0)
jekyll-avatar (0.5.0)
jekyll (~> 3.0)
jekyll-coffeescript (1.1.1)
coffee-script (~> 2.2)
coffee-script-source (~> 1.11.1)
jekyll-commonmark (1.2.0)
commonmarker (~> 0.14)
jekyll (>= 3.0, < 4.0)
jekyll-commonmark-ghpages (0.1.5)
commonmarker (~> 0.17.6)
jekyll-commonmark (~> 1)
rouge (~> 2)
jekyll-default-layout (0.1.4)
jekyll (~> 3.0)
jekyll-feed (0.9.3)
jekyll (~> 3.3)
jekyll-gist (1.5.0)
octokit (~> 4.2)
jekyll-github-metadata (2.9.4)
jekyll (~> 3.1)
octokit (~> 4.0, != 4.4.0)
jekyll-mentions (1.3.0)
activesupport (~> 4.0)
html-pipeline (~> 2.3)
jekyll (~> 3.0)
jekyll-optional-front-matter (0.3.0)
jekyll (~> 3.0)
jekyll-paginate (1.1.0)
jekyll-readme-index (0.2.0)
jekyll (~> 3.0)
jekyll-redirect-from (0.13.0)
jekyll (~> 3.3)
jekyll-relative-links (0.5.3)
jekyll (~> 3.3)
jekyll-remote-theme (0.3.1)
jekyll (~> 3.5)
rubyzip (>= 1.2.1, < 3.0)
jekyll-sass-converter (1.5.2)
sass (~> 3.4)
jekyll-seo-tag (2.4.0)
jekyll (~> 3.3)
jekyll-sitemap (1.2.0)
jekyll (~> 3.3)
jekyll-swiss (0.4.0)
jekyll-theme-architect (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-cayman (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-dinky (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-hacker (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-leap-day (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-merlot (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-midnight (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-minimal (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-modernist (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-primer (0.5.3)
jekyll (~> 3.5)
jekyll-github-metadata (~> 2.9)
jekyll-seo-tag (~> 2.0)
jekyll-theme-slate (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-tactile (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-theme-time-machine (0.1.1)
jekyll (~> 3.5)
jekyll-seo-tag (~> 2.0)
jekyll-titles-from-headings (0.5.1)
jekyll (~> 3.3)
jekyll-watch (2.0.0)
listen (~> 3.0)
jemoji (0.9.0)
activesupport (~> 4.0, >= 4.2.9)
gemoji (~> 3.0)
html-pipeline (~> 2.2)
jekyll (~> 3.0)
kramdown (1.16.2)
liquid (4.0.0)
listen (3.1.5)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
ruby_dep (~> 1.2)
mercenary (0.3.6)
mini_portile2 (2.3.0)
minima (2.4.1)
jekyll (~> 3.5)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
minitest (5.11.3)
multipart-post (2.0.0)
nokogiri (1.8.2)
mini_portile2 (~> 2.3.0)
octokit (4.9.0)
sawyer (~> 0.8.0, >= 0.5.3)
pathutil (0.16.1)
forwardable-extended (~> 2.6)
public_suffix (2.0.5)
rb-fsevent (0.10.3)
rb-inotify (0.9.10)
ffi (>= 0.5.0, < 2)
rouge (2.2.1)
ruby-enum (0.7.2)
i18n
ruby_dep (1.5.0)
rubyzip (1.2.1)
safe_yaml (1.0.4)
sass (3.5.6)
sass-listen (~> 4.0.0)
sass-listen (4.0.0)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
sawyer (0.8.1)
addressable (>= 2.3.5, < 2.6)
faraday (~> 0.8, < 1.0)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thread_safe (0.3.6)
typhoeus (1.3.0)
ethon (>= 0.9.0)
tzinfo (1.2.5)
thread_safe (~> 0.1)
unicode-display_width (1.3.3)
PLATFORMS
ruby
DEPENDENCIES
github-pages
jekyll
BUNDLED WITH
1.16.2

22
docs/README.md Normal file
View File

@@ -0,0 +1,22 @@
# PMD-New-Site
New Site For PMD Core Open Source Project
## Site Theme
This site was built using the tomjohnson1492/documentation-theme-jekyll theme
A Jekyll-based theme designed for documentation and help systems. See the link for detailed instructions on setting up and configuring everything. http://idratherbewriting.com/documentation-theme-jekyll/
## Building using Bundler
bundle install # once
bundle exec jekyll serve
Go to: http://localhost:4005/
## Building using Docker
docker build --no-cache -t pmd-doc . # once
docker run --rm=true -v "$PWD:/src" -p 4005:4005 pmd-doc serve -H 0.0.0.0
Go to: http://localhost:4005/

107
docs/_config.yml Normal file
View File

@@ -0,0 +1,107 @@
repository: pmd/pmd
pmd:
version: 6.5.0
date: 2018-06-26
output: web
# this property is useful for conditional filtering of content that is separate from the PDF.
topnav_title: PMD Source Code Analyzer Project
# this appears on the top navigation bar next to the home button
site_title: PMD Source Code Analyzer
# this appears in the html browser tab for the site title (seen mostly by search engines, not users)
company_name: PMD Open Source Project
# this appears in the footer
github_editme_path: pmd/pmd/blob/master/docs/
# if you're using Github, provide the basepath to the branch you've created for reviews, following the sample here. if not, leave this value blank.
disqus_shortname:
# if you're using disqus for comments, add the shortname here. if not, leave this value blank.
host: 127.0.0.1
# the preview server used. Leave as is.
port: 4005
# the port where the preview is rendered. You can leave this as is unless you have other Jekyll builds using this same port that might cause conflicts. in that case, use another port such as 4006.
exclude:
- .idea/
- .gitignore
# these are the files and directories that jekyll will exclude from the build
feedback_subject_line: PMD Source Code Analyzer
feedback_email:
# used as a contact email for the Feedback link in the top navigation bar
feedback_disable: true
# if you uncomment the previous line, the Feedback link gets removed
# feedback_text: "Need help?"
# if you uncomment the previous line, it changes the Feedback text
# feedback_link: "http://helpy.io/"
# if you uncomment the previous line, it changes where the feedback link points to
markdown: kramdown
highlighter: rouge
kramdown:
input: GFM
auto_ids: true
hard_wrap: false
syntax_highlighter: rouge
syntax_highlighter_opts:
css_class: 'highlight'
# filter used to process markdown. note that kramdown differs from github-flavored markdown in some subtle ways
collections:
tooltips:
output: false
# collections are declared here. this renders the content in _tooltips and processes it, but doesn't output it as actual files in the output unless you change output to true
defaults:
-
scope:
path: ""
type: "pages"
values:
layout: "page"
comments: true
search: true
sidebar: pmd_sidebar
-
scope:
path: ""
type: "tooltips"
values:
layout: "page"
comments: true
search: true
tooltip: true
-
scope:
path: ""
type: "posts"
values:
layout: "post"
comments: true
search: true
sidebar: pmd_sidebar
# these are defaults used for the frontmatter for these file types
sidebars:
- pmd_sidebar
description: "Intended as a documentation theme based on Jekyll for technical writers documenting software and other technical products, this theme has all the elements you would need to handle multiple products with both multi-level sidebar navigation, tags, and other documentation features."
# the description is used in the feed.xml file
# needed for sitemap.xml file only
url: https://pmd.github.io/pmd
baseurl: ""

Some files were not shown because too many files have changed in this diff Show More