Update integration test

The plain text language of the designer is
not registered through LanguageRegistry anymore
since pmd-ui 6.21.0, so that regular PMD
cannot access it

.github/ISSUE_TEMPLATE.md

@@ -1,5 +1,7 @@
-Please, prefix the report title with the language it applies to within brackets, such as [java] or [apex].
-If not specific to a language, you can use [core].
+<!-- Please, prefix the report title with the language it applies to within brackets, such as [java] or [apex].
+If not specific to a language, you can use [core]. -->
+
+<!-- NB: issues about the rule designer should be opened at https://github.com/pmd/pmd-designer/issues -->
 
 **Affects PMD Version:** 
 
@@ -15,3 +17,4 @@ If not specific to a language, you can use [core].
 
 **Running PMD through:** *[CLI | Ant | Maven | Gradle | Designer | Other]*
 
+<!-- If relevant, also include your JDK and OS information, e.g. for ClassNotFoundException, LinkageError, reflection failures, etc. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,9 +1,10 @@
+<!--
 Please, prefix the PR title with the language it applies to within brackets, such as *[java]* or *[apex]*. If not specific to a language, you can use *[core]*
+-->
 
 Before submitting a PR, please check that:
  - [ ] The PR is submitted against `master`. The PMD team will merge back to support branches as needed.
- - [ ] `mvn test` passes.
- - [ ] `mvn checkstyle:check` passes. [Check this for more info](https://github.com/pmd/pmd/blob/master/CONTRIBUTING.md#code-style)
+ - [ ] `./mvnw clean verify` passes. This will [build](https://github.com/pmd/pmd/blob/master/BUILDING.md) and test PMD, execute PMD and checkstyle rules. [Check this for more info](https://github.com/pmd/pmd/blob/master/CONTRIBUTING.md#code-style)
 
 **PR Description:**
 

.gitignore

@@ -10,3 +10,9 @@ bin/
 .idea
 *.patch
 */src/site/site.xml
+pmd-core/dependency-reduced-pom.xml
+.bundle
+vendor
+
+# rule docs are generated
+docs/pages/pmd/rules

.mvn/wrapper/MavenWrapperDownloader.java

@@ -0,0 +1,117 @@
+/*
+ * Copyright 2007-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import java.net.*;
+import java.io.*;
+import java.nio.channels.*;
+import java.util.Properties;
+
+public class MavenWrapperDownloader {
+
+    private static final String WRAPPER_VERSION = "0.5.6";
+    /**
+     * Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' is provided.
+     */
+    private static final String DEFAULT_DOWNLOAD_URL = "https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/"
+        + WRAPPER_VERSION + "/maven-wrapper-" + WRAPPER_VERSION + ".jar";
+
+    /**
+     * Path to the maven-wrapper.properties file, which might contain a downloadUrl property to
+     * use instead of the default one.
+     */
+    private static final String MAVEN_WRAPPER_PROPERTIES_PATH =
+            ".mvn/wrapper/maven-wrapper.properties";
+
+    /**
+     * Path where the maven-wrapper.jar will be saved to.
+     */
+    private static final String MAVEN_WRAPPER_JAR_PATH =
+            ".mvn/wrapper/maven-wrapper.jar";
+
+    /**
+     * Name of the property which should be used to override the default download url for the wrapper.
+     */
+    private static final String PROPERTY_NAME_WRAPPER_URL = "wrapperUrl";
+
+    public static void main(String args[]) {
+        System.out.println("- Downloader started");
+        File baseDirectory = new File(args[0]);
+        System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
+
+        // If the maven-wrapper.properties exists, read it and check if it contains a custom
+        // wrapperUrl parameter.
+        File mavenWrapperPropertyFile = new File(baseDirectory, MAVEN_WRAPPER_PROPERTIES_PATH);
+        String url = DEFAULT_DOWNLOAD_URL;
+        if(mavenWrapperPropertyFile.exists()) {
+            FileInputStream mavenWrapperPropertyFileInputStream = null;
+            try {
+                mavenWrapperPropertyFileInputStream = new FileInputStream(mavenWrapperPropertyFile);
+                Properties mavenWrapperProperties = new Properties();
+                mavenWrapperProperties.load(mavenWrapperPropertyFileInputStream);
+                url = mavenWrapperProperties.getProperty(PROPERTY_NAME_WRAPPER_URL, url);
+            } catch (IOException e) {
+                System.out.println("- ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'");
+            } finally {
+                try {
+                    if(mavenWrapperPropertyFileInputStream != null) {
+                        mavenWrapperPropertyFileInputStream.close();
+                    }
+                } catch (IOException e) {
+                    // Ignore ...
+                }
+            }
+        }
+        System.out.println("- Downloading from: " + url);
+
+        File outputFile = new File(baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH);
+        if(!outputFile.getParentFile().exists()) {
+            if(!outputFile.getParentFile().mkdirs()) {
+                System.out.println(
+                        "- ERROR creating output directory '" + outputFile.getParentFile().getAbsolutePath() + "'");
+            }
+        }
+        System.out.println("- Downloading to: " + outputFile.getAbsolutePath());
+        try {
+            downloadFileFromURL(url, outputFile);
+            System.out.println("Done");
+            System.exit(0);
+        } catch (Throwable e) {
+            System.out.println("- Error downloading");
+            e.printStackTrace();
+            System.exit(1);
+        }
+    }
+
+    private static void downloadFileFromURL(String urlString, File destination) throws Exception {
+        if (System.getenv("MVNW_USERNAME") != null && System.getenv("MVNW_PASSWORD") != null) {
+            String username = System.getenv("MVNW_USERNAME");
+            char[] password = System.getenv("MVNW_PASSWORD").toCharArray();
+            Authenticator.setDefault(new Authenticator() {
+                @Override
+                protected PasswordAuthentication getPasswordAuthentication() {
+                    return new PasswordAuthentication(username, password);
+                }
+            });
+        }
+        URL website = new URL(urlString);
+        ReadableByteChannel rbc;
+        rbc = Channels.newChannel(website.openStream());
+        FileOutputStream fos = new FileOutputStream(destination);
+        fos.getChannel().transferFrom(rbc, 0, Long.MAX_VALUE);
+        fos.close();
+        rbc.close();
+    }
+
+}

.mvn/wrapper/maven-wrapper.properties

@@ -1 +1,2 @@
-distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.2/apache-maven-3.5.2-bin.zip
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
+wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar

.travis.yml

@@ -1,70 +1,80 @@
-dist: trusty
-sudo: false
-addons:
-  apt:
-    packages:
-      - oracle-java9-installer
-  ssh_known_hosts:
-    - web.sourceforge.net
-
 language: java
-
-jdk: oraclejdk9
-
+os: linux
 env:
   global:
-  - secure: KBEuB6U1p5RQXSYe157AwydFr/zpXQPA0IChVCgZV+X1mMyy9ZtrjH1J1AXuviseDDXDbaT25sRnsvpl82rfRw2xOkMGXHy4N95/ylTSr8DjHxTao71BhXsvFycNobFva5y2EGNWqDvpS8I2oSZo7Qk4la3yep3rcJQvcy6RDbbhpDTbL1QMFyadunIBm0WtqbunrMqtjSqaoPsXz8TiQuxHvX4vEXzVbaxV1QQt79Vi+daa6wAV3mRQAugnx+UffsC8JqMxgm06usWeJgCJzxgm8E7clZCLmf53B2TL8dK6bIYbqyvOY3uFxitsTG0d8Z0GOJwXBgZNgbniTRO8ZJSty5eZP8LBybbjVLSL25DNTWtCjADUL/uySnXIEidlMt2N/3QmH7zrGAfAk/tIwKpdRca2GLLydeXf6PSkiahnPEkIY/QupcsOLELhdifpdOjb8QW1OenA+vUbNM9dccLwKnX6Fj9cu4VQG601AcYDr2eyhq8WYkr3wYdw/6KdUa3hmplowTBs+qguppP+eOSgGuEsy38KLtqnvm6WlHy6tcLmcVYKG3DmR1b7TWXsOXC6/VMH8BHBkvsF1QdRg9+Cgx07vX3Hw7roPiYzmaO9Ajs20ATsUfRskMuWCTeTSK5pN8X27veRCZlhFjeKQMDdmfVwzpAfRgKsl3TEn1I=
-  - secure: U1DfAv6acUUWe+dao/ZSDUX64JRadNJY16rITsdrM4ZNAJSuXpEY3p/LWcYjN7D49YmyutbXH9+L3KKQUQGrGXj9QTarfYvd8ZsKt4FK8yv7AFy+RQNIbAjNEHBzHx15p+srMheTaetl7aLwY0qhF+D/RtGapxHKyY4dBHrb0lp8VGyiCiL7Aop8GGskosi1mtirPBp/BStPZ2bEyxG0QzU5SsVWkJWwV9aWLPVAR/n7Xgx/6Gjl6Fed2c/WSrWi4vchm3Ny8pfTweOax3PGYYjBVxIfuX0mqmwuJsY7gNfXCfN3dPiPKGJPFy1pC+LGyGkklO5ReKFLd4O1ME6fU0dlIGfD6n+Q4H6/w9FHXegcKTfWIJm/MFa6vA/tJM5R6zJQuiTQJboHm/UmS/iQj76z0p6sK15Xp5vFId+/dHKqa8xY+Bt6HiXy6z401HOc8QcYBAf7TqhqUt/ZE7HN4be46uR90KmzIrWz6wEoDW7HfwQ9ZMbs55zoOXrvekyE9/gXskypO0p2JT3Y0vlvO27KQvIrSwI480kOVOrlyrYA+LZqlcKaayOuCuZh4lITQUYinUoZZict5joYthH+Cyh2zovoBpxsntDJdMnaZNLtSC7hlhpbMBYaT2y1O6vZH5Yix0mxuDvs/x6ogP5CNBeUYlXhaL+g4GnwKyr0ZA0=
-  - secure: "ElWjttpoMwqezP2zyHkx7CiPON/mRLUW7SsSlEqdlTUYRIaSaL7sShUORJUzj58U/Nnfi/eY4Rweo0CtVu20sG16s9B4adnmPS44LAitztybPR/co93gN9qb8jiIl41nVcOJq+Rut2Z4nr8AGRhVCG9Drg4+DreCqQ4DE5ZD6J99GN0IFGrREt59HQUlBlT9jD0AndK/1GQ6kWAenuSREE2P5ih59rf6FrrfddQO5iqyFFoaHek3JiOmpaLK+z7i4EvMKsAJEooFNuGhHVuyaJJRRZHAncGiQ+uW/yL7G5rY51G6YSNJczzEtfrRg+YrIUbokUPmifSIbnXO/AIZRAq1dMhA8exRc5n+75RB1X164qm4a+yggdybFBh0L59xu606PJQJAuWy+x10nled7FAVXiotxbB0r2bhlVmWFEN+FWPqXg2rVkHvw6+5PM67rG5g1LCgjKzb9I6JWPiVI+EMn8Pw8gryL2Sdqtl08Da0Ypbl2ZK/afU4CEPEKnrDc9ecXKjacehTYwGS48V213XvArcmoEpsyZDRSMTrvK3/e29GEaxoK/ZzWJylpeOtsICEEFYEBEiDsiIW4C50MIUPT2xHV6MaPQzhkuwrbQ6QFYzHzihBaiQuMmXUQ4DMb3fOPkNZAQHQo8CgJ78IcbCABAoGv9mu/fo2KoLo11U="
+  - secure: "KBEuB6U1p5RQXSYe157AwydFr/zpXQPA0IChVCgZV+X1mMyy9ZtrjH1J1AXuviseDDXDbaT25sRnsvpl82rfRw2xOkMGXHy4N95/ylTSr8DjHxTao71BhXsvFycNobFva5y2EGNWqDvpS8I2oSZo7Qk4la3yep3rcJQvcy6RDbbhpDTbL1QMFyadunIBm0WtqbunrMqtjSqaoPsXz8TiQuxHvX4vEXzVbaxV1QQt79Vi+daa6wAV3mRQAugnx+UffsC8JqMxgm06usWeJgCJzxgm8E7clZCLmf53B2TL8dK6bIYbqyvOY3uFxitsTG0d8Z0GOJwXBgZNgbniTRO8ZJSty5eZP8LBybbjVLSL25DNTWtCjADUL/uySnXIEidlMt2N/3QmH7zrGAfAk/tIwKpdRca2GLLydeXf6PSkiahnPEkIY/QupcsOLELhdifpdOjb8QW1OenA+vUbNM9dccLwKnX6Fj9cu4VQG601AcYDr2eyhq8WYkr3wYdw/6KdUa3hmplowTBs+qguppP+eOSgGuEsy38KLtqnvm6WlHy6tcLmcVYKG3DmR1b7TWXsOXC6/VMH8BHBkvsF1QdRg9+Cgx07vX3Hw7roPiYzmaO9Ajs20ATsUfRskMuWCTeTSK5pN8X27veRCZlhFjeKQMDdmfVwzpAfRgKsl3TEn1I="
+  - secure: "U1DfAv6acUUWe+dao/ZSDUX64JRadNJY16rITsdrM4ZNAJSuXpEY3p/LWcYjN7D49YmyutbXH9+L3KKQUQGrGXj9QTarfYvd8ZsKt4FK8yv7AFy+RQNIbAjNEHBzHx15p+srMheTaetl7aLwY0qhF+D/RtGapxHKyY4dBHrb0lp8VGyiCiL7Aop8GGskosi1mtirPBp/BStPZ2bEyxG0QzU5SsVWkJWwV9aWLPVAR/n7Xgx/6Gjl6Fed2c/WSrWi4vchm3Ny8pfTweOax3PGYYjBVxIfuX0mqmwuJsY7gNfXCfN3dPiPKGJPFy1pC+LGyGkklO5ReKFLd4O1ME6fU0dlIGfD6n+Q4H6/w9FHXegcKTfWIJm/MFa6vA/tJM5R6zJQuiTQJboHm/UmS/iQj76z0p6sK15Xp5vFId+/dHKqa8xY+Bt6HiXy6z401HOc8QcYBAf7TqhqUt/ZE7HN4be46uR90KmzIrWz6wEoDW7HfwQ9ZMbs55zoOXrvekyE9/gXskypO0p2JT3Y0vlvO27KQvIrSwI480kOVOrlyrYA+LZqlcKaayOuCuZh4lITQUYinUoZZict5joYthH+Cyh2zovoBpxsntDJdMnaZNLtSC7hlhpbMBYaT2y1O6vZH5Yix0mxuDvs/x6ogP5CNBeUYlXhaL+g4GnwKyr0ZA0="
+  - secure: "gxI7W4V4fUPQLMCvecXXdet1/mCh6m0RIQMtErVVOnwxEEjeDmko/3rHSl+wk6IeFaaQKcmHJJSJEj+e5TgWRH1uuzCnbFHZhuH28ce/H0EqLJ3GTXeDEgFLzhh//T3ySOZChZELgJ67cKxZJNFMhBVOR2/QIGjZjdzvl36ugsu80Ak3XJb8HCm8D2P8Vuezz/OlCkSOGXaiqZXfflV/cuaLWuueGfQGW9x/UyDTNsuBdB7YnEcxOWt8RgB4JrcPGV7/etxLHXTw9IMEeUhQ/RsxLZHKNYt9cx/QOZkpXemhdT9L2pAIi77eO98x+yAfB1qV6T6IeDd/OiABUzfb7asNBwE+bYRuVkCiWLo3x3hs8FcgsPe4L10guxfRMJPxax9E7uYb9TFxtvc42dDWNyp1BVCtEtmjErO4CJeW97ukhgkUkPhzUZgQ2Gj5Tn4VRjQOQyzh/S/YsHyfxoAQrscc/3bq5PBmtdowyGQd5dsvShdpE6glf+HnBZ8TCw5BaxQuTjapQWjsGuJVCVsrNDtwOFy5UTfxK9OeTUsjwfO5JjkoIeqGyLHPnTMWyZ6EYa//nWPOU1KgVE6Hrzfr3zxEzL1nN/TYahzhKOxXE701W9YhTmhCVljMlSYioTUfTaXHgGLpojvSWlhsTbc3r0gj4NglqakIy7MKgQLgES8="
   - secure: "otZkFNhApMofp2Jl2baZdpNEPcTa79Xc9wyOw1gl1+ubCLtOGr32FDUSr0HQWKrGXcYZR4bc0A80hx0/ykZ/twJaRAabcNYtjwRMDKKrp3plvp8RTZlB1QW85nsdmk3qmHACzc94wKnmcaDohM5FPxnWspZG5Y4ejYX4HEK6r1fwL4FjMPSLd5QW8yCaAc7dpBSm2UyIXuuDjkekXblJFe8ydbf9aF97WKJMCwqIs9Zo5oJa2pnWCw47ixwjVdkaH5x5727I+YmFqn5rjdEideUFEAlggqMaxuOtfYhuG/8k5W3Q/+WX+G7rEPTcemjmaosbbpoOUE0YUHV3Wi3R5D66NuWIpQwX6kw4rTwL0YIh//0aNb8jv4Z8KwkiTMrYuj0we5tXzARp3yYn56P0JBAm6BihNhfEBv06655Tg5LUsWqUTZCl3KJhwtO1N+OuOkE5qoZm59knq6DeZOsYWAVb3MpzklP06kXGYTjb44PVMUc6ynuuZjgPJDv/0906feA3REHBJVxd3PvJp1c8VvQSeW3ndghEz0akJHY/jxV1rJZAZC1ZeshYUpBNmh0sFDty/UE43IvIB4EInypQHyTtQvMc6LuLjTeu2E5ZMsA3udj66EMrYm4Y2eheJycSfttDqzhsKXIVJ4LmA/xtDR01cp1jsqbbZBhVI67rA40="
   - secure: "mmHRnK/8CHfgtwaTN3MgjFD1R8EVQhIb/a0Aag3gPaHWW52Ex6xWG7GsF4kRcdzHdIdrQxHZTiDa2oVMWbnQ16CAu4dZJadwTxhBW4JmE1tsi2C6i+uwMBPvnKBXHwt+QOAqNB0L/ByYwWLkucSLoyRs6qU0i7sJ3ZC/EPCuLI8VfBlFUVegSbp2WmclmFnxOi5MKr15Zwd8BGgyWUsvd1OHxhvO3Xr/ZPO4R+1kIgyojloTMu6oGM/shYgsrUXgmI/WvZRTq+25SRCjUmATJtuDXXgVeJtYabi/+Zju5Z7K06oaKvFYM+BgZWPmGQkVCxKVjSlug0rx6+qgRKIf/B/cPxmQDS0ZZVDmDcbxeibBL9JhRqIDwDb0XS9t1qBXvIJ5E4ZmdX/XuvLCnC4xJptu/vHyKl1wbRM3dcXEBk8J0knJc4JvY2yupF3LS32sfEHftLwzr63U3/0dOQvsCSJRBy5zgI8ieABUZAeZmmaQ6RCGOTEYrGO2G4CCF2uVq4YdrCOsfmrb0DzH8llNMkXKzXlITRvmkuBlTRRKxGnPzS3vf0iicdAkmTiU5u7lArFFc7IKcW4ypO+RKDTUpq74K+UZBI9eBjV7Po368EO8epJ5aIx32a2kyS/hYWkS/dZh7I0fNZa2qBUceZO/KZGRjH4dQFW9t0J9Q7LLXJY="
-  - secure: "geOU/7VR83KYTOCR5XkgFqnHJEnXeB6hNDE7UFcN4ZsL9uVLhxlDVWV3ujJ87nyBzggG1KfSnUx11UwOQrbBl0K6sEXo/B2q5ytOsWoSLi7+0qm/uhhw/DTBOq57p8TIDKFM7rDhO7uajSn7Y86LeZkh9wIs5265Fh1yhCkiPbczDUMsX4P0GGg2qgkIKSBw4DZf6sPDc4xjJq/4/cLnjXo/K0ZYAIoSLqDfe1gmkzMtQlad+1t8Lwv/gOJ4BNRF4a5aEvGF6kbFovFoeFWCQTKlkn6VJtY+BETGKW2RH9efGeMs7JbBbNm+nnpoNsbJ0gdmGlhSbWT8enIm72/P0ThTBJWVcLJ30tUd0UeYD9C49wbJ3RHSxsoUKP9YhHJ+XKNx+8irkJ8LPCkNMQEFE153gEVvU7tCgah9Uq6laYZv9cQE0dWzNt3//Ymls8BzY38Ha4PbrIIJqEuWwnAX6ZgTgzVtXx1AJjkDFG9KFKPhN7NfNMbh7rn5C84a1h5zrIydm+6RcIBC+xTLDEiN7djiquf3PcNtyGLcO8dNN4Uv8iU0Jw8ch3+w0PJO53v5py+IS1V8pwwYaYF2iVPOoziS0tP8MsgYVGwpTZhvz3v8x0ge8r6KJE4zdvoPtCRNr2Oo3sJGYqkt86Hu6agKFiljP5AgJNx7iQD5GQn6J3w="
-  - secure: "gqyPF3d75JuwZptnQQQKO6rGUILXGO09y9dZhShdX8qq5Mexa2ISk77Y/b0yyAdhJMgEglls5cWlbHkwCAB0i4yL25RE5CtQUe4er+CIKwBIs0M56ghbcOwWAFB/cXeyyWmXDHBVnVUeKm7IJ34txsEclnMzQSR/DInSzsCFMUQok8HEaWZNssMjyRgo6goKGdG5vNWGfLLY7mKGMe/6PpYJD0G8k+Na08aX06ZWph38He8O3imUAngoQrxiSp0UYmnHDkigbV7S2LdZOsj7kMxkiyigzK/P1eygHVbFAhohLroaqS9B4CBK7QeOyup2vxVKqJVzFwOCylD0786CImvaG2ZYMtvJkapvaEE0mdMlyYpHgdIkmHZu28aMW7hXEhxHyBAxKuPcj5eGCGziO+ztCvfYIA9CGs1uA4KLrED7SahvB0oXnt3KTFdRc857cWcpp2NmRKihLzVdgHlmT8zcYaec3zP1VdMoa2bmLHoaZtAwvMTcAG56FcET1p7f9v+uiU88ZeptEjTJfpAWlq34tpwZXNyIQi5IROocSHM+PKTgLAsAMP5klGascr8E0sEzREl7tg8hqEwXKym/sVKyT+HMptA3UZcrZZhm07/cmQ0pUVvbV9QDb0MzU3O2wF7vT3U7R7Fb1u0LxMjblPyEazTp8ldabVRJREwlsDc="
-  - secure: "JIhuqaI0i+zvuqqXiQBHpuKr7AQ8jfk6Gbr8Qgiq4yJtdEWXZGxnAT9BmlbjkgT7ABXvLgxf2CIdUOMo1yYfBlxQL/y5+e89jaVpYF3tvNAzYQ1e12VzQRsd/jDb7qvm7tw3rDHEn3dSEot7Q6KbPcL6WzWJINVMCCmOgvq9gKHgE6Y5q5EgZ5rxiXyuO27ndzcbxaor4PIaiSzHO9+AJQ7p2zDLP+kG4nKVTBX0l9VoKiYFhIpIhpbigi3jyLDMDRiWpwTWZC6P8/RXfZg/lc5ADOuM2DM8oXPpZuqOa/g31LWQOSCuEnQ1G16vbLgipSPpgAc7jYWD5cywhG9dLkiKaZDh5x0meLM2RoAgz6eAnQfTTqJ68OM9o9yXjubEedsNpNRAr9/DXMd+fbh10W2vbvL5HCNB3lic3anehhR9le7PLuEKxg654wXt3KM2PZGVWbotIyBK0CvGzqGkppvwT23QdDDqSdkWuGQIhGQ0xBOdYkwebycxP5wwPUmObG+mymQ1Be2BXvmghttsiJdKlt4CVSYOJUMus6kU32G95hdTgKblsX4J1Of2i1nYsjyMKh3k945tqXwQrIsxOOQug0oIkz24zlLaOaQcorWtJ6Y1HPaZKpVIFUEF0y8Uq/O4oB2bOYC6WDUQfpj7nRG6xbi+BeBS84m1ttCEk4g="
-  matrix:
-  - BUILD=deploy
-  - BUILD=doc
-  - BUILD=sonar
-  - BUILD=coveralls
+  - secure: "B2quYqla3mqu3QHqeRGMde66IFAluUHhzY87q/giPvONm/V7xmIcxzC6JNQ7X4pHotC7MUbsMf7vdcL1tyuPP5nqyfaxk0nnGnVoJZIQhMaBQ6Lkyt2Ac5u5/QBeHujrj8gqGjT7vzgPIYMYiSLV09VcPgMaYS6WxCrFmXOEJOeVGOGjG9J2wApAmlf6m/hBogLEbdbzRheqJwX5gMxppKX5XRaiqvKGR7hHFiW5HBaAiQ6caQEw6DZL9GnjMsqd5VMVL7DmbETncNE1utLVDO7mFwDMbkeonmwjsmQsJAo5Be+WFl/a/yRQLrqhhTFwag+V7g7RjcBKAdJ5IZJkN0EC9GjY0ZGOjE2cmcrX03U1g1voO7oreH6+25VqPTTGWHv5K8wDWM5QnhBJGtH2yH76p5XYK8iNOXPTqvjubN9sG3INsnTjxBHuQw+aY2vgwBGCvW+Asqe73BV8SDrmqcCqgmm/BUy0kZRd8mhaQdFL0SAO3suV7uf+fzIsmRtndFx24J5Cm6LE6NnTmtbhHhs4mUEqfngMq0XZBXj5z4LDhzOH4g3rf/Y7jHBjAAa6sKeh1sINdHrMdB843dDfNQPp/7g3hfKi31U9ZMczndsr2QYqm2OC/3lPiRHC+8Grj5PxXmiBplzTppyhl+1pjZWy5SCoQi6ulBOyaZcwfYM="
+  - secure: "Kmh31kozw9NBbwtkucpf+QslinJIclB7rcktHz4RokVS5xiMD7njWvD8ptZhXqZG/tNcNiXkWskgM9EV/OvLTTavJToHE1gMhJel5ODxKM0b5QZDy6tkW/wI0Kdl0lck90EAJ7bmsOmF+oGczGsauiLPSlBOZV0tn1zdeJKwwmg46C9UyIhTDcFqUD1ehxExkDHnbOk6HmEPGCsZQCGNXY2t++dO7fRodIgjZAKcyTwgrh6WEZDfQDjvC51yQlVzL2mrcFqHi8qYAx3OHnuidRoMZ4huaoxLimw/1bGii/txTZwJ/pQdF90kGqSqLpRiO2lHLq5l8WAd4Z1XPSs1ZzbKUEhWO8VGgfR0Cp+Bkkd6P/vcuTq7bdhpvdnZn9FRUI/bfgZi827Skj/WoUh0RR7ns6RuDfQ5uGD9NiWDsbfoKLbvvYjyQycQlQTKglYQVcU/pWsuqVlx+27vM6JltR0Pct4uAJxAN+EFA4sTT/u4HiZ0NQyZWisZauu7CyMRN29fkKVVyYHHCr6QcNMUpvp1vvKYaUN7GeykGNVfoHB7CWAKcc6banh33c+QqG5DSTE++ZNa712gxEizQnO5MmLECUxNDpOGZnLsTlgbABwDxxe4PxFxXvBLm9pkJftq5cp9T9Syzz/yyT7z5weSGvRes94eUtSt0agoeX2MKsE="
+  - secure: "VezxV+VdmbmtrQYT8AZIyg41WBROxuxpumerkcubADF7V4wV6lwx9Rd2G6yAr0VuHCNUUhS4m+gPFIsuiQbAhyupiEkwhzUYqk1tF+LITlLLPegLypjiLmhJMwGUNuDSSsih1Icmg9FzrP4VyzgGn9pBjoG9QYj1civBZeGwg++e/XDYlHMXrpd/UEfMKVB71JwB0tle4fKJZSvblIqP62yvbBaKHx6A4+ZWzJV5Vps0DoIeNtKCNmNNloKZVHfjbsvqSjnMYUJzkOzyPkM822q41N/D+3IAufO16+jH/W0vAZeN0e4GXiN5W+CVkr2Gbh0FwkVQcI3bekaOIn45XLUMLKdf+JsWDPKz9RraHelR9YxL5GoJ7ntwvmucxw0p8EVyJ/xLk/pBCP8iHq0Jb8//js25XHgxzzAWI37MErPAAGgTKZAVdAN0mGXbe63tWmwaBlEbK8h2A8di6abW5x6YHTkTo2BRlHUSTU8dE3VqTnpSkne5n1SlEa4g1Bci3J45M0/pLmHV6yCxCM5BrVXS5ByaB61py/umSbpmdIBFV6TM1MaKK3lAucQrR+8To/vCbm8XqPyujJdOR+ENIuuDgEU/Yh5Hv5SAODekUYaCp4pjfGzFADHQWVNDxIOXrwBN4OfSiAvRc1x6HXndOmNI4QtOxheuCRFFthq8VZI="
 
-matrix:
+jobs:
   fast_finish: true
+  include:
+    - stage: build
+      name: "linux - mvn deploy"
+      os: linux
+      dist: bionic
+      env: BUILD=deploy
+    - name: "linux - build documentation"
+      os: linux
+      dist: bionic
+      env: BUILD=doc
+    - name: "linux - run sonar"
+      os: linux
+      dist: bionic
+      env: BUILD=sonar
+      if: "type = push && repo = pmd/pmd && fork = false"
+    - name: "linux - run coveralls"
+      os: linux
+      dist: bionic
+      env: BUILD=coveralls
+      if: "type = push && repo = pmd/pmd && fork = false"
+    - name: "macosx - mvn verify"
+      os: osx
+      env: BUILD=deploy
+    - name: "windows - mvn verify"
+      os: windows
+      env: BUILD=deploy
+      language: shell
+    - stage: publish
+      name: "Release Build - Publish"
+      os: linux
+      dist: bionic
+      if: "type = push && repo = pmd/pmd && fork = false && tag is present"
+      env: BUILD=publish
 
 before_install:
-  - bash .travis/setup-secrets.sh
-  - bash .travis/configure-maven.sh
+  - bash .travis/before_install.sh "11.0.6+10"
+  - source ${HOME}/java.env
 install: true
 before_script: true
 script: source .travis/build-$BUILD.sh
 after_success: true
 
 
-before_deploy: true
-deploy:
-  provider: releases
-  api_key: ${GITHUB_OAUTH_TOKEN}
-  file_glob: true
-  file:
-  - pmd-dist/target/pmd-*.zip
-  - docs/pmd-doc-*.zip
-  skip_cleanup: true
-  on:
-    tags: true
-    repo: pmd/pmd
-    condition: "${TRAVIS_SECURE_ENV_VARS} = true && ${BUILD} != sonar"
-after_deploy: bash .travis/release.sh
-
 notifications:
+  webhooks:
+    urls:
+      - https://webhooks.gitter.im/e/0e6dd310db54b96c2653
+      - https://webhooks.gitter.im/e/65efc1ea65175ad23ab6
+    on_success: always  # options: [always|never|change] default: always
+    on_failure: always  # options: [always|never|change] default: always
+    on_start: never     # options: [always|never|change] default: always
   email:
     recipients:
     - andreas.dangel@adangel.org
-    - pmd-commits@lists.sourceforge.net
-    on_success: always
+    on_success: change
     on_failure: always
 cache:
   directories:
   - "$HOME/.m2"
-
+  - "$HOME/.cache"
+  - vendor/bundle
+  - "$HOME/.rvm/"
 
 # Secure Keys, that need to be set for snapshot builds
 #
@@ -76,7 +86,6 @@ cache:
 # PMD_SF_USER - the sourceforge user, which is used to upload created binaries to sf files section. Note: an ssh key is
 #               required. See "before_install".
 #
-#
 # Secure Keys, that need to be set for releases:
 #
 # PMD_SF_APIKEY - used to make the new release the default file in the files section. See https://sourceforge.net/auth/preferences/

.travis/all-java.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0"?>
+
+<ruleset name="All Java Rules" 
+    xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+    <description>Every java rule in PMD which is used for the regression tests with pmdtester</description>
+
+    <rule ref="category/java/bestpractices.xml" />
+    <rule ref="category/java/codestyle.xml" />
+    <rule ref="category/java/design.xml" />
+    <rule ref="category/java/documentation.xml" />
+    <rule ref="category/java/errorprone.xml" />
+    <rule ref="category/java/multithreading.xml" />
+    <rule ref="category/java/performance.xml" />
+    <rule ref="category/java/security.xml" />
+
+</ruleset>

.travis/before_install.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+set -e
+
+source .travis/logger.sh
+source .travis/common-functions.sh
+
+travis_debug
+
+OPENJDK_VERSION=$1
+
+bash .travis/setup-secrets.sh
+bash .travis/configure-maven.sh
+bash .travis/install-openjdk.sh $OPENJDK_VERSION
+
+
+if travis_isLinux; then
+    gem install bundler
+    bundle install --with=release_notes_preprocessing --path=vendor/bundle
+else
+    log_info "Not setting up ruby for ${TRAVIS_OS_NAME}."
+    exit 0
+fi

.travis/build-coveralls.sh

@@ -1,20 +1,28 @@
 #!/bin/bash
 set -e
 
+source .travis/logger.sh
 source .travis/common-functions.sh
 
-VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
-echo "Building PMD Coveralls.io report ${VERSION} on branch ${TRAVIS_BRANCH}"
+VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
+log_info "Building PMD Coveralls.io report ${VERSION} on branch ${TRAVIS_BRANCH}"
 
 if ! travis_isPush; then
     echo "Not proceeding, since this is not a push!"
     exit 0
 fi
 
-#
-# for java9: enable all modules.
-# coveralls plugin seems to need java.xml.bind module
-echo "MAVEN_OPTS='-Xms1g -Xmx1g --add-modules java.se.ee'" > ${HOME}/.mavenrc
+(
+    # disable fast fail, exit immediately, in this subshell
+    set +e
 
-./mvnw clean install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
-./mvnw test jacoco:report coveralls:report -Pcoveralls -B -V
+    ./mvnw clean install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
+    ./mvnw package jacoco:report coveralls:report -Pcoveralls -B -V
+
+    if [ $? -ne 0 ]; then
+        log_error "Error creating coveralls report"
+    else
+        log_success "New coveralls result: https://coveralls.io/github/pmd/pmd"
+    fi
+    true
+)

.travis/build-deploy.sh

@@ -1,59 +1,78 @@
 #!/bin/bash
 set -e
 
+source .travis/logger.sh
 source .travis/common-functions.sh
+source .travis/github-releases-api.sh
+source .travis/sourceforge-api.sh
+source .travis/regression-tester.sh
 
-function push_docs() {
-    if git diff --quiet docs; then
-        echo "No changes in docs..."
-    else
-        echo "Found changes in docs..."
-
-        if [ "$TRAVIS_BRANCH" == "master" ]; then
-            git config user.name "Travis CI (pmd-bot)"
-            git config user.email "andreas.dangel+pmd-bot@adangel.org"
-            git add -A docs
-            git commit -m "Update documentation"
-            git push git@github.com:pmd/pmd.git HEAD:master
-        else
-            echo "Not on master branch, won't commit+push"
-        fi
-    fi
-}
-
-
-VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
-echo "Building PMD ${VERSION} on branch ${TRAVIS_BRANCH}"
+VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
+log_info "Building PMD ${VERSION} on branch ${TRAVIS_BRANCH}"
 
 MVN_BUILD_FLAGS="-B -V"
 
-if travis_isPullRequest; then
+if travis_isOSX; then
 
-    echo "This is a pull-request build"
+    log_info "The build is running on OSX"
     ./mvnw verify $MVN_BUILD_FLAGS
 
+elif travis_isWindows; then
+
+    log_info "The build is running on Windows"
+    ./mvnw verify $MVN_BUILD_FLAGS
+
+elif travis_isPullRequest; then
+
+    log_info "This is a pull-request build"
+    ./mvnw verify $MVN_BUILD_FLAGS
+
+    regression-tester_executeDanger
+
 elif travis_isPush; then
 
     if [[ "${VERSION}" != *-SNAPSHOT && "${TRAVIS_TAG}" != "" ]]; then
-        echo "This is a release build for tag ${TRAVIS_TAG}"
-        ./mvnw deploy -Possrh,pmd-release $MVN_BUILD_FLAGS
+        echo -e "\n\n"
+        log_info "This is a release build for tag ${TRAVIS_TAG}"
+        echo -e "\n\n"
+
+        # create a draft github release
+        gh_releases_createDraftRelease "${TRAVIS_TAG}" "$(git rev-list -n 1 ${TRAVIS_TAG})"
+        GH_RELEASE="$RESULT"
+
+        # Build and deploy to ossrh / maven-central
+        ./mvnw deploy -Possrh,sign,pmd-release $MVN_BUILD_FLAGS
+        echo -e "\n\n"
+
+        # Deploy to github releases
+        gh_release_uploadAsset "$GH_RELEASE" "pmd-dist/target/pmd-bin-${VERSION}.zip"
+        gh_release_uploadAsset "$GH_RELEASE" "pmd-dist/target/pmd-src-${VERSION}.zip"
+
+        # Deploy to sourceforge files
+        sourceforge_uploadFile "${VERSION}" "pmd-dist/target/pmd-bin-${VERSION}.zip"
+        sourceforge_uploadFile "${VERSION}" "pmd-dist/target/pmd-src-${VERSION}.zip"
+
+        regression-tester_uploadBaseline
+
     elif [[ "${VERSION}" == *-SNAPSHOT ]]; then
-        echo "This is a snapshot build"
-        ./mvnw deploy -Possrh $MVN_BUILD_FLAGS
-        push_docs
+        log_info "This is a snapshot build"
+        ./mvnw deploy -Possrh,sign $MVN_BUILD_FLAGS
+        
+        # Deploy to sourceforge files
+        sourceforge_uploadFile "${VERSION}" "pmd-dist/target/pmd-bin-${VERSION}.zip"
+        sourceforge_uploadFile "${VERSION}" "pmd-dist/target/pmd-src-${VERSION}.zip"
+
+        regression-tester_uploadBaseline
+
     else
         # other build. Can happen during release: the commit with a non snapshot version is built, but not from the tag.
-        echo "This is some other build, probably during release: commit with a non-snapshot version on branch master..."
-        ./mvnw verify -Possrh $MVN_BUILD_FLAGS
+        log_info "This is some other build, probably during release: commit with a non-snapshot version on branch master..."
+        ./mvnw verify $MVN_BUILD_FLAGS
         # we stop here - no need to execute further steps
         exit 0
     fi
 
-    # Uploading pmd distribution to sourceforge
-    rsync -avh pmd-dist/target/pmd-*-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
-    rsync -avh docs/pages/release_notes.md ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/ReadMe.md
-
 else
-    echo "This is neither a pull request nor a push!"
+    log_info "This is neither a pull request nor a push. Not executing any build."
     exit 1
 fi

.travis/build-doc.sh

@@ -1,39 +1,170 @@
 #!/bin/bash
 set -e
 
+source .travis/logger.sh
 source .travis/common-functions.sh
+source .travis/github-releases-api.sh
+source .travis/sourceforge-api.sh
 
-VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
-echo "Building PMD Documentation ${VERSION} on branch ${TRAVIS_BRANCH}"
+function main() {
+    VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
+    log_info "Building PMD Documentation ${VERSION} on branch ${TRAVIS_BRANCH}"
 
-if ! travis_isPush; then
-    echo "Not building site, since this is not a push!"
-    exit 0
-fi
+    #
+    # First step: build pmd with profile "generate-rule-docs"
+    # The docs should appear under "docs/pages/rules/..." for each language
+    # With this profile, also the checks are executed (e.g. DeadLinksChecker).
+    #
+    ./mvnw clean verify -Dmaven.test.skip=true -Dmaven.javadoc.skip=true -P generate-rule-docs
 
-pushd docs
+    if ! travis_isPush; then
+        log_info "Not publishing site, since this is not a push!"
+        exit 0
+    fi
 
-# run jekyll
-echo -e "\n\nBuilding documentation using jekyll...\n\n"
-bundle install
-bundle exec jekyll build
+    #
+    # For pushes, we'll update the online documentation
+    #
+    generate_jekyll_doc
+    create_pmd-doc_archive
 
-# create pmd-doc archive
-echo -e "\n\nCreating pmd-doc archive...\n\n"
-mv _site pmd-doc-${VERSION}
-zip -qr pmd-doc-${VERSION}.zip pmd-doc-${VERSION}/
+    # Deploy to sourceforge files
+    sourceforge_uploadFile "${VERSION}" "docs/pmd-doc-${VERSION}.zip"
+
+    if [[ "${VERSION}" == *-SNAPSHOT && "${TRAVIS_BRANCH}" == "master" ]]; then
+        # only for snapshot builds from branch master
+
+        # update github pages https://pmd.github.io/pmd/
+        publish_to_github_pages
+        # rsync site to https://pmd.sourceforge.io/snapshot
+        sourceforge_rsyncSnapshotDocumentation "${VERSION}" "snapshot"
+    fi
 
 
-# Uploading pmd doc distribution to sourceforge
-if [[ "${TRAVIS_TAG}" != "" || "${VERSION}" == *-SNAPSHOT ]]; then
-    echo -e "\n\nUploading pmd-doc archive to sourceforge...\n\n"
-    rsync -avh pmd-doc-${VERSION}.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${VERSION}/
-fi
+    if [[ "${VERSION}" != *-SNAPSHOT && "${TRAVIS_TAG}" != "" ]]; then
+        log_info "This is a release documentation build for pmd ${VERSION}"
 
-# rsync site to pmd.sourceforge.net/snapshot
-if [[ "${VERSION}" == *-SNAPSHOT && "${TRAVIS_BRANCH}" == "master" ]]; then
-    echo -e "\n\nUploading snapshot site...\n\n"
-    travis_wait rsync -ah --stats --delete pmd-doc-${VERSION}/ ${PMD_SF_USER}@web.sourceforge.net:/home/project-web/pmd/htdocs/snapshot/
-fi
+        # Deploy to github releases
+        gh_releases_getLatestDraftRelease
+        GH_RELEASE="$RESULT"
 
-popd
+        gh_release_uploadAsset "$GH_RELEASE" "docs/pmd-doc-${VERSION}.zip"
+
+        # updating github release text
+        # renders, and skips the first 6 lines - the Jekyll front-matter
+        RENDERED_RELEASE_NOTES=$(bundle exec .travis/render_release_notes.rb docs/pages/release_notes.md | tail -n +6)
+        RELEASE_NAME="PMD ${VERSION} ($(date -u +%d-%B-%Y))"
+        gh_release_updateRelease "$GH_RELEASE" "$RELEASE_NAME" "$RENDERED_RELEASE_NOTES"
+        sourceforge_uploadReleaseNotes "${VERSION}" "${RENDERED_RELEASE_NOTES}"
+
+        publish_release_documentation_github
+        sourceforge_rsyncSnapshotDocumentation "${VERSION}" "pmd-${VERSION}"
+    fi
+}
+
+#
+# Executes jekyll and generates the documentation
+# The documentation will be generated in the directory "docs/_site".
+#
+function generate_jekyll_doc() {
+    pushd docs
+
+    echo -e "\n\n"
+    log_info "Building documentation using jekyll..."
+    bundle install
+    bundle exec jekyll build
+
+    popd
+}
+
+#
+# Creates the pmd-doc.zip archive. It will be placed in "docs/".
+#
+function create_pmd-doc_archive() {
+    pushd docs
+
+    echo -e "\n\n"
+    log_info "Creating pmd-doc archive..."
+    mv _site pmd-doc-${VERSION}
+    zip -qr pmd-doc-${VERSION}.zip pmd-doc-${VERSION}/
+    log_success "Successfully created pmd-doc-${VERSION}.zip"
+
+    popd
+}
+
+#
+# Publishes the site to https://pmd.github.io/pmd-${VERSION} and
+# https://pmd.github.io/latest/
+#
+function publish_release_documentation_github() {
+    echo -e "\n\n"
+    log_info "Adding the new doc to pmd.github.io..."
+    # clone pmd.github.io. Note: This uses the ssh key setup earlier
+    # In order to speed things up, we use a sparse checkout - no need to checkout all directories here
+    mkdir pmd.github.io
+    (
+        cd pmd.github.io
+        git init
+        git config user.name "Travis CI (pmd-bot)"
+        git config user.email "andreas.dangel+pmd-bot@adangel.org"
+        git config core.sparsecheckout true
+        git remote add origin git@github.com:pmd/pmd.github.io.git
+        echo "/latest/" > .git/info/sparse-checkout
+        echo "/sitemap.xml" >> .git/info/sparse-checkout
+        git pull --depth=1 origin master
+        log_info "Copying documentation from ../docs/pmd-doc-${VERSION}/ to pmd-${VERSION}/ ..."
+        rsync -ah --stats ../docs/pmd-doc-${VERSION}/ pmd-${VERSION}/
+        git status
+        echo "Executing: git add pmd-${VERSION}"
+        git add pmd-${VERSION}
+        echo "Executing: git commit..."
+        git commit -q -m "Added pmd-${VERSION}"
+
+        log_info "Copying pmd-${VERSION} to latest ..."
+        git rm -qr latest
+        cp -a pmd-${VERSION} latest
+        echo "Executing: git add latest"
+        git add latest
+        echo "Executing: git commit..."
+        git commit -q -m "Copying pmd-${VERSION} to latest"
+
+        log_info "Generating sitemap.xml"
+        ../.travis/sitemap_generator.sh > sitemap.xml
+        echo "Executing: git add sitemap.xml"
+        git add sitemap.xml
+        echo "Executing: git commit..."
+        git commit -q -m "Generated sitemap.xml"
+
+        echo "Executing: git push origin master"
+        git push origin master
+    )
+}
+
+#
+# Updates github pages of the main repository,
+# so that https://pmd.github.io/pmd/ has the latest (snapshot) content
+#
+function publish_to_github_pages() {
+    echo -e "\n\n"
+    log_info "Pushing the new site to github pages..."
+    git clone --branch gh-pages --depth 1 git@github.com:pmd/pmd.git pmd-gh-pages
+    # clear the files first
+    rm -rf pmd-gh-pages/*
+    # copy the new site
+    cp -a docs/pmd-doc-${VERSION}/* pmd-gh-pages/
+    (
+        cd pmd-gh-pages
+        git config user.name "Travis CI (pmd-bot)"
+        git config user.email "andreas.dangel+pmd-bot@adangel.org"
+        git add -A
+        MSG="Update documentation
+
+TRAVIS_JOB_NUMBER=${TRAVIS_JOB_NUMBER}
+TRAVIS_COMMIT_RANGE=${TRAVIS_COMMIT_RANGE}"
+        git commit -q -m "$MSG"
+        git push git@github.com:pmd/pmd.git HEAD:gh-pages
+        log_success "Successfully pushed site to https://pmd.github.io/pmd/"
+    )
+}
+
+main

.travis/build-publish.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+set -e
+
+source .travis/logger.sh
+source .travis/common-functions.sh
+source .travis/github-releases-api.sh
+source .travis/sourceforge-api.sh
+
+VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
+log_info "PMD Release ${VERSION}"
+
+if ! travis_isPush; then
+    log_info "Not publishing release, since this is not a push!"
+    exit 0
+fi
+
+if [[ "${VERSION}" == *-SNAPSHOT || "${TRAVIS_TAG}" == "" ]]; then
+    log_info "Not publishing release, since this is not a release!"
+    exit 0
+fi
+
+
+# Publish github release
+gh_releases_getLatestDraftRelease
+GH_RELEASE="$RESULT"
+
+gh_release_publishRelease "$GH_RELEASE"
+sourceforge_selectDefault "${VERSION}"

.travis/build-sonar.sh

@@ -1,20 +1,33 @@
 #!/bin/bash
 set -e
 
+source .travis/logger.sh
 source .travis/common-functions.sh
 
-VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
-echo "Building PMD Sonar ${VERSION} on branch ${TRAVIS_BRANCH}"
+VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec)
+log_info "Building PMD Sonar ${VERSION} on branch ${TRAVIS_BRANCH}"
 
 if ! travis_isPush; then
     echo "Not updating sonar, since this is not a push!"
     exit 0
 fi
 
-#
-# for java9: enable all modules.
-# sonar plugin seems to need java.xml.bind module
-echo "MAVEN_OPTS='-Xms1g -Xmx1g --add-modules java.se.ee'" > ${HOME}/.mavenrc
+(
+    # for sonar, we need to use java10, until sonarjava 5.8.0 is released (Sept. 2018)
+    JAVA_HOME=$(bash ./install-jdk.sh -F 10 -L GPL -W $HOME/jdk --emit-java-home  | tail --lines 1)
+    export JAVA_HOME
+    export PATH=${JAVA_HOME}/bin:$PATH
 
-# Run the build, truncate output due to Travis log limits
-./mvnw clean org.jacoco:jacoco-maven-plugin:prepare-agent package sonar:sonar -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=${SONAR_TOKEN} -B -V
+    # disable fast fail, exit immediately, in this subshell
+    set +e
+
+    # Run the build
+    ./mvnw clean package sonar:sonar -Dsonar.login=${SONAR_TOKEN} -Psonar -B -V
+
+    if [ $? -ne 0 ]; then
+        log_error "Error updating sonar..."
+    else
+        log_success "New sonar results: https://sonarcloud.io/dashboard?id=net.sourceforge.pmd%3Apmd"
+    fi
+    true
+)

.travis/common-functions.sh

@@ -2,14 +2,17 @@
 set -e
 
 
-echo "TRAVIS_REPO_SLUG: ${TRAVIS_REPO_SLUG}"
-echo "TRAVIS_PULL_REQUEST_SLUG: ${TRAVIS_PULL_REQUEST_SLUG}"
-echo "TRAVIS_PULL_REQUEST_BRANCH: ${TRAVIS_PULL_REQUEST_BRANCH}"
-echo "TRAVIS_PULL_REQUEST: ${TRAVIS_PULL_REQUEST}"
-echo "TRAVIS_SECURE_ENV_VARS: ${TRAVIS_SECURE_ENV_VARS}"
-echo "TRAVIS_BRANCH: ${TRAVIS_BRANCH}"
-echo "TRAVIS_TAG: ${TRAVIS_TAG}"
-echo "TRAVIS_ALLOW_FAILURE: ${TRAVIS_ALLOW_FAILURE}"
+function travis_debug() {
+    echo "TRAVIS_REPO_SLUG: ${TRAVIS_REPO_SLUG}"
+    echo "TRAVIS_PULL_REQUEST_SLUG: ${TRAVIS_PULL_REQUEST_SLUG}"
+    echo "TRAVIS_PULL_REQUEST_BRANCH: ${TRAVIS_PULL_REQUEST_BRANCH}"
+    echo "TRAVIS_PULL_REQUEST: ${TRAVIS_PULL_REQUEST}"
+    echo "TRAVIS_SECURE_ENV_VARS: ${TRAVIS_SECURE_ENV_VARS}"
+    echo "TRAVIS_BRANCH: ${TRAVIS_BRANCH}"
+    echo "TRAVIS_TAG: ${TRAVIS_TAG}"
+    echo "TRAVIS_ALLOW_FAILURE: ${TRAVIS_ALLOW_FAILURE}"
+    echo "TRAVIS_OS_NAME: ${TRAVIS_OS_NAME}"
+}
 
 function travis_isPullRequest() {
     if [ "${TRAVIS_REPO_SLUG}" != "pmd/pmd" ] || [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
@@ -26,3 +29,27 @@ function travis_isPush() {
         return 1
     fi
 }
+
+function travis_isOSX() {
+    if [[ $TRAVIS_OS_NAME == 'osx' ]]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+function travis_isLinux() {
+    if [[ $TRAVIS_OS_NAME == 'linux' ]]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+function travis_isWindows() {
+    if [[ $TRAVIS_OS_NAME == 'windows' ]]; then
+        return 0
+    else
+        return 1
+    fi
+}

.travis/github-releases-api.sh

@@ -0,0 +1,200 @@
+#
+# The functions here require the following scripts:
+# .travis/logger.sh
+#
+# The functions here require the following environment variables:
+# GITHUB_OAUTH_TOKEN
+#
+
+#
+# Creates a new release on github with the given tag and target_commit.
+# The release is draft and not published.
+#
+# $RESULT = release json string
+#
+# See: https://developer.github.com/v3/repos/releases/#create-a-release
+#
+function gh_releases_createDraftRelease() {
+    local tagName="$1"
+    local targetCommitish="$2"
+
+    log_debug "$FUNCNAME: Creating new draft release for tag=$tagName and commit=$targetCommitish"
+
+    local request=$(cat <<-EOF
+		{
+		    "tag_name": "${tagName}",
+		    "target_commitish": "${targetCommitish}",
+		    "name": "${tagName}",
+		    "draft": true
+		}
+		EOF
+    )
+
+    log_debug "POST https://api.github.com/repos/pmd/pmd/releases"
+    log_info "Creating github draft release"
+    RESULT=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+                -H "Content-Type: application/json" \
+                -X POST \
+                --data "${request}" \
+                "https://api.github.com/repos/pmd/pmd/releases")
+    log_debug " -> response: $RESULT"
+
+    log_success "Created draft release with id $(echo $RESULT | jq --raw-output ".url")"
+}
+
+#
+# Gets the latest release, if it is a draft and returns with 0.
+# Returns with 1, if the latest release is not a draft - meaning, there is no
+# draft release (yet?).
+# 
+# RESULT = release json string
+#
+# See: https://developer.github.com/v3/repos/releases/#list-releases-for-a-repository
+#
+function gh_releases_getLatestDraftRelease() {
+    log_debug "$FUNCNAME"
+    log_debug "GET https://api.github.com/repos/pmd/pmd/releases?per_page=1"
+    RESULT=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+                "https://api.github.com/repos/pmd/pmd/releases?per_page=1" | jq ".[0]")
+    log_debug " -> response: $RESULT"
+    local draft=$(echo $RESULT | jq ".draft")
+    if [ "$draft" != "true" ]; then
+        RESULT=""
+        log_error "Could not find draft release!"
+        return 1
+    fi
+    log_info "Found draft release: $(echo $RESULT | jq --raw-output ".url")"
+}
+
+#
+# Deletes a release.
+#
+# See: https://developer.github.com/v3/repos/releases/#delete-a-release
+#
+function gh_release_deleteRelease() {
+    local release="$1"
+
+    gh_release_getIdFromData "$release"
+    local releaseId="$RESULT"
+    log_debug "$FUNCNAME id=$releaseId"
+    log_debug "DELETE https://api.github.com/repos/pmd/pmd/releases/$releaseId"
+    log_info "Deleting github release $releaseId"
+    local response
+    response=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+        -X DELETE \
+        "https://api.github.com/repos/pmd/pmd/releases/$releaseId")
+    log_debug " -> response: $response"
+    log_success "Deleted release with id $releaseId"
+}
+
+#
+# Determines the release id from the given JSON release data.
+#
+# RESULT = "the release id"
+#
+function gh_release_getIdFromData() {
+    local release="$1"
+
+    RESULT=$(echo $release | jq --raw-output ".id")
+}
+
+#
+# Uploads a asset to an existing release.
+#
+# See: https://developer.github.com/v3/repos/releases/#upload-a-release-asset
+#
+function gh_release_uploadAsset() {
+    local release="$1"
+    local filename="$2"
+    local name=$(basename $filename)
+
+    gh_release_getIdFromData "$release"
+    local releaseId="$RESULT"
+    log_debug "$FUNCNAME: releaseId=$releaseId file=$filename name=$name"
+
+    local uploadUrl=$(echo "$release" | jq --raw-output ".upload_url")
+    uploadUrl="${uploadUrl%%\{\?name,label\}}"
+    uploadUrl="${uploadUrl}?name=${name}"
+    log_debug "POST $uploadUrl"
+    log_info "Uploading $filename to github release $releaseId"
+    local response
+    response=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+                        -H "Content-Type: application/zip" \
+                        --data-binary "@$filename" \
+                        -X POST \
+                        "${uploadUrl}")
+    log_debug " -> response: $response"
+    log_success "Uploaded release asset $filename for release $releaseId"
+}
+
+#
+# Updates the release info: name and body.
+# The body is escaped to fit into JSON, so it is allowed for the body to be
+# a multi-line string.
+#
+# See: https://developer.github.com/v3/repos/releases/#edit-a-release
+#
+function gh_release_updateRelease() {
+    local release="$1"
+    local name="$2"
+    local body="$3"
+
+    gh_release_getIdFromData "$release"
+    local releaseId="$RESULT"
+    log_debug "$FUNCNAME releaseId=$releaseId name=$name"
+
+    body="${body//'\'/\\\\}"
+    body="${body//$'\r'/}"
+    body="${body//$'\n'/\\r\\n}"
+    body="${body//'"'/\\\"}"
+
+    local request=$(cat <<-EOF
+		{
+		    "name": "${name}",
+		    "body": "${body}"
+		}
+		EOF
+    )
+
+    log_debug "PATCH https://api.github.com/repos/pmd/pmd/releases/${releaseId}"
+    log_debug " -> request: $request"
+    log_info "Updating github release $releaseId"
+    local response
+    response=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+                         -H "Content-Type: application/json" \
+                         --data "${request}" \
+                         -X PATCH \
+                         "https://api.github.com/repos/pmd/pmd/releases/${releaseId}")
+    log_debug " -> response: $response"
+    log_success "Updated release with id=$releaseId"
+}
+
+#
+# Publish a release by setting draft="false".
+# Note: This will send out the notification emails if somebody
+# watched the releases.
+#
+# See: https://developer.github.com/v3/repos/releases/#edit-a-release
+#
+function gh_release_publishRelease() {
+    local release="$1"
+
+    gh_release_getIdFromData "$release"
+    local releaseId="$RESULT"
+    log_debug "$FUNCNAME releaseId=$releaseId"
+
+    local request='{"draft":false}'
+    log_debug "PATCH https://api.github.com/repos/pmd/pmd/releases/${releaseId}"
+    log_debug " -> request: $request"
+    log_info "Publishing github release $releaseId"
+    local response
+    response=$(curl --fail -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" \
+                         -H "Content-Type: application/json" \
+                         --data "${request}" \
+                         -X PATCH \
+                         "https://api.github.com/repos/pmd/pmd/releases/${releaseId}")
+    log_debug " -> response: $response"
+    local htmlUrl=$(echo "$response" | jq --raw-output ".html_url")
+    log_success "Published release with id=$releaseId at $htmlUrl"
+}
+

.travis/install-openjdk.sh

@@ -0,0 +1,62 @@
+#!/bin/bash
+set -e
+
+#
+# AdoptOpenJDK Builds from:
+# https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11.0.4%2B11
+#
+
+source .travis/logger.sh
+source .travis/common-functions.sh
+
+# VERSION_TAG e.g. "11.0.4+11" or "13+33"
+VERSION_TAG=$1
+OPENJDK_MAJOR=${VERSION_TAG/.*/}
+OPENJDK_MAJOR=${OPENJDK_MAJOR/+*/}
+#BASE_URL=https://github.com/AdoptOpenJDK/openjdk${OPENJDK_MAJOR}-binaries/releases/download
+BASE_URL=https://pmd-code.org/openjdk
+
+log_info "Installing OpenJDK${OPENJDK_MAJOR}U ${VERSION_TAG} for ${TRAVIS_OS_NAME}"
+
+if travis_isOSX; then
+    DOWNLOAD_URL=${BASE_URL}/jdk-${VERSION_TAG/+/%2B}/OpenJDK${OPENJDK_MAJOR}U-jdk_x64_mac_hotspot_${VERSION_TAG/+/_}.tar.gz
+    COMPONENTS_TO_STRIP=3 # e.g. jdk-11.0.3+7/Contents/Home/bin/java
+elif travis_isWindows; then
+    DOWNLOAD_URL=${BASE_URL}/jdk-${VERSION_TAG/+/%2B}/OpenJDK${OPENJDK_MAJOR}U-jdk_x64_windows_hotspot_${VERSION_TAG/+/_}.zip
+else
+    DOWNLOAD_URL=${BASE_URL}/jdk-${VERSION_TAG/+/%2B}/OpenJDK${OPENJDK_MAJOR}U-jdk_x64_linux_hotspot_${VERSION_TAG/+/_}.tar.gz
+    COMPONENTS_TO_STRIP=1 # e.g. openjdk-11.0.3+7/bin/java
+fi
+
+OPENJDK_ARCHIVE=$(basename $DOWNLOAD_URL)
+
+LOCAL_DIR=${HOME}/.cache/openjdk
+TARGET_DIR=${HOME}/openjdk${OPENJDK_MAJOR}
+
+mkdir -p ${LOCAL_DIR}
+mkdir -p ${TARGET_DIR}
+if [ ! -e ${LOCAL_DIR}/${OPENJDK_ARCHIVE} ]; then
+    log_info "Downloading from ${DOWNLOAD_URL} to ${LOCAL_DIR}"
+    wget --directory-prefix ${LOCAL_DIR} --timestamping --continue ${DOWNLOAD_URL}
+else
+    log_info "Skipped download, file ${LOCAL_DIR}/${OPENJDK_ARCHIVE} already exists"
+fi
+
+log_info "Extracting to ${TARGET_DIR}"
+if travis_isWindows; then
+    7z x ${LOCAL_DIR}/${OPENJDK_ARCHIVE} -o${TARGET_DIR}
+    mv ${TARGET_DIR}/*/* ${TARGET_DIR}/
+else
+    tar --extract --file ${LOCAL_DIR}/${OPENJDK_ARCHIVE} -C ${TARGET_DIR} --strip-components=${COMPONENTS_TO_STRIP}
+fi
+
+cat > ${HOME}/java.env <<EOF
+export JAVA_HOME="${TARGET_DIR}"
+export PATH="${TARGET_DIR}/bin:${PATH}"
+java -version
+EOF
+
+log_info "OpenJDK can be used via ${HOME}/java.env"
+cat ${HOME}/java.env
+source ${HOME}/java.env
+

.travis/logger.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+COL_GREEN="\e[32m"
+COL_RED="\e[31m"
+COL_RESET="\e[0m"
+COL_YELLOW="\e[33;1m"
+
+function log_error() {
+    echo -e "${COL_RED}[ERROR  ] $*${COL_RESET}"
+}
+
+function log_info() {
+    echo -e "${COL_YELLOW}[INFO   ] $*${COL_RESET}"
+}
+
+function log_success() {
+    echo -e "${COL_GREEN}[SUCCESS] $*${COL_RESET}"
+}
+
+function log_debug() {
+    true
+    #echo -e "[DEBUG  ] $*"
+}

.travis/project-list.xml

@@ -0,0 +1,27 @@
+<?xml version="1.0"?>
+
+<projectlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+xsi:noNamespaceSchemaLocation="projectlist_1_0_0.xsd">
+  <description>Standard Projects</description>
+
+  <project>
+    <name>checkstyle</name>
+    <type>git</type>
+    <connection>https://github.com/checkstyle/checkstyle</connection>
+    <tag>checkstyle-8.10</tag>
+  </project>
+
+  <project>
+    <name>spring-framework</name>
+    <type>git</type>
+    <connection>https://github.com/spring-projects/spring-framework</connection>
+    <tag>v5.0.6.RELEASE</tag>
+  </project>
+
+  <!---<project>
+    <name>openjdk10</name>
+    <type>hg</type>
+    <connection>http://hg.openjdk.java.net/jdk10/jdk10/jdk</connection>
+    <webview-url>http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/777356696811</webview-url>
+  </project> -->
+</projectlist>

.travis/regression-tester.sh

@@ -0,0 +1,79 @@
+#
+# The functions here require the following scripts:
+# .travis/logger.sh
+#
+# The functions here require the following environment variables:
+# PMD_SF_USER
+
+#
+# Generate a new baseline and upload it to sourceforge
+#
+# Note: this function always succeeds, even if the upload fails.
+# In that case, just a error logging is provided.
+#
+function regression-tester_uploadBaseline() {
+    log_debug "$FUNCNAME branch=${TRAVIS_BRANCH}"
+    local targetUrl="https://sourceforge.net/projects/pmd/files/pmd-regression-tester/"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function upload_failed() {
+            log_error "Error while uploading ${BRANCH_FILENAME}-baseline.zip to sourceforge!"
+            log_error "Please upload manually: ${targetUrl}"
+        }
+
+        # exit subshell after trap
+        set -e
+        trap upload_failed ERR
+
+        log_info "Generating and uploading baseline for pmdtester..."
+        cd ..
+        bundle config --local gemfile pmd/Gemfile
+        pmd/.travis/travis_wait "bundle exec pmdtester -m single -r ./pmd -p ${TRAVIS_BRANCH} -pc ./pmd/.travis/all-java.xml -l ./pmd/.travis/project-list.xml -f"
+        cd target/reports
+        BRANCH_FILENAME="${TRAVIS_BRANCH/\//_}"
+        zip -q -r ${BRANCH_FILENAME}-baseline.zip ${BRANCH_FILENAME}/
+        ../../pmd/.travis/travis_wait "rsync -avh ${BRANCH_FILENAME}-baseline.zip ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd-regression-tester/"
+        log_success "Successfully uploaded ${BRANCH_FILENAME}-baseline.zip to ${targetUrl}"
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}
+
+#
+# Execute danger, which executes pmd-regression-tester (via Dangerfile).
+#
+# Note: this function always succeeds, even if the danger fails.
+# In that case, just a error logging is provided.
+#
+function regression-tester_executeDanger() {
+    log_debug "$FUNCNAME"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function danger_failed() {
+            log_error "Error while executing danger/pmd-regression-tester"
+        }
+
+        # exit subshell after trap
+        set -e
+        trap danger_failed ERR
+
+        # Create a corresponding remote branch locally
+        if ! git show-ref --verify --quiet refs/heads/${TRAVIS_BRANCH}; then
+            git fetch --no-tags origin +refs/heads/${TRAVIS_BRANCH}:refs/remotes/origin/${TRAVIS_BRANCH}
+            git branch ${TRAVIS_BRANCH} origin/${TRAVIS_BRANCH}
+            log_debug "Created local branch ${TRAVIS_BRANCH}"
+        fi
+
+        log_info "Running danger on branch ${TRAVIS_BRANCH}"
+        bundle exec danger --verbose
+        log_success "Executing danger successfully"
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}

.travis/release.sh

@@ -1,75 +0,0 @@
-#!/bin/bash
-set -e
-
-echo "BUILD: $BUILD"
-RELEASE_VERSION=$(./mvnw -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.5.0:exec | tail -1)
-echo "RELEASE_VERSION: $RELEASE_VERSION"
-
-if [ "${BUILD}" = "deploy" ]; then
-
-# Deploy to ossrh has already been done with the usual build. See build-deploy.sh
-
-# The site has been built before, the files have already been uploaded to sourceforge.
-# Since this is a release, making the binary the new default file...
-curl -H "Accept: application/json" -X PUT -d "default=windows&default=mac&default=linux&default=bsd&default=solaris&default=others" \
-     -d "api_key=${PMD_SF_APIKEY}" https://sourceforge.net/projects/pmd/files/pmd/${RELEASE_VERSION}/pmd-bin-${RELEASE_VERSION}.zip
-
-
-# Assumes, the release has already been created by travis github releases provider
-RELEASE_ID=$(curl -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" https://api.github.com/repos/pmd/pmd/releases/tags/pmd_releases/${RELEASE_VERSION}|jq ".id")
-RELEASE_NAME="PMD ${RELEASE_VERSION} ($(date -u +%d-%B-%Y))"
-RELEASE_BODY=$(tail -n +6 docs/pages/release_notes.md) # skips the first 6 lines - the heading 'PMD Release Notes'
-RELEASE_BODY="${RELEASE_BODY//'\'/\\\\}"
-RELEASE_BODY="${RELEASE_BODY//$'\r'/}"
-RELEASE_BODY="${RELEASE_BODY//$'\n'/\\r\\n}"
-RELEASE_BODY="${RELEASE_BODY//'"'/\\\"}"
-cat > release-edit-request.json <<EOF
-{
-  "name": "$RELEASE_NAME",
-  "body": "$RELEASE_BODY"
-}
-EOF
-echo "Updating release at https://api.github.com/repos/pmd/pmd/releases/${RELEASE_ID}..."
-
-
-RESPONSE=$(curl -i -s -H "Authorization: token ${GITHUB_OAUTH_TOKEN}" -H "Content-Type: application/json" --data "@release-edit-request.json" -X PATCH https://api.github.com/repos/pmd/pmd/releases/${RELEASE_ID})
-if [[ "$RESPONSE" != *"HTTP/1.1 200"* ]]; then
-    echo "Request:"
-    cat release-edit-request.json
-    echo
-    echo "Response:"
-    echo "$RESPONSE"
-else
-    echo "Update OK"
-fi
-
-fi
-
-
-if [ "${BUILD}" = "doc" ]; then
-
-echo "Adding the new doc to pmd.github.io..."
-# clone pmd.github.io. Note: This uses the ssh key setup earlier
-# In order to speed things up, we use a sparse checkout - no need to checkout all directories here
-mkdir pmd.github.io
-(
-    cd pmd.github.io
-    git init
-    git config user.name "Travis CI (pmd-bot)"
-    git config user.email "andreas.dangel+pmd-bot@adangel.org"
-    git config core.sparsecheckout true
-    git remote add origin git@github.com:pmd/pmd.github.io.git
-    echo "latest/" > .git/info/sparse-checkout
-    git pull --depth=1 origin master
-    rsync -a ../docs/pmd-doc-${RELEASE_VERSION}/ pmd-${RELEASE_VERSION}/
-    git add pmd-${RELEASE_VERSION}
-    git commit -q -m "Added pmd-${RELEASE_VERSION}"
-    git rm -qr latest
-    cp -a pmd-${RELEASE_VERSION} latest
-    git add latest
-    git commit -q -m "Copying pmd-${RELEASE_VERSION} to latest"
-    git push origin master
-)
-
-fi
-

.travis/render_release_notes.rb

@@ -0,0 +1,44 @@
+#!/usr/bin/env ruby
+
+# Renders the release notes for Github releases,
+# and prints them to standard output
+
+# Doesn't trim the header, which is done in shell
+
+# Args:
+# ARGV[0] : location of the file to render
+
+require "liquid"
+require "safe_yaml"
+
+# include some custom liquid extensions
+require_relative "../docs/_plugins/all_extensions"
+
+# explicitly setting safe mode to get rid of the warning
+SafeYAML::OPTIONS[:default_mode] = :safe
+
+# START OF THE SCRIPT
+
+unless ARGV.length == 1 && File.exists?(ARGV[0])
+  print "\e[31m[ERROR] In #{$0}: The first arg must be a valid file name\e[0m\n"
+  exit 1
+end
+
+release_notes_file = ARGV[0]
+
+# Make the script execute wherever we are
+travis_dir = File.expand_path File.dirname(__FILE__)
+
+liquid_env = {
+    # wrap the config under a "site." namespace because that's how jekyll does it
+    'site' => YAML.load_file(travis_dir + "/../docs/_config.yml"),
+    # This signals the links in {% rule %} tags that they should be rendered as absolute
+    'is_release_notes_processor' => true
+}
+
+
+to_render = File.read(release_notes_file)
+rendered = Liquid::Template.parse(to_render).render(liquid_env)
+
+
+print(rendered)

.travis/setup-secrets.sh

@@ -1,24 +1,63 @@
 #!/bin/bash
 set -e
 
-if [ "${TRAVIS_REPO_SLUG}" != "pmd/pmd" ] || [ "${TRAVIS_PULL_REQUEST}" != "false" ] || [ "${TRAVIS_SECURE_ENV_VARS}" != "true" ] || [ "${encrypted_5630fbebf057_iv}" = "" ]; then
+source .travis/logger.sh
+source .travis/common-functions.sh
+
+if [ "${TRAVIS_REPO_SLUG}" != "pmd/pmd" ] || [ "${TRAVIS_PULL_REQUEST}" != "false" ] || [ "${TRAVIS_SECURE_ENV_VARS}" != "true" ]; then
     echo "Not setting up secrets:"
     echo "  TRAVIS_REPO_SLUG=${TRAVIS_REPO_SLUG}"
     echo "  TRAVIS_PULL_REQUEST=${TRAVIS_PULL_REQUEST}"
     echo "  TRAVIS_SECURE_ENV_VARS=${TRAVIS_SECURE_ENV_VARS}"
-    [ "${encrypted_5630fbebf057_iv}" = "" ] && echo "  Variable encrypted_5630fbebf057_iv is not set"
     exit 0
 fi
 
 echo "Setting up secrets..."
 
-openssl aes-256-cbc -K ${encrypted_5630fbebf057_key} -iv ${encrypted_5630fbebf057_iv} -in .travis/secrets.tar.enc -out .travis/secrets.tar -d
+#
+# contents of secrets.tar:
+# *   id_rsa
+# *   release-signing-key-D0BF1D737C9A1C22.gpg
+
+openssl aes-256-cbc -K ${encrypted_a5724fade5c6_key} -iv ${encrypted_a5724fade5c6_iv} -in .travis/secrets.tar.enc -out .travis/secrets.tar -d
 pushd .travis && tar xfv secrets.tar && popd
 mkdir -p "$HOME/.ssh"
 chmod 700 "$HOME/.ssh"
 mv .travis/id_rsa "$HOME/.ssh/id_rsa"
 chmod 600 "$HOME/.ssh/id_rsa"
-mkdir -p "$HOME/.gpg"
-gpg --batch --import .travis/release-signing-key-82DE7BE82166E84E.gpg
+
+if travis_isLinux; then
+    mkdir -p "$HOME/.gpg"
+    gpg --batch --import .travis/release-signing-key-D0BF1D737C9A1C22.gpg
+else
+    log_info "Not setting up gpg for ${TRAVIS_OS_NAME}."
+    # Note: importing keys into gpg will start gpg-agent. This background task then
+    # prevents travis-ci from terminating the build job under Windows.
+    # Alternatively "gpgconf --kill gpg-agent" can be executed to stop the
+    # gpg-agent at the end, if the gpg keys are needed.
+fi
 rm .travis/secrets.tar
-rm .travis/release-signing-key-82DE7BE82166E84E.gpg
+rm .travis/release-signing-key-D0BF1D737C9A1C22.gpg
+
+echo "Setting up .ssh/known_hosts..."
+#
+# https://sourceforge.net/p/forge/documentation/SSH%20Key%20Fingerprints/
+#
+# run locally:
+# ssh-keyscan web.sourceforge.net | tee -a known_hosts
+#
+# verify fingerprints:
+# ssh-keygen -F web.sourceforge.net -l -f known_hosts 
+# # Host web.sourceforge.net found: line 1 
+# web.sourceforge.net RSA SHA256:xB2rnn0NUjZ/E0IXQp4gyPqc7U7gjcw7G26RhkDyk90 
+# # Host web.sourceforge.net found: line 2 
+# web.sourceforge.net ECDSA SHA256:QAAxYkf0iI/tc9oGa0xSsVOAzJBZstcO8HqGKfjpxcY 
+# # Host web.sourceforge.net found: line 3 
+# web.sourceforge.net ED25519 SHA256:209BDmH3jsRyO9UeGPPgLWPSegKmYCBIya0nR/AWWCY 
+#
+# then add output of `ssh-keygen -F web.sourceforge.net -f known_hosts`
+#
+echo 'web.sourceforge.net ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA2uifHZbNexw6cXbyg1JnzDitL5VhYs0E65Hk/tLAPmcmm5GuiGeUoI/B0eUSNFsbqzwgwrttjnzKMKiGLN5CWVmlN1IXGGAfLYsQwK6wAu7kYFzkqP4jcwc5Jr9UPRpJdYIK733tSEmzab4qc5Oq8izKQKIaxXNe7FgmL15HjSpatFt9w/ot/CHS78FUAr3j3RwekHCm/jhPeqhlMAgC+jUgNJbFt3DlhDaRMa0NYamVzmX8D47rtmBbEDU3ld6AezWBPUR5Lh7ODOwlfVI58NAf/aYNlmvl2TZiauBCTa7OPYSyXJnIPbQXg6YQlDknNCr0K769EjeIlAfY87Z4tw==' >> "$HOME/.ssh/known_hosts"
+echo 'web.sourceforge.net ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBCwsY6sZT4MTTkHfpRzYjxG7mnXrGL74RCT2cO/NFvRrZVNB5XNwKNn7G5fHbYLdJ6UzpURDRae1eMg92JG0+yo=' >> "$HOME/.ssh/known_hosts"
+echo 'web.sourceforge.net ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOQD35Ujalhh+JJkPvMckDlhu4dS7WH6NsOJ15iGCJLC' >> "$HOME/.ssh/known_hosts"
+

.travis/sitemap_generator.sh

@@ -0,0 +1,56 @@
+#!/bin/bash
+
+# Sitemap generator
+# Assumes we have the latest version of the site under "latest" and "pmd-${RELEASE_VERSION}"
+# https://www.sitemaps.org/protocol.html
+
+WEBSITE_PREFIX="https://pmd.github.io/"
+DOC_PREFIX="latest/" # "pmd-${RELEASE_VERSION}/"
+DATE=`date +%Y-%m-%d`
+# Priority is relative to the website, can be chosen in {0.1, 0.2, ..., 1}
+# Default priority is 0.5
+LATEST_PRIORITY=0.8
+
+
+# Writes to standard output
+
+cat << HEADER_END
+<?xml version="1.0" encoding="UTF-8"?>
+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
+
+    <url>
+        <loc>${WEBSITE_PREFIX}index.html</loc>
+        <priority>1</priority>
+        <changefreq>monthly</changefreq>
+        <lastmod>$DATE</lastmod>
+    </url>
+
+    <url>
+        <loc>${WEBSITE_PREFIX}${DOC_PREFIX}index.html</loc>
+        <priority>0.9</priority>
+        <changefreq>monthly</changefreq>
+        <lastmod>$DATE</lastmod>
+    </url>
+
+
+
+HEADER_END
+
+
+for page in ${DOC_PREFIX}pmd_*.html
+do
+
+    cat << ENTRY_END
+    <url>
+        <loc>${WEBSITE_PREFIX}$page</loc>
+        <priority>$LATEST_PRIORITY</priority>
+        <changefreq>monthly</changefreq>
+        <lastmod>$DATE</lastmod>
+    </url>
+
+ENTRY_END
+
+done
+
+echo "</urlset>"
+

.travis/sourceforge-api.sh

@@ -0,0 +1,166 @@
+#
+# The functions here require the following scripts:
+# .travis/logger.sh
+#
+# The functions here require the following environment variables:
+# PMD_SF_USER
+# PMD_SF_APIKEY
+#
+
+#
+# Uploads the release notes to sourceforge files as "ReadMe.md".
+#
+# Note: this function always succeeds, even if the upload fails.
+# In that case, just a error logging is provided.
+#
+function sourceforge_uploadReleaseNotes() {
+    local pmdVersion="$1"
+    local releaseNotes="$2"
+
+    log_debug "$FUNCNAME pmdVersion=$pmdVersion"
+    local targetUrl="https://sourceforge.net/projects/pmd/files/pmd/${pmdVersion}"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function release_notes_fail() {
+            log_error "Error while uploading release notes as ReadMe.md to sourceforge!"
+            log_error "Please upload manually: ${targetUrl}"
+            cleanup_temp_dir
+        }
+
+        function cleanup_temp_dir() {
+            log_debug "Cleanup tempdir $releaseNotesTempDir"
+            rm "${releaseNotesTempDir}/${pmdVersion}/ReadMe.md" || true
+            rmdir "${releaseNotesTempDir}/${pmdVersion}" || true
+            rmdir "${releaseNotesTempDir}" || true
+        }
+
+        # exit subshell after trap
+        set -e
+        trap release_notes_fail ERR
+
+        local releaseNotesTempDir=$(mktemp -d)
+        log_debug "Tempdir: $releaseNotesTempDir"
+        mkdir -p "${releaseNotesTempDir}/${pmdVersion}"
+        echo "$releaseNotes" > "${releaseNotesTempDir}/${pmdVersion}/ReadMe.md"
+
+        log_info "Uploading release notes to sourceforge for version $pmdVersion"
+        rsync -avz \
+            "${releaseNotesTempDir}/" \
+            "${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/"
+
+        log_success "Successfully uploaded release notes as ReadMe.md to sourceforge: ${targetUrl}"
+
+        cleanup_temp_dir
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}
+
+#
+# Uploads the given file to sourceforge.
+#
+# Note: This function always succeeds, even if the upload fails.
+# In that case, just a error logging is provided.
+#
+function sourceforge_uploadFile() {
+    local pmdVersion="$1"
+    local filename="$2"
+
+    log_debug "$FUNCNAME pmdVersion=$pmdVersion filename=$filename"
+    local targetUrl="https://sourceforge.net/projects/pmd/files/pmd/${pmdVersion}"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function upload_failed() {
+            log_error "Error while uploading ${filename} to sourceforge!"
+            log_error "Please upload manually: ${targetUrl}"
+        }
+
+        # exit subshell after trap
+        set -e
+        trap upload_failed ERR
+
+        log_info "Uploading $filename to sourceforge..."
+        .travis/travis_wait "rsync -avh ${filename} ${PMD_SF_USER}@web.sourceforge.net:/home/frs/project/pmd/pmd/${pmdVersion}/"
+        log_success "Successfully uploaded ${filename} to sourceforge: ${targetUrl}"
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}
+
+#
+# Select the given version as the new default download.
+#
+# Note: This function always succeeds, even if the request fails.
+# In that case, just a error logging is provided.
+#
+function sourceforge_selectDefault() {
+    local pmdVersion="$1"
+
+    log_debug "$FUNCNAME pmdVersion=$pmdVersion"
+    local targetUrl="https://sourceforge.net/projects/pmd/files/pmd/${pmdVersion}"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function request_failed() {
+            log_error "Error while selecting ${pmdVersion} as new default download on sourceforge!"
+            log_error "Please do it manually: ${targetUrl}"
+        }
+
+        # exit subshell after trap
+        set -e
+        trap request_failed ERR
+
+        log_info "Selecting $pmdVersion as new default on sourceforge..."
+        local response
+        response=$(curl --fail -s -H "Accept: application/json" \
+            -X PUT \
+            -d "api_key=${PMD_SF_APIKEY}" \
+            -d "default=windows&default=mac&default=linux&default=bsd&default=solaris&default=others" \
+            "https://sourceforge.net/projects/pmd/files/pmd/${pmdVersion}/pmd-bin-${pmdVersion}.zip")
+        log_debug " -> response: $response"
+        log_success "Successfully selected $pmdVersion as new default on sourceforge: ${targetUrl}"
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}
+
+#
+# Rsyncs the complete documentation to sourceforge.
+#
+# Note: This function always succeeds, even if the upload fails.
+# In that case, just a error logging is provided.
+#
+function sourceforge_rsyncSnapshotDocumentation() {
+    local pmdVersion="$1"
+    local targetPath="$2"
+
+    log_debug "$FUNCNAME pmdVersion=$pmdVersion targetPath=$targetPath"
+    local targetUrl="https://pmd.sourceforge.io/${targetPath}/"
+
+    local errexitstate="$(shopt -po errexit)"
+    set +e # disable errexit
+    (
+        # This handler is called if any command fails
+        function upload_failed() {
+            log_error "Couldn't upload the documentation. It won't be current on ${targetUrl}"
+        }
+
+        # exit subshell after trap
+        set -e
+        trap upload_failed ERR
+
+        log_info "Uploading documentation to ${targetUrl}..."
+        .travis/travis_wait "rsync -ah --stats --delete docs/pmd-doc-${VERSION}/ ${PMD_SF_USER}@web.sourceforge.net:/home/project-web/pmd/htdocs/snapshot/"
+        log_success "Successfully uploaded documentation: ${targetUrl}"
+    )
+    # restore errexit state
+    eval "$errexitstate"
+}

.travis/travis-settings.xml

@@ -6,7 +6,9 @@
   <interactiveMode/>
   <usePluginRegistry/>
   <offline/>
-  <pluginGroups/>
+  <pluginGroups>
+    <pluginGroup>org.sonarsource.scanner.maven</pluginGroup>
+  </pluginGroups>
   <servers>
     <server>
       <id>ossrh</id>

BUILDING.md

@@ -1,7 +1,8 @@
 # How to build PMD
 
-PMD uses [Maven](https://maven.apache.org/) and requires [Java 9](http://www.oracle.com/technetwork/java/javase/downloads/index.html)
-for building.
+PMD uses [Maven](https://maven.apache.org/) and requires at least Java 10 for building.
+You can get Java 10 from [Oracle](http://www.oracle.com/technetwork/java/javase/downloads/index.html)
+or from the [OpenJDK Project](http://jdk.java.net).
 
 PMD uses the [maven wrapper](https://github.com/takari/maven-wrapper), so you can simply build PMD as following:
 
@@ -15,7 +16,7 @@ This will create the zip files in the directory `pmd-dist/target`:
 
 That's all !
 
-**Note:** While Java 9 is required for building, running PMD only requires Java 7 (or Java 8 for Apex).
+**Note:** While Java 10 is required for building, running PMD only requires Java 7 (or Java 8 for Apex and the Designer).
 
 ## How to build the documentation?
 

CONTRIBUTING.md

@@ -3,6 +3,9 @@
 First off, thanks for taking the time to contribute!
 
 
+| NB: the rule designer is developed over at [pmd/pmd-designer](https://github.com/pmd/pmd-designer). Please refer to the specific [contributor documentation](https://github.com/pmd/pmd-designer#contributing) if your issue, feature request or PR touches the designer.  |
+| --- |
+
 ## Pull requests
 
 *   Please create your pull request against the `master` branch. We will rebase/merge it to the maintenance
@@ -29,10 +32,11 @@ When filing a bug report, please provide as much information as possible, so tha
 
 ## Documentation
 
-There is some documentation available under <https://pmd.github.io>. Feel free to create a bug report if
-documentation is missing, incomplete or outdated.
+There is some documentation available under <https://pmd.github.io/pmd>. Feel free to create a bug report if
+documentation is missing, incomplete or outdated. See [Bug reports](#bug-reports).
 
-The documentation is generated as a maven site, the source is available at: <https://github.com/pmd/pmd/tree/master/src/site>
+The documentation is generated as a Jekyll site, the source is available at: <https://github.com/pmd/pmd/tree/master/docs>. You can find build instructions there.
+For more on contributing documentation check <https://pmd.github.io/pmd/pmd_devdocs_writing_documentation.html>
 
 ## Questions